<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[150207] trunk</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/150207">150207</a></dd>
<dt>Author</dt> <dd>csaavedra@igalia.com</dd>
<dt>Date</dt> <dd>2013-05-16 14:04:57 -0700 (Thu, 16 May 2013)</dd>
</dl>

<h3>Log Message</h3>
<pre>[CSS] CSS Variables are case-sensitive
https://bugs.webkit.org/show_bug.cgi?id=116239

Reviewed by Ryosuke Niwa.

Source/WebCore:

The CSS Variables specification states that variables are
case-sensitive, unlike other CSS properties.

Test: fast/css/variables/case-sensitive.html

* css/CSSParser.cpp:
(WebCore::CSSParserString::substring): Replace
the now unnecessary lowerSubstring() with this method.
Also, since the method is only used by the CSS variables
implementation, #ifdef it.
(WebCore::CSSParser::createPrimitiveVariableNameValue):
(WebCore::CSSParser::storeVariableDeclaration):
Do not normalize variable declarations to lowercase.
* css/CSSParserValues.h:
(CSSParserString): Replace the lowerSubstring() declaration
and wrap with #if/#endif.

LayoutTests:

* fast/css/variables/case-sensitive-expected.html: Renamed from
fast/css/variables/case-insensitive-expected.html.
* fast/css/variables/case-sensitive.html: Renamed from
LayoutTests/fast/css/variables/case-insensitive.html.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorecssCSSParsercpp">trunk/Source/WebCore/css/CSSParser.cpp</a></li>
<li><a href="#trunkSourceWebCorecssCSSParserValuesh">trunk/Source/WebCore/css/CSSParserValues.h</a></li>
</ul>

<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastcssvariablescasesensitiveexpectedhtml">trunk/LayoutTests/fast/css/variables/case-sensitive-expected.html</a></li>
<li><a href="#trunkLayoutTestsfastcssvariablescasesensitivehtml">trunk/LayoutTests/fast/css/variables/case-sensitive.html</a></li>
</ul>

<h3>Removed Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastcssvariablescaseinsensitiveexpectedhtml">trunk/LayoutTests/fast/css/variables/case-insensitive-expected.html</a></li>
<li><a href="#trunkLayoutTestsfastcssvariablescaseinsensitivehtml">trunk/LayoutTests/fast/css/variables/case-insensitive.html</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (150206 => 150207)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog        2013-05-16 21:02:11 UTC (rev 150206)
+++ trunk/LayoutTests/ChangeLog        2013-05-16 21:04:57 UTC (rev 150207)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2013-05-16  Claudio Saavedra  &lt;csaavedra@igalia.com&gt;
+
+        [CSS] CSS Variables are case-sensitive
+        https://bugs.webkit.org/show_bug.cgi?id=116239
+
+        Reviewed by Ryosuke Niwa.
+
+        * fast/css/variables/case-sensitive-expected.html: Renamed from
+        fast/css/variables/case-insensitive-expected.html.
+        * fast/css/variables/case-sensitive.html: Renamed from
+        LayoutTests/fast/css/variables/case-insensitive.html.
+
</ins><span class="cx"> 2013-05-16  Gustavo Noronha Silva  &lt;gustavo.noronha@collabora.com&gt;
</span><span class="cx"> 
</span><span class="cx">         [GTK] Build Xvfb with jhbuild
</span></span></pre></div>
<a id="trunkLayoutTestsfastcssvariablescaseinsensitiveexpectedhtml"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/fast/css/variables/case-insensitive-expected.html (150206 => 150207)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/css/variables/case-insensitive-expected.html        2013-05-16 21:02:11 UTC (rev 150206)
+++ trunk/LayoutTests/fast/css/variables/case-insensitive-expected.html        2013-05-16 21:04:57 UTC (rev 150207)
</span><span class="lines">@@ -1,9 +0,0 @@
</span><del>-&lt;!DOCTYPE html&gt;
-&lt;html&gt;
-&lt;style&gt;
-div {
-    background-color: green;
-}
-&lt;/style&gt;
-&lt;div&gt;This text should have a green background.&lt;/div&gt;
-&lt;/html&gt;
</del></span></pre></div>
<a id="trunkLayoutTestsfastcssvariablescaseinsensitivehtml"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/fast/css/variables/case-insensitive.html (150206 => 150207)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/css/variables/case-insensitive.html        2013-05-16 21:02:11 UTC (rev 150206)
+++ trunk/LayoutTests/fast/css/variables/case-insensitive.html        2013-05-16 21:04:57 UTC (rev 150207)
</span><span class="lines">@@ -1,13 +0,0 @@
</span><del>-&lt;!DOCTYPE html&gt;
-&lt;html&gt;
-&lt;script&gt;
-internals.settings.setCSSVariablesEnabled(true);
-&lt;/script&gt;
-&lt;style&gt;
-div {
-  background-color: -webkit-var(NaMe);
-  -webkit-var-nAmE: green;
-}
-&lt;/style&gt;
-&lt;div&gt;This text should have a green background.&lt;/div&gt;
-&lt;/html&gt;
</del></span></pre></div>
<a id="trunkLayoutTestsfastcssvariablescasesensitiveexpectedhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/css/variables/case-sensitive-expected.html (0 => 150207)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/css/variables/case-sensitive-expected.html                                (rev 0)
+++ trunk/LayoutTests/fast/css/variables/case-sensitive-expected.html        2013-05-16 21:04:57 UTC (rev 150207)
</span><span class="lines">@@ -0,0 +1,4 @@
</span><ins>+&lt;!DOCTYPE html&gt;
+&lt;html&gt;
+&lt;div&gt;This text should have a transparent background.&lt;/div&gt;
+&lt;/html&gt;
</ins></span></pre></div>
<a id="trunkLayoutTestsfastcssvariablescasesensitivehtmlfromrev150206trunkLayoutTestsfastcssvariablescaseinsensitivehtml"></a>
<div class="copfile"><h4>Copied: trunk/LayoutTests/fast/css/variables/case-sensitive.html (from rev 150206, trunk/LayoutTests/fast/css/variables/case-insensitive.html) (0 => 150207)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/css/variables/case-sensitive.html                                (rev 0)
+++ trunk/LayoutTests/fast/css/variables/case-sensitive.html        2013-05-16 21:04:57 UTC (rev 150207)
</span><span class="lines">@@ -0,0 +1,13 @@
</span><ins>+&lt;!DOCTYPE html&gt;
+&lt;html&gt;
+&lt;script&gt;
+internals.settings.setCSSVariablesEnabled(true);
+&lt;/script&gt;
+&lt;style&gt;
+div {
+  background-color: -webkit-var(NaMe);
+  -webkit-var-nAmE: green;
+}
+&lt;/style&gt;
+&lt;div&gt;This text should have a transparent background.&lt;/div&gt;
+&lt;/html&gt;
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (150206 => 150207)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog        2013-05-16 21:02:11 UTC (rev 150206)
+++ trunk/Source/WebCore/ChangeLog        2013-05-16 21:04:57 UTC (rev 150207)
</span><span class="lines">@@ -1,3 +1,27 @@
</span><ins>+2013-05-16  Claudio Saavedra  &lt;csaavedra@igalia.com&gt;
+
+        [CSS] CSS Variables are case-sensitive
+        https://bugs.webkit.org/show_bug.cgi?id=116239
+
+        Reviewed by Ryosuke Niwa.
+
+        The CSS Variables specification states that variables are
+        case-sensitive, unlike other CSS properties.
+
+        Test: fast/css/variables/case-sensitive.html
+
+        * css/CSSParser.cpp:
+        (WebCore::CSSParserString::substring): Replace
+        the now unnecessary lowerSubstring() with this method.
+        Also, since the method is only used by the CSS variables
+        implementation, #ifdef it.
+        (WebCore::CSSParser::createPrimitiveVariableNameValue):
+        (WebCore::CSSParser::storeVariableDeclaration):
+        Do not normalize variable declarations to lowercase.
+        * css/CSSParserValues.h:
+        (CSSParserString): Replace the lowerSubstring() declaration
+        and wrap with #if/#endif.
+
</ins><span class="cx"> 2013-05-16  Brady Eidson  &lt;beidson@apple.com&gt;
</span><span class="cx"> 
</span><span class="cx">         svg/as-image/img-zoom-svg-stylesheet.html crashes with NetworkProcess enabled.
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSParsercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSParser.cpp (150206 => 150207)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSParser.cpp        2013-05-16 21:02:11 UTC (rev 150206)
+++ trunk/Source/WebCore/css/CSSParser.cpp        2013-05-16 21:04:57 UTC (rev 150207)
</span><span class="lines">@@ -391,24 +391,22 @@
</span><span class="cx">     makeLower(characters16(), characters16(), length());
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-AtomicString CSSParserString::lowerSubstring(unsigned position, unsigned length) const
</del><ins>+#if ENABLE(CSS_VARIABLES)
+AtomicString CSSParserString::substring(unsigned position, unsigned length) const
</ins><span class="cx"> {
</span><span class="cx">     ASSERT(m_length &gt;= position + length);
</span><span class="cx"> 
</span><span class="cx">     RefPtr&lt;StringImpl&gt; result;
</span><span class="cx"> 
</span><span class="cx">     if (is8Bit()) {
</span><del>-        LChar* buffer;
-        result = StringImpl::createUninitialized(length, buffer);
-        makeLower(characters8() + position, buffer, length);
</del><ins>+        result = StringImpl::create(characters8() + position, length);
</ins><span class="cx">     } else {
</span><del>-        UChar* buffer = 0;
-        result = StringImpl::createUninitialized(length, buffer);
-        makeLower(characters16() + position, buffer, length);
</del><ins>+        result = StringImpl::create(characters16() + position, length);
</ins><span class="cx">     }
</span><span class="cx"> 
</span><span class="cx">     return AtomicString(result);
</span><span class="cx"> }
</span><ins>+#endif
</ins><span class="cx"> 
</span><span class="cx"> void CSSParser::setupParser(const char* prefix, unsigned prefixLength, const String&amp; string, const char* suffix, unsigned suffixLength)
</span><span class="cx"> {
</span><span class="lines">@@ -1758,7 +1756,7 @@
</span><span class="cx"> inline PassRefPtr&lt;CSSPrimitiveValue&gt; CSSParser::createPrimitiveVariableNameValue(CSSParserValue* value)
</span><span class="cx"> {
</span><span class="cx">     ASSERT(value-&gt;unit == CSSPrimitiveValue::CSS_VARIABLE_NAME);
</span><del>-    AtomicString variableName = String(value-&gt;string).lower();
</del><ins>+    AtomicString variableName = String(value-&gt;string);
</ins><span class="cx">     return CSSPrimitiveValue::create(variableName, CSSPrimitiveValue::CSS_VARIABLE_NAME);
</span><span class="cx"> }
</span><span class="cx"> #endif
</span><span class="lines">@@ -3330,7 +3328,7 @@
</span><span class="cx">     static const unsigned prefixLength = sizeof(&quot;-webkit-var-&quot;) - 1;
</span><span class="cx">     
</span><span class="cx">     ASSERT(name.length() &gt; prefixLength);
</span><del>-    AtomicString variableName = name.lowerSubstring(prefixLength, name.length() - prefixLength);
</del><ins>+    AtomicString variableName = name.substring(prefixLength, name.length() - prefixLength);
</ins><span class="cx"> 
</span><span class="cx">     StringBuilder builder;
</span><span class="cx">     for (unsigned i = 0, size = value-&gt;size(); i &lt; size; i++) {
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSParserValuesh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSParserValues.h (150206 => 150207)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSParserValues.h        2013-05-16 21:02:11 UTC (rev 150206)
+++ trunk/Source/WebCore/css/CSSParserValues.h        2013-05-16 21:04:57 UTC (rev 150207)
</span><span class="lines">@@ -94,7 +94,9 @@
</span><span class="cx">     operator String() const { return is8Bit() ? String(m_data.characters8, m_length) : String(m_data.characters16, m_length); }
</span><span class="cx">     operator AtomicString() const { return is8Bit() ? AtomicString(m_data.characters8, m_length) : AtomicString(m_data.characters16, m_length); }
</span><span class="cx"> 
</span><del>-    AtomicString lowerSubstring(unsigned position, unsigned length) const;
</del><ins>+#if ENABLE(CSS_VARIABLES)
+    AtomicString substring(unsigned position, unsigned length) const;
+#endif
</ins><span class="cx"> 
</span><span class="cx">     union {
</span><span class="cx">         LChar* characters8;
</span></span></pre>
</div>
</div>

</body>
</html>