<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[149839] trunk/Source/WebCore</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/149839">149839</a></dd>
<dt>Author</dt> <dd>enrica@apple.com</dd>
<dt>Date</dt> <dd>2013-05-09 13:54:16 -0700 (Thu, 09 May 2013)</dd>
</dl>

<h3>Log Message</h3>
<pre>A change in system environment should force all CSS properties to be recomputed.
https://bugs.webkit.org/show_bug.cgi?id=115872
&lt;rdar://problem/13781171&gt;

Reviewed by Antti Koivisto.

When a change in the global environment occurs, for example system colors,
we need to make sure all the CSS properties are recomputed and not fetched
from the cache. For this reason we invalidate the properties cache.
I've also renamed the function to give it a more meaningful name.
        
* page/Page.cpp:
(WebCore::Page::updateStyleForAllPagesAfterGlobalChangeInEnvironment):
* page/Page.h:
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::platformColorsDidChange):</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorepagePagecpp">trunk/Source/WebCore/page/Page.cpp</a></li>
<li><a href="#trunkSourceWebCorepagePageh">trunk/Source/WebCore/page/Page.h</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderThemecpp">trunk/Source/WebCore/rendering/RenderTheme.cpp</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (149838 => 149839)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog        2013-05-09 20:35:32 UTC (rev 149838)
+++ trunk/Source/WebCore/ChangeLog        2013-05-09 20:54:16 UTC (rev 149839)
</span><span class="lines">@@ -1,3 +1,22 @@
</span><ins>+2013-05-09  Enrica Casucci  &lt;enrica@apple.com&gt;
+
+        A change in system environment should force all CSS properties to be recomputed.
+        https://bugs.webkit.org/show_bug.cgi?id=115872
+        &lt;rdar://problem/13781171&gt;
+
+        Reviewed by Antti Koivisto.
+
+        When a change in the global environment occurs, for example system colors,
+        we need to make sure all the CSS properties are recomputed and not fetched
+        from the cache. For this reason we invalidate the properties cache.
+        I've also renamed the function to give it a more meaningful name.
+        
+        * page/Page.cpp:
+        (WebCore::Page::updateStyleForAllPagesAfterGlobalChangeInEnvironment):
+        * page/Page.h:
+        * rendering/RenderTheme.cpp:
+        (WebCore::RenderTheme::platformColorsDidChange):
+
</ins><span class="cx"> 2013-05-09  Antti Koivisto  &lt;antti@apple.com&gt;
</span><span class="cx"> 
</span><span class="cx">         Reoptimize free-standing :focus/link/visited/-webkit-any-link selectors.
</span></span></pre></div>
<a id="trunkSourceWebCorepagePagecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/Page.cpp (149838 => 149839)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/Page.cpp        2013-05-09 20:35:32 UTC (rev 149838)
+++ trunk/Source/WebCore/page/Page.cpp        2013-05-09 20:54:16 UTC (rev 149839)
</span><span class="lines">@@ -76,6 +76,7 @@
</span><span class="cx"> #include &quot;SharedBuffer.h&quot;
</span><span class="cx"> #include &quot;StorageArea.h&quot;
</span><span class="cx"> #include &quot;StorageNamespace.h&quot;
</span><ins>+#include &quot;StyleResolver.h&quot;
</ins><span class="cx"> #include &quot;TextResourceDecoder.h&quot;
</span><span class="cx"> #include &quot;VisitedLinkState.h&quot;
</span><span class="cx"> #include &quot;VoidCallback.h&quot;
</span><span class="lines">@@ -458,14 +459,20 @@
</span><span class="cx">     m_group = m_singlePageGroup.get();
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-void Page::scheduleForcedStyleRecalcForAllPages()
</del><ins>+void Page::updateStyleForAllPagesAfterGlobalChangeInEnvironment()
</ins><span class="cx"> {
</span><span class="cx">     if (!allPages)
</span><span class="cx">         return;
</span><span class="cx">     HashSet&lt;Page*&gt;::iterator end = allPages-&gt;end();
</span><span class="cx">     for (HashSet&lt;Page*&gt;::iterator it = allPages-&gt;begin(); it != end; ++it)
</span><del>-        for (Frame* frame = (*it)-&gt;mainFrame(); frame; frame = frame-&gt;tree()-&gt;traverseNext())
</del><ins>+        for (Frame* frame = (*it)-&gt;mainFrame(); frame; frame = frame-&gt;tree()-&gt;traverseNext()) {
+            // If a change in the global environment has occurred, we need to
+            // make sure all the properties a recomputed, therefore we invalidate
+            // the properties cache.
+            if (StyleResolver* styleResolver = frame-&gt;document()-&gt;styleResolverIfExists())
+                styleResolver-&gt;invalidateMatchedPropertiesCache();
</ins><span class="cx">             frame-&gt;document()-&gt;scheduleForcedStyleRecalc();
</span><ins>+        }
</ins><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> void Page::setNeedsRecalcStyleInAllFrames()
</span></span></pre></div>
<a id="trunkSourceWebCorepagePageh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/Page.h (149838 => 149839)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/Page.h        2013-05-09 20:35:32 UTC (rev 149838)
+++ trunk/Source/WebCore/page/Page.h        2013-05-09 20:54:16 UTC (rev 149839)
</span><span class="lines">@@ -111,7 +111,7 @@
</span><span class="cx">     WTF_MAKE_NONCOPYABLE(Page);
</span><span class="cx">     friend class Settings;
</span><span class="cx"> public:
</span><del>-    static void scheduleForcedStyleRecalcForAllPages();
</del><ins>+    static void updateStyleForAllPagesAfterGlobalChangeInEnvironment();
</ins><span class="cx"> 
</span><span class="cx">     // It is up to the platform to ensure that non-null clients are provided where required.
</span><span class="cx">     struct PageClients {
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderThemecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderTheme.cpp (149838 => 149839)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderTheme.cpp        2013-05-09 20:35:32 UTC (rev 149838)
+++ trunk/Source/WebCore/rendering/RenderTheme.cpp        2013-05-09 20:54:16 UTC (rev 149839)
</span><span class="lines">@@ -1123,7 +1123,7 @@
</span><span class="cx">     m_activeListBoxSelectionBackgroundColor = Color();
</span><span class="cx">     m_inactiveListBoxSelectionForegroundColor = Color();
</span><span class="cx"> 
</span><del>-    Page::scheduleForcedStyleRecalcForAllPages();
</del><ins>+    Page::updateStyleForAllPagesAfterGlobalChangeInEnvironment();
</ins><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> Color RenderTheme::systemColor(int cssValueId) const
</span></span></pre>
</div>
</div>

</body>
</html>