<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[149550] trunk</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/149550">149550</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2013-05-03 20:49:25 -0700 (Fri, 03 May 2013)</dd>
</dl>

<h3>Log Message</h3>
<pre>incorrect repainting when a table has a transform
https://bugs.webkit.org/show_bug.cgi?id=109867

Patch by Arnaud Renevier &lt;a.renevier@sisa.samsung.com&gt; on 2013-05-03
Reviewed by Simon Fraser.

Source/WebCore:

Disable LayoutState when table, tableRow or tableSection render
objects have transforms or reflections.

Tests: fast/repaint/reflection-table-layout.html
       fast/repaint/transform-table-layout.html

* rendering/RenderTable.cpp:
(WebCore::RenderTable::layout):
* rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::layout):
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::layout):
(WebCore::RenderTableSection::layoutRows):

LayoutTests:

Create tests that resize an element inside a display: table element.
Compare to a reference html file where the element has a static size.
In the first test, the table like element has a transform. In the
second, it has a reflection.

* fast/repaint/reflection-table-layout-expected.html: Added.
* fast/repaint/reflection-table-layout.html: Added.
* fast/repaint/transform-table-layout-expected.html: Added.
* fast/repaint/transform-table-layout.html: Added.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderTablecpp">trunk/Source/WebCore/rendering/RenderTable.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderTableRowcpp">trunk/Source/WebCore/rendering/RenderTableRow.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderTableSectioncpp">trunk/Source/WebCore/rendering/RenderTableSection.cpp</a></li>
</ul>

<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastrepaintreflectiontablelayoutexpectedtxt">trunk/LayoutTests/fast/repaint/reflection-table-layout-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastrepaintreflectiontablelayouthtml">trunk/LayoutTests/fast/repaint/reflection-table-layout.html</a></li>
<li><a href="#trunkLayoutTestsfastrepainttransformtablelayoutexpectedtxt">trunk/LayoutTests/fast/repaint/transform-table-layout-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastrepainttransformtablelayouthtml">trunk/LayoutTests/fast/repaint/transform-table-layout.html</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (149549 => 149550)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog        2013-05-04 03:43:12 UTC (rev 149549)
+++ trunk/LayoutTests/ChangeLog        2013-05-04 03:49:25 UTC (rev 149550)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2013-05-03  Arnaud Renevier  &lt;a.renevier@sisa.samsung.com&gt;
+
+        incorrect repainting when a table has a transform
+        https://bugs.webkit.org/show_bug.cgi?id=109867
+
+        Reviewed by Simon Fraser.
+
+        Create tests that resize an element inside a display: table element.
+        Compare to a reference html file where the element has a static size.
+        In the first test, the table like element has a transform. In the
+        second, it has a reflection.
+
+        * fast/repaint/reflection-table-layout-expected.html: Added.
+        * fast/repaint/reflection-table-layout.html: Added.
+        * fast/repaint/transform-table-layout-expected.html: Added.
+        * fast/repaint/transform-table-layout.html: Added.
+
</ins><span class="cx"> 2013-05-03  Antti Koivisto  &lt;antti@apple.com&gt;
</span><span class="cx"> 
</span><span class="cx">         Remove concept of younger and older shadow trees
</span></span></pre></div>
<a id="trunkLayoutTestsfastrepaintreflectiontablelayoutexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/repaint/reflection-table-layout-expected.txt (0 => 149550)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/repaint/reflection-table-layout-expected.txt                                (rev 0)
+++ trunk/LayoutTests/fast/repaint/reflection-table-layout-expected.txt        2013-05-04 03:49:25 UTC (rev 149550)
</span><span class="lines">@@ -0,0 +1,11 @@
</span><ins>+(repaint rects
+  (rect 7 8 2 1)
+  (rect 6 8 4 2)
+  (rect -92 9 200 1)
+  (rect -92 8 200 2)
+  (rect 8 9 784 1)
+  (rect 0 17 800 1)
+  (rect -92 9 200 1)
+  (rect -92 9 200 1)
+)
+
</ins></span></pre></div>
<a id="trunkLayoutTestsfastrepaintreflectiontablelayouthtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/repaint/reflection-table-layout.html (0 => 149550)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/repaint/reflection-table-layout.html                                (rev 0)
+++ trunk/LayoutTests/fast/repaint/reflection-table-layout.html        2013-05-04 03:49:25 UTC (rev 149550)
</span><span class="lines">@@ -0,0 +1,35 @@
</span><ins>+&lt;!DOCTYPE html&gt;
+&lt;html&gt;
+&lt;head&gt;
+
+    &lt;style&gt;
+    #container {
+        width: 100px;
+        display: table;
+        -webkit-box-reflect: left;
+    }
+    #main {
+        width: 1px;
+        height: 1px;
+        background-color: black;
+    }
+    &lt;/style&gt;
+
+&lt;script src=&quot;resources/text-based-repaint.js&quot;&gt;&lt;/script&gt;
+&lt;script&gt;
+function repaintTest() {
+    var div = document.getElementById(&quot;main&quot;);
+    div.style.width = '2px';
+    div.style.height = '2px';
+}
+&lt;/script&gt;
+
+&lt;/head&gt;
+&lt;body onload=&quot;runRepaintTest()&quot;&gt;
+
+&lt;div id=&quot;container&quot;&gt;
+    &lt;div id=&quot;main&quot;&gt;&lt;/div&gt; 
+&lt;/div&gt;
+
+&lt;/body&gt;
+&lt;/html&gt;
</ins></span></pre></div>
<a id="trunkLayoutTestsfastrepainttransformtablelayoutexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/repaint/transform-table-layout-expected.txt (0 => 149550)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/repaint/transform-table-layout-expected.txt                                (rev 0)
+++ trunk/LayoutTests/fast/repaint/transform-table-layout-expected.txt        2013-05-04 03:49:25 UTC (rev 149550)
</span><span class="lines">@@ -0,0 +1,10 @@
</span><ins>+(repaint rects
+  (rect 8 108 1 1)
+  (rect 8 108 2 2)
+  (rect 8 109 100 1)
+  (rect 8 108 100 2)
+  (rect 8 9 784 1)
+  (rect 0 17 800 1)
+  (rect 8 109 100 1)
+)
+
</ins></span></pre></div>
<a id="trunkLayoutTestsfastrepainttransformtablelayouthtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/repaint/transform-table-layout.html (0 => 149550)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/repaint/transform-table-layout.html                                (rev 0)
+++ trunk/LayoutTests/fast/repaint/transform-table-layout.html        2013-05-04 03:49:25 UTC (rev 149550)
</span><span class="lines">@@ -0,0 +1,35 @@
</span><ins>+&lt;!DOCTYPE html&gt;
+&lt;html&gt;
+&lt;head&gt;
+
+    &lt;style&gt;
+    #container {
+        width: 100px;
+        display: table;
+        -webkit-transform: translate(0px, 100px);
+    }
+    #main {
+        width: 1px;
+        height: 1px;
+        background-color: black;
+    }
+    &lt;/style&gt;
+
+&lt;script src=&quot;resources/text-based-repaint.js&quot;&gt;&lt;/script&gt;
+&lt;script&gt;
+function repaintTest() {
+    var div = document.getElementById(&quot;main&quot;);
+    div.style.width = '2px';
+    div.style.height = '2px';
+}
+&lt;/script&gt;
+
+&lt;/head&gt;
+&lt;body onload=&quot;runRepaintTest()&quot;&gt;
+
+&lt;div id=&quot;container&quot;&gt;
+    &lt;div id=&quot;main&quot;&gt;&lt;/div&gt; 
+&lt;/div&gt;
+
+&lt;/body&gt;
+&lt;/html&gt;
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (149549 => 149550)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog        2013-05-04 03:43:12 UTC (rev 149549)
+++ trunk/Source/WebCore/ChangeLog        2013-05-04 03:49:25 UTC (rev 149550)
</span><span class="lines">@@ -1,3 +1,24 @@
</span><ins>+2013-05-03  Arnaud Renevier  &lt;a.renevier@sisa.samsung.com&gt;
+
+        incorrect repainting when a table has a transform
+        https://bugs.webkit.org/show_bug.cgi?id=109867
+
+        Reviewed by Simon Fraser.
+
+        Disable LayoutState when table, tableRow or tableSection render
+        objects have transforms or reflections.
+
+        Tests: fast/repaint/reflection-table-layout.html
+               fast/repaint/transform-table-layout.html
+
+        * rendering/RenderTable.cpp:
+        (WebCore::RenderTable::layout):
+        * rendering/RenderTableRow.cpp:
+        (WebCore::RenderTableRow::layout):
+        * rendering/RenderTableSection.cpp:
+        (WebCore::RenderTableSection::layout):
+        (WebCore::RenderTableSection::layoutRows):
+
</ins><span class="cx"> 2013-05-03  Antti Koivisto  &lt;antti@apple.com&gt;
</span><span class="cx"> 
</span><span class="cx">         Remove concept of younger and older shadow trees
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderTablecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderTable.cpp (149549 => 149550)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderTable.cpp        2013-05-04 03:43:12 UTC (rev 149549)
+++ trunk/Source/WebCore/rendering/RenderTable.cpp        2013-05-04 03:49:25 UTC (rev 149550)
</span><span class="lines">@@ -404,7 +404,7 @@
</span><span class="cx">     recalcBordersInRowDirection();
</span><span class="cx">         
</span><span class="cx">     LayoutRepainter repainter(*this, checkForRepaintDuringLayout());
</span><del>-    LayoutStateMaintainer statePusher(view(), this, locationOffset(), style()-&gt;isFlippedBlocksWritingMode());
</del><ins>+    LayoutStateMaintainer statePusher(view(), this, locationOffset(), hasTransform() || hasReflection() || style()-&gt;isFlippedBlocksWritingMode());
</ins><span class="cx"> 
</span><span class="cx">     setLogicalHeight(0);
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderTableRowcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderTableRow.cpp (149549 => 149550)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderTableRow.cpp        2013-05-04 03:43:12 UTC (rev 149549)
+++ trunk/Source/WebCore/rendering/RenderTableRow.cpp        2013-05-04 03:49:25 UTC (rev 149550)
</span><span class="lines">@@ -159,7 +159,7 @@
</span><span class="cx">     ASSERT(needsLayout());
</span><span class="cx"> 
</span><span class="cx">     // Table rows do not add translation.
</span><del>-    LayoutStateMaintainer statePusher(view(), this, LayoutSize(), style()-&gt;isFlippedBlocksWritingMode());
</del><ins>+    LayoutStateMaintainer statePusher(view(), this, LayoutSize(), hasTransform() || hasReflection() || style()-&gt;isFlippedBlocksWritingMode());
</ins><span class="cx"> 
</span><span class="cx">     bool paginated = view()-&gt;layoutState()-&gt;isPaginated();
</span><span class="cx">                 
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderTableSectioncpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderTableSection.cpp (149549 => 149550)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderTableSection.cpp        2013-05-04 03:43:12 UTC (rev 149549)
+++ trunk/Source/WebCore/rendering/RenderTableSection.cpp        2013-05-04 03:49:25 UTC (rev 149550)
</span><span class="lines">@@ -371,7 +371,7 @@
</span><span class="cx">     // can be called in a loop (e.g during parsing). Doing it now ensures we have a stable-enough structure.
</span><span class="cx">     m_grid.shrinkToFit();
</span><span class="cx"> 
</span><del>-    LayoutStateMaintainer statePusher(view(), this, locationOffset(), style()-&gt;isFlippedBlocksWritingMode());
</del><ins>+    LayoutStateMaintainer statePusher(view(), this, locationOffset(), hasTransform() || hasReflection() || style()-&gt;isFlippedBlocksWritingMode());
</ins><span class="cx"> 
</span><span class="cx">     const Vector&lt;int&gt;&amp; columnPos = table()-&gt;columnPositions();
</span><span class="cx"> 
</span><span class="lines">@@ -518,7 +518,7 @@
</span><span class="cx">     int vspacing = table()-&gt;vBorderSpacing();
</span><span class="cx">     unsigned nEffCols = table()-&gt;numEffCols();
</span><span class="cx"> 
</span><del>-    LayoutStateMaintainer statePusher(view(), this, locationOffset(), style()-&gt;isFlippedBlocksWritingMode());
</del><ins>+    LayoutStateMaintainer statePusher(view(), this, locationOffset(), hasTransform() || style()-&gt;isFlippedBlocksWritingMode());
</ins><span class="cx"> 
</span><span class="cx">     for (unsigned r = 0; r &lt; totalRows; r++) {
</span><span class="cx">         // Set the row's x/y position and width/height.
</span></span></pre>
</div>
</div>

</body>
</html>