<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[145930] trunk/Source/WebCore</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/145930">145930</a></dd>
<dt>Author</dt> <dd>ap@apple.com</dd>
<dt>Date</dt> <dd>2013-03-15 12:03:39 -0700 (Fri, 15 Mar 2013)</dd>
</dl>

<h3>Log Message</h3>
<pre>        Minor cleanup in worker code
        https://bugs.webkit.org/show_bug.cgi?id=112455

        Reviewed by Anders Carlsson.

        - Added OVERRIDE keywords.
        - Toned down FIXMEs about single MessagePort versions of functions. It's not a given
        that we'll want to get rid of them even when implementing array versions.
        - Explicitly marked virtual destructors as virtual.

        * dom/MessageEvent.cpp:
        * dom/MessageEvent.h:
        * workers/Worker.cpp:
        * workers/Worker.h:
        Removed an unused version of postMessage() that took no MessagePorts. This makes
        it less confusing why MessagePortArray is passed by pointer, and not by reference.

        * workers/DedicatedWorkerContext.cpp:
        (WebCore::DedicatedWorkerContext::~DedicatedWorkerContext):
        * workers/DedicatedWorkerContext.h:
        Added a destructor instead of an implicit one.
        Removed an unused version of postMessage() that took no MessagePorts.

        * workers/SharedWorker.h: Removed an unused virtual function (thank you OVERRIDE!)

        * dom/MessagePort.cpp:
        * dom/MessagePort.h:
        * loader/WorkerThreadableLoader.h:
        * page/DOMWindow.h:
        * workers/AbstractWorker.h:
        * workers/DedicatedWorkerThread.h:
        * workers/SharedWorkerContext.h:
        * workers/SharedWorkerThread.h:
        * workers/WorkerContext.h:
        * workers/WorkerMessagingProxy.h:
        * workers/WorkerObjectProxy.h:
        * workers/WorkerScriptLoader.h:</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoredomMessageEventcpp">trunk/Source/WebCore/dom/MessageEvent.cpp</a></li>
<li><a href="#trunkSourceWebCoredomMessageEventh">trunk/Source/WebCore/dom/MessageEvent.h</a></li>
<li><a href="#trunkSourceWebCoredomMessagePortcpp">trunk/Source/WebCore/dom/MessagePort.cpp</a></li>
<li><a href="#trunkSourceWebCoredomMessagePorth">trunk/Source/WebCore/dom/MessagePort.h</a></li>
<li><a href="#trunkSourceWebCoreloaderWorkerThreadableLoaderh">trunk/Source/WebCore/loader/WorkerThreadableLoader.h</a></li>
<li><a href="#trunkSourceWebCorepageDOMWindowh">trunk/Source/WebCore/page/DOMWindow.h</a></li>
<li><a href="#trunkSourceWebCoreworkersAbstractWorkerh">trunk/Source/WebCore/workers/AbstractWorker.h</a></li>
<li><a href="#trunkSourceWebCoreworkersDedicatedWorkerContextcpp">trunk/Source/WebCore/workers/DedicatedWorkerContext.cpp</a></li>
<li><a href="#trunkSourceWebCoreworkersDedicatedWorkerContexth">trunk/Source/WebCore/workers/DedicatedWorkerContext.h</a></li>
<li><a href="#trunkSourceWebCoreworkersDedicatedWorkerThreadh">trunk/Source/WebCore/workers/DedicatedWorkerThread.h</a></li>
<li><a href="#trunkSourceWebCoreworkersSharedWorkerh">trunk/Source/WebCore/workers/SharedWorker.h</a></li>
<li><a href="#trunkSourceWebCoreworkersSharedWorkerContexth">trunk/Source/WebCore/workers/SharedWorkerContext.h</a></li>
<li><a href="#trunkSourceWebCoreworkersSharedWorkerThreadh">trunk/Source/WebCore/workers/SharedWorkerThread.h</a></li>
<li><a href="#trunkSourceWebCoreworkersWorkercpp">trunk/Source/WebCore/workers/Worker.cpp</a></li>
<li><a href="#trunkSourceWebCoreworkersWorkerh">trunk/Source/WebCore/workers/Worker.h</a></li>
<li><a href="#trunkSourceWebCoreworkersWorkerContexth">trunk/Source/WebCore/workers/WorkerContext.h</a></li>
<li><a href="#trunkSourceWebCoreworkersWorkerMessagingProxyh">trunk/Source/WebCore/workers/WorkerMessagingProxy.h</a></li>
<li><a href="#trunkSourceWebCoreworkersWorkerObjectProxyh">trunk/Source/WebCore/workers/WorkerObjectProxy.h</a></li>
<li><a href="#trunkSourceWebCoreworkersWorkerScriptLoaderh">trunk/Source/WebCore/workers/WorkerScriptLoader.h</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (145929 => 145930)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog        2013-03-15 18:58:05 UTC (rev 145929)
+++ trunk/Source/WebCore/ChangeLog        2013-03-15 19:03:39 UTC (rev 145930)
</span><span class="lines">@@ -1,3 +1,43 @@
</span><ins>+2013-03-15  Alexey Proskuryakov  &lt;ap@apple.com&gt;
+
+        Minor cleanup in worker code
+        https://bugs.webkit.org/show_bug.cgi?id=112455
+
+        Reviewed by Anders Carlsson.
+
+        - Added OVERRIDE keywords.
+        - Toned down FIXMEs about single MessagePort versions of functions. It's not a given
+        that we'll want to get rid of them even when implementing array versions.
+        - Explicitly marked virtual destructors as virtual.
+
+        * dom/MessageEvent.cpp:
+        * dom/MessageEvent.h:
+        * workers/Worker.cpp:
+        * workers/Worker.h:
+        Removed an unused version of postMessage() that took no MessagePorts. This makes
+        it less confusing why MessagePortArray is passed by pointer, and not by reference.
+
+        * workers/DedicatedWorkerContext.cpp:
+        (WebCore::DedicatedWorkerContext::~DedicatedWorkerContext):
+        * workers/DedicatedWorkerContext.h:
+        Added a destructor instead of an implicit one.
+        Removed an unused version of postMessage() that took no MessagePorts.
+
+        * workers/SharedWorker.h: Removed an unused virtual function (thank you OVERRIDE!)
+
+        * dom/MessagePort.cpp:
+        * dom/MessagePort.h:
+        * loader/WorkerThreadableLoader.h:
+        * page/DOMWindow.h:
+        * workers/AbstractWorker.h:
+        * workers/DedicatedWorkerThread.h:
+        * workers/SharedWorkerContext.h:
+        * workers/SharedWorkerThread.h:
+        * workers/WorkerContext.h:
+        * workers/WorkerMessagingProxy.h:
+        * workers/WorkerObjectProxy.h:
+        * workers/WorkerScriptLoader.h:
+
</ins><span class="cx"> 2013-03-15  Joshua Bell  &lt;jsbell@chromium.org&gt;
</span><span class="cx"> 
</span><span class="cx">         [V8] Binding: Implement EnforceRange IDL Attribute for long long conversions
</span></span></pre></div>
<a id="trunkSourceWebCoredomMessageEventcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/MessageEvent.cpp (145929 => 145930)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/MessageEvent.cpp        2013-03-15 18:58:05 UTC (rev 145929)
+++ trunk/Source/WebCore/dom/MessageEvent.cpp        2013-03-15 19:03:39 UTC (rev 145930)
</span><span class="lines">@@ -153,7 +153,6 @@
</span><span class="cx">     return m_dataAsSerializedScriptValue.get();
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-// FIXME: remove this when we update the ObjC bindings (bug #28774).
</del><span class="cx"> MessagePort* MessageEvent::messagePort()
</span><span class="cx"> {
</span><span class="cx">     if (!m_ports)
</span><span class="lines">@@ -162,7 +161,6 @@
</span><span class="cx">     return (*m_ports)[0].get();
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-// FIXME: remove this when we update the ObjC bindings (bug #28774).
</del><span class="cx"> void MessageEvent::initMessageEvent(const AtomicString&amp; type, bool canBubble, bool cancelable, PassRefPtr&lt;SerializedScriptValue&gt; data, const String&amp; origin, const String&amp; lastEventId, DOMWindow* source, MessagePort* port)
</span><span class="cx"> {
</span><span class="cx">     OwnPtr&lt;MessagePortArray&gt; ports;
</span></span></pre></div>
<a id="trunkSourceWebCoredomMessageEventh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/MessageEvent.h (145929 => 145930)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/MessageEvent.h        2013-03-15 18:58:05 UTC (rev 145929)
+++ trunk/Source/WebCore/dom/MessageEvent.h        2013-03-15 19:03:39 UTC (rev 145930)
</span><span class="lines">@@ -92,9 +92,9 @@
</span><span class="cx"> 
</span><span class="cx">     // FIXME: Remove this when we have custom ObjC binding support.
</span><span class="cx">     SerializedScriptValue* data() const;
</span><del>-    // FIXME: remove this when we update the ObjC bindings (bug #28774).
</del><ins>+
+    // Needed for Objective-C bindings (see bug 28774).
</ins><span class="cx">     MessagePort* messagePort();
</span><del>-    // FIXME: remove this when we update the ObjC bindings (bug #28774).
</del><span class="cx">     void initMessageEvent(const AtomicString&amp; type, bool canBubble, bool cancelable, PassRefPtr&lt;SerializedScriptValue&gt; data, const String&amp; origin, const String&amp; lastEventId, DOMWindow* source, MessagePort*);
</span><span class="cx"> 
</span><span class="cx">     virtual const AtomicString&amp; interfaceName() const;
</span></span></pre></div>
<a id="trunkSourceWebCoredomMessagePortcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/MessagePort.cpp (145929 => 145930)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/MessagePort.cpp        2013-03-15 18:58:05 UTC (rev 145929)
+++ trunk/Source/WebCore/dom/MessagePort.cpp        2013-03-15 19:03:39 UTC (rev 145930)
</span><span class="lines">@@ -57,7 +57,6 @@
</span><span class="cx">         m_scriptExecutionContext-&gt;destroyedMessagePort(this);
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-// FIXME: remove this when we update the ObjC bindings (bug #28774).
</del><span class="cx"> void MessagePort::postMessage(PassRefPtr&lt;SerializedScriptValue&gt; message, MessagePort* port, ExceptionCode&amp; ec)
</span><span class="cx"> {
</span><span class="cx">     MessagePortArray ports;
</span><span class="lines">@@ -66,11 +65,6 @@
</span><span class="cx">     postMessage(message, &amp;ports, ec);
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-void MessagePort::postMessage(PassRefPtr&lt;SerializedScriptValue&gt; message, ExceptionCode&amp; ec)
-{
-    postMessage(message, static_cast&lt;MessagePortArray*&gt;(0), ec);
-}
-
</del><span class="cx"> void MessagePort::postMessage(PassRefPtr&lt;SerializedScriptValue&gt; message, const MessagePortArray* ports, ExceptionCode&amp; ec)
</span><span class="cx"> {
</span><span class="cx">     if (!isEntangled())
</span></span></pre></div>
<a id="trunkSourceWebCoredomMessagePorth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/MessagePort.h (145929 => 145930)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/MessagePort.h        2013-03-15 18:58:05 UTC (rev 145929)
+++ trunk/Source/WebCore/dom/MessagePort.h        2013-03-15 19:03:39 UTC (rev 145930)
</span><span class="lines">@@ -55,11 +55,10 @@
</span><span class="cx">     class MessagePort : public RefCounted&lt;MessagePort&gt;, public EventTarget {
</span><span class="cx">     public:
</span><span class="cx">         static PassRefPtr&lt;MessagePort&gt; create(ScriptExecutionContext&amp; scriptExecutionContext) { return adoptRef(new MessagePort(scriptExecutionContext)); }
</span><del>-        ~MessagePort();
</del><ins>+        virtual ~MessagePort();
</ins><span class="cx"> 
</span><del>-        void postMessage(PassRefPtr&lt;SerializedScriptValue&gt; message, ExceptionCode&amp;);
</del><span class="cx">         void postMessage(PassRefPtr&lt;SerializedScriptValue&gt; message, const MessagePortArray*, ExceptionCode&amp;);
</span><del>-        // FIXME: remove this when we update the ObjC bindings (bug #28774).
</del><ins>+        // Needed for Objective-C bindings (see bug 28774).
</ins><span class="cx">         void postMessage(PassRefPtr&lt;SerializedScriptValue&gt; message, MessagePort*, ExceptionCode&amp;);
</span><span class="cx"> 
</span><span class="cx">         void start();
</span><span class="lines">@@ -82,8 +81,8 @@
</span><span class="cx"> 
</span><span class="cx">         void contextDestroyed();
</span><span class="cx"> 
</span><del>-        virtual const AtomicString&amp; interfaceName() const;
-        virtual ScriptExecutionContext* scriptExecutionContext() const;
</del><ins>+        virtual const AtomicString&amp; interfaceName() const OVERRIDE;
+        virtual ScriptExecutionContext* scriptExecutionContext() const OVERRIDE;
</ins><span class="cx"> 
</span><span class="cx">         void dispatchMessages();
</span><span class="cx"> 
</span><span class="lines">@@ -111,10 +110,10 @@
</span><span class="cx">     private:
</span><span class="cx">         explicit MessagePort(ScriptExecutionContext&amp;);
</span><span class="cx"> 
</span><del>-        virtual void refEventTarget() { ref(); }
-        virtual void derefEventTarget() { deref(); }
-        virtual EventTargetData* eventTargetData();
-        virtual EventTargetData* ensureEventTargetData();
</del><ins>+        virtual void refEventTarget() OVERRIDE { ref(); }
+        virtual void derefEventTarget() OVERRIDE { deref(); }
+        virtual EventTargetData* eventTargetData() OVERRIDE;
+        virtual EventTargetData* ensureEventTargetData() OVERRIDE;
</ins><span class="cx"> 
</span><span class="cx">         OwnPtr&lt;MessagePortChannel&gt; m_entangledChannel;
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceWebCoreloaderWorkerThreadableLoaderh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/loader/WorkerThreadableLoader.h (145929 => 145930)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/loader/WorkerThreadableLoader.h        2013-03-15 18:58:05 UTC (rev 145929)
+++ trunk/Source/WebCore/loader/WorkerThreadableLoader.h        2013-03-15 19:03:39 UTC (rev 145930)
</span><span class="lines">@@ -64,7 +64,7 @@
</span><span class="cx"> 
</span><span class="cx">         ~WorkerThreadableLoader();
</span><span class="cx"> 
</span><del>-        virtual void cancel();
</del><ins>+        virtual void cancel() OVERRIDE;
</ins><span class="cx"> 
</span><span class="cx">         bool done() const { return m_workerClientWrapper-&gt;done(); }
</span><span class="cx"> 
</span><span class="lines">@@ -72,8 +72,8 @@
</span><span class="cx">         using RefCounted&lt;WorkerThreadableLoader&gt;::deref;
</span><span class="cx"> 
</span><span class="cx">     protected:
</span><del>-        virtual void refThreadableLoader() { ref(); }
-        virtual void derefThreadableLoader() { deref(); }
</del><ins>+        virtual void refThreadableLoader() OVERRIDE { ref(); }
+        virtual void derefThreadableLoader() OVERRIDE { deref(); }
</ins><span class="cx"> 
</span><span class="cx">     private:
</span><span class="cx">         // Creates a loader on the main thread and bridges communication between
</span><span class="lines">@@ -112,14 +112,14 @@
</span><span class="cx"> 
</span><span class="cx">             static void mainThreadCreateLoader(ScriptExecutionContext*, MainThreadBridge*, PassOwnPtr&lt;CrossThreadResourceRequestData&gt;, ThreadableLoaderOptions, const String&amp; outgoingReferrer);
</span><span class="cx">             static void mainThreadCancel(ScriptExecutionContext*, MainThreadBridge*);
</span><del>-            virtual void didSendData(unsigned long long bytesSent, unsigned long long totalBytesToBeSent);
-            virtual void didReceiveResponse(unsigned long identifier, const ResourceResponse&amp;);
-            virtual void didReceiveData(const char*, int dataLength);
-            virtual void didReceiveCachedMetadata(const char*, int dataLength);
-            virtual void didFinishLoading(unsigned long identifier, double finishTime);
-            virtual void didFail(const ResourceError&amp;);
-            virtual void didFailAccessControlCheck(const ResourceError&amp;);
-            virtual void didFailRedirectCheck();
</del><ins>+            virtual void didSendData(unsigned long long bytesSent, unsigned long long totalBytesToBeSent) OVERRIDE;
+            virtual void didReceiveResponse(unsigned long identifier, const ResourceResponse&amp;) OVERRIDE;
+            virtual void didReceiveData(const char*, int dataLength) OVERRIDE;
+            virtual void didReceiveCachedMetadata(const char*, int dataLength) OVERRIDE;
+            virtual void didFinishLoading(unsigned long identifier, double finishTime) OVERRIDE;
+            virtual void didFail(const ResourceError&amp;) OVERRIDE;
+            virtual void didFailAccessControlCheck(const ResourceError&amp;) OVERRIDE;
+            virtual void didFailRedirectCheck() OVERRIDE;
</ins><span class="cx"> 
</span><span class="cx">             // Only to be used on the main thread.
</span><span class="cx">             RefPtr&lt;ThreadableLoader&gt; m_mainThreadLoader;
</span></span></pre></div>
<a id="trunkSourceWebCorepageDOMWindowh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/DOMWindow.h (145929 => 145930)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/DOMWindow.h        2013-03-15 18:58:05 UTC (rev 145929)
+++ trunk/Source/WebCore/page/DOMWindow.h        2013-03-15 19:03:39 UTC (rev 145930)
</span><span class="lines">@@ -238,7 +238,7 @@
</span><span class="cx">         String crossDomainAccessErrorMessage(DOMWindow* activeWindow);
</span><span class="cx"> 
</span><span class="cx">         void postMessage(PassRefPtr&lt;SerializedScriptValue&gt; message, const MessagePortArray*, const String&amp; targetOrigin, DOMWindow* source, ExceptionCode&amp;);
</span><del>-        // FIXME: remove this when we update the ObjC bindings (bug #28774).
</del><ins>+        // Needed for Objective-C bindings (see bug 28774).
</ins><span class="cx">         void postMessage(PassRefPtr&lt;SerializedScriptValue&gt; message, MessagePort*, const String&amp; targetOrigin, DOMWindow* source, ExceptionCode&amp;);
</span><span class="cx">         void postMessageTimerFired(PassOwnPtr&lt;PostMessageTimer&gt;);
</span><span class="cx">         void dispatchMessageEventWithOriginCheck(SecurityOrigin* intendedTargetOrigin, PassRefPtr&lt;Event&gt;, PassRefPtr&lt;ScriptCallStack&gt;);
</span></span></pre></div>
<a id="trunkSourceWebCoreworkersAbstractWorkerh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/workers/AbstractWorker.h (145929 => 145930)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/workers/AbstractWorker.h        2013-03-15 18:58:05 UTC (rev 145929)
+++ trunk/Source/WebCore/workers/AbstractWorker.h        2013-03-15 19:03:39 UTC (rev 145930)
</span><span class="lines">@@ -50,14 +50,14 @@
</span><span class="cx">     class AbstractWorker : public RefCounted&lt;AbstractWorker&gt;, public ActiveDOMObject, public EventTarget {
</span><span class="cx">     public:
</span><span class="cx">         // EventTarget APIs
</span><del>-        virtual ScriptExecutionContext* scriptExecutionContext() const { return ActiveDOMObject::scriptExecutionContext(); }
</del><ins>+        virtual ScriptExecutionContext* scriptExecutionContext() const OVERRIDE { return ActiveDOMObject::scriptExecutionContext(); }
</ins><span class="cx"> 
</span><span class="cx">         DEFINE_ATTRIBUTE_EVENT_LISTENER(error);
</span><span class="cx"> 
</span><span class="cx">         using RefCounted&lt;AbstractWorker&gt;::ref;
</span><span class="cx">         using RefCounted&lt;AbstractWorker&gt;::deref;
</span><span class="cx"> 
</span><del>-        virtual void contextDestroyed();
</del><ins>+        virtual void contextDestroyed() OVERRIDE;
</ins><span class="cx">         AbstractWorker(ScriptExecutionContext*);
</span><span class="cx">         virtual ~AbstractWorker();
</span><span class="cx"> 
</span><span class="lines">@@ -67,10 +67,10 @@
</span><span class="cx">         intptr_t asID() const { return reinterpret_cast&lt;intptr_t&gt;(this); }
</span><span class="cx"> 
</span><span class="cx">     private:
</span><del>-        virtual void refEventTarget() { ref(); }
-        virtual void derefEventTarget() { deref(); }
-        virtual EventTargetData* eventTargetData();
-        virtual EventTargetData* ensureEventTargetData();
</del><ins>+        virtual void refEventTarget() OVERRIDE { ref(); }
+        virtual void derefEventTarget() OVERRIDE { deref(); }
+        virtual EventTargetData* eventTargetData() OVERRIDE;
+        virtual EventTargetData* ensureEventTargetData() OVERRIDE;
</ins><span class="cx">         
</span><span class="cx">         EventTargetData m_eventTargetData;
</span><span class="cx">     };
</span></span></pre></div>
<a id="trunkSourceWebCoreworkersDedicatedWorkerContextcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/workers/DedicatedWorkerContext.cpp (145929 => 145930)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/workers/DedicatedWorkerContext.cpp        2013-03-15 18:58:05 UTC (rev 145929)
+++ trunk/Source/WebCore/workers/DedicatedWorkerContext.cpp        2013-03-15 19:03:39 UTC (rev 145930)
</span><span class="lines">@@ -41,7 +41,6 @@
</span><span class="cx"> 
</span><span class="cx"> namespace WebCore {
</span><span class="cx"> 
</span><del>-// static
</del><span class="cx"> PassRefPtr&lt;DedicatedWorkerContext&gt; DedicatedWorkerContext::create(const KURL&amp; url, const String&amp; userAgent, PassOwnPtr&lt;GroupSettings&gt; settings, DedicatedWorkerThread* thread, const String&amp; contentSecurityPolicy, ContentSecurityPolicy::HeaderType contentSecurityPolicyType, PassRefPtr&lt;SecurityOrigin&gt; topOrigin)
</span><span class="cx"> {
</span><span class="cx">     RefPtr&lt;DedicatedWorkerContext&gt; context = adoptRef(new DedicatedWorkerContext(url, userAgent, settings, thread, topOrigin));
</span><span class="lines">@@ -54,12 +53,15 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx"> 
</span><ins>+DedicatedWorkerContext::~DedicatedWorkerContext()
+{
+}
+
</ins><span class="cx"> const AtomicString&amp; DedicatedWorkerContext::interfaceName() const
</span><span class="cx"> {
</span><span class="cx">     return eventNames().interfaceForDedicatedWorkerContext;
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-// FIXME: remove this when we update the ObjC bindings (bug #28774).
</del><span class="cx"> void DedicatedWorkerContext::postMessage(PassRefPtr&lt;SerializedScriptValue&gt; message, MessagePort* port, ExceptionCode&amp; ec)
</span><span class="cx"> {
</span><span class="cx">     MessagePortArray ports;
</span><span class="lines">@@ -68,11 +70,6 @@
</span><span class="cx">     postMessage(message, &amp;ports, ec);
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-void DedicatedWorkerContext::postMessage(PassRefPtr&lt;SerializedScriptValue&gt; message, ExceptionCode&amp; ec)
-{
-    postMessage(message, static_cast&lt;MessagePortArray*&gt;(0), ec);
-}
-
</del><span class="cx"> void DedicatedWorkerContext::postMessage(PassRefPtr&lt;SerializedScriptValue&gt; message, const MessagePortArray* ports, ExceptionCode&amp; ec)
</span><span class="cx"> {
</span><span class="cx">     // Disentangle the port in preparation for sending it to the remote context.
</span></span></pre></div>
<a id="trunkSourceWebCoreworkersDedicatedWorkerContexth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/workers/DedicatedWorkerContext.h (145929 => 145930)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/workers/DedicatedWorkerContext.h        2013-03-15 18:58:05 UTC (rev 145929)
+++ trunk/Source/WebCore/workers/DedicatedWorkerContext.h        2013-03-15 19:03:39 UTC (rev 145930)
</span><span class="lines">@@ -45,23 +45,24 @@
</span><span class="cx">     public:
</span><span class="cx">         typedef WorkerContext Base;
</span><span class="cx">         static PassRefPtr&lt;DedicatedWorkerContext&gt; create(const KURL&amp;, const String&amp; userAgent, PassOwnPtr&lt;GroupSettings&gt;, DedicatedWorkerThread*, const String&amp; contentSecurityPolicy, ContentSecurityPolicy::HeaderType contentSecurityPolicyType, PassRefPtr&lt;SecurityOrigin&gt; topOrigin);
</span><ins>+        virtual ~DedicatedWorkerContext();
</ins><span class="cx"> 
</span><del>-        virtual bool isDedicatedWorkerContext() const { return true; }
</del><ins>+        virtual bool isDedicatedWorkerContext() const OVERRIDE { return true; }
</ins><span class="cx"> 
</span><span class="cx">         // Overridden to allow us to check our pending activity after executing imported script.
</span><del>-        virtual void importScripts(const Vector&lt;String&gt;&amp; urls, ExceptionCode&amp;);
</del><ins>+        virtual void importScripts(const Vector&lt;String&gt;&amp; urls, ExceptionCode&amp;) OVERRIDE;
</ins><span class="cx"> 
</span><span class="cx">         // EventTarget
</span><del>-        virtual const AtomicString&amp; interfaceName() const;
</del><ins>+        virtual const AtomicString&amp; interfaceName() const OVERRIDE;
</ins><span class="cx"> 
</span><del>-        void postMessage(PassRefPtr&lt;SerializedScriptValue&gt;, ExceptionCode&amp;);
</del><span class="cx">         void postMessage(PassRefPtr&lt;SerializedScriptValue&gt;, const MessagePortArray*, ExceptionCode&amp;);
</span><del>-        // FIXME: remove this when we update the ObjC bindings (bug #28774).
</del><ins>+        // Needed for Objective-C bindings (see bug 28774).
</ins><span class="cx">         void postMessage(PassRefPtr&lt;SerializedScriptValue&gt;, MessagePort*, ExceptionCode&amp;);
</span><span class="cx"> 
</span><span class="cx">         DEFINE_ATTRIBUTE_EVENT_LISTENER(message);
</span><span class="cx"> 
</span><span class="cx">         DedicatedWorkerThread* thread();
</span><ins>+
</ins><span class="cx">     private:
</span><span class="cx">         DedicatedWorkerContext(const KURL&amp;, const String&amp; userAgent, PassOwnPtr&lt;GroupSettings&gt;, DedicatedWorkerThread*, PassRefPtr&lt;SecurityOrigin&gt; topOrigin);
</span><span class="cx">     };
</span></span></pre></div>
<a id="trunkSourceWebCoreworkersDedicatedWorkerThreadh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/workers/DedicatedWorkerThread.h (145929 => 145930)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/workers/DedicatedWorkerThread.h        2013-03-15 18:58:05 UTC (rev 145929)
+++ trunk/Source/WebCore/workers/DedicatedWorkerThread.h        2013-03-15 19:03:39 UTC (rev 145930)
</span><span class="lines">@@ -43,11 +43,11 @@
</span><span class="cx">     public:
</span><span class="cx">         static PassRefPtr&lt;DedicatedWorkerThread&gt; create(const KURL&amp; scriptURL, const String&amp; userAgent, const GroupSettings*, const String&amp; sourceCode, WorkerLoaderProxy&amp;, WorkerObjectProxy&amp;, WorkerThreadStartMode, const String&amp; contentSecurityPolicy, ContentSecurityPolicy::HeaderType, const SecurityOrigin* topOrigin);
</span><span class="cx">         WorkerObjectProxy&amp; workerObjectProxy() const { return m_workerObjectProxy; }
</span><del>-        ~DedicatedWorkerThread();
</del><ins>+        virtual ~DedicatedWorkerThread();
</ins><span class="cx"> 
</span><span class="cx">     protected:
</span><del>-        virtual PassRefPtr&lt;WorkerContext&gt; createWorkerContext(const KURL&amp;, const String&amp; userAgent, PassOwnPtr&lt;GroupSettings&gt;, const String&amp; contentSecurityPolicy, ContentSecurityPolicy::HeaderType, PassRefPtr&lt;SecurityOrigin&gt; topOrigin);
-        virtual void runEventLoop();
</del><ins>+        virtual PassRefPtr&lt;WorkerContext&gt; createWorkerContext(const KURL&amp;, const String&amp; userAgent, PassOwnPtr&lt;GroupSettings&gt;, const String&amp; contentSecurityPolicy, ContentSecurityPolicy::HeaderType, PassRefPtr&lt;SecurityOrigin&gt; topOrigin) OVERRIDE;
+        virtual void runEventLoop() OVERRIDE;
</ins><span class="cx"> 
</span><span class="cx">     private:
</span><span class="cx">         DedicatedWorkerThread(const KURL&amp;, const String&amp; userAgent, const GroupSettings*, const String&amp; sourceCode, WorkerLoaderProxy&amp;, WorkerObjectProxy&amp;, WorkerThreadStartMode, const String&amp; contentSecurityPolicy, ContentSecurityPolicy::HeaderType, const SecurityOrigin* topOrigin);
</span></span></pre></div>
<a id="trunkSourceWebCoreworkersSharedWorkerh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/workers/SharedWorker.h (145929 => 145930)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/workers/SharedWorker.h        2013-03-15 18:58:05 UTC (rev 145929)
+++ trunk/Source/WebCore/workers/SharedWorker.h        2013-03-15 19:03:39 UTC (rev 145930)
</span><span class="lines">@@ -45,13 +45,11 @@
</span><span class="cx"> 
</span><span class="cx">         MessagePort* port() const { return m_port.get(); }
</span><span class="cx"> 
</span><del>-        virtual const AtomicString&amp; interfaceName() const;
</del><ins>+        virtual const AtomicString&amp; interfaceName() const OVERRIDE;
</ins><span class="cx"> 
</span><span class="cx">     private:
</span><span class="cx">         explicit SharedWorker(ScriptExecutionContext*);
</span><span class="cx"> 
</span><del>-        virtual SharedWorker* toSharedWorker() { return this; }
-
</del><span class="cx">         RefPtr&lt;MessagePort&gt; m_port;
</span><span class="cx">     };
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceWebCoreworkersSharedWorkerContexth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/workers/SharedWorkerContext.h (145929 => 145930)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/workers/SharedWorkerContext.h        2013-03-15 18:58:05 UTC (rev 145929)
+++ trunk/Source/WebCore/workers/SharedWorkerContext.h        2013-03-15 19:03:39 UTC (rev 145930)
</span><span class="lines">@@ -47,19 +47,20 @@
</span><span class="cx">         static PassRefPtr&lt;SharedWorkerContext&gt; create(const String&amp; name, const KURL&amp;, const String&amp; userAgent, PassOwnPtr&lt;GroupSettings&gt;, SharedWorkerThread*, const String&amp; contentSecurityPolicy, ContentSecurityPolicy::HeaderType contentSecurityPolicyType);
</span><span class="cx">         virtual ~SharedWorkerContext();
</span><span class="cx"> 
</span><del>-        virtual bool isSharedWorkerContext() const { return true; }
</del><ins>+        virtual bool isSharedWorkerContext() const OVERRIDE { return true; }
</ins><span class="cx"> 
</span><span class="cx">         // EventTarget
</span><del>-        virtual const AtomicString&amp; interfaceName() const;
</del><ins>+        virtual const AtomicString&amp; interfaceName() const OVERRIDE;
</ins><span class="cx"> 
</span><span class="cx">         // Setters/Getters for attributes in SharedWorkerContext.idl
</span><span class="cx">         DEFINE_ATTRIBUTE_EVENT_LISTENER(connect);
</span><span class="cx">         String name() const { return m_name; }
</span><span class="cx"> 
</span><span class="cx">         SharedWorkerThread* thread();
</span><ins>+
</ins><span class="cx">     private:
</span><span class="cx">         SharedWorkerContext(const String&amp; name, const KURL&amp;, const String&amp; userAgent, PassOwnPtr&lt;GroupSettings&gt;, SharedWorkerThread*);
</span><del>-        virtual void logExceptionToConsole(const String&amp; errorMessage, const String&amp; sourceURL, int lineNumber, PassRefPtr&lt;ScriptCallStack&gt;);
</del><ins>+        virtual void logExceptionToConsole(const String&amp; errorMessage, const String&amp; sourceURL, int lineNumber, PassRefPtr&lt;ScriptCallStack&gt;) OVERRIDE;
</ins><span class="cx"> 
</span><span class="cx">         String m_name;
</span><span class="cx">     };
</span></span></pre></div>
<a id="trunkSourceWebCoreworkersSharedWorkerThreadh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/workers/SharedWorkerThread.h (145929 => 145930)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/workers/SharedWorkerThread.h        2013-03-15 18:58:05 UTC (rev 145929)
+++ trunk/Source/WebCore/workers/SharedWorkerThread.h        2013-03-15 19:03:39 UTC (rev 145930)
</span><span class="lines">@@ -40,10 +40,10 @@
</span><span class="cx">     class SharedWorkerThread : public WorkerThread {
</span><span class="cx">     public:
</span><span class="cx">         static PassRefPtr&lt;SharedWorkerThread&gt; create(const String&amp; name, const KURL&amp;, const String&amp; userAgent, const GroupSettings*, const String&amp; sourceCode, WorkerLoaderProxy&amp;, WorkerReportingProxy&amp;, WorkerThreadStartMode, const String&amp; contentSecurityPolicy, ContentSecurityPolicy::HeaderType);
</span><del>-        ~SharedWorkerThread();
</del><ins>+        virtual ~SharedWorkerThread();
</ins><span class="cx"> 
</span><span class="cx">     protected:
</span><del>-        virtual PassRefPtr&lt;WorkerContext&gt; createWorkerContext(const KURL&amp;, const String&amp; userAgent, PassOwnPtr&lt;GroupSettings&gt;, const String&amp; contentSecurityPolicy, ContentSecurityPolicy::HeaderType, PassRefPtr&lt;SecurityOrigin&gt; topOrigin);
</del><ins>+        virtual PassRefPtr&lt;WorkerContext&gt; createWorkerContext(const KURL&amp;, const String&amp; userAgent, PassOwnPtr&lt;GroupSettings&gt;, const String&amp; contentSecurityPolicy, ContentSecurityPolicy::HeaderType, PassRefPtr&lt;SecurityOrigin&gt; topOrigin) OVERRIDE;
</ins><span class="cx"> 
</span><span class="cx">     private:
</span><span class="cx">         SharedWorkerThread(const String&amp; name, const KURL&amp;, const String&amp; userAgent, const GroupSettings*, const String&amp; sourceCode, WorkerLoaderProxy&amp;, WorkerReportingProxy&amp;, WorkerThreadStartMode, const String&amp; contentSecurityPolicy, ContentSecurityPolicy::HeaderType);
</span></span></pre></div>
<a id="trunkSourceWebCoreworkersWorkercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/workers/Worker.cpp (145929 => 145930)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/workers/Worker.cpp        2013-03-15 18:58:05 UTC (rev 145929)
+++ trunk/Source/WebCore/workers/Worker.cpp        2013-03-15 19:03:39 UTC (rev 145930)
</span><span class="lines">@@ -94,7 +94,6 @@
</span><span class="cx">     return eventNames().interfaceForWorker;
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-// FIXME: remove this when we update the ObjC bindings (bug #28774).
</del><span class="cx"> void Worker::postMessage(PassRefPtr&lt;SerializedScriptValue&gt; message, MessagePort* port, ExceptionCode&amp; ec)
</span><span class="cx"> {
</span><span class="cx">     MessagePortArray ports;
</span><span class="lines">@@ -103,11 +102,6 @@
</span><span class="cx">     postMessage(message, &amp;ports, ec);
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-void Worker::postMessage(PassRefPtr&lt;SerializedScriptValue&gt; message, ExceptionCode&amp; ec)
-{
-    postMessage(message, static_cast&lt;MessagePortArray*&gt;(0), ec);
-}
-
</del><span class="cx"> void Worker::postMessage(PassRefPtr&lt;SerializedScriptValue&gt; message, const MessagePortArray* ports, ExceptionCode&amp; ec)
</span><span class="cx"> {
</span><span class="cx">     // Disentangle the port in preparation for sending it to the remote context.
</span></span></pre></div>
<a id="trunkSourceWebCoreworkersWorkerh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/workers/Worker.h (145929 => 145930)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/workers/Worker.h        2013-03-15 18:58:05 UTC (rev 145929)
+++ trunk/Source/WebCore/workers/Worker.h        2013-03-15 19:03:39 UTC (rev 145930)
</span><span class="lines">@@ -54,18 +54,17 @@
</span><span class="cx">         static PassRefPtr&lt;Worker&gt; create(ScriptExecutionContext*, const String&amp; url, ExceptionCode&amp;);
</span><span class="cx">         virtual ~Worker();
</span><span class="cx"> 
</span><del>-        virtual const AtomicString&amp; interfaceName() const;
</del><ins>+        virtual const AtomicString&amp; interfaceName() const OVERRIDE;
</ins><span class="cx"> 
</span><del>-        void postMessage(PassRefPtr&lt;SerializedScriptValue&gt; message, ExceptionCode&amp;);
</del><span class="cx">         void postMessage(PassRefPtr&lt;SerializedScriptValue&gt; message, const MessagePortArray*, ExceptionCode&amp;);
</span><del>-        // FIXME: remove this when we update the ObjC bindings (bug #28774).
</del><ins>+        // Needed for Objective-C bindings (see bug 28774).
</ins><span class="cx">         void postMessage(PassRefPtr&lt;SerializedScriptValue&gt; message, MessagePort*, ExceptionCode&amp;);
</span><span class="cx"> 
</span><span class="cx">         void terminate();
</span><span class="cx"> 
</span><del>-        virtual bool canSuspend() const;
-        virtual void stop();
-        virtual bool hasPendingActivity() const;
</del><ins>+        virtual bool canSuspend() const OVERRIDE;
+        virtual void stop() OVERRIDE;
+        virtual bool hasPendingActivity() const OVERRIDE;
</ins><span class="cx">     
</span><span class="cx">         DEFINE_ATTRIBUTE_EVENT_LISTENER(message);
</span><span class="cx"> 
</span><span class="lines">@@ -73,11 +72,11 @@
</span><span class="cx">         explicit Worker(ScriptExecutionContext*);
</span><span class="cx"> 
</span><span class="cx">         // WorkerScriptLoaderClient callbacks
</span><del>-        virtual void didReceiveResponse(unsigned long identifier, const ResourceResponse&amp;);
-        virtual void notifyFinished();
</del><ins>+        virtual void didReceiveResponse(unsigned long identifier, const ResourceResponse&amp;) OVERRIDE;
+        virtual void notifyFinished() OVERRIDE;
</ins><span class="cx"> 
</span><del>-        virtual void refEventTarget() { ref(); }
-        virtual void derefEventTarget() { deref(); }
</del><ins>+        virtual void refEventTarget() OVERRIDE { ref(); }
+        virtual void derefEventTarget() OVERRIDE { deref(); }
</ins><span class="cx"> 
</span><span class="cx">         RefPtr&lt;WorkerScriptLoader&gt; m_scriptLoader;
</span><span class="cx">         WorkerContextProxy* m_contextProxy; // The proxy outlives the worker to perform thread shutdown.
</span></span></pre></div>
<a id="trunkSourceWebCoreworkersWorkerContexth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/workers/WorkerContext.h (145929 => 145930)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/workers/WorkerContext.h        2013-03-15 18:58:05 UTC (rev 145929)
+++ trunk/Source/WebCore/workers/WorkerContext.h        2013-03-15 19:03:39 UTC (rev 145930)
</span><span class="lines">@@ -59,9 +59,9 @@
</span><span class="cx">     public:
</span><span class="cx">         virtual ~WorkerContext();
</span><span class="cx"> 
</span><del>-        virtual bool isWorkerContext() const { return true; }
</del><ins>+        virtual bool isWorkerContext() const OVERRIDE { return true; }
</ins><span class="cx"> 
</span><del>-        virtual ScriptExecutionContext* scriptExecutionContext() const;
</del><ins>+        virtual ScriptExecutionContext* scriptExecutionContext() const OVERRIDE;
</ins><span class="cx"> 
</span><span class="cx">         virtual bool isSharedWorkerContext() const { return false; }
</span><span class="cx">         virtual bool isDedicatedWorkerContext() const { return false; }
</span><span class="lines">@@ -72,7 +72,7 @@
</span><span class="cx">         const GroupSettings* groupSettings() { return m_groupSettings.get(); }
</span><span class="cx">         virtual String userAgent(const KURL&amp;) const;
</span><span class="cx"> 
</span><del>-        virtual void disableEval(const String&amp; errorMessage);
</del><ins>+        virtual void disableEval(const String&amp; errorMessage) OVERRIDE;
</ins><span class="cx"> 
</span><span class="cx">         WorkerScriptController* script() { return m_script.get(); }
</span><span class="cx">         void clearScript() { m_script.clear(); }
</span><span class="lines">@@ -84,7 +84,7 @@
</span><span class="cx"> 
</span><span class="cx">         bool hasPendingActivity() const;
</span><span class="cx"> 
</span><del>-        virtual void postTask(PassOwnPtr&lt;Task&gt;); // Executes the task on context's thread asynchronously.
</del><ins>+        virtual void postTask(PassOwnPtr&lt;Task&gt;) OVERRIDE; // Executes the task on context's thread asynchronously.
</ins><span class="cx"> 
</span><span class="cx">         // WorkerGlobalScope
</span><span class="cx">         WorkerContext* self() { return this; }
</span><span class="lines">@@ -104,10 +104,10 @@
</span><span class="cx">         void clearInterval(int timeoutId);
</span><span class="cx"> 
</span><span class="cx">         // ScriptExecutionContext
</span><del>-        virtual WorkerEventQueue* eventQueue() const;
</del><ins>+        virtual WorkerEventQueue* eventQueue() const OVERRIDE;
</ins><span class="cx"> 
</span><del>-        virtual bool isContextThread() const;
-        virtual bool isJSExecutionForbidden() const;
</del><ins>+        virtual bool isContextThread() const OVERRIDE;
+        virtual bool isJSExecutionForbidden() const OVERRIDE;
</ins><span class="cx"> 
</span><span class="cx"> #if ENABLE(INSPECTOR)
</span><span class="cx">         WorkerInspectorController* workerInspectorController() { return m_workerInspectorController.get(); }
</span><span class="lines">@@ -144,25 +144,25 @@
</span><span class="cx">         WorkerContext(const KURL&amp;, const String&amp; userAgent, PassOwnPtr&lt;GroupSettings&gt;, WorkerThread*, PassRefPtr&lt;SecurityOrigin&gt; topOrigin);
</span><span class="cx">         void applyContentSecurityPolicyFromString(const String&amp; contentSecurityPolicy, ContentSecurityPolicy::HeaderType);
</span><span class="cx"> 
</span><del>-        virtual void logExceptionToConsole(const String&amp; errorMessage, const String&amp; sourceURL, int lineNumber, PassRefPtr&lt;ScriptCallStack&gt;);
</del><ins>+        virtual void logExceptionToConsole(const String&amp; errorMessage, const String&amp; sourceURL, int lineNumber, PassRefPtr&lt;ScriptCallStack&gt;) OVERRIDE;
</ins><span class="cx">         void addMessageToWorkerConsole(MessageSource, MessageLevel, const String&amp; message, const String&amp; sourceURL, unsigned lineNumber, PassRefPtr&lt;ScriptCallStack&gt;, ScriptState* = 0, unsigned long requestIdentifier = 0);
</span><span class="cx"> 
</span><span class="cx">     private:
</span><del>-        virtual void refScriptExecutionContext() { ref(); }
-        virtual void derefScriptExecutionContext() { deref(); }
</del><ins>+        virtual void refScriptExecutionContext() OVERRIDE { ref(); }
+        virtual void derefScriptExecutionContext() OVERRIDE { deref(); }
</ins><span class="cx"> 
</span><del>-        virtual void refEventTarget() { ref(); }
-        virtual void derefEventTarget() { deref(); }
-        virtual EventTargetData* eventTargetData();
-        virtual EventTargetData* ensureEventTargetData();
</del><ins>+        virtual void refEventTarget() OVERRIDE { ref(); }
+        virtual void derefEventTarget() OVERRIDE { deref(); }
+        virtual EventTargetData* eventTargetData() OVERRIDE;
+        virtual EventTargetData* ensureEventTargetData() OVERRIDE;
</ins><span class="cx"> 
</span><del>-        virtual const KURL&amp; virtualURL() const;
</del><ins>+        virtual const KURL&amp; virtualURL() const OVERRIDE;
</ins><span class="cx">         virtual KURL virtualCompleteURL(const String&amp;) const;
</span><span class="cx"> 
</span><del>-        virtual void addMessage(MessageSource, MessageLevel, const String&amp; message, const String&amp; sourceURL, unsigned lineNumber, PassRefPtr&lt;ScriptCallStack&gt;, ScriptState* = 0, unsigned long requestIdentifier = 0);
-        virtual void addConsoleMessage(MessageSource, MessageLevel, const String&amp; message, unsigned long requestIdentifier = 0);
</del><ins>+        virtual void addMessage(MessageSource, MessageLevel, const String&amp; message, const String&amp; sourceURL, unsigned lineNumber, PassRefPtr&lt;ScriptCallStack&gt;, ScriptState* = 0, unsigned long requestIdentifier = 0) OVERRIDE;
+        virtual void addConsoleMessage(MessageSource, MessageLevel, const String&amp; message, unsigned long requestIdentifier = 0) OVERRIDE;
</ins><span class="cx"> 
</span><del>-        virtual EventTarget* errorEventTarget();
</del><ins>+        virtual EventTarget* errorEventTarget() OVERRIDE;
</ins><span class="cx"> 
</span><span class="cx">         KURL m_url;
</span><span class="cx">         String m_userAgent;
</span></span></pre></div>
<a id="trunkSourceWebCoreworkersWorkerMessagingProxyh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/workers/WorkerMessagingProxy.h (145929 => 145930)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/workers/WorkerMessagingProxy.h        2013-03-15 18:58:05 UTC (rev 145929)
+++ trunk/Source/WebCore/workers/WorkerMessagingProxy.h        2013-03-15 19:03:39 UTC (rev 145930)
</span><span class="lines">@@ -53,36 +53,36 @@
</span><span class="cx"> 
</span><span class="cx">         // Implementations of WorkerContextProxy.
</span><span class="cx">         // (Only use these methods in the worker object thread.)
</span><del>-        virtual void startWorkerContext(const KURL&amp; scriptURL, const String&amp; userAgent, const String&amp; sourceCode, WorkerThreadStartMode);
-        virtual void terminateWorkerContext();
-        virtual void postMessageToWorkerContext(PassRefPtr&lt;SerializedScriptValue&gt;, PassOwnPtr&lt;MessagePortChannelArray&gt;);
-        virtual bool hasPendingActivity() const;
-        virtual void workerObjectDestroyed();
</del><ins>+        virtual void startWorkerContext(const KURL&amp; scriptURL, const String&amp; userAgent, const String&amp; sourceCode, WorkerThreadStartMode) OVERRIDE;
+        virtual void terminateWorkerContext() OVERRIDE;
+        virtual void postMessageToWorkerContext(PassRefPtr&lt;SerializedScriptValue&gt;, PassOwnPtr&lt;MessagePortChannelArray&gt;) OVERRIDE;
+        virtual bool hasPendingActivity() const OVERRIDE;
+        virtual void workerObjectDestroyed() OVERRIDE;
</ins><span class="cx"> #if ENABLE(INSPECTOR)
</span><del>-        virtual void connectToInspector(WorkerContextProxy::PageInspector*);
-        virtual void disconnectFromInspector();
-        virtual void sendMessageToInspector(const String&amp;);
</del><ins>+        virtual void connectToInspector(WorkerContextProxy::PageInspector*) OVERRIDE;
+        virtual void disconnectFromInspector() OVERRIDE;
+        virtual void sendMessageToInspector(const String&amp;) OVERRIDE;
</ins><span class="cx"> #endif
</span><span class="cx"> 
</span><span class="cx">         // Implementations of WorkerObjectProxy.
</span><span class="cx">         // (Only use these methods in the worker context thread.)
</span><del>-        virtual void postMessageToWorkerObject(PassRefPtr&lt;SerializedScriptValue&gt;, PassOwnPtr&lt;MessagePortChannelArray&gt;);
-        virtual void postExceptionToWorkerObject(const String&amp; errorMessage, int lineNumber, const String&amp; sourceURL);
-        virtual void postConsoleMessageToWorkerObject(MessageSource, MessageLevel, const String&amp; message, int lineNumber, const String&amp; sourceURL);
</del><ins>+        virtual void postMessageToWorkerObject(PassRefPtr&lt;SerializedScriptValue&gt;, PassOwnPtr&lt;MessagePortChannelArray&gt;) OVERRIDE;
+        virtual void postExceptionToWorkerObject(const String&amp; errorMessage, int lineNumber, const String&amp; sourceURL) OVERRIDE;
+        virtual void postConsoleMessageToWorkerObject(MessageSource, MessageLevel, const String&amp; message, int lineNumber, const String&amp; sourceURL) OVERRIDE;
</ins><span class="cx"> #if ENABLE(INSPECTOR)
</span><del>-        virtual void postMessageToPageInspector(const String&amp;);
-        virtual void updateInspectorStateCookie(const String&amp;);
</del><ins>+        virtual void postMessageToPageInspector(const String&amp;) OVERRIDE;
+        virtual void updateInspectorStateCookie(const String&amp;) OVERRIDE;
</ins><span class="cx"> #endif
</span><del>-        virtual void confirmMessageFromWorkerObject(bool hasPendingActivity);
-        virtual void reportPendingActivity(bool hasPendingActivity);
-        virtual void workerContextClosed();
-        virtual void workerContextDestroyed();
</del><ins>+        virtual void confirmMessageFromWorkerObject(bool hasPendingActivity) OVERRIDE;
+        virtual void reportPendingActivity(bool hasPendingActivity) OVERRIDE;
+        virtual void workerContextClosed() OVERRIDE;
+        virtual void workerContextDestroyed() OVERRIDE;
</ins><span class="cx"> 
</span><span class="cx">         // Implementation of WorkerLoaderProxy.
</span><span class="cx">         // These methods are called on different threads to schedule loading
</span><span class="cx">         // requests and to send callbacks back to WorkerContext.
</span><del>-        virtual void postTaskToLoader(PassOwnPtr&lt;ScriptExecutionContext::Task&gt;);
-        virtual bool postTaskForModeToWorkerContext(PassOwnPtr&lt;ScriptExecutionContext::Task&gt;, const String&amp; mode);
</del><ins>+        virtual void postTaskToLoader(PassOwnPtr&lt;ScriptExecutionContext::Task&gt;) OVERRIDE;
+        virtual bool postTaskForModeToWorkerContext(PassOwnPtr&lt;ScriptExecutionContext::Task&gt;, const String&amp; mode) OVERRIDE;
</ins><span class="cx"> 
</span><span class="cx">         void workerThreadCreated(PassRefPtr&lt;DedicatedWorkerThread&gt;);
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceWebCoreworkersWorkerObjectProxyh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/workers/WorkerObjectProxy.h (145929 => 145930)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/workers/WorkerObjectProxy.h        2013-03-15 18:58:05 UTC (rev 145929)
+++ trunk/Source/WebCore/workers/WorkerObjectProxy.h        2013-03-15 19:03:39 UTC (rev 145930)
</span><span class="lines">@@ -50,7 +50,7 @@
</span><span class="cx">         virtual void reportPendingActivity(bool hasPendingActivity) = 0;
</span><span class="cx"> 
</span><span class="cx">         // No need to notify the parent page context when dedicated workers are closing.
</span><del>-        virtual void workerContextClosed() { }
</del><ins>+        virtual void workerContextClosed() OVERRIDE { }
</ins><span class="cx">     };
</span><span class="cx"> 
</span><span class="cx"> } // namespace WebCore
</span></span></pre></div>
<a id="trunkSourceWebCoreworkersWorkerScriptLoaderh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/workers/WorkerScriptLoader.h (145929 => 145930)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/workers/WorkerScriptLoader.h        2013-03-15 18:58:05 UTC (rev 145929)
+++ trunk/Source/WebCore/workers/WorkerScriptLoader.h        2013-03-15 19:03:39 UTC (rev 145930)
</span><span class="lines">@@ -67,11 +67,11 @@
</span><span class="cx">         bool failed() const { return m_failed; }
</span><span class="cx">         unsigned long identifier() const { return m_identifier; }
</span><span class="cx"> 
</span><del>-        virtual void didReceiveResponse(unsigned long /*identifier*/, const ResourceResponse&amp;);
-        virtual void didReceiveData(const char* data, int dataLength);
-        virtual void didFinishLoading(unsigned long identifier, double);
-        virtual void didFail(const ResourceError&amp;);
-        virtual void didFailRedirectCheck();
</del><ins>+        virtual void didReceiveResponse(unsigned long /*identifier*/, const ResourceResponse&amp;) OVERRIDE;
+        virtual void didReceiveData(const char* data, int dataLength) OVERRIDE;
+        virtual void didFinishLoading(unsigned long identifier, double) OVERRIDE;
+        virtual void didFail(const ResourceError&amp;) OVERRIDE;
+        virtual void didFailRedirectCheck() OVERRIDE;
</ins><span class="cx"> 
</span><span class="cx"> #if PLATFORM(CHROMIUM) || PLATFORM(BLACKBERRY)
</span><span class="cx">         void setTargetType(ResourceRequest::TargetType targetType) { m_targetType = targetType; }
</span></span></pre>
</div>
</div>

</body>
</html>