<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[145048] trunk</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/145048">145048</a></dd>
<dt>Author</dt> <dd>vsevik@chromium.org</dd>
<dt>Date</dt> <dd>2013-03-07 00:27:14 -0800 (Thu, 07 Mar 2013)</dd>
</dl>

<h3>Log Message</h3>
<pre>Web Inspector: NavigatorView should show (program) for uiSourceCodes with empty name.
https://bugs.webkit.org/show_bug.cgi?id=111691

Reviewed by Alexander Pavlov.

Source/WebCore:

Made String.prototype methods return string literal, not String object.

* inspector/front-end/utilities.js:
(String.prototype.escapeCharacters):

LayoutTests:

* inspector/debugger/navigator-view-expected.txt:
* inspector/debugger/navigator-view.html:</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsinspectordebuggernavigatorviewexpectedtxt">trunk/LayoutTests/inspector/debugger/navigator-view-expected.txt</a></li>
<li><a href="#trunkLayoutTestsinspectordebuggernavigatorviewhtml">trunk/LayoutTests/inspector/debugger/navigator-view.html</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreinspectorfrontendutilitiesjs">trunk/Source/WebCore/inspector/front-end/utilities.js</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (145047 => 145048)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog        2013-03-07 08:18:45 UTC (rev 145047)
+++ trunk/LayoutTests/ChangeLog        2013-03-07 08:27:14 UTC (rev 145048)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2013-03-07  Vsevolod Vlasov  &lt;vsevik@chromium.org&gt;
+
+        Web Inspector: NavigatorView should show (program) for uiSourceCodes with empty name.
+        https://bugs.webkit.org/show_bug.cgi?id=111691
+
+        Reviewed by Alexander Pavlov.
+
+        * inspector/debugger/navigator-view-expected.txt:
+        * inspector/debugger/navigator-view.html:
+
</ins><span class="cx"> 2013-03-06  Takashi Sakamoto  &lt;tasak@google.com&gt;
</span><span class="cx"> 
</span><span class="cx">         Box-shadow displayed improperly with border-radius.
</span></span></pre></div>
<a id="trunkLayoutTestsinspectordebuggernavigatorviewexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/inspector/debugger/navigator-view-expected.txt (145047 => 145048)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/inspector/debugger/navigator-view-expected.txt        2013-03-07 08:18:45 UTC (rev 145047)
+++ trunk/LayoutTests/inspector/debugger/navigator-view-expected.txt        2013-03-07 08:27:14 UTC (rev 145048)
</span><span class="lines">@@ -100,6 +100,7 @@
</span><span class="cx">       ?a=b
</span><span class="cx">       very_looooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooo…
</span><span class="cx">     example.com
</span><ins>+      (program)
</ins><span class="cx">       ?a=b
</span><span class="cx">     localhost:8080
</span><span class="cx">       LayoutTests/inspector
</span></span></pre></div>
<a id="trunkLayoutTestsinspectordebuggernavigatorviewhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/inspector/debugger/navigator-view.html (145047 => 145048)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/inspector/debugger/navigator-view.html        2013-03-07 08:18:45 UTC (rev 145047)
+++ trunk/LayoutTests/inspector/debugger/navigator-view.html        2013-03-07 08:27:14 UTC (rev 145048)
</span><span class="lines">@@ -51,6 +51,7 @@
</span><span class="cx">     addUISourceCode(rootURL + &quot;foo/bar/contentScript2.js?a=1&quot;, true);
</span><span class="cx">     addUISourceCode(rootURL + &quot;foo/bar/contentScript.js?a=2&quot;, true);
</span><span class="cx">     addUISourceCode(rootURL + &quot;foo/bar/contentScript.js?a=1&quot;, true);
</span><ins>+    addUISourceCode(&quot;http://example.com/&quot;, false);
</ins><span class="cx">     addUISourceCode(&quot;http://example.com/?a=b&quot;, false);
</span><span class="cx">     addUISourceCode(&quot;?a=b&quot;, false);
</span><span class="cx">     addUISourceCode(&quot;very_looooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooong_url&quot;, false);
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (145047 => 145048)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog        2013-03-07 08:18:45 UTC (rev 145047)
+++ trunk/Source/WebCore/ChangeLog        2013-03-07 08:27:14 UTC (rev 145048)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2013-03-07  Vsevolod Vlasov  &lt;vsevik@chromium.org&gt;
+
+        Web Inspector: NavigatorView should show (program) for uiSourceCodes with empty name.
+        https://bugs.webkit.org/show_bug.cgi?id=111691
+
+        Reviewed by Alexander Pavlov.
+
+        Made String.prototype methods return string literal, not String object.
+
+        * inspector/front-end/utilities.js:
+        (String.prototype.escapeCharacters):
+
</ins><span class="cx"> 2013-03-07  Eugene Klyuchnikov  &lt;eustas@chromium.org&gt;
</span><span class="cx"> 
</span><span class="cx">         Web Inspector: Cmd+L (Go-to-Line) masks Go to location bar action
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorfrontendutilitiesjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/front-end/utilities.js (145047 => 145048)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/front-end/utilities.js        2013-03-07 08:18:45 UTC (rev 145047)
+++ trunk/Source/WebCore/inspector/front-end/utilities.js        2013-03-07 08:27:14 UTC (rev 145048)
</span><span class="lines">@@ -82,7 +82,7 @@
</span><span class="cx">     }
</span><span class="cx"> 
</span><span class="cx">     if (!foundChar)
</span><del>-        return this;
</del><ins>+        return String(this);
</ins><span class="cx"> 
</span><span class="cx">     var result = &quot;&quot;;
</span><span class="cx">     for (var i = 0; i &lt; this.length; ++i) {
</span><span class="lines">@@ -117,7 +117,7 @@
</span><span class="cx"> String.prototype.trimMiddle = function(maxLength)
</span><span class="cx"> {
</span><span class="cx">     if (this.length &lt;= maxLength)
</span><del>-        return this;
</del><ins>+        return String(this);
</ins><span class="cx">     var leftHalf = maxLength &gt;&gt; 1;
</span><span class="cx">     var rightHalf = maxLength - leftHalf - 1;
</span><span class="cx">     return this.substr(0, leftHalf) + &quot;\u2026&quot; + this.substr(this.length - rightHalf, rightHalf);
</span><span class="lines">@@ -126,7 +126,7 @@
</span><span class="cx"> String.prototype.trimEnd = function(maxLength)
</span><span class="cx"> {
</span><span class="cx">     if (this.length &lt;= maxLength)
</span><del>-        return this;
</del><ins>+        return String(this);
</ins><span class="cx">     return this.substr(0, maxLength - 1) + &quot;\u2026&quot;;
</span><span class="cx"> }
</span><span class="cx"> 
</span></span></pre>
</div>
</div>

</body>
</html>