<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[129213] trunk</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/129213">129213</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2012-09-21 05:00:20 -0700 (Fri, 21 Sep 2012)</dd>
</dl>

<h3>Log Message</h3>
<pre>WebKitTestRunner needs to print frame load delegate information
https://bugs.webkit.org/show_bug.cgi?id=42705

Patch by Mikhail Pozdnyakov &lt;mikhail.pozdnyakov@intel.com&gt; on 2012-09-21
Reviewed by Kenneth Rohde Christiansen.

Tools:

Added missing dumping from WTR::InjectedBundlePage::didFailLoadWithErrorForFrame.

* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):

LayoutTests:

Unskipped corresponding test cases from wk2/Skipped, put those which still fail to an appropriate
group in wk2/Skipped.
Moved couple of http/tests/loading tests from platform/efl-wk1/TestExpectations to
platform/efl/TestExpectations as they actually fail for both WK1 EFL and WK2 EFL.

* platform/efl-wk1/TestExpectations:
* platform/efl/TestExpectations:
* platform/wk2/Skipped:</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsplatformeflTestExpectations">trunk/LayoutTests/platform/efl/TestExpectations</a></li>
<li><a href="#trunkLayoutTestsplatformeflwk1TestExpectations">trunk/LayoutTests/platform/efl-wk1/TestExpectations</a></li>
<li><a href="#trunkLayoutTestsplatformwk2Skipped">trunk/LayoutTests/platform/wk2/Skipped</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsWebKitTestRunnerInjectedBundleInjectedBundlePagecpp">trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (129212 => 129213)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog        2012-09-21 11:35:42 UTC (rev 129212)
+++ trunk/LayoutTests/ChangeLog        2012-09-21 12:00:20 UTC (rev 129213)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2012-09-21  Mikhail Pozdnyakov  &lt;mikhail.pozdnyakov@intel.com&gt;
+
+        WebKitTestRunner needs to print frame load delegate information
+        https://bugs.webkit.org/show_bug.cgi?id=42705
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        Unskipped corresponding test cases from wk2/Skipped, put those which still fail to an appropriate
+        group in wk2/Skipped.
+        Moved couple of http/tests/loading tests from platform/efl-wk1/TestExpectations to
+        platform/efl/TestExpectations as they actually fail for both WK1 EFL and WK2 EFL.
+
+        * platform/efl-wk1/TestExpectations:
+        * platform/efl/TestExpectations:
+        * platform/wk2/Skipped:
+
</ins><span class="cx"> 2012-09-21  Christophe Dumez  &lt;christophe.dumez@intel.com&gt;
</span><span class="cx"> 
</span><span class="cx">         [EFL] EventSender should mimic CTRL+o emacs shortcut
</span></span></pre></div>
<a id="trunkLayoutTestsplatformeflTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/efl/TestExpectations (129212 => 129213)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/efl/TestExpectations        2012-09-21 11:35:42 UTC (rev 129212)
+++ trunk/LayoutTests/platform/efl/TestExpectations        2012-09-21 12:00:20 UTC (rev 129213)
</span><span class="lines">@@ -1062,4 +1062,7 @@
</span><span class="cx"> # Fails after r129175.
</span><span class="cx"> webkit.org/b/97296 fast/text/international/hebrew-selection.html [ ImageOnlyFailure ]
</span><span class="cx"> 
</span><ins>+# Fail after r128393.
+webkit.org/b/96620 http/tests/loading/pdf-commit-load-callbacks.html [ Failure ]
+webkit.org/b/96620 http/tests/loading/text-content-type-with-binary-extension.html [ Failure ]
</ins><span class="cx"> 
</span></span></pre></div>
<a id="trunkLayoutTestsplatformeflwk1TestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/efl-wk1/TestExpectations (129212 => 129213)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/efl-wk1/TestExpectations        2012-09-21 11:35:42 UTC (rev 129212)
+++ trunk/LayoutTests/platform/efl-wk1/TestExpectations        2012-09-21 12:00:20 UTC (rev 129213)
</span><span class="lines">@@ -100,10 +100,6 @@
</span><span class="cx"> # Failing after 125592
</span><span class="cx"> webkit.org/b/94194 http/tests/security/frameNavigation/inactive-function-in-popup-navigate-child.html [ Failure ]
</span><span class="cx"> 
</span><del>-# Fail after r128393.
-webkit.org/b/96620 http/tests/loading/pdf-commit-load-callbacks.html [ Failure ]
-webkit.org/b/96620 http/tests/loading/text-content-type-with-binary-extension.html [ Failure ]
-
</del><span class="cx"> # EFL's LayoutTestController does not implement setTabKeyCyclesThroughElements.
</span><span class="cx"> webkit.org/b/82864 fast/events/keypress-insert-tab.html [ Failure ]
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkLayoutTestsplatformwk2Skipped"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/wk2/Skipped (129212 => 129213)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/wk2/Skipped        2012-09-21 11:35:42 UTC (rev 129212)
+++ trunk/LayoutTests/platform/wk2/Skipped        2012-09-21 12:00:20 UTC (rev 129213)
</span><span class="lines">@@ -470,25 +470,6 @@
</span><span class="cx"> http/tests/globalhistory/history-delegate-basic-title.html
</span><span class="cx"> http/tests/globalhistory/history-delegate-basic-visited-links.html
</span><span class="cx"> 
</span><del>-# WebKitTestRunner needs to print frame load delegate information
-# &lt;https://bugs.webkit.org/show_bug.cgi?id=42705&gt;
-fast/loader/subframe-removes-itself.html
-http/tests/loading/bad-scheme-subframe.html
-http/tests/loading/bad-server-subframe.html
-http/tests/loading/basic.html
-http/tests/loading/deleted-host-in-resource-load-delegate-callback.html
-http/tests/loading/empty-subframe.html
-http/tests/loading/load-javascript-after-many-xhrs.html
-http/tests/loading/location-hash-reload-cycle.html
-http/tests/loading/nested_bad_objects.php
-http/tests/loading/onload-vs-immediate-refresh.pl
-http/tests/loading/preload-img-test.html
-http/tests/loading/redirect-with-no-location-crash.html
-http/tests/loading/simple-subframe.html
-http/tests/loading/slow-parsing-subframe.html
-http/tests/loading/text-content-type-with-binary-extension.html
-http/tests/loading/state-object-security-exception.html
-
</del><span class="cx"> # These tests crash the WebProcess when run under WebKitTestRunner.
</span><span class="cx"> # &lt;https://bugs.webkit.org/show_bug.cgi?id=44479&gt;
</span><span class="cx"> fast/parser/remove-misnested-iframe-in-beforeload.html
</span><span class="lines">@@ -844,6 +825,11 @@
</span><span class="cx"> webarchive/loading/test-loading-archive.html
</span><span class="cx"> webarchive/loading/test-loading-archive-subresource-null-mimetype.html
</span><span class="cx"> 
</span><ins>+# Should pass now on ports other than EFL and GTK.
+# But it needs to be checked first.
+http/tests/loading/bad-scheme-subframe.html
+http/tests/loading/text-content-type-with-binary-extension.html
+
</ins><span class="cx"> # Some elements are skipped when focus is moved.
</span><span class="cx"> fast/spatial-navigation/snav-container-white-space.html
</span><span class="cx"> fast/spatial-navigation/snav-div-overflow-scrol-hidden.html
</span><span class="lines">@@ -859,6 +845,9 @@
</span><span class="cx"> # WebFrameLoaderClient::canHandleRequest() has to be implemented.
</span><span class="cx"> http/tests/misc/redirect-to-external-url.html
</span><span class="cx"> 
</span><ins>+# WebKitTestRunner needs testRunner.dispatchPendingLoadRequests
+http/tests/loading/deleted-host-in-resource-load-delegate-callback.html
+
</ins><span class="cx"> ### END OF (2) Classified failures without bug reports (yet)
</span><span class="cx"> ########################################
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (129212 => 129213)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog        2012-09-21 11:35:42 UTC (rev 129212)
+++ trunk/Tools/ChangeLog        2012-09-21 12:00:20 UTC (rev 129213)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2012-09-21  Mikhail Pozdnyakov  &lt;mikhail.pozdnyakov@intel.com&gt;
+
+        WebKitTestRunner needs to print frame load delegate information
+        https://bugs.webkit.org/show_bug.cgi?id=42705
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        Added missing dumping from WTR::InjectedBundlePage::didFailLoadWithErrorForFrame.
+
+        * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
+        (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
+
</ins><span class="cx"> 2012-09-21  Christophe Dumez  &lt;christophe.dumez@intel.com&gt;
</span><span class="cx"> 
</span><span class="cx">         [EFL] EventSender should mimic CTRL+o emacs shortcut
</span></span></pre></div>
<a id="trunkToolsWebKitTestRunnerInjectedBundleInjectedBundlePagecpp"></a>
<div class="modfile"><h4>Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp (129212 => 129213)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp        2012-09-21 11:35:42 UTC (rev 129212)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp        2012-09-21 12:00:20 UTC (rev 129213)
</span><span class="lines">@@ -981,6 +981,11 @@
</span><span class="cx">     if (!InjectedBundle::shared().isTestRunning())
</span><span class="cx">         return;
</span><span class="cx"> 
</span><ins>+    if (InjectedBundle::shared().testRunner()-&gt;shouldDumpFrameLoadCallbacks()) {
+        dumpFrameDescriptionSuitableForTestResult(frame);
+        InjectedBundle::shared().stringBuilder()-&gt;appendLiteral(&quot; - didFailLoadWithError\n&quot;);
+    }
+
</ins><span class="cx">     if (frame != InjectedBundle::shared().topLoadingFrame())
</span><span class="cx">         return;
</span><span class="cx">     InjectedBundle::shared().setTopLoadingFrame(0);
</span></span></pre>
</div>
</div>

</body>
</html>