<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[129036] trunk</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/129036">129036</a></dd>
<dt>Author</dt> <dd>dmazzoni@google.com</dd>
<dt>Date</dt> <dd>2012-09-19 12:55:19 -0700 (Wed, 19 Sep 2012)</dd>
</dl>

<h3>Log Message</h3>
<pre>AX: A few control types are returning the wrong answer for isReadOnly
https://bugs.webkit.org/show_bug.cgi?id=96735

Reviewed by Chris Fleizach.

Source/WebCore:

All input types should be read-only except ones that
are text fields. The previous logic was marking things like
checkboxes as not read-only.

Tests: platform/chromium/accessibility/readonly.html
       platform/mac/accessibility/form-control-value-settable.html

* accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::isReadOnly):

Tools:

Exposing isReadOnly in an AccessibilityObject to DumpRenderTree.

* DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
(AccessibilityUIElement::AccessibilityUIElement):
(AccessibilityUIElement::isReadOnlyGetterCallback):
* DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.h:
(AccessibilityUIElement):

LayoutTests:

Adds a new test to make sure that readonly is exposed correctly on
all elements.

* platform/chromium/accessibility/readonly-expected.txt: Added.
* platform/chromium/accessibility/readonly.html: Added.
* platform/mac/accessibility/form-control-value-settable-expected.txt: Added.
* platform/mac/accessibility/form-control-value-settable.html: Added.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityAccessibilityNodeObjectcpp">trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsDumpRenderTreechromiumTestRunnerAccessibilityUIElementChromiumcpp">trunk/Tools/DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp</a></li>
<li><a href="#trunkToolsDumpRenderTreechromiumTestRunnerAccessibilityUIElementChromiumh">trunk/Tools/DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.h</a></li>
</ul>

<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsplatformchromiumaccessibilityreadonlyexpectedtxt">trunk/LayoutTests/platform/chromium/accessibility/readonly-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformchromiumaccessibilityreadonlyhtml">trunk/LayoutTests/platform/chromium/accessibility/readonly.html</a></li>
<li><a href="#trunkLayoutTestsplatformmacaccessibilityformcontrolvaluesettableexpectedtxt">trunk/LayoutTests/platform/mac/accessibility/form-control-value-settable-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformmacaccessibilityformcontrolvaluesettablehtml">trunk/LayoutTests/platform/mac/accessibility/form-control-value-settable.html</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (129035 => 129036)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog        2012-09-19 19:49:45 UTC (rev 129035)
+++ trunk/LayoutTests/ChangeLog        2012-09-19 19:55:19 UTC (rev 129036)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2012-09-19  Dominic Mazzoni  &lt;dmazzoni@google.com&gt;
+
+        AX: A few control types are returning the wrong answer for isReadOnly
+        https://bugs.webkit.org/show_bug.cgi?id=96735
+
+        Reviewed by Chris Fleizach.
+
+        Adds a new test to make sure that readonly is exposed correctly on
+        all elements.
+
+        * platform/chromium/accessibility/readonly-expected.txt: Added.
+        * platform/chromium/accessibility/readonly.html: Added.
+        * platform/mac/accessibility/form-control-value-settable-expected.txt: Added.
+        * platform/mac/accessibility/form-control-value-settable.html: Added.
+
</ins><span class="cx"> 2012-09-19  Nate Chapin  &lt;japhet@chromium.org&gt;
</span><span class="cx"> 
</span><span class="cx">         Chromium gardening.
</span></span></pre></div>
<a id="trunkLayoutTestsplatformchromiumaccessibilityreadonlyexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/platform/chromium/accessibility/readonly-expected.txt (0 => 129036)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/chromium/accessibility/readonly-expected.txt                                (rev 0)
+++ trunk/LayoutTests/platform/chromium/accessibility/readonly-expected.txt        2012-09-19 19:55:19 UTC (rev 129036)
</span><span class="lines">@@ -0,0 +1,89 @@
</span><ins>+Link  Button                 
+Focusable
+Heading
+
+ARIA button
+ARIA toggle button
+ARIA link
+Button
+This tests which elements expose themselves as readonly. Readonly here refers to whether the item is not editable, not whether a control value can be changed vs if it's unavailable.
+
+On success, you will see a series of &quot;PASS&quot; messages, followed by &quot;TEST COMPLETE&quot;.
+
+
+link1
+PASS document.activeElement == element is true
+PASS axElement.isReadOnly is true
+
+button1
+PASS document.activeElement == element is true
+PASS axElement.isReadOnly is true
+
+text1
+PASS document.activeElement == element is true
+PASS axElement.isReadOnly is false
+
+checkbox1
+PASS document.activeElement == element is true
+PASS axElement.isReadOnly is true
+
+number1
+PASS document.activeElement == element is true
+PASS axElement.isReadOnly is false
+
+radio1
+PASS document.activeElement == element is true
+PASS axElement.isReadOnly is true
+
+slider1
+PASS document.activeElement == element is true
+PASS axElement.isReadOnly is true
+
+submit1
+PASS document.activeElement == element is true
+PASS axElement.isReadOnly is true
+
+combobox1
+PASS document.activeElement == element is true
+PASS axElement.isReadOnly is true
+
+listbox1
+PASS document.activeElement == element is true
+PASS axElement.isReadOnly is true
+
+textarea1
+PASS document.activeElement == element is true
+PASS axElement.isReadOnly is false
+
+focusable1
+PASS document.activeElement == element is true
+PASS axElement.isReadOnly is true
+
+heading1
+PASS document.activeElement == element is true
+PASS axElement.isReadOnly is true
+
+aria-button1
+PASS document.activeElement == element is true
+PASS axElement.isReadOnly is true
+
+aria-togglebutton1
+PASS document.activeElement == element is true
+PASS axElement.isReadOnly is true
+
+aria-link1
+PASS document.activeElement == element is true
+PASS axElement.isReadOnly is true
+
+contenteditable_root1
+PASS document.activeElement == element is true
+PASS axElement.isReadOnly is false
+
+contenteditable_button1
+PASS document.activeElement == element is true
+PASS axElement.isReadOnly is false
+
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestsplatformchromiumaccessibilityreadonlyhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/platform/chromium/accessibility/readonly.html (0 => 129036)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/chromium/accessibility/readonly.html                                (rev 0)
+++ trunk/LayoutTests/platform/chromium/accessibility/readonly.html        2012-09-19 19:55:19 UTC (rev 129036)
</span><span class="lines">@@ -0,0 +1,71 @@
</span><ins>+&lt;!DOCTYPE HTML&gt;
+&lt;html&gt;
+&lt;body&gt;
+&lt;script src=&quot;../../../fast/js/resources/js-test-pre.js&quot;&gt;&lt;/script&gt;
+
+&lt;div&gt;
+  &lt;a id=&quot;link1&quot; href=&quot;#&quot;&gt;Link&lt;/a&gt;
+  &lt;button id=&quot;button1&quot;&gt;Button&lt;/button&gt;
+  &lt;input id=&quot;text1&quot; type=&quot;text&quot; value=&quot;Value&quot;&gt;
+  &lt;input id=&quot;checkbox1&quot; type=&quot;checkbox&quot; checked&gt;
+  &lt;input id=&quot;number1&quot; type=&quot;number&quot; value=&quot;123&quot;&gt;
+  &lt;input id=&quot;radio1&quot; type=&quot;radio&quot; checked&gt;
+  &lt;input id=&quot;slider1&quot; type=&quot;range&quot; min=&quot;1&quot; max=&quot;10&quot; value=&quot;5&quot;&gt;
+  &lt;input id=&quot;submit1&quot; type=&quot;submit&quot;&gt;
+  &lt;select id=&quot;combobox1&quot;&gt;&lt;option&gt;1&lt;option selected&gt;2&lt;/select&gt;
+  &lt;select multiple id=&quot;listbox1&quot;&gt;&lt;option&gt;1&lt;option selected&gt;2&lt;/select&gt;
+  &lt;textarea id=&quot;textarea1&quot;&gt;Textarea&lt;/textarea&gt;
+  &lt;div id=&quot;focusable1&quot; tabindex=&quot;0&quot;&gt;Focusable&lt;/div&gt;
+  &lt;h5 id=&quot;heading1&quot; tabindex=&quot;0&quot;&gt;Heading&lt;/h5&gt;
+  &lt;div id=&quot;aria-button1&quot; tabindex=&quot;0&quot; role=&quot;button&quot;&gt;ARIA button&lt;/div&gt;
+  &lt;div id=&quot;aria-togglebutton1&quot; tabindex=&quot;0&quot; role=&quot;button&quot; aria-pressed=&quot;false&quot;&gt;ARIA toggle button&lt;/div&gt;
+  &lt;div id=&quot;aria-link1&quot; tabindex=&quot;0&quot; role=&quot;link&quot;&gt;ARIA link&lt;/div&gt;
+  &lt;div id=&quot;contenteditable_root1&quot; contentEditable&gt;
+    &lt;button id=&quot;contenteditable_button1&quot;&gt;Button&lt;/button&gt;
+  &lt;/div&gt;
+
+&lt;/div&gt;
+
+&lt;div id=&quot;console&quot;&gt;&lt;/div&gt;
+&lt;script&gt;
+description(&quot;This tests which elements expose themselves as readonly. Readonly here refers to whether the item is not editable, not whether a control value can be changed vs if it's unavailable.&quot;);
+
+if (window.testRunner &amp;&amp; window.accessibilityController) {
+    window.testRunner.dumpAsText();
+
+    function check(id, expected_readonly) {
+        debug(id);
+        window.element = document.getElementById(id);
+        element.focus();
+        shouldBe(&quot;document.activeElement == element&quot;, &quot;true&quot;);
+        window.axElement = accessibilityController.focusedElement;
+
+        shouldBe(&quot;axElement.isReadOnly&quot;, &quot;&quot; + expected_readonly);
+        debug(&quot;&quot;);
+    }
+
+    check(&quot;link1&quot;, true);
+    check(&quot;button1&quot;, true);
+    check(&quot;text1&quot;, false);
+    check(&quot;checkbox1&quot;, true);
+    check(&quot;number1&quot;, false);
+    check(&quot;radio1&quot;, true);
+    check(&quot;slider1&quot;, true);
+    check(&quot;submit1&quot;, true);
+    check(&quot;combobox1&quot;, true);
+    check(&quot;listbox1&quot;, true);
+    check(&quot;textarea1&quot;, false);
+    check(&quot;focusable1&quot;, true);
+    check(&quot;heading1&quot;, true);
+    check(&quot;aria-button1&quot;, true);
+    check(&quot;aria-togglebutton1&quot;, true);
+    check(&quot;aria-link1&quot;, true);
+    check(&quot;contenteditable_root1&quot;, false);
+    check(&quot;contenteditable_button1&quot;, false);
+}
+
+&lt;/script&gt;
+
+&lt;script src=&quot;../../../fast/js/resources/js-test-post.js&quot;&gt;&lt;/script&gt;
+&lt;/body&gt;
+&lt;/html&gt;
</ins></span></pre></div>
<a id="trunkLayoutTestsplatformmacaccessibilityformcontrolvaluesettableexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/platform/mac/accessibility/form-control-value-settable-expected.txt (0 => 129036)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac/accessibility/form-control-value-settable-expected.txt                                (rev 0)
+++ trunk/LayoutTests/platform/mac/accessibility/form-control-value-settable-expected.txt        2012-09-19 19:55:19 UTC (rev 129036)
</span><span class="lines">@@ -0,0 +1,74 @@
</span><ins>+                
+                
+This tests whether AXValue is writable for various form controls.
+
+On success, you will see a series of &quot;PASS&quot; messages, followed by &quot;TEST COMPLETE&quot;.
+
+
+text1
+PASS document.activeElement == element1 is true
+text2
+PASS document.activeElement == element2 is true
+PASS axElement1.isAttributeSettable('AXValue') is true
+PASS axElement2.isAttributeSettable('AXValue') is true
+
+number1
+PASS document.activeElement == element1 is true
+number2
+PASS document.activeElement == element2 is true
+PASS axElement1.isAttributeSettable('AXValue') is true
+PASS axElement2.isAttributeSettable('AXValue') is true
+
+textarea1
+PASS document.activeElement == element1 is true
+textarea2
+PASS document.activeElement == element2 is true
+PASS axElement1.isAttributeSettable('AXValue') is true
+PASS axElement2.isAttributeSettable('AXValue') is true
+
+slider1
+PASS document.activeElement == element1 is true
+slider2
+PASS document.activeElement == element2 is true
+PASS axElement1.isAttributeSettable('AXValue') is true
+PASS axElement2.isAttributeSettable('AXValue') is true
+
+checkbox1
+PASS document.activeElement == element1 is true
+checkbox2
+PASS document.activeElement == element2 is true
+PASS axElement1.isAttributeSettable('AXValue') is false
+PASS axElement2.isAttributeSettable('AXValue') is true
+
+radio1
+PASS document.activeElement == element1 is true
+radio2
+PASS document.activeElement == element2 is true
+PASS axElement1.isAttributeSettable('AXValue') is false
+PASS axElement2.isAttributeSettable('AXValue') is true
+
+submit1
+PASS document.activeElement == element1 is true
+submit2
+PASS document.activeElement == element2 is true
+PASS axElement1.isAttributeSettable('AXValue') is false
+PASS axElement2.isAttributeSettable('AXValue') is true
+
+combobox1
+PASS document.activeElement == element1 is true
+combobox2
+PASS document.activeElement == element2 is true
+PASS axElement1.isAttributeSettable('AXValue') is false
+PASS axElement2.isAttributeSettable('AXValue') is true
+
+listbox1
+PASS document.activeElement == element1 is true
+listbox2
+PASS document.activeElement == element2 is true
+PASS axElement1.isAttributeSettable('AXValue') is false
+PASS axElement2.isAttributeSettable('AXValue') is true
+
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestsplatformmacaccessibilityformcontrolvaluesettablehtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/platform/mac/accessibility/form-control-value-settable.html (0 => 129036)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac/accessibility/form-control-value-settable.html                                (rev 0)
+++ trunk/LayoutTests/platform/mac/accessibility/form-control-value-settable.html        2012-09-19 19:55:19 UTC (rev 129036)
</span><span class="lines">@@ -0,0 +1,77 @@
</span><ins>+&lt;!DOCTYPE HTML&gt;
+&lt;html&gt;
+&lt;body&gt;
+&lt;script src=&quot;../../../fast/js/resources/js-test-pre.js&quot;&gt;&lt;/script&gt;
+
+&lt;div&gt;
+  &lt;input id=&quot;text1&quot; type=&quot;text&quot; value=&quot;Value&quot;&gt;
+  &lt;input id=&quot;checkbox1&quot; type=&quot;checkbox&quot; checked&gt;
+  &lt;input id=&quot;number1&quot; type=&quot;number&quot; value=&quot;123&quot;&gt;
+  &lt;input id=&quot;radio1&quot; type=&quot;radio&quot; checked&gt;
+  &lt;input id=&quot;slider1&quot; type=&quot;range&quot; min=&quot;1&quot; max=&quot;10&quot; value=&quot;5&quot;&gt;
+  &lt;input id=&quot;submit1&quot; type=&quot;submit&quot;&gt;
+  &lt;select id=&quot;combobox1&quot;&gt;&lt;option&gt;1&lt;option selected&gt;2&lt;/select&gt;
+  &lt;select multiple id=&quot;listbox1&quot;&gt;&lt;option&gt;1&lt;option selected&gt;2&lt;/select&gt;
+  &lt;textarea id=&quot;textarea1&quot;&gt;Textarea&lt;/textarea&gt;
+&lt;/div&gt;
+
+&lt;div contentEditable&gt;
+  &lt;input id=&quot;text2&quot; type=&quot;text&quot; value=&quot;Value&quot;&gt;
+  &lt;input id=&quot;checkbox2&quot; type=&quot;checkbox&quot; checked&gt;
+  &lt;input id=&quot;number2&quot; type=&quot;number&quot; value=&quot;123&quot;&gt;
+  &lt;input id=&quot;radio2&quot; type=&quot;radio&quot; checked&gt;
+  &lt;input id=&quot;slider2&quot; type=&quot;range&quot; min=&quot;1&quot; max=&quot;10&quot; value=&quot;5&quot;&gt;
+  &lt;input id=&quot;submit2&quot; type=&quot;submit&quot;&gt;
+  &lt;select id=&quot;combobox2&quot;&gt;&lt;option&gt;1&lt;option selected&gt;2&lt;/select&gt;
+  &lt;select multiple id=&quot;listbox2&quot;&gt;&lt;option&gt;1&lt;option selected&gt;2&lt;/select&gt;
+  &lt;textarea id=&quot;textarea2&quot;&gt;Textarea&lt;/textarea&gt;
+&lt;/div&gt;
+
+&lt;div id=&quot;console&quot;&gt;&lt;/div&gt;
+&lt;script&gt;
+description(&quot;This tests whether AXValue is writable for various form controls.&quot;);
+
+if (window.testRunner &amp;&amp; window.accessibilityController) {
+    window.testRunner.dumpAsText();
+
+    function check(id1, id2, expected1) {
+        debug(id1);
+        window.element1 = document.getElementById(id1);
+        element1.focus();
+        shouldBe(&quot;document.activeElement == element1&quot;, &quot;true&quot;);
+        window.axElement1 = accessibilityController.focusedElement;
+
+        debug(id2);
+        window.element2 = document.getElementById(id2);
+        element2.focus();
+        shouldBe(&quot;document.activeElement == element2&quot;, &quot;true&quot;);
+        window.axElement2 = accessibilityController.focusedElement;
+
+        shouldBe(&quot;axElement1.isAttributeSettable('AXValue')&quot;, String(expected1));
+        // If contentEditable, AXValue is always writable.
+        shouldBe(&quot;axElement2.isAttributeSettable('AXValue')&quot;, &quot;true&quot;);
+        debug(&quot;&quot;);
+    }
+
+    // All text-like form controls should have a writable AXValue.
+    check(&quot;text1&quot;, &quot;text2&quot;, true);
+    check(&quot;number1&quot;, &quot;number2&quot;, true);
+    check(&quot;textarea1&quot;, &quot;textarea2&quot;, true);
+
+    // A slider can set AXValue.
+    check(&quot;slider1&quot;, &quot;slider2&quot;, true);
+
+    // Other form controls, even toggleable ones, should have a read-only AXValue -
+    // unless they're inside contentEditable, then everything should have writable AXValue.
+    check(&quot;checkbox1&quot;, &quot;checkbox2&quot;, false);
+    check(&quot;radio1&quot;, &quot;radio2&quot;, false);
+    check(&quot;submit1&quot;, &quot;submit2&quot;, false);
+    check(&quot;combobox1&quot;, &quot;combobox2&quot;, false);
+    check(&quot;listbox1&quot;, &quot;listbox2&quot;, false);
+}
+
+&lt;/script&gt;
+
+&lt;script src=&quot;../../../fast/js/resources/js-test-post.js&quot;&gt;&lt;/script&gt;
+&lt;/body&gt;
+&lt;/html&gt;
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (129035 => 129036)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog        2012-09-19 19:49:45 UTC (rev 129035)
+++ trunk/Source/WebCore/ChangeLog        2012-09-19 19:55:19 UTC (rev 129036)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2012-09-19  Dominic Mazzoni  &lt;dmazzoni@google.com&gt;
+
+        AX: A few control types are returning the wrong answer for isReadOnly
+        https://bugs.webkit.org/show_bug.cgi?id=96735
+
+        Reviewed by Chris Fleizach.
+
+        All input types should be read-only except ones that
+        are text fields. The previous logic was marking things like
+        checkboxes as not read-only.
+
+        Tests: platform/chromium/accessibility/readonly.html
+               platform/mac/accessibility/form-control-value-settable.html
+
+        * accessibility/AccessibilityNodeObject.cpp:
+        (WebCore::AccessibilityNodeObject::isReadOnly):
+
</ins><span class="cx"> 2012-09-19  Mark Pilgrim  &lt;pilgrim@chromium.org&gt;
</span><span class="cx"> 
</span><span class="cx">         [Chromium] Remove unused PlatformSupport reference in V8GCController
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityAccessibilityNodeObjectcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp (129035 => 129036)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp        2012-09-19 19:49:45 UTC (rev 129035)
+++ trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp        2012-09-19 19:55:19 UTC (rev 129036)
</span><span class="lines">@@ -634,8 +634,11 @@
</span><span class="cx">     if (node-&gt;hasTagName(textareaTag))
</span><span class="cx">         return static_cast&lt;HTMLTextAreaElement*&gt;(node)-&gt;readOnly();
</span><span class="cx"> 
</span><del>-    if (node-&gt;hasTagName(inputTag))
-        return static_cast&lt;HTMLInputElement*&gt;(node)-&gt;readOnly();
</del><ins>+    if (node-&gt;hasTagName(inputTag)) {
+        HTMLInputElement* input = static_cast&lt;HTMLInputElement*&gt;(node);
+        if (input-&gt;isTextField())
+            return input-&gt;readOnly();
+    }
</ins><span class="cx"> 
</span><span class="cx">     return !node-&gt;rendererIsEditable();
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (129035 => 129036)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog        2012-09-19 19:49:45 UTC (rev 129035)
+++ trunk/Tools/ChangeLog        2012-09-19 19:55:19 UTC (rev 129036)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2012-09-19  Dominic Mazzoni  &lt;dmazzoni@google.com&gt;
+
+        AX: A few control types are returning the wrong answer for isReadOnly
+        https://bugs.webkit.org/show_bug.cgi?id=96735
+
+        Reviewed by Chris Fleizach.
+
+        Exposing isReadOnly in an AccessibilityObject to DumpRenderTree.
+
+        * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
+        (AccessibilityUIElement::AccessibilityUIElement):
+        (AccessibilityUIElement::isReadOnlyGetterCallback):
+        * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.h:
+        (AccessibilityUIElement):
+
</ins><span class="cx"> 2012-09-19  Sudarsana Nagineni  &lt;sudarsana.nagineni@intel.com&gt;
</span><span class="cx"> 
</span><span class="cx">         [WTR] Memory leaks in TestRunner::deliverWebIntent()
</span></span></pre></div>
<a id="trunkToolsDumpRenderTreechromiumTestRunnerAccessibilityUIElementChromiumcpp"></a>
<div class="modfile"><h4>Modified: trunk/Tools/DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp (129035 => 129036)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp        2012-09-19 19:49:45 UTC (rev 129035)
+++ trunk/Tools/DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp        2012-09-19 19:55:19 UTC (rev 129036)
</span><span class="lines">@@ -348,6 +348,7 @@
</span><span class="cx">     bindProperty(&quot;isCollapsed&quot;, &amp;AccessibilityUIElement::isCollapsedGetterCallback);
</span><span class="cx">     bindProperty(&quot;hasPopup&quot;, &amp;AccessibilityUIElement::hasPopupGetterCallback);
</span><span class="cx">     bindProperty(&quot;isValid&quot;, &amp;AccessibilityUIElement::isValidGetterCallback);
</span><ins>+    bindProperty(&quot;isReadOnly&quot;, &amp;AccessibilityUIElement::isReadOnlyGetterCallback);
</ins><span class="cx">     bindProperty(&quot;orientation&quot;, &amp;AccessibilityUIElement::orientationGetterCallback);
</span><span class="cx"> 
</span><span class="cx">     //
</span><span class="lines">@@ -584,6 +585,11 @@
</span><span class="cx">     result-&gt;set(!accessibilityObject().isDetached());
</span><span class="cx"> }
</span><span class="cx"> 
</span><ins>+void AccessibilityUIElement::isReadOnlyGetterCallback(CppVariant* result)
+{
+    result-&gt;set(accessibilityObject().isReadOnly());
+}
+
</ins><span class="cx"> void AccessibilityUIElement::orientationGetterCallback(CppVariant* result)
</span><span class="cx"> {
</span><span class="cx">     result-&gt;set(getOrientation(accessibilityObject()));
</span></span></pre></div>
<a id="trunkToolsDumpRenderTreechromiumTestRunnerAccessibilityUIElementChromiumh"></a>
<div class="modfile"><h4>Modified: trunk/Tools/DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.h (129035 => 129036)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.h        2012-09-19 19:49:45 UTC (rev 129035)
+++ trunk/Tools/DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.h        2012-09-19 19:55:19 UTC (rev 129036)
</span><span class="lines">@@ -90,6 +90,7 @@
</span><span class="cx">     void isCollapsedGetterCallback(CppVariant*);
</span><span class="cx">     void hasPopupGetterCallback(CppVariant*);
</span><span class="cx">     void isValidGetterCallback(CppVariant*);
</span><ins>+    void isReadOnlyGetterCallback(CppVariant*);
</ins><span class="cx">     void orientationGetterCallback(CppVariant*);
</span><span class="cx"> 
</span><span class="cx">     // Bound methods.
</span></span></pre>
</div>
</div>

</body>
</html>