<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[128257] trunk/Source</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/128257">128257</a></dd>
<dt>Author</dt> <dd>keishi@webkit.org</dd>
<dt>Date</dt> <dd>2012-09-11 19:24:57 -0700 (Tue, 11 Sep 2012)</dd>
</dl>

<h3>Log Message</h3>
<pre>Create Localizer factory method for LocaleICU
https://bugs.webkit.org/show_bug.cgi?id=96363

Reviewed by Kent Tamura.

Source/WebCore:

Preparing to use Localizer instead of LocaleMac/Win/ICU

No new tests. Covered in unit test tests/LocalizedNumberICUTest.cpp

* platform/text/LocaleICU.cpp:
(WebCore::Localizer::create):
(WebCore):

Source/WebKit/chromium:

* tests/LocalizedNumberICUTest.cpp:
(testNumberIsReversible):
(testDecimalSeparator):</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreplatformtextLocaleICUcpp">trunk/Source/WebCore/platform/text/LocaleICU.cpp</a></li>
<li><a href="#trunkSourceWebKitchromiumChangeLog">trunk/Source/WebKit/chromium/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitchromiumtestsLocalizedNumberICUTestcpp">trunk/Source/WebKit/chromium/tests/LocalizedNumberICUTest.cpp</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (128256 => 128257)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog        2012-09-12 01:57:23 UTC (rev 128256)
+++ trunk/Source/WebCore/ChangeLog        2012-09-12 02:24:57 UTC (rev 128257)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2012-09-11  Keishi Hattori  &lt;keishi@webkit.org&gt;
+
+        Create Localizer factory method for LocaleICU
+        https://bugs.webkit.org/show_bug.cgi?id=96363
+
+        Reviewed by Kent Tamura.
+
+        Preparing to use Localizer instead of LocaleMac/Win/ICU
+
+        No new tests. Covered in unit test tests/LocalizedNumberICUTest.cpp
+
+        * platform/text/LocaleICU.cpp:
+        (WebCore::Localizer::create):
+        (WebCore):
+
</ins><span class="cx"> 2012-09-11  Michael Saboff  &lt;msaboff@apple.com&gt;
</span><span class="cx"> 
</span><span class="cx">         Build fixed for http://trac.webkit.org/changeset/128243
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformtextLocaleICUcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/text/LocaleICU.cpp (128256 => 128257)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/text/LocaleICU.cpp        2012-09-12 01:57:23 UTC (rev 128256)
+++ trunk/Source/WebCore/platform/text/LocaleICU.cpp        2012-09-12 02:24:57 UTC (rev 128257)
</span><span class="lines">@@ -42,6 +42,11 @@
</span><span class="cx"> 
</span><span class="cx"> namespace WebCore {
</span><span class="cx"> 
</span><ins>+PassOwnPtr&lt;Localizer&gt; Localizer::create(const AtomicString&amp; locale)
+{
+    return LocaleICU::create(locale.string().utf8().data());
+}
+
</ins><span class="cx"> LocaleICU::LocaleICU(const char* locale)
</span><span class="cx">     : m_locale(locale)
</span><span class="cx">     , m_numberFormat(0)
</span></span></pre></div>
<a id="trunkSourceWebKitchromiumChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/chromium/ChangeLog (128256 => 128257)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/chromium/ChangeLog        2012-09-12 01:57:23 UTC (rev 128256)
+++ trunk/Source/WebKit/chromium/ChangeLog        2012-09-12 02:24:57 UTC (rev 128257)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2012-09-11  Keishi Hattori  &lt;keishi@webkit.org&gt;
+
+        Create Localizer factory method for LocaleICU
+        https://bugs.webkit.org/show_bug.cgi?id=96363
+
+        Reviewed by Kent Tamura.
+
+        * tests/LocalizedNumberICUTest.cpp:
+        (testNumberIsReversible):
+        (testDecimalSeparator):
+
</ins><span class="cx"> 2012-09-11  Christopher Cameron  &lt;ccameron@chromium.org&gt;
</span><span class="cx"> 
</span><span class="cx">         [chromium] Make prioritized texture manager not touch backings array on the main thread
</span></span></pre></div>
<a id="trunkSourceWebKitchromiumtestsLocalizedNumberICUTestcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/chromium/tests/LocalizedNumberICUTest.cpp (128256 => 128257)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/chromium/tests/LocalizedNumberICUTest.cpp        2012-09-12 01:57:23 UTC (rev 128256)
+++ trunk/Source/WebKit/chromium/tests/LocalizedNumberICUTest.cpp        2012-09-12 02:24:57 UTC (rev 128257)
</span><span class="lines">@@ -36,13 +36,13 @@
</span><span class="cx"> 
</span><span class="cx"> using namespace WebCore;
</span><span class="cx"> 
</span><del>-void testNumberIsReversible(const char* localeString, const char* original, const char* shouldHave = 0)
</del><ins>+void testNumberIsReversible(const AtomicString&amp; locale, const char* original, const char* shouldHave = 0)
</ins><span class="cx"> {
</span><del>-    OwnPtr&lt;LocaleICU&gt; locale = LocaleICU::create(localeString);
-    String localized = locale-&gt;convertToLocalizedNumber(original);
</del><ins>+    OwnPtr&lt;Localizer&gt; localizer = Localizer::create(locale);
+    String localized = localizer-&gt;convertToLocalizedNumber(original);
</ins><span class="cx">     if (shouldHave)
</span><span class="cx">         EXPECT_TRUE(localized.contains(shouldHave));
</span><del>-    String converted = locale-&gt;convertFromLocalizedNumber(localized);
</del><ins>+    String converted = localizer-&gt;convertFromLocalizedNumber(localized);
</ins><span class="cx">     EXPECT_EQ(original, converted);
</span><span class="cx"> }
</span><span class="cx"> 
</span><span class="lines">@@ -82,10 +82,10 @@
</span><span class="cx"> 
</span><span class="cx"> #if ENABLE(INPUT_TYPE_TIME_MULTIPLE_FIELDS)
</span><span class="cx"> 
</span><del>-static String testDecimalSeparator(const char* localeString)
</del><ins>+static String testDecimalSeparator(const AtomicString&amp; locale)
</ins><span class="cx"> {
</span><del>-    OwnPtr&lt;LocaleICU&gt; locale = LocaleICU::create(localeString);
-    return locale-&gt;localizedDecimalSeparator();
</del><ins>+    OwnPtr&lt;Localizer&gt; localizer = Localizer::create(locale);
+    return localizer-&gt;localizedDecimalSeparator();
</ins><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> TEST(LocalizedNumberICUTest, localizedDecimalSeparator)
</span></span></pre>
</div>
</div>

</body>
</html>