<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[128077] trunk/Tools</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/128077">128077</a></dd>
<dt>Author</dt> <dd>ojan@chromium.org</dd>
<dt>Date</dt> <dd>2012-09-10 10:26:58 -0700 (Mon, 10 Sep 2012)</dd>
</dl>

<h3>Log Message</h3>
<pre>Make EFL bots work on the flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=96164

Reviewed by Tony Chang.

Also, update outdated unittests that had started failing.

* TestResultServer/static-dashboards/builders.js:
(isWebkitTestRunner):
* TestResultServer/static-dashboards/flakiness_dashboard.js:
(nonChromiumPlatform):
* TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
(test):</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsTestResultServerstaticdashboardsbuildersjs">trunk/Tools/TestResultServer/static-dashboards/builders.js</a></li>
<li><a href="#trunkToolsTestResultServerstaticdashboardsflakiness_dashboardjs">trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.js</a></li>
<li><a href="#trunkToolsTestResultServerstaticdashboardsflakiness_dashboard_unittestsjs">trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard_unittests.js</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (128076 => 128077)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog        2012-09-10 17:20:54 UTC (rev 128076)
+++ trunk/Tools/ChangeLog        2012-09-10 17:26:58 UTC (rev 128077)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2012-09-10  Ojan Vafai  &lt;ojan@chromium.org&gt;
+
+        Make EFL bots work on the flakiness dashboard
+        https://bugs.webkit.org/show_bug.cgi?id=96164
+
+        Reviewed by Tony Chang.
+
+        Also, update outdated unittests that had started failing.
+
+        * TestResultServer/static-dashboards/builders.js:
+        (isWebkitTestRunner):
+        * TestResultServer/static-dashboards/flakiness_dashboard.js:
+        (nonChromiumPlatform):
+        * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
+        (test):
+
</ins><span class="cx"> 2012-09-10  Tommy Widenflycht  &lt;tommyw@google.com&gt;
</span><span class="cx"> 
</span><span class="cx">         [chromium] MediaStream API: Remove the Descriptor postfix
</span></span></pre></div>
<a id="trunkToolsTestResultServerstaticdashboardsbuildersjs"></a>
<div class="modfile"><h4>Modified: trunk/Tools/TestResultServer/static-dashboards/builders.js (128076 => 128077)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/TestResultServer/static-dashboards/builders.js        2012-09-10 17:20:54 UTC (rev 128076)
+++ trunk/Tools/TestResultServer/static-dashboards/builders.js        2012-09-10 17:26:58 UTC (rev 128077)
</span><span class="lines">@@ -163,6 +163,8 @@
</span><span class="cx"> 
</span><span class="cx"> function isWebkitTestRunner(builder)
</span><span class="cx"> {
</span><ins>+    if (builder.indexOf('EFL') != -1)
+        return builder.indexOf('Build') == -1;
</ins><span class="cx">     if (builder.indexOf('Tests') != -1) {
</span><span class="cx">         // Apple Windows bots still run old-run-webkit-tests, so they don't upload data.
</span><span class="cx">         return builder.indexOf('Win') == -1 || (builder.indexOf('Qt') != -1 &amp;&amp; builder.indexOf('Chromium') != -1);
</span></span></pre></div>
<a id="trunkToolsTestResultServerstaticdashboardsflakiness_dashboardjs"></a>
<div class="modfile"><h4>Modified: trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.js (128076 => 128077)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.js        2012-09-10 17:20:54 UTC (rev 128076)
+++ trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.js        2012-09-10 17:26:58 UTC (rev 128077)
</span><span class="lines">@@ -40,7 +40,7 @@
</span><span class="cx"> 
</span><span class="cx"> // FIXME: These platform names should probably be changed to match the directories in LayoutTests/platform
</span><span class="cx"> // instead of matching the values we use in the TestExpectations file.
</span><del>-var PLATFORMS = ['LION', 'SNOWLEOPARD', 'XP', 'VISTA', 'WIN7', 'LUCID', 'APPLE_LION', 'APPLE_SNOWLEOPARD', 'APPLE_XP', 'APPLE_WIN7', 'GTK_LINUX', 'QT_LINUX'];
</del><ins>+var PLATFORMS = ['LION', 'SNOWLEOPARD', 'XP', 'VISTA', 'WIN7', 'LUCID', 'APPLE_LION', 'APPLE_SNOWLEOPARD', 'APPLE_XP', 'APPLE_WIN7', 'GTK_LINUX', 'QT_LINUX', 'EFL'];
</ins><span class="cx"> var PLATFORM_UNIONS = {
</span><span class="cx">     'MAC': ['SNOWLEOPARD', 'LION'],
</span><span class="cx">     'WIN': ['XP', 'WIN7'],
</span><span class="lines">@@ -265,6 +265,8 @@
</span><span class="cx">         return 'GTK_LINUX';
</span><span class="cx">     if (stringContains(builderNameUpperCase, 'QT LINUX'))
</span><span class="cx">         return 'QT_LINUX';
</span><ins>+    if (stringContains(builderNameUpperCase, 'EFL'))
+        return 'EFL';
</ins><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> function chromiumPlatform(builderNameUpperCase)
</span></span></pre></div>
<a id="trunkToolsTestResultServerstaticdashboardsflakiness_dashboard_unittestsjs"></a>
<div class="modfile"><h4>Modified: trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard_unittests.js (128076 => 128077)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard_unittests.js        2012-09-10 17:20:54 UTC (rev 128076)
+++ trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard_unittests.js        2012-09-10 17:26:58 UTC (rev 128077)
</span><span class="lines">@@ -190,7 +190,7 @@
</span><span class="cx">     equal(realModifiers('BUGFOO'), '');
</span><span class="cx"> });
</span><span class="cx"> 
</span><del>-test('allTestsWithSamePlatformAndBuildType', 12, function() {
</del><ins>+test('allTestsWithSamePlatformAndBuildType', 13, function() {
</ins><span class="cx">     // FIXME: test that allTestsWithSamePlatformAndBuildType actually returns the right set of tests.
</span><span class="cx">     for (var i = 0; i &lt; PLATFORMS.length; i++)
</span><span class="cx">         ok(g_allTestsByPlatformAndBuildType[PLATFORMS[i]]);
</span><span class="lines">@@ -310,20 +310,20 @@
</span><span class="cx"> test('htmlForTestTypeSwitcherGroup', 6, function() {
</span><span class="cx">     var container = document.createElement('div');
</span><span class="cx">     g_crossDashboardState.testType = 'ui_tests';
</span><del>-    container.innerHTML = htmlForTestTypeSwitcher();
</del><ins>+    container.innerHTML = htmlForTestTypeSwitcher(true);
</ins><span class="cx">     var selects = container.querySelectorAll('select');
</span><del>-    equal(selects.length, 3);
-    var group = selects[2];
</del><ins>+    equal(selects.length, 2);
+    var group = selects[1];
</ins><span class="cx">     equal(group.parentNode.textContent.indexOf('Group:'), 0);
</span><span class="cx">     equal(group.children.length, 3);
</span><span class="cx"> 
</span><span class="cx">     g_crossDashboardState.testType = 'layout-tests';
</span><del>-    container.innerHTML = htmlForTestTypeSwitcher();
</del><ins>+    container.innerHTML = htmlForTestTypeSwitcher(true);
</ins><span class="cx">     var selects = container.querySelectorAll('select');
</span><del>-    equal(selects.length, 3);
-    var group = selects[2];
</del><ins>+    equal(selects.length, 2);
+    var group = selects[1];
</ins><span class="cx">     equal(group.parentNode.textContent.indexOf('Group:'), 0);
</span><del>-    equal(group.children.length, 3);
</del><ins>+    equal(group.children.length, 4);
</ins><span class="cx"> });
</span><span class="cx"> 
</span><span class="cx"> test('htmlForIndividualTestOnAllBuilders', 1, function() {
</span><span class="lines">@@ -348,6 +348,7 @@
</span><span class="cx">     resetGlobals();
</span><span class="cx">     var test = 'dummytest.html';
</span><span class="cx">     var builderName = 'dummyBuilder';
</span><ins>+    BUILDER_TO_MASTER[builderName] = CHROMIUM_BUILDER_MASTER;
</ins><span class="cx">     g_testToResultsMap[test] = [createResultsObjectForTest(test, builderName)];
</span><span class="cx"> 
</span><span class="cx">     equal(htmlForIndividualTestOnAllBuildersWithResultsLinks(test),
</span><span class="lines">@@ -361,13 +362,6 @@
</span><span class="cx">             '&lt;/tr&gt;&lt;/thead&gt;' +
</span><span class="cx">             '&lt;tbody&gt;&lt;/tbody&gt;' +
</span><span class="cx">         '&lt;/table&gt;' +
</span><del>-        '&lt;div&gt;The following builders either don\'t run this test (e.g. it\'s skipped) or all runs passed:&lt;/div&gt;' +
-        '&lt;div class=skipped-builder-list&gt;' +
-            '&lt;div class=skipped-builder&gt;Webkit Linux&lt;/div&gt;' +
-            '&lt;div class=skipped-builder&gt;Webkit Linux (dbg)&lt;/div&gt;' +
-            '&lt;div class=skipped-builder&gt;Webkit Mac10.7&lt;/div&gt;' +
-            '&lt;div class=skipped-builder&gt;Webkit Win&lt;/div&gt;' +
-        '&lt;/div&gt;' +
</del><span class="cx">         '&lt;div class=expectations test=dummytest.html&gt;' +
</span><span class="cx">             '&lt;div&gt;&lt;span class=link onclick=&quot;setQueryParameter(\'showExpectations\', true)&quot;&gt;Show results&lt;/span&gt; | ' +
</span><span class="cx">             '&lt;span class=link onclick=&quot;setQueryParameter(\'showLargeExpectations\', true)&quot;&gt;Show large thumbnails&lt;/span&gt; | ' +
</span><span class="lines">@@ -393,13 +387,6 @@
</span><span class="cx">             '&lt;/tr&gt;&lt;/thead&gt;' +
</span><span class="cx">             '&lt;tbody&gt;&lt;/tbody&gt;' +
</span><span class="cx">         '&lt;/table&gt;' +
</span><del>-        '&lt;div&gt;The following builders either don\'t run this test (e.g. it\'s skipped) or all runs passed:&lt;/div&gt;' +
-        '&lt;div class=skipped-builder-list&gt;' +
-            '&lt;div class=skipped-builder&gt;Webkit Linux&lt;/div&gt;' +
-            '&lt;div class=skipped-builder&gt;Webkit Linux (dbg)&lt;/div&gt;' +
-            '&lt;div class=skipped-builder&gt;Webkit Mac10.7&lt;/div&gt;' +
-            '&lt;div class=skipped-builder&gt;Webkit Win&lt;/div&gt;' +
-        '&lt;/div&gt;' +
</del><span class="cx">         '&lt;div class=expectations test=dummytest.html&gt;' +
</span><span class="cx">             '&lt;div&gt;&lt;span class=link onclick=&quot;setQueryParameter(\'showExpectations\', true)&quot;&gt;Show results&lt;/span&gt; | ' +
</span><span class="cx">             '&lt;span class=link onclick=&quot;setQueryParameter(\'showLargeExpectations\', true)&quot;&gt;Show large thumbnails&lt;/span&gt;' +
</span><span class="lines">@@ -511,10 +498,11 @@
</span><span class="cx">         &quot;Qt Linux 64-bit Release (WebKit2 Perf)&quot;, &quot;Qt Linux ARMv7 Release&quot;, &quot;Qt Linux MIPS Release&quot;, &quot;Qt Linux Release&quot;, &quot;Qt Linux Release minimal&quot;, &quot;Qt Linux SH4 Release&quot;,
</span><span class="cx">         &quot;Qt SnowLeopard Release&quot;, &quot;Qt Windows 32-bit Debug&quot;, &quot;Qt Windows 32-bit Release&quot;, &quot;SnowLeopard Intel Debug (Build)&quot;, &quot;SnowLeopard Intel Debug (Tests)&quot;,
</span><span class="cx">         &quot;SnowLeopard Intel Debug (WebKit2 Tests)&quot;, &quot;SnowLeopard Intel Release (Build)&quot;, &quot;SnowLeopard Intel Release (Tests)&quot;, &quot;SnowLeopard Intel Release (WebKit2 Tests)&quot;,
</span><del>-        &quot;WinCE Release (Build)&quot;, &quot;WinCairo Release&quot;, &quot;Windows 7 Release (Tests)&quot;, &quot;Windows 7 Release (WebKit2 Tests)&quot;, &quot;Windows Debug (Build)&quot;, &quot;Windows Release (Build)&quot;, &quot;Windows XP Debug (Tests)&quot;];
-    var expectedBuilders = [[&quot;Chromium Linux Release (Tests)&quot;, 2], [&quot;Chromium Mac Release (Tests)&quot;], [&quot;Chromium Win Release (Tests)&quot;], [&quot;GTK Linux 32-bit Release&quot;], [&quot;GTK Linux 64-bit Debug&quot;],
</del><ins>+        &quot;WinCE Release (Build)&quot;, &quot;WinCairo Release&quot;, &quot;Windows 7 Release (Tests)&quot;, &quot;Windows 7 Release (WebKit2 Tests)&quot;, &quot;Windows Debug (Build)&quot;, &quot;Windows Release (Build)&quot;, &quot;Windows XP Debug (Tests)&quot;,
+        &quot;EFL Linux 32-bit Release (Build)&quot;, &quot;EFL Linux 64-bit Debug&quot;];
+    var expectedBuilders = [[&quot;Chromium Linux Release (Tests)&quot;, 2], [&quot;Chromium Mac Release (Tests)&quot;], [&quot;EFL Linux Release&quot;], [&quot;GTK Linux 32-bit Release&quot;], [&quot;GTK Linux 64-bit Debug&quot;],
</ins><span class="cx">         [&quot;GTK Linux 64-bit Release&quot;], [&quot;Lion Debug (Tests)&quot;], [&quot;Lion Debug (WebKit2 Tests)&quot;], [&quot;Lion Release (Tests)&quot;], [&quot;Lion Release (WebKit2 Tests)&quot;], [&quot;Qt Linux Release&quot;],
</span><del>-        [&quot;SnowLeopard Intel Debug (Tests)&quot;], [&quot;SnowLeopard Intel Debug (WebKit2 Tests)&quot;], [&quot;SnowLeopard Intel Release (Tests)&quot;], [&quot;SnowLeopard Intel Release (WebKit2 Tests)&quot;]];
</del><ins>+        [&quot;SnowLeopard Intel Debug (Tests)&quot;], [&quot;SnowLeopard Intel Debug (WebKit2 Tests)&quot;], [&quot;SnowLeopard Intel Release (Tests)&quot;], [&quot;SnowLeopard Intel Release (WebKit2 Tests)&quot;], [&quot;EFL Linux 64-bit Debug&quot;]];
</ins><span class="cx">     deepEqual(generateBuildersFromBuilderList(builderList, isWebkitTestRunner), expectedBuilders);
</span><span class="cx"> });
</span><span class="cx"> 
</span><span class="lines">@@ -526,7 +514,7 @@
</span><span class="cx">         &quot;Webkit Win Builder (deps)&quot;, &quot;Webkit Win7&quot;, &quot;Win (dbg)&quot;, &quot;Win Builder&quot;,
</span><span class="cx">         &quot;Linux (Content Shell)&quot;];
</span><span class="cx">     var expectedBuilders = [[&quot;Webkit Linux&quot;, 2], [&quot;Webkit Linux (dbg)&quot;], [&quot;Webkit Linux 32&quot;], [&quot;Webkit Mac10.6&quot;],
</span><del>-        [&quot;Webkit Mac10.6 (dbg)&quot;], [&quot;Webkit Mac10.7&quot;], [&quot;Webkit Win&quot;], [&quot;Webkit Win (dbg)(1)&quot;], [&quot;Webkit Win (dbg)(2)&quot;], [&quot;Webkit Win7&quot;], [&quot;Linux (Content Shell)&quot;]];
</del><ins>+        [&quot;Webkit Mac10.6 (dbg)&quot;], [&quot;Webkit Mac10.7&quot;], [&quot;Webkit Win&quot;], [&quot;Webkit Win (dbg)(1)&quot;], [&quot;Webkit Win (dbg)(2)&quot;], [&quot;Webkit Win7&quot;]];
</ins><span class="cx">     deepEqual(generateBuildersFromBuilderList(builderList, isChromiumWebkitTipOfTreeTestRunner), expectedBuilders);
</span><span class="cx"> });
</span><span class="cx"> 
</span><span class="lines">@@ -629,9 +617,9 @@
</span><span class="cx">     testBuilderGroups['@DEPS - dummy.org'].expectedGroups = 1;
</span><span class="cx"> 
</span><span class="cx">     var testJSONData = &quot;{ \&quot;Dummy Builder 1\&quot;: null, \&quot;Dummy Builder 2\&quot;: null }&quot;;
</span><del>-    onBuilderListLoad(testBuilderGroups,  function() { return true; }, dummyMaster, '@ToT - dummy.org', BuilderGroup.TOT_WEBKIT, JSON.parse(testJSONData));
</del><ins>+    onBuilderListLoad(testBuilderGroups, function() { return true; }, dummyMaster, '@ToT - dummy.org', JSON.parse(testJSONData));
</ins><span class="cx">     equal(testBuilderGroups['@ToT - dummy.org'].isToTWebKit, true);
</span><del>-    onBuilderListLoad(testBuilderGroups,  function() { return true; }, dummyMaster, '@DEPS - dummy.org', BuilderGroup.DEPS_WEBKIT, JSON.parse(testJSONData));
</del><ins>+    onBuilderListLoad(testBuilderGroups, function() { return true; }, dummyMaster, '@DEPS - dummy.org', JSON.parse(testJSONData));
</ins><span class="cx">     equal(testBuilderGroups['@DEPS - dummy.org'].isToTWebKit, false);
</span><span class="cx"> });
</span><span class="cx"> 
</span><span class="lines">@@ -644,10 +632,10 @@
</span><span class="cx"> 
</span><span class="cx">     var testJSONData = &quot;{ \&quot;Dummy Builder 1\&quot;: null }&quot;;
</span><span class="cx">     equal(testBuilderGroups['@ToT - dummy.org'].expectedGroups, 3);
</span><del>-    onBuilderListLoad(testBuilderGroups,  function() { return true; }, dummyMaster, '@ToT - dummy.org', BuilderGroup.TOT_WEBKIT, JSON.parse(testJSONData));
</del><ins>+    onBuilderListLoad(testBuilderGroups,  function() { return true; }, dummyMaster, '@ToT - dummy.org', JSON.parse(testJSONData));
</ins><span class="cx">     equal(testBuilderGroups['@ToT - dummy.org'].groups, 1);
</span><span class="cx">     var testJSONData = &quot;{ \&quot;Dummy Builder 2\&quot;: null }&quot;;
</span><del>-    onBuilderListLoad(testBuilderGroups,  function() { return true; }, dummyMaster, '@ToT - dummy.org', BuilderGroup.TOT_WEBKIT, JSON.parse(testJSONData));
</del><ins>+    onBuilderListLoad(testBuilderGroups,  function() { return true; }, dummyMaster, '@ToT - dummy.org', JSON.parse(testJSONData));
</ins><span class="cx">     equal(testBuilderGroups['@ToT - dummy.org'].groups, 2);
</span><span class="cx">     onErrorLoadingBuilderList('http://build.dummy.org', testBuilderGroups,  '@ToT - dummy.org');
</span><span class="cx">     equal(testBuilderGroups['@ToT - dummy.org'].groups, 3);
</span><span class="lines">@@ -662,9 +650,8 @@
</span><span class="cx">         var builderFilter = null;
</span><span class="cx">         var master = { builderJsonPath: function() {} };
</span><span class="cx">         var groupName = '@ToT - dummy.org';
</span><del>-        var groupEnum = null;
</del><span class="cx">         var builderGroup = { expectedGroups: 0 };
</span><del>-        requestBuilderList(testBuilderGroups, builderFilter, master, groupName, groupEnum, builderGroup);
</del><ins>+        requestBuilderList(testBuilderGroups, builderFilter, master, groupName, builderGroup);
</ins><span class="cx"> 
</span><span class="cx">         equal(testBuilderGroups['@ToT - dummy.org'], builderGroup);
</span><span class="cx">         equal(testBuilderGroups['@ToT - dummy.org'].expectedGroups, 1);
</span></span></pre>
</div>
</div>

</body>
</html>