<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[127631] branches/chromium/1229</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/127631">127631</a></dd>
<dt>Author</dt> <dd>cevans@google.com</dd>
<dt>Date</dt> <dd>2012-09-05 12:29:53 -0700 (Wed, 05 Sep 2012)</dd>
</dl>

<h3>Log Message</h3>
<pre>Merge 125343
BUG=131815
Review URL: https://chromiumcodereview.appspot.com/10913091</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#brancheschromium1229SourceWebCorerenderingRenderQuotecpp">branches/chromium/1229/Source/WebCore/rendering/RenderQuote.cpp</a></li>
</ul>

<h3>Added Paths</h3>
<ul>
<li><a href="#brancheschromium1229LayoutTestsfastcssgeneratedcontentquotecrash93750expectedtxt">branches/chromium/1229/LayoutTests/fast/css-generated-content/quote-crash-93750-expected.txt</a></li>
<li><a href="#brancheschromium1229LayoutTestsfastcssgeneratedcontentquotecrash93750html">branches/chromium/1229/LayoutTests/fast/css-generated-content/quote-crash-93750.html</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="brancheschromium1229LayoutTestsfastcssgeneratedcontentquotecrash93750expectedtxtfromrev125343trunkLayoutTestsfastcssgeneratedcontentquotecrash93750expectedtxt"></a>
<div class="copfile"><h4>Copied: branches/chromium/1229/LayoutTests/fast/css-generated-content/quote-crash-93750-expected.txt (from rev 125343, trunk/LayoutTests/fast/css-generated-content/quote-crash-93750-expected.txt) (0 => 127631)</h4>
<pre class="diff"><span>
<span class="info">--- branches/chromium/1229/LayoutTests/fast/css-generated-content/quote-crash-93750-expected.txt                                (rev 0)
+++ branches/chromium/1229/LayoutTests/fast/css-generated-content/quote-crash-93750-expected.txt        2012-09-05 19:29:53 UTC (rev 127631)
</span><span class="lines">@@ -0,0 +1,5 @@
</span><ins>+Bug 93750: RenderQuote corrupts doubly linked list on insertion before head of list
+
+It passes if it does not CRASH or ASSERT.
+
+
</ins></span></pre></div>
<a id="brancheschromium1229LayoutTestsfastcssgeneratedcontentquotecrash93750htmlfromrev125343trunkLayoutTestsfastcssgeneratedcontentquotecrash93750html"></a>
<div class="copfile"><h4>Copied: branches/chromium/1229/LayoutTests/fast/css-generated-content/quote-crash-93750.html (from rev 125343, trunk/LayoutTests/fast/css-generated-content/quote-crash-93750.html) (0 => 127631)</h4>
<pre class="diff"><span>
<span class="info">--- branches/chromium/1229/LayoutTests/fast/css-generated-content/quote-crash-93750.html                                (rev 0)
+++ branches/chromium/1229/LayoutTests/fast/css-generated-content/quote-crash-93750.html        2012-09-05 19:29:53 UTC (rev 127631)
</span><span class="lines">@@ -0,0 +1,21 @@
</span><ins>+&lt;!doctype html&gt;
+
+&lt;style&gt;
+    .fixed::before {
+        position:fixed;
+    }
+&lt;/style&gt;
+
+&lt;script&gt;
+    if (window.testRunner) window.testRunner.dumpAsText();
+    onload = function(){
+      document.designMode = &quot;on&quot;;
+      document.execCommand(&quot;SelectAll&quot;);
+      document.execCommand(&quot;Indent&quot;, false);
+    }
+&lt;/script&gt;
+
+&lt;p&gt;Bug &lt;a href=&quot;https://bugs.webkit.org/show_bug.cgi?id=93750&quot;&gt;93750&lt;/a&gt;: RenderQuote corrupts doubly linked list on insertion before head of list&lt;/p&gt;
+&lt;p&gt;It passes if it does not CRASH or ASSERT.&lt;/p&gt;

+&lt;q class=&quot;fixed&quot;&gt;&lt;/q&gt;
</ins></span></pre></div>
<a id="brancheschromium1229SourceWebCorerenderingRenderQuotecpp"></a>
<div class="modfile"><h4>Modified: branches/chromium/1229/Source/WebCore/rendering/RenderQuote.cpp (127630 => 127631)</h4>
<pre class="diff"><span>
<span class="info">--- branches/chromium/1229/Source/WebCore/rendering/RenderQuote.cpp        2012-09-05 19:27:07 UTC (rev 127630)
+++ branches/chromium/1229/Source/WebCore/rendering/RenderQuote.cpp        2012-09-05 19:29:53 UTC (rev 127631)
</span><span class="lines">@@ -292,6 +292,8 @@
</span><span class="cx">     if (!m_previous) {
</span><span class="cx">         m_next = view()-&gt;renderQuoteHead();
</span><span class="cx">         view()-&gt;setRenderQuoteHead(this);
</span><ins>+        if (m_next)
+            m_next-&gt;m_previous = this;
</ins><span class="cx">     }
</span><span class="cx">     m_attached = true;
</span><span class="cx"> 
</span><span class="lines">@@ -299,7 +301,9 @@
</span><span class="cx">         quote-&gt;updateDepth();
</span><span class="cx"> 
</span><span class="cx">     ASSERT(!m_next || m_next-&gt;m_attached);
</span><ins>+    ASSERT(!m_next || m_next-&gt;m_previous == this);
</ins><span class="cx">     ASSERT(!m_previous || m_previous-&gt;m_attached);
</span><ins>+    ASSERT(!m_previous || m_previous-&gt;m_next == this);
</ins><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> void RenderQuote::detachQuote()
</span></span></pre>
</div>
</div>

</body>
</html>