<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[81540] trunk/Source/WebCore</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/81540">81540</a></dd>
<dt>Author</dt> <dd>abarth@webkit.org</dd>
<dt>Date</dt> <dd>2011-03-18 17:51:25 -0700 (Fri, 18 Mar 2011)</dd>
</dl>

<h3>Log Message</h3>
<pre>2011-03-18  Adam Barth  <abarth@webkit.org>

        Reviewed by Dimitri Glazkov.

        WebCore GYP build should build
        https://bugs.webkit.org/show_bug.cgi?id=56696

        After this patch, the WebCore GYP build successfully compiles and
        links.  I haven't trying executing it yet.

        * WebCore.gypi:
            - DOMMouseEvent should be included as part of the Objective-C bindings.
        * WebCore.xcodeproj/project.pbxproj:
            - RenderSVGPath.cpp was mistakenly included directly in the project
              instead of being built by RenderSVGAllInOne.
        * gyp/WebCore.gyp:
            - Exclude some more files from the build.  These files are absent
              in the normal build.  I didn't see them earlier because the dead
              code stripping was hiding them.  (They're probably unreferenced.)
            - Switch to using RenderSVGAllInOne.  I'm not entirely sure if this
              part of the patch is necessary, but it matches the normal build
              more closely.
        * platform/mac/WebCoreObjCExtras.mm:
            - The normal build passes the -Wdeprecated-declarations flag when
              compiling this file.  The GYP folks explicitly do not want to add
              that feature to GYP, and there does not appear to be a way to
              remove the deprecated call from this file.
        * rendering/svg/RenderSVGAllInOne.cpp:
            - Add RenderSVGPath.cpp, which was missing previously.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreWebCoregypi">trunk/Source/WebCore/WebCore.gypi</a></li>
<li><a href="#trunkSourceWebCoreWebCorexcodeprojprojectpbxproj">trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj</a></li>
<li><a href="#trunkSourceWebCoregypWebCoregyp">trunk/Source/WebCore/gyp/WebCore.gyp</a></li>
<li><a href="#trunkSourceWebCoreplatformmacWebCoreObjCExtrasmm">trunk/Source/WebCore/platform/mac/WebCoreObjCExtras.mm</a></li>
<li><a href="#trunkSourceWebCorerenderingsvgRenderSVGAllInOnecpp">trunk/Source/WebCore/rendering/svg/RenderSVGAllInOne.cpp</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (81539 => 81540)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog   2011-03-19 00:48:10 UTC (rev 81539)
+++ trunk/Source/WebCore/ChangeLog      2011-03-19 00:51:25 UTC (rev 81540)
</span><span class="lines">@@ -2,6 +2,36 @@
</span><span class="cx"> 
</span><span class="cx">         Reviewed by Dimitri Glazkov.
</span><span class="cx"> 
</span><ins>+        WebCore GYP build should build
+        https://bugs.webkit.org/show_bug.cgi?id=56696
+
+        After this patch, the WebCore GYP build successfully compiles and
+        links.  I haven't trying executing it yet.
+
+        * WebCore.gypi:
+            - DOMMouseEvent should be included as part of the Objective-C bindings.
+        * WebCore.xcodeproj/project.pbxproj:
+            - RenderSVGPath.cpp was mistakenly included directly in the project
+              instead of being built by RenderSVGAllInOne.
+        * gyp/WebCore.gyp:
+            - Exclude some more files from the build.  These files are absent
+              in the normal build.  I didn't see them earlier because the dead
+              code stripping was hiding them.  (They're probably unreferenced.)
+            - Switch to using RenderSVGAllInOne.  I'm not entirely sure if this
+              part of the patch is necessary, but it matches the normal build
+              more closely.
+        * platform/mac/WebCoreObjCExtras.mm:
+            - The normal build passes the -Wdeprecated-declarations flag when
+              compiling this file.  The GYP folks explicitly do not want to add
+              that feature to GYP, and there does not appear to be a way to
+              remove the deprecated call from this file.
+        * rendering/svg/RenderSVGAllInOne.cpp:
+            - Add RenderSVGPath.cpp, which was missing previously.
+
+2011-03-18  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Dimitri Glazkov.
+
</ins><span class="cx">         WebCore GYP build should (almost!) link
</span><span class="cx">         https://bugs.webkit.org/show_bug.cgi?id=56689
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceWebCoreWebCoregypi"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/WebCore.gypi (81539 => 81540)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/WebCore.gypi        2011-03-19 00:48:10 UTC (rev 81539)
+++ trunk/Source/WebCore/WebCore.gypi   2011-03-19 00:51:25 UTC (rev 81540)
</span><span class="lines">@@ -6763,6 +6763,8 @@
</span><span class="cx">             '<(PRODUCT_DIR)/DerivedSources/WebCore/DOMMessagePort.h',
</span><span class="cx">             '<(PRODUCT_DIR)/DerivedSources/WebCore/DOMMessagePort.mm',
</span><span class="cx">             '<(PRODUCT_DIR)/DerivedSources/WebCore/DOMMessagePortInternal.h',
</span><ins>+            '<(PRODUCT_DIR)/DerivedSources/WebCore/DOMMouseEvent.mm',
+            '<(PRODUCT_DIR)/DerivedSources/WebCore/DOMMouseEventInternal.h',
</ins><span class="cx">             '<(PRODUCT_DIR)/DerivedSources/WebCore/DOMMutationEvent.mm',
</span><span class="cx">             '<(PRODUCT_DIR)/DerivedSources/WebCore/DOMMutationEventInternal.h',
</span><span class="cx">             '<(PRODUCT_DIR)/DerivedSources/WebCore/DOMNamedNodeMap.mm',
</span></span></pre></div>
<a id="trunkSourceWebCoreWebCorexcodeprojprojectpbxproj"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (81539 => 81540)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj   2011-03-19 00:48:10 UTC (rev 81539)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj      2011-03-19 00:51:25 UTC (rev 81540)
</span><span class="lines">@@ -4072,7 +4072,6 @@
</span><span class="cx">          ABDDFE7A0A5C6E7000A3E11D /* RenderMenuList.h in Headers */ = {isa = PBXBuildFile; fileRef = ABDDFE740A5C6E7000A3E11D /* RenderMenuList.h */; };
</span><span class="cx">          ABFE7E120D32FAF60066F4D2 /* MediaControlElements.cpp in Sources */ = {isa = PBXBuildFile; fileRef = ABFE7E100D32FAF50066F4D2 /* MediaControlElements.cpp */; };
</span><span class="cx">          ABFE7E130D32FAF60066F4D2 /* MediaControlElements.h in Headers */ = {isa = PBXBuildFile; fileRef = ABFE7E110D32FAF50066F4D2 /* MediaControlElements.h */; };
</span><del>-               ADDF1AD61257CD9A0003A759 /* RenderSVGPath.cpp in Sources */ = {isa = PBXBuildFile; fileRef = ADDF1AD41257CD9A0003A759 /* RenderSVGPath.cpp */; };
</del><span class="cx">           ADDF1AD71257CD9A0003A759 /* RenderSVGPath.h in Headers */ = {isa = PBXBuildFile; fileRef = ADDF1AD51257CD9A0003A759 /* RenderSVGPath.h */; };
</span><span class="cx">          B0149E7D11A4B21500196A7B /* AsyncImageResizer.cpp in Sources */ = {isa = PBXBuildFile; fileRef = B0149E7911A4B21500196A7B /* AsyncImageResizer.cpp */; };
</span><span class="cx">          B0149E7E11A4B21500196A7B /* AsyncImageResizer.h in Headers */ = {isa = PBXBuildFile; fileRef = B0149E7A11A4B21500196A7B /* AsyncImageResizer.h */; };
</span><span class="lines">@@ -24770,7 +24769,6 @@
</span><span class="cx">                          BC8C8FAD0DDCD31B00B592F4 /* RenderStyle.cpp in Sources */,
</span><span class="cx">                          D302754D12A5FEAB004BD828 /* RenderSummary.cpp in Sources */,
</span><span class="cx">                          0F4E57171313276200CF85AF /* RenderSVGAllInOne.cpp in Sources */,
</span><del>-                               ADDF1AD61257CD9A0003A759 /* RenderSVGPath.cpp in Sources */,
</del><span class="cx">                           A8DF4AEC0980C42C0052981B /* RenderTable.cpp in Sources */,
</span><span class="cx">                          A8DF4AEA0980C42C0052981B /* RenderTableCell.cpp in Sources */,
</span><span class="cx">                          A8DF4AE80980C42C0052981B /* RenderTableCol.cpp in Sources */,
</span></span></pre></div>
<a id="trunkSourceWebCoregypWebCoregyp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/gyp/WebCore.gyp (81539 => 81540)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/gyp/WebCore.gyp     2011-03-19 00:48:10 UTC (rev 81539)
+++ trunk/Source/WebCore/gyp/WebCore.gyp        2011-03-19 00:51:25 UTC (rev 81540)
</span><span class="lines">@@ -68,6 +68,10 @@
</span><span class="cx">         ['exclude', 'platform/KillRingNone\\.cpp$'],
</span><span class="cx">         ['exclude', 'platform/graphics/cg/FontPlatformData\\.h$'],
</span><span class="cx">         ['exclude', 'platform/graphics/gpu/LoopBlinnPathProcessor\\.(cpp|h)$'],
</span><ins>+        ['exclude', 'platform/graphics/gpu/LoopBlinnLocalTriangulator\\.(cpp|h)$'],
+        ['exclude', 'platform/graphics/gpu/LoopBlinnPathCache\\.(cpp|h)$'],
+        ['exclude', 'platform/graphics/gpu/LoopBlinnShader\\.(cpp|h)$'],
+        ['exclude', 'platform/graphics/gpu/LoopBlinnSolidFillShader\\.(cpp|h)$'],
</ins><span class="cx">         # FIXME: Consider excluding GL as a suffix.
</span><span class="cx">         ['exclude', 'platform/graphics/ImageSource\\.cpp$'],
</span><span class="cx">         ['exclude', 'platform/graphics/opengl/TextureMapperGL\\.cpp$'],
</span><span class="lines">@@ -80,8 +84,10 @@
</span><span class="cx">         ['exclude', 'plugins/PluginDataNone\\.cpp$'],
</span><span class="cx">         ['exclude', 'plugins/PluginDatabase\\.cpp$'],
</span><span class="cx">         ['exclude', 'plugins/PluginPackageNone\\.cpp$'],
</span><ins>+        ['exclude', 'plugins/PluginPackage\\.cpp$'],
</ins><span class="cx">         ['exclude', 'plugins/PluginStream\\.cpp$'],
</span><span class="cx">         ['exclude', 'plugins/PluginView\\.cpp$'],
</span><ins>+        ['exclude', 'plugins/mac/PluginPackageMac\\.cpp$'],
</ins><span class="cx">         ['exclude', 'plugins/mac/PluginViewMac\\.mm$'],
</span><span class="cx">         ['exclude', 'plugins/npapi\\.cpp$'],
</span><span class="cx"> 
</span><span class="lines">@@ -102,6 +108,9 @@
</span><span class="cx">         ['exclude', 'tokenizer\\.cpp'],
</span><span class="cx"> 
</span><span class="cx">         ['exclude', 'AllInOne\\.cpp$'],
</span><ins>+
+        ['exclude', 'rendering/svg/[^/]+\\.cpp'],
+        ['include', 'rendering/svg/RenderSVGAllInOne\\.cpp$'],
</ins><span class="cx">       ],
</span><span class="cx">       'mac_framework_private_headers': [
</span><span class="cx">         '<@(webcore_privateheader_files)',
</span><span class="lines">@@ -143,6 +152,7 @@
</span><span class="cx">             'GCC_PREFIX_HEADER': '<(DEPTH)/WebCore/WebCorePrefix.h',
</span><span class="cx">             'INFOPLIST_FILE': '<(DEPTH)/WebCore/Info.plist',
</span><span class="cx">             'ALWAYS_SEARCH_USER_PATHS': 'NO',
</span><ins>+            'DEAD_CODE_STRIPPING': 'NO',
</ins><span class="cx">           },
</span><span class="cx">         }],
</span><span class="cx">       ],
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformmacWebCoreObjCExtrasmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/mac/WebCoreObjCExtras.mm (81539 => 81540)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/mac/WebCoreObjCExtras.mm   2011-03-19 00:48:10 UTC (rev 81539)
+++ trunk/Source/WebCore/platform/mac/WebCoreObjCExtras.mm      2011-03-19 00:51:25 UTC (rev 81540)
</span><span class="lines">@@ -26,6 +26,11 @@
</span><span class="cx">  * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
</span><span class="cx">  */
</span><span class="cx"> 
</span><ins>+// This file intentionally calls objc_finalizeOnMainThread, which is deprecated.
+// According to http://gcc.gnu.org/onlinedocs/gcc-4.2.1/gcc/Diagnostic-Pragmas.html#Diagnostic-Pragmas
+// we need to place this directive before any data or functions are defined.
+#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
+
</ins><span class="cx"> #include "config.h"
</span><span class="cx"> #include "WebCoreObjCExtras.h"
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingsvgRenderSVGAllInOnecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/svg/RenderSVGAllInOne.cpp (81539 => 81540)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/svg/RenderSVGAllInOne.cpp 2011-03-19 00:48:10 UTC (rev 81539)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGAllInOne.cpp    2011-03-19 00:51:25 UTC (rev 81540)
</span><span class="lines">@@ -34,6 +34,7 @@
</span><span class="cx"> #include "RenderSVGInline.cpp"
</span><span class="cx"> #include "RenderSVGInlineText.cpp"
</span><span class="cx"> #include "RenderSVGModelObject.cpp"
</span><ins>+#include "RenderSVGPath.cpp"
</ins><span class="cx"> #include "RenderSVGResource.cpp"
</span><span class="cx"> #include "RenderSVGResourceClipper.cpp"
</span><span class="cx"> #include "RenderSVGResourceContainer.cpp"
</span></span></pre>
</div>
</div>

</body>
</html>