<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[80738] trunk</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/80738">80738</a></dd>
<dt>Author</dt> <dd>oliver@apple.com</dd>
<dt>Date</dt> <dd>2011-03-10 11:27:49 -0800 (Thu, 10 Mar 2011)</dd>
</dl>

<h3>Log Message</h3>
<pre>2011-03-10  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        jquery/manipulation.html fails after <a href="http://trac.webkit.org/projects/webkit/changeset/80598">r80598</a>
        https://bugs.webkit.org/show_bug.cgi?id=56019

        Removed jQuery tests from skiplists

        * platform/gtk/Skipped:
        * platform/qt/Skipped:
2011-03-09  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        jquery/manipulation.html fails after <a href="http://trac.webkit.org/projects/webkit/changeset/80598">r80598</a>
        https://bugs.webkit.org/show_bug.cgi?id=56019

        When linking a call, codeblock now takes ownership of the linked function
        This removes the need for unlinking, and thus the incorrectness that was
        showing up in these tests.

        * bytecode/CodeBlock.cpp:
        (JSC::CodeBlock::~CodeBlock):
        (JSC::CodeBlock::markAggregate):
        * bytecode/CodeBlock.h:
        (JSC::CallLinkInfo::CallLinkInfo):
        (JSC::CallLinkInfo::setUnlinked):
        (JSC::CodeBlock::addCaller):
        * jit/JIT.cpp:
        (JSC::JIT::privateCompile):
        (JSC::JIT::linkCall):
        (JSC::JIT::linkConstruct):
        * jit/JIT.h:
        * runtime/Executable.cpp:
        * runtime/Executable.h:</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsplatformgtkSkipped">trunk/LayoutTests/platform/gtk/Skipped</a></li>
<li><a href="#trunkLayoutTestsplatformqtSkipped">trunk/LayoutTests/platform/qt/Skipped</a></li>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCorebytecodeCodeBlockcpp">trunk/Source/JavaScriptCore/bytecode/CodeBlock.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCorebytecodeCodeBlockh">trunk/Source/JavaScriptCore/bytecode/CodeBlock.h</a></li>
<li><a href="#trunkSourceJavaScriptCorejitJITcpp">trunk/Source/JavaScriptCore/jit/JIT.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCorejitJITh">trunk/Source/JavaScriptCore/jit/JIT.h</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeExecutablecpp">trunk/Source/JavaScriptCore/runtime/Executable.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeExecutableh">trunk/Source/JavaScriptCore/runtime/Executable.h</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (80737 => 80738)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog      2011-03-10 19:22:42 UTC (rev 80737)
+++ trunk/LayoutTests/ChangeLog 2011-03-10 19:27:49 UTC (rev 80738)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2011-03-10  Oliver Hunt  <oliver@apple.com>
+
+        Reviewed by Gavin Barraclough.
+
+        jquery/manipulation.html fails after r80598
+        https://bugs.webkit.org/show_bug.cgi?id=56019
+
+        Removed jQuery tests from skiplists
+
+        * platform/gtk/Skipped:
+        * platform/qt/Skipped:
+
</ins><span class="cx"> 2011-03-10  Ryosuke Niwa  <rniwa@webkit.org>
</span><span class="cx"> 
</span><span class="cx">         Reviewed by Ojan Vafai.
</span></span></pre></div>
<a id="trunkLayoutTestsplatformgtkSkipped"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/gtk/Skipped (80737 => 80738)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/gtk/Skipped   2011-03-10 19:22:42 UTC (rev 80737)
+++ trunk/LayoutTests/platform/gtk/Skipped      2011-03-10 19:27:49 UTC (rev 80738)
</span><span class="lines">@@ -103,12 +103,6 @@
</span><span class="cx"> # https://bugs.webkit.org/show_bug.cgi?id=55126
</span><span class="cx"> media/video-aspect-ratio.html
</span><span class="cx"> 
</span><del>-# https://bugs.webkit.org/show_bug.cgi?id=56080
-jquery/effects.html
-
-# https://bugs.webkit.org/show_bug.cgi?id=22770
-tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody.html
-
</del><span class="cx"> ###############################################################################
</span><span class="cx"> # TESTS TIMING OUT
</span><span class="cx"> ###############################################################################
</span><span class="lines">@@ -1321,10 +1315,3 @@
</span><span class="cx"> fast/viewport/viewport-128.html
</span><span class="cx"> http/tests/security/xss-DENIED-xsl-document-redirect.xml
</span><span class="cx"> http/tests/security/xss-DENIED-xsl-external-entity-redirect.xml
</span><del>-
-# This test has failed since the import of the jquery test suite.
-# https://bugs.webkit.org/show_bug.cgi?id=56019
-jquery/manipulation.html
-
-# https://bugs.webkit.org/show_bug.cgi?id=56081
-fast/js/large-expressions.html
</del></span></pre></div>
<a id="trunkLayoutTestsplatformqtSkipped"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/qt/Skipped (80737 => 80738)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/qt/Skipped    2011-03-10 19:22:42 UTC (rev 80737)
+++ trunk/LayoutTests/platform/qt/Skipped       2011-03-10 19:27:49 UTC (rev 80738)
</span><span class="lines">@@ -3199,7 +3199,3 @@
</span><span class="cx"> # https://bugs.webkit.org/show_bug.cgi?id=55767
</span><span class="cx"> http/tests/appcache/auth.html
</span><span class="cx"> http/tests/xmlhttprequest/basic-auth.html
</span><del>-
-# jquery/manipulation.html fails after r80598
-# https://bugs.webkit.org/show_bug.cgi?id=56019
-jquery
</del></span></pre></div>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (80737 => 80738)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog    2011-03-10 19:22:42 UTC (rev 80737)
+++ trunk/Source/JavaScriptCore/ChangeLog       2011-03-10 19:27:49 UTC (rev 80738)
</span><span class="lines">@@ -1,3 +1,29 @@
</span><ins>+2011-03-09  Oliver Hunt  <oliver@apple.com>
+
+        Reviewed by Gavin Barraclough.
+
+        jquery/manipulation.html fails after r80598
+        https://bugs.webkit.org/show_bug.cgi?id=56019
+
+        When linking a call, codeblock now takes ownership of the linked function
+        This removes the need for unlinking, and thus the incorrectness that was
+        showing up in these tests.
+
+        * bytecode/CodeBlock.cpp:
+        (JSC::CodeBlock::~CodeBlock):
+        (JSC::CodeBlock::markAggregate):
+        * bytecode/CodeBlock.h:
+        (JSC::CallLinkInfo::CallLinkInfo):
+        (JSC::CallLinkInfo::setUnlinked):
+        (JSC::CodeBlock::addCaller):
+        * jit/JIT.cpp:
+        (JSC::JIT::privateCompile):
+        (JSC::JIT::linkCall):
+        (JSC::JIT::linkConstruct):
+        * jit/JIT.h:
+        * runtime/Executable.cpp:
+        * runtime/Executable.h:
+
</ins><span class="cx"> 2011-03-09  Daniel Bates  <dbates@rim.com>
</span><span class="cx"> 
</span><span class="cx">         Attempt to fix the WinCE build after changeset 80684 <http://trac.webkit.org/changeset/80684>
</span></span></pre></div>
<a id="trunkSourceJavaScriptCorebytecodeCodeBlockcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/bytecode/CodeBlock.cpp (80737 => 80738)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/bytecode/CodeBlock.cpp       2011-03-10 19:22:42 UTC (rev 80737)
+++ trunk/Source/JavaScriptCore/bytecode/CodeBlock.cpp  2011-03-10 19:27:49 UTC (rev 80738)
</span><span class="lines">@@ -1406,12 +1406,6 @@
</span><span class="cx">     for (size_t size = m_structureStubInfos.size(), i = 0; i < size; ++i)
</span><span class="cx">         m_structureStubInfos[i].deref();
</span><span class="cx"> 
</span><del>-    for (size_t size = m_callLinkInfos.size(), i = 0; i < size; ++i) {
-        CallLinkInfo* callLinkInfo = &m_callLinkInfos[i];
-        if (callLinkInfo->isLinked())
-            callLinkInfo->callee->removeCaller(callLinkInfo);
-    }
-
</del><span class="cx">     for (size_t size = m_methodCallLinkInfos.size(), i = 0; i < size; ++i) {
</span><span class="cx">         if (Structure* structure = m_methodCallLinkInfos[i].cachedStructure) {
</span><span class="cx">             structure->deref();
</span><span class="lines">@@ -1421,10 +1415,6 @@
</span><span class="cx">         }
</span><span class="cx">     }
</span><span class="cx"> 
</span><del>-#if ENABLE(JIT_OPTIMIZE_CALL)
-    unlinkCallers();
-#endif
-
</del><span class="cx"> #endif // ENABLE(JIT)
</span><span class="cx"> 
</span><span class="cx"> #if DUMP_CODE_BLOCK_STATISTICS
</span><span class="lines">@@ -1432,19 +1422,6 @@
</span><span class="cx"> #endif
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-#if ENABLE(JIT_OPTIMIZE_CALL)
-void CodeBlock::unlinkCallers()
-{
-    size_t size = m_linkedCallerList.size();
-    for (size_t i = 0; i < size; ++i) {
-        CallLinkInfo* currentCaller = m_linkedCallerList[i];
-        JIT::unlinkCallOrConstruct(currentCaller);
-        currentCaller->setUnlinked();
-    }
-    m_linkedCallerList.clear();
-}
-#endif
-
</del><span class="cx"> void CodeBlock::derefStructures(Instruction* vPC) const
</span><span class="cx"> {
</span><span class="cx">     Interpreter* interpreter = m_globalData->interpreter;
</span><span class="lines">@@ -1545,6 +1522,11 @@
</span><span class="cx">         markStack.append(&m_functionExprs[i]);
</span><span class="cx">     for (size_t i = 0; i < m_functionDecls.size(); ++i)
</span><span class="cx">         markStack.append(&m_functionDecls[i]);
</span><ins>+#if ENABLE(JIT_OPTIMIZE_CALL)
+    for (unsigned i = 0; i < numberOfCallLinkInfos(); ++i)
+        if (callLinkInfo(i).isLinked())
+            markStack.append(&callLinkInfo(i).callee);
+#endif
</ins><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> HandlerInfo* CodeBlock::handlerForBytecodeOffset(unsigned bytecodeOffset)
</span></span></pre></div>
<a id="trunkSourceJavaScriptCorebytecodeCodeBlockh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/bytecode/CodeBlock.h (80737 => 80738)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/bytecode/CodeBlock.h 2011-03-10 19:22:42 UTC (rev 80737)
+++ trunk/Source/JavaScriptCore/bytecode/CodeBlock.h    2011-03-10 19:27:49 UTC (rev 80738)
</span><span class="lines">@@ -96,8 +96,7 @@
</span><span class="cx"> #if ENABLE(JIT)
</span><span class="cx">     struct CallLinkInfo {
</span><span class="cx">         CallLinkInfo()
</span><del>-            : callee(0)
-            , position(0)
</del><ins>+            : position(0)
</ins><span class="cx">             , hasSeenShouldRepatch(0)
</span><span class="cx">         {
</span><span class="cx">         }
</span><span class="lines">@@ -105,12 +104,11 @@
</span><span class="cx">         CodeLocationNearCall callReturnLocation;
</span><span class="cx">         CodeLocationDataLabelPtr hotPathBegin;
</span><span class="cx">         CodeLocationNearCall hotPathOther;
</span><del>-        CodeBlock* ownerCodeBlock;
-        CodeBlock* callee;
</del><ins>+        WriteBarrier<JSFunction> callee;
</ins><span class="cx">         unsigned position : 31;
</span><span class="cx">         unsigned hasSeenShouldRepatch : 1;
</span><span class="cx">         
</span><del>-        void setUnlinked() { callee = 0; }
</del><ins>+        void setUnlinked() { callee.clear(); }
</ins><span class="cx">         bool isLinked() { return callee; }
</span><span class="cx"> 
</span><span class="cx">         bool seenOnce()
</span><span class="lines">@@ -257,9 +255,6 @@
</span><span class="cx">         void markAggregate(MarkStack&);
</span><span class="cx">         void refStructures(Instruction* vPC) const;
</span><span class="cx">         void derefStructures(Instruction* vPC) const;
</span><del>-#if ENABLE(JIT_OPTIMIZE_CALL)
-        void unlinkCallers();
-#endif
</del><span class="cx"> 
</span><span class="cx">         static void dumpStatistics();
</span><span class="cx"> 
</span><span class="lines">@@ -292,25 +287,13 @@
</span><span class="cx">         void expressionRangeForBytecodeOffset(unsigned bytecodeOffset, int& divot, int& startOffset, int& endOffset);
</span><span class="cx"> 
</span><span class="cx"> #if ENABLE(JIT)
</span><del>-        void addCaller(CallLinkInfo* caller)
</del><ins>+        void addCaller(JSGlobalData& globalData, CallLinkInfo* caller, JSFunction* callee)
</ins><span class="cx">         {
</span><del>-            caller->callee = this;
</del><ins>+            caller->callee.set(globalData, ownerExecutable(), callee);
</ins><span class="cx">             caller->position = m_linkedCallerList.size();
</span><span class="cx">             m_linkedCallerList.append(caller);
</span><span class="cx">         }
</span><span class="cx"> 
</span><del>-        void removeCaller(CallLinkInfo* caller)
-        {
-            unsigned pos = caller->position;
-            unsigned lastPos = m_linkedCallerList.size() - 1;
-
-            if (pos != lastPos) {
-                m_linkedCallerList[pos] = m_linkedCallerList[lastPos];
-                m_linkedCallerList[pos]->position = pos;
-            }
-            m_linkedCallerList.shrink(lastPos);
-        }
-
</del><span class="cx">         StructureStubInfo& getStubInfo(ReturnAddressPtr returnAddress)
</span><span class="cx">         {
</span><span class="cx">             return *(binaryChop<StructureStubInfo, void*, getStructureStubInfoReturnLocation>(m_structureStubInfos.begin(), m_structureStubInfos.size(), returnAddress.value()));
</span></span></pre></div>
<a id="trunkSourceJavaScriptCorejitJITcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/jit/JIT.cpp (80737 => 80738)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/jit/JIT.cpp  2011-03-10 19:22:42 UTC (rev 80737)
+++ trunk/Source/JavaScriptCore/jit/JIT.cpp     2011-03-10 19:27:49 UTC (rev 80738)
</span><span class="lines">@@ -567,7 +567,6 @@
</span><span class="cx"> #if ENABLE(JIT_OPTIMIZE_CALL)
</span><span class="cx">     for (unsigned i = 0; i < m_codeBlock->numberOfCallLinkInfos(); ++i) {
</span><span class="cx">         CallLinkInfo& info = m_codeBlock->callLinkInfo(i);
</span><del>-        info.ownerCodeBlock = m_codeBlock;
</del><span class="cx">         info.callReturnLocation = patchBuffer.locationOfNearCall(m_callStructureStubCompilationInfo[i].callReturnLocation);
</span><span class="cx">         info.hotPathBegin = patchBuffer.locationOf(m_callStructureStubCompilationInfo[i].hotPathBegin);
</span><span class="cx">         info.hotPathOther = patchBuffer.locationOfNearCall(m_callStructureStubCompilationInfo[i].hotPathOther);
</span><span class="lines">@@ -588,18 +587,6 @@
</span><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> #if ENABLE(JIT_OPTIMIZE_CALL)
</span><del>-void JIT::unlinkCallOrConstruct(CallLinkInfo* callLinkInfo)
-{
-    // When the JSFunction is deleted the pointer embedded in the instruction stream will no longer be valid
-    // (and, if a new JSFunction happened to be constructed at the same location, we could get a false positive
-    // match).  Reset the check so it no longer matches.
-    RepatchBuffer repatchBuffer(callLinkInfo->ownerCodeBlock);
-#if USE(JSVALUE32_64)
-    repatchBuffer.repatch(callLinkInfo->hotPathBegin, 0);
-#else
-    repatchBuffer.repatch(callLinkInfo->hotPathBegin, JSValue::encode(JSValue()));
-#endif
-}
</del><span class="cx"> 
</span><span class="cx"> void JIT::linkCall(JSFunction* callee, CodeBlock* callerCodeBlock, CodeBlock* calleeCodeBlock, JIT::CodePtr code, CallLinkInfo* callLinkInfo, int callerArgCount, JSGlobalData* globalData)
</span><span class="cx"> {
</span><span class="lines">@@ -611,7 +598,7 @@
</span><span class="cx">         ASSERT(!callLinkInfo->isLinked());
</span><span class="cx">     
</span><span class="cx">         if (calleeCodeBlock)
</span><del>-            calleeCodeBlock->addCaller(callLinkInfo);
</del><ins>+            calleeCodeBlock->addCaller(*globalData, callLinkInfo, callee);
</ins><span class="cx">     
</span><span class="cx">         repatchBuffer.repatch(callLinkInfo->hotPathBegin, callee);
</span><span class="cx">         repatchBuffer.relink(callLinkInfo->hotPathOther, code);
</span><span class="lines">@@ -631,7 +618,7 @@
</span><span class="cx">         ASSERT(!callLinkInfo->isLinked());
</span><span class="cx">     
</span><span class="cx">         if (calleeCodeBlock)
</span><del>-            calleeCodeBlock->addCaller(callLinkInfo);
</del><ins>+            calleeCodeBlock->addCaller(*globalData, callLinkInfo, callee);
</ins><span class="cx">     
</span><span class="cx">         repatchBuffer.repatch(callLinkInfo->hotPathBegin, callee);
</span><span class="cx">         repatchBuffer.relink(callLinkInfo->hotPathOther, code);
</span></span></pre></div>
<a id="trunkSourceJavaScriptCorejitJITh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/jit/JIT.h (80737 => 80738)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/jit/JIT.h    2011-03-10 19:22:42 UTC (rev 80737)
+++ trunk/Source/JavaScriptCore/jit/JIT.h       2011-03-10 19:27:49 UTC (rev 80738)
</span><span class="lines">@@ -245,7 +245,6 @@
</span><span class="cx"> 
</span><span class="cx">         static void linkCall(JSFunction* callee, CodeBlock* callerCodeBlock, CodeBlock* calleeCodeBlock, CodePtr, CallLinkInfo*, int callerArgCount, JSGlobalData*);
</span><span class="cx">         static void linkConstruct(JSFunction* callee, CodeBlock* callerCodeBlock, CodeBlock* calleeCodeBlock, CodePtr, CallLinkInfo*, int callerArgCount, JSGlobalData*);
</span><del>-        static void unlinkCallOrConstruct(CallLinkInfo*);
</del><span class="cx"> 
</span><span class="cx">     private:
</span><span class="cx">         struct JSRInfo {
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeExecutablecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/Executable.cpp (80737 => 80738)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/Executable.cpp       2011-03-10 19:22:42 UTC (rev 80737)
+++ trunk/Source/JavaScriptCore/runtime/Executable.cpp  2011-03-10 19:27:49 UTC (rev 80738)
</span><span class="lines">@@ -85,15 +85,6 @@
</span><span class="cx">     m_lastLine = lastLine;
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-FunctionExecutable::~FunctionExecutable()
-{
-#if ENABLE(JIT_OPTIMIZE_CALL)
-    if (isGeneratedForCall())
-        generatedBytecodeForCall().unlinkCallers();
-    if (isGeneratedForConstruct())
-        generatedBytecodeForConstruct().unlinkCallers();
-#endif
-}
</del><span class="cx"> 
</span><span class="cx"> JSObject* EvalExecutable::compileInternal(ExecState* exec, ScopeChainNode* scopeChainNode)
</span><span class="cx"> {
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeExecutableh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/Executable.h (80737 => 80738)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/Executable.h 2011-03-10 19:22:42 UTC (rev 80737)
+++ trunk/Source/JavaScriptCore/runtime/Executable.h    2011-03-10 19:27:49 UTC (rev 80738)
</span><span class="lines">@@ -307,8 +307,6 @@
</span><span class="cx">             return new (globalData) FunctionExecutable(globalData, name, source, forceUsesArguments, parameters, isInStrictContext, firstLine, lastLine);
</span><span class="cx">         }
</span><span class="cx"> 
</span><del>-        ~FunctionExecutable();
-
</del><span class="cx">         JSFunction* make(ExecState* exec, ScopeChainNode* scopeChain)
</span><span class="cx">         {
</span><span class="cx">             return new (exec) JSFunction(exec, this, scopeChain);
</span></span></pre>
</div>
</div>

</body>
</html>