<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[80559] trunk/Source/WebCore</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/80559">80559</a></dd>
<dt>Author</dt> <dd>andreas.kling@nokia.com</dd>
<dt>Date</dt> <dd>2011-03-08 04:35:53 -0800 (Tue, 08 Mar 2011)</dd>
</dl>

<h3>Log Message</h3>
<pre>2011-03-08  Andreas Kling  <kling@webkit.org>

        Reviewed by Benjamin Poulain.

        RenderObject: Pass complex type arguments as const-references.

        * WebCore.exp.in:
        * rendering/RenderObject.h:
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::drawBoxSideFromPath):
        (WebCore::RenderObject::drawArcForBoxSide):
        (WebCore::RenderObject::localToAbsolute):
        (WebCore::RenderObject::absoluteToLocal):</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreWebCoreexpin">trunk/Source/WebCore/WebCore.exp.in</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderObjectcpp">trunk/Source/WebCore/rendering/RenderObject.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderObjecth">trunk/Source/WebCore/rendering/RenderObject.h</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (80558 => 80559)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog   2011-03-08 11:47:37 UTC (rev 80558)
+++ trunk/Source/WebCore/ChangeLog      2011-03-08 12:35:53 UTC (rev 80559)
</span><span class="lines">@@ -1,5 +1,19 @@
</span><span class="cx"> 2011-03-08  Andreas Kling  <kling@webkit.org>
</span><span class="cx"> 
</span><ins>+        Reviewed by Benjamin Poulain.
+
+        RenderObject: Pass complex type arguments as const-references.
+
+        * WebCore.exp.in:
+        * rendering/RenderObject.h:
+        * rendering/RenderObject.cpp:
+        (WebCore::RenderObject::drawBoxSideFromPath):
+        (WebCore::RenderObject::drawArcForBoxSide):
+        (WebCore::RenderObject::localToAbsolute):
+        (WebCore::RenderObject::absoluteToLocal):
+
+2011-03-08  Andreas Kling  <kling@webkit.org>
+
</ins><span class="cx">         Reviewed by Antonio Gomes.
</span><span class="cx"> 
</span><span class="cx">         Path: Make measurement functions const
</span></span></pre></div>
<a id="trunkSourceWebCoreWebCoreexpin"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/WebCore.exp.in (80558 => 80559)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/WebCore.exp.in      2011-03-08 11:47:37 UTC (rev 80558)
+++ trunk/Source/WebCore/WebCore.exp.in 2011-03-08 12:35:53 UTC (rev 80559)
</span><span class="lines">@@ -1042,7 +1042,7 @@
</span><span class="cx"> __ZNK7WebCore12IconDatabase24shouldStopThreadActivityEv
</span><span class="cx"> __ZNK7WebCore12IconDatabase9isEnabledEv
</span><span class="cx"> __ZNK7WebCore12RenderObject14enclosingLayerEv
</span><del>-__ZNK7WebCore12RenderObject15localToAbsoluteENS_10FloatPointEbb
</del><ins>+__ZNK7WebCore12RenderObject15localToAbsoluteERKNS_10FloatPointEbb
</ins><span class="cx"> __ZNK7WebCore12RenderObject4viewEv
</span><span class="cx"> __ZNK7WebCore12RenderObject7childAtEj
</span><span class="cx"> __ZNK7WebCore12RenderWidget14windowClipRectEv
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderObjectcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderObject.cpp (80558 => 80559)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderObject.cpp  2011-03-08 11:47:37 UTC (rev 80558)
+++ trunk/Source/WebCore/rendering/RenderObject.cpp     2011-03-08 12:35:53 UTC (rev 80559)
</span><span class="lines">@@ -901,7 +901,7 @@
</span><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> #if HAVE(PATH_BASED_BORDER_RADIUS_DRAWING)
</span><del>-void RenderObject::drawBoxSideFromPath(GraphicsContext* graphicsContext, IntRect borderRect, Path borderPath, 
</del><ins>+void RenderObject::drawBoxSideFromPath(GraphicsContext* graphicsContext, const IntRect& borderRect, const Path& borderPath,
</ins><span class="cx">                                     float thickness, float drawThickness, BoxSide s, const RenderStyle* style, 
</span><span class="cx">                                     Color c, EBorderStyle borderStyle)
</span><span class="cx"> {
</span><span class="lines">@@ -1048,7 +1048,7 @@
</span><span class="cx">     graphicsContext->drawRect(borderRect);
</span><span class="cx"> }
</span><span class="cx"> #else
</span><del>-void RenderObject::drawArcForBoxSide(GraphicsContext* graphicsContext, int x, int y, float thickness, IntSize radius,
</del><ins>+void RenderObject::drawArcForBoxSide(GraphicsContext* graphicsContext, int x, int y, float thickness, const IntSize& radius,
</ins><span class="cx">                                      int angleStart, int angleSpan, BoxSide s, Color c,
</span><span class="cx">                                      EBorderStyle style, bool firstCorner)
</span><span class="cx"> {
</span><span class="lines">@@ -1936,7 +1936,7 @@
</span><span class="cx">     return view()->viewRect();
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-FloatPoint RenderObject::localToAbsolute(FloatPoint localPoint, bool fixed, bool useTransforms) const
</del><ins>+FloatPoint RenderObject::localToAbsolute(const FloatPoint& localPoint, bool fixed, bool useTransforms) const
</ins><span class="cx"> {
</span><span class="cx">     TransformState transformState(TransformState::ApplyTransformDirection, localPoint);
</span><span class="cx">     mapLocalToContainer(0, fixed, useTransforms, transformState);
</span><span class="lines">@@ -1945,7 +1945,7 @@
</span><span class="cx">     return transformState.lastPlanarPoint();
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-FloatPoint RenderObject::absoluteToLocal(FloatPoint containerPoint, bool fixed, bool useTransforms) const
</del><ins>+FloatPoint RenderObject::absoluteToLocal(const FloatPoint& containerPoint, bool fixed, bool useTransforms) const
</ins><span class="cx"> {
</span><span class="cx">     TransformState transformState(TransformState::UnapplyInverseTransformDirection, containerPoint);
</span><span class="cx">     mapAbsoluteToLocalPoint(fixed, useTransforms, transformState);
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderObjecth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderObject.h (80558 => 80559)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderObject.h    2011-03-08 11:47:37 UTC (rev 80558)
+++ trunk/Source/WebCore/rendering/RenderObject.h       2011-03-08 12:35:53 UTC (rev 80559)
</span><span class="lines">@@ -432,13 +432,13 @@
</span><span class="cx">     void drawLineForBoxSide(GraphicsContext*, int x1, int y1, int x2, int y2, BoxSide,
</span><span class="cx">                             Color, EBorderStyle, int adjbw1, int adjbw2);
</span><span class="cx"> #if HAVE(PATH_BASED_BORDER_RADIUS_DRAWING)
</span><del>-    void drawBoxSideFromPath(GraphicsContext*, IntRect, Path, 
</del><ins>+    void drawBoxSideFromPath(GraphicsContext*, const IntRect&, const Path&,
</ins><span class="cx">                             float thickness, float drawThickness, BoxSide, const RenderStyle*, 
</span><span class="cx">                             Color, EBorderStyle);
</span><span class="cx"> #else
</span><span class="cx">     // FIXME: This function should be removed when all ports implement GraphicsContext::clipConvexPolygon()!!
</span><span class="cx">     // At that time, everyone can use RenderObject::drawBoxSideFromPath() instead. This should happen soon.
</span><del>-    void drawArcForBoxSide(GraphicsContext*, int x, int y, float thickness, IntSize radius, int angleStart,
</del><ins>+    void drawArcForBoxSide(GraphicsContext*, int x, int y, float thickness, const IntSize& radius, int angleStart,
</ins><span class="cx">                            int angleSpan, BoxSide, Color, EBorderStyle, bool firstCorner);
</span><span class="cx"> #endif
</span><span class="cx"> 
</span><span class="lines">@@ -557,8 +557,8 @@
</span><span class="cx"> 
</span><span class="cx">     // Convert the given local point to absolute coordinates
</span><span class="cx">     // FIXME: Temporary. If useTransforms is true, take transforms into account. Eventually localToAbsolute() will always be transform-aware.
</span><del>-    FloatPoint localToAbsolute(FloatPoint localPoint = FloatPoint(), bool fixed = false, bool useTransforms = false) const;
-    FloatPoint absoluteToLocal(FloatPoint, bool fixed = false, bool useTransforms = false) const;
</del><ins>+    FloatPoint localToAbsolute(const FloatPoint& localPoint = FloatPoint(), bool fixed = false, bool useTransforms = false) const;
+    FloatPoint absoluteToLocal(const FloatPoint&, bool fixed = false, bool useTransforms = false) const;
</ins><span class="cx"> 
</span><span class="cx">     // Convert a local quad to absolute coordinates, taking transforms into account.
</span><span class="cx">     FloatQuad localToAbsoluteQuad(const FloatQuad& quad, bool fixed = false) const
</span></span></pre>
</div>
</div>

</body>
</html>