<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[70975] trunk</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/70975">70975</a></dd>
<dt>Author</dt> <dd>tonikitoo@webkit.org</dd>
<dt>Date</dt> <dd>2010-10-29 22:38:42 -0700 (Fri, 29 Oct 2010)</dd>
</dl>

<h3>Log Message</h3>
<pre>Needs a &quot;LinuxEditingBehavior&quot;, perhaps with a better name
https://bugs.webkit.org/show_bug.cgi?id=36627

Reviewed by Ojan Vafai.
Patch by Antonio Gomes &lt;agomes@rim.com&gt;

WebCore:

Added EditingUnixBehavior editing type aim to cover the cases when
neither Mac or Windows behaviors are appropriated.

It was decided to name it Unix not Linux.

No new tests. The current editing tests that involve platform specific
bahaviors are coded so that they go through all editing behavior
types possible. There will be a follow up bug where all of them will
be updated to include the new editing behavior (&quot;unix&quot;).

* editing/EditingBehaviorTypes.h:
* page/Settings.cpp:
(WebCore::editingBehaviorTypeForPlatform):
(WebCore::Settings::Settings):

WebKit/chromium:

Added the corresponding Chromium setting to WebCore's EditingUnixBehavior: EditingBehaviorUnix.

* public/WebSettings.h:
* src/AssertMatchingEnums.cpp:

WebKit/gtk:

Added the corresponding GTK+ setting to WebCore's EditingUnixBehavior: WEBKIT_EDITING_BEHAVIOR_UNIX.

* webkit/webkitwebsettings.cpp:
(webkit_web_settings_class_init):
* webkit/webkitwebsettings.h:

WebKit/mac:

Added the corresponding GTK+ setting to WebCore's EditingUnixBehavior: WebKitEditingUnixBehavior.

* WebView/WebFrame.mm:
(core):
* WebView/WebPreferencesPrivate.h:

WebKit/qt:

Adding support to Qt's DRTSupport class to test the newly introduced Unix editing behavior.

* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::setEditingBehavior):

WebKit/win:

Added the corresponding GTK+ setting to WebCore's EditingUnixBehavior: WebKitEditingUnixBehavior.

* Interfaces/IWebPreferences.idl:

WebKitTools:

Adding support to Mac's, GTK+'s, Windows' and Chromium's LayoutTestController class to test the newly introduced Unix editing behavior.

* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::setEditingBehavior):
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::setEditingBehavior):
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::setEditingBehavior):
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::setEditingBehavior):</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkWebCoreChangeLog">trunk/WebCore/ChangeLog</a></li>
<li><a href="#trunkWebCoreeditingEditingBehaviorTypesh">trunk/WebCore/editing/EditingBehaviorTypes.h</a></li>
<li><a href="#trunkWebCorepageSettingscpp">trunk/WebCore/page/Settings.cpp</a></li>
<li><a href="#trunkWebKitchromiumChangeLog">trunk/WebKit/chromium/ChangeLog</a></li>
<li><a href="#trunkWebKitchromiumpublicWebSettingsh">trunk/WebKit/chromium/public/WebSettings.h</a></li>
<li><a href="#trunkWebKitchromiumsrcAssertMatchingEnumscpp">trunk/WebKit/chromium/src/AssertMatchingEnums.cpp</a></li>
<li><a href="#trunkWebKitgtkChangeLog">trunk/WebKit/gtk/ChangeLog</a></li>
<li><a href="#trunkWebKitgtkwebkitwebkitwebsettingscpp">trunk/WebKit/gtk/webkit/webkitwebsettings.cpp</a></li>
<li><a href="#trunkWebKitgtkwebkitwebkitwebsettingsh">trunk/WebKit/gtk/webkit/webkitwebsettings.h</a></li>
<li><a href="#trunkWebKitmacChangeLog">trunk/WebKit/mac/ChangeLog</a></li>
<li><a href="#trunkWebKitmacWebViewWebFramemm">trunk/WebKit/mac/WebView/WebFrame.mm</a></li>
<li><a href="#trunkWebKitmacWebViewWebPreferencesPrivateh">trunk/WebKit/mac/WebView/WebPreferencesPrivate.h</a></li>
<li><a href="#trunkWebKitqtChangeLog">trunk/WebKit/qt/ChangeLog</a></li>
<li><a href="#trunkWebKitqtWebCoreSupportDumpRenderTreeSupportQtcpp">trunk/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp</a></li>
<li><a href="#trunkWebKitwinChangeLog">trunk/WebKit/win/ChangeLog</a></li>
<li><a href="#trunkWebKitwinInterfacesIWebPreferencesidl">trunk/WebKit/win/Interfaces/IWebPreferences.idl</a></li>
<li><a href="#trunkWebKitToolsChangeLog">trunk/WebKitTools/ChangeLog</a></li>
<li><a href="#trunkWebKitToolsDumpRenderTreechromiumLayoutTestControllercpp">trunk/WebKitTools/DumpRenderTree/chromium/LayoutTestController.cpp</a></li>
<li><a href="#trunkWebKitToolsDumpRenderTreegtkLayoutTestControllerGtkcpp">trunk/WebKitTools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp</a></li>
<li><a href="#trunkWebKitToolsDumpRenderTreemacLayoutTestControllerMacmm">trunk/WebKitTools/DumpRenderTree/mac/LayoutTestControllerMac.mm</a></li>
<li><a href="#trunkWebKitToolsDumpRenderTreewinLayoutTestControllerWincpp">trunk/WebKitTools/DumpRenderTree/win/LayoutTestControllerWin.cpp</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/ChangeLog (70974 => 70975)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/ChangeLog        2010-10-30 04:07:39 UTC (rev 70974)
+++ trunk/WebCore/ChangeLog        2010-10-30 05:38:42 UTC (rev 70975)
</span><span class="lines">@@ -1,3 +1,25 @@
</span><ins>+2010-10-28  Antonio Gomes  &lt;agomes@rim.com&gt;
+
+        Reviewed by Ojan Vafai.
+
+        Needs a &quot;LinuxEditingBehavior&quot;, perhaps with a better name
+        https://bugs.webkit.org/show_bug.cgi?id=36627
+
+        Added EditingUnixBehavior editing type aim to cover the cases when
+        neither Mac or Windows behaviors are appropriated.
+
+        It was decided to name it Unix not Linux.
+
+        No new tests. The current editing tests that involve platform specific
+        bahaviors are coded so that they go through all editing behavior
+        types possible. There will be a follow up bug where all of them will
+        be updated to include the new editing behavior (&quot;unix&quot;).
+
+        * editing/EditingBehaviorTypes.h:
+        * page/Settings.cpp:
+        (WebCore::editingBehaviorTypeForPlatform):
+        (WebCore::Settings::Settings):
+
</ins><span class="cx"> 2010-10-29  Daniel Bates  &lt;dbates@rim.com&gt;
</span><span class="cx"> 
</span><span class="cx">         Reviewed by Adam Barth.
</span></span></pre></div>
<a id="trunkWebCoreeditingEditingBehaviorTypesh"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/editing/EditingBehaviorTypes.h (70974 => 70975)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/editing/EditingBehaviorTypes.h        2010-10-30 04:07:39 UTC (rev 70974)
+++ trunk/WebCore/editing/EditingBehaviorTypes.h        2010-10-30 05:38:42 UTC (rev 70975)
</span><span class="lines">@@ -38,7 +38,8 @@
</span><span class="cx"> // if possible in the future.
</span><span class="cx"> enum EditingBehaviorType {
</span><span class="cx">     EditingMacBehavior,
</span><del>-    EditingWindowsBehavior
</del><ins>+    EditingWindowsBehavior,
+    EditingUnixBehavior
</ins><span class="cx"> };
</span><span class="cx"> 
</span><span class="cx"> } // WebCore namespace
</span></span></pre></div>
<a id="trunkWebCorepageSettingscpp"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/page/Settings.cpp (70974 => 70975)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/page/Settings.cpp        2010-10-30 04:07:39 UTC (rev 70974)
+++ trunk/WebCore/page/Settings.cpp        2010-10-30 05:38:42 UTC (rev 70975)
</span><span class="lines">@@ -64,6 +64,27 @@
</span><span class="cx"> bool Settings::gShouldUseHighResolutionTimers = true;
</span><span class="cx"> #endif
</span><span class="cx"> 
</span><ins>+// NOTEs
+//  1) EditingMacBehavior comprises Tiger, Leopard, SnowLeopard and iOS builds, as well QtWebKit and Chromium when built on Mac;
+//  2) EditingWindowsBehavior comprises Win32 and WinCE builds, as well as QtWebKit and Chromium when built on Windows;
+//  3) EditingUnixBehavior comprises all unix-based systems, but Darwin/MacOS (and then abusing the terminology);
+// 99) MacEditingBehavior is used a fallback.
+static EditingBehaviorType editingBehaviorTypeForPlatform()
+{
+    return
+#if OS(DARWIN)
+    EditingMacBehavior
+#elif OS(WINDOWS)
+    EditingWindowsBehavior
+#elif OS(UNIX)
+    EditingUnixBehavior
+#else
+    // Fallback
+    EditingMacBehavior
+#endif
+    ;
+}
+
</ins><span class="cx"> Settings::Settings(Page* page)
</span><span class="cx">     : m_page(page)
</span><span class="cx">     , m_editableLinkBehavior(EditableLinkDefaultBehavior)
</span><span class="lines">@@ -120,14 +141,7 @@
</span><span class="cx">     , m_enforceCSSMIMETypeInNoQuirksMode(true)
</span><span class="cx">     , m_usesEncodingDetector(false)
</span><span class="cx">     , m_allowScriptsToCloseWindows(false)
</span><del>-    , m_editingBehaviorType(
-#if PLATFORM(MAC) || (PLATFORM(CHROMIUM) &amp;&amp; OS(DARWIN))
-        // (PLATFORM(MAC) is always false in Chromium, hence the extra condition.)
-        EditingMacBehavior
-#else
-        EditingWindowsBehavior
-#endif
-        )
</del><ins>+    , m_editingBehaviorType(editingBehaviorTypeForPlatform())
</ins><span class="cx">     // FIXME: This should really be disabled by default as it makes platforms that don't support the feature download files
</span><span class="cx">     // they can't use by. Leaving enabled for now to not change existing behavior.
</span><span class="cx">     , m_downloadableBinaryFontsEnabled(true)
</span></span></pre></div>
<a id="trunkWebKitchromiumChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/WebKit/chromium/ChangeLog (70974 => 70975)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebKit/chromium/ChangeLog        2010-10-30 04:07:39 UTC (rev 70974)
+++ trunk/WebKit/chromium/ChangeLog        2010-10-30 05:38:42 UTC (rev 70975)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2010-10-28  Antonio Gomes  &lt;agomes@rim.com&gt;
+
+        Reviewed by Ojan Vafai.
+
+        Needs a &quot;LinuxEditingBehavior&quot;, perhaps with a better name
+        https://bugs.webkit.org/show_bug.cgi?id=36627
+
+        Added the corresponding Chromium setting to WebCore's EditingUnixBehavior: EditingBehaviorUnix.
+
+        * public/WebSettings.h:
+        * src/AssertMatchingEnums.cpp:
+
</ins><span class="cx"> 2010-10-29  Daniel Bates  &lt;dbates@rim.com&gt;
</span><span class="cx"> 
</span><span class="cx">         Reviewed by Adam Barth.
</span></span></pre></div>
<a id="trunkWebKitchromiumpublicWebSettingsh"></a>
<div class="modfile"><h4>Modified: trunk/WebKit/chromium/public/WebSettings.h (70974 => 70975)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebKit/chromium/public/WebSettings.h        2010-10-30 04:07:39 UTC (rev 70974)
+++ trunk/WebKit/chromium/public/WebSettings.h        2010-10-30 05:38:42 UTC (rev 70975)
</span><span class="lines">@@ -45,7 +45,8 @@
</span><span class="cx"> public:
</span><span class="cx">     enum EditingBehavior {
</span><span class="cx">         EditingBehaviorMac,
</span><del>-        EditingBehaviorWin
</del><ins>+        EditingBehaviorWin,
+        EditingBehaviorUnix
</ins><span class="cx">     };
</span><span class="cx"> 
</span><span class="cx">     virtual void setStandardFontFamily(const WebString&amp;) = 0;
</span></span></pre></div>
<a id="trunkWebKitchromiumsrcAssertMatchingEnumscpp"></a>
<div class="modfile"><h4>Modified: trunk/WebKit/chromium/src/AssertMatchingEnums.cpp (70974 => 70975)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebKit/chromium/src/AssertMatchingEnums.cpp        2010-10-30 04:07:39 UTC (rev 70974)
+++ trunk/WebKit/chromium/src/AssertMatchingEnums.cpp        2010-10-30 05:38:42 UTC (rev 70975)
</span><span class="lines">@@ -344,6 +344,7 @@
</span><span class="cx"> 
</span><span class="cx"> COMPILE_ASSERT_MATCHING_ENUM(WebSettings::EditingBehaviorMac, EditingMacBehavior);
</span><span class="cx"> COMPILE_ASSERT_MATCHING_ENUM(WebSettings::EditingBehaviorWin, EditingWindowsBehavior);
</span><ins>+COMPILE_ASSERT_MATCHING_ENUM(WebSettings::EditingBehaviorUnix, EditingUnixBehavior);
</ins><span class="cx"> 
</span><span class="cx"> COMPILE_ASSERT_MATCHING_ENUM(WebTextAffinityUpstream, UPSTREAM);
</span><span class="cx"> COMPILE_ASSERT_MATCHING_ENUM(WebTextAffinityDownstream, DOWNSTREAM);
</span></span></pre></div>
<a id="trunkWebKitgtkChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/WebKit/gtk/ChangeLog (70974 => 70975)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebKit/gtk/ChangeLog        2010-10-30 04:07:39 UTC (rev 70974)
+++ trunk/WebKit/gtk/ChangeLog        2010-10-30 05:38:42 UTC (rev 70975)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2010-10-28  Antonio Gomes  &lt;agomes@rim.com&gt;
+
+        Reviewed by Ojan Vafai.
+
+        Needs a &quot;LinuxEditingBehavior&quot;, perhaps with a better name
+        https://bugs.webkit.org/show_bug.cgi?id=36627
+
+        Added the corresponding GTK+ setting to WebCore's EditingUnixBehavior: WEBKIT_EDITING_BEHAVIOR_UNIX.
+
+        * webkit/webkitwebsettings.cpp:
+        (webkit_web_settings_class_init):
+        * webkit/webkitwebsettings.h:
+
</ins><span class="cx"> 2010-10-29  Daniel Bates  &lt;dbates@rim.com&gt;
</span><span class="cx"> 
</span><span class="cx">         Reviewed by Adam Barth.
</span></span></pre></div>
<a id="trunkWebKitgtkwebkitwebkitwebsettingscpp"></a>
<div class="modfile"><h4>Modified: trunk/WebKit/gtk/webkit/webkitwebsettings.cpp (70974 => 70975)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebKit/gtk/webkit/webkitwebsettings.cpp        2010-10-30 04:07:39 UTC (rev 70974)
+++ trunk/WebKit/gtk/webkit/webkitwebsettings.cpp        2010-10-30 05:38:42 UTC (rev 70975)
</span><span class="lines">@@ -689,6 +689,7 @@
</span><span class="cx"> 
</span><span class="cx">     COMPILE_ASSERT(static_cast&lt;int&gt;(WEBKIT_EDITING_BEHAVIOR_MAC) == static_cast&lt;int&gt;(WebCore::EditingMacBehavior), editing_behavior_type_mac_match);
</span><span class="cx">     COMPILE_ASSERT(static_cast&lt;int&gt;(WEBKIT_EDITING_BEHAVIOR_WINDOWS) == static_cast&lt;int&gt;(WebCore::EditingWindowsBehavior), editing_behavior_type_windows_match);
</span><ins>+    COMPILE_ASSERT(static_cast&lt;int&gt;(WEBKIT_EDITING_BEHAVIOR_UNIX) == static_cast&lt;int&gt;(WebCore::EditingUnixBehavior), editing_behavior_type_unix_match);
</ins><span class="cx"> 
</span><span class="cx">     /**
</span><span class="cx">     * WebKitWebSettings:editing-behavior
</span><span class="lines">@@ -713,7 +714,7 @@
</span><span class="cx">                                                       _(&quot;Editing behavior&quot;),
</span><span class="cx">                                                       _(&quot;The behavior mode to use in editing mode&quot;),
</span><span class="cx">                                                       WEBKIT_TYPE_EDITING_BEHAVIOR,
</span><del>-                                                      WEBKIT_EDITING_BEHAVIOR_MAC,
</del><ins>+                                                      WEBKIT_EDITING_BEHAVIOR_UNIX,
</ins><span class="cx">                                                       flags));
</span><span class="cx"> 
</span><span class="cx">     /**
</span></span></pre></div>
<a id="trunkWebKitgtkwebkitwebkitwebsettingsh"></a>
<div class="modfile"><h4>Modified: trunk/WebKit/gtk/webkit/webkitwebsettings.h (70974 => 70975)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebKit/gtk/webkit/webkitwebsettings.h        2010-10-30 04:07:39 UTC (rev 70974)
+++ trunk/WebKit/gtk/webkit/webkitwebsettings.h        2010-10-30 05:38:42 UTC (rev 70975)
</span><span class="lines">@@ -36,7 +36,8 @@
</span><span class="cx"> 
</span><span class="cx"> typedef enum {
</span><span class="cx">     WEBKIT_EDITING_BEHAVIOR_MAC,
</span><del>-    WEBKIT_EDITING_BEHAVIOR_WINDOWS
</del><ins>+    WEBKIT_EDITING_BEHAVIOR_WINDOWS,
+    WEBKIT_EDITING_BEHAVIOR_UNIX
</ins><span class="cx"> } WebKitEditingBehavior;
</span><span class="cx"> 
</span><span class="cx"> typedef struct _WebKitWebSettingsPrivate WebKitWebSettingsPrivate;
</span></span></pre></div>
<a id="trunkWebKitmacChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/WebKit/mac/ChangeLog (70974 => 70975)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebKit/mac/ChangeLog        2010-10-30 04:07:39 UTC (rev 70974)
+++ trunk/WebKit/mac/ChangeLog        2010-10-30 05:38:42 UTC (rev 70975)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2010-10-28  Antonio Gomes  &lt;agomes@rim.com&gt;
+
+        Reviewed by Ojan Vafai.
+
+        Needs a &quot;LinuxEditingBehavior&quot;, perhaps with a better name
+        https://bugs.webkit.org/show_bug.cgi?id=36627
+
+        Added the corresponding GTK+ setting to WebCore's EditingUnixBehavior: WebKitEditingUnixBehavior.
+
+        * WebView/WebFrame.mm:
+        (core):
+        * WebView/WebPreferencesPrivate.h:
+
</ins><span class="cx"> 2010-10-29  Daniel Bates  &lt;dbates@rim.com&gt;
</span><span class="cx"> 
</span><span class="cx">         Reviewed by Adam Barth.
</span></span></pre></div>
<a id="trunkWebKitmacWebViewWebFramemm"></a>
<div class="modfile"><h4>Modified: trunk/WebKit/mac/WebView/WebFrame.mm (70974 => 70975)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebKit/mac/WebView/WebFrame.mm        2010-10-30 04:07:39 UTC (rev 70974)
+++ trunk/WebKit/mac/WebView/WebFrame.mm        2010-10-30 05:38:42 UTC (rev 70975)
</span><span class="lines">@@ -203,6 +203,8 @@
</span><span class="cx">             return WebCore::EditingMacBehavior;
</span><span class="cx">         case WebKitEditingWinBehavior:
</span><span class="cx">             return WebCore::EditingWindowsBehavior;
</span><ins>+        case WebKitEditingUnixBehavior:
+            return WebCore::EditingUnixBehavior;
</ins><span class="cx">     }
</span><span class="cx">     ASSERT_NOT_REACHED();
</span><span class="cx">     return WebCore::EditingMacBehavior;
</span></span></pre></div>
<a id="trunkWebKitmacWebViewWebPreferencesPrivateh"></a>
<div class="modfile"><h4>Modified: trunk/WebKit/mac/WebView/WebPreferencesPrivate.h (70974 => 70975)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebKit/mac/WebView/WebPreferencesPrivate.h        2010-10-30 04:07:39 UTC (rev 70974)
+++ trunk/WebKit/mac/WebView/WebPreferencesPrivate.h        2010-10-30 05:38:42 UTC (rev 70975)
</span><span class="lines">@@ -45,7 +45,8 @@
</span><span class="cx"> 
</span><span class="cx"> typedef enum {
</span><span class="cx">     WebKitEditingMacBehavior,
</span><del>-    WebKitEditingWinBehavior
</del><ins>+    WebKitEditingWinBehavior,
+    WebKitEditingUnixBehavior
</ins><span class="cx"> } WebKitEditingBehavior;
</span><span class="cx"> 
</span><span class="cx"> extern NSString *WebPreferencesChangedNotification;
</span></span></pre></div>
<a id="trunkWebKitqtChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/WebKit/qt/ChangeLog (70974 => 70975)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebKit/qt/ChangeLog        2010-10-30 04:07:39 UTC (rev 70974)
+++ trunk/WebKit/qt/ChangeLog        2010-10-30 05:38:42 UTC (rev 70975)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2010-10-28  Antonio Gomes  &lt;agomes@rim.com&gt;
+
+        Reviewed by Ojan Vafai.
+
+        Needs a &quot;LinuxEditingBehavior&quot;, perhaps with a better name
+        https://bugs.webkit.org/show_bug.cgi?id=36627
+
+        Adding support to Qt's DRTSupport class to test the newly introduced Unix editing behavior.
+
+        * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
+        (DumpRenderTreeSupportQt::setEditingBehavior):
+
</ins><span class="cx"> 2010-10-29  Daniel Bates  &lt;dbates@rim.com&gt;
</span><span class="cx"> 
</span><span class="cx">         Reviewed by Adam Barth.
</span></span></pre></div>
<a id="trunkWebKitqtWebCoreSupportDumpRenderTreeSupportQtcpp"></a>
<div class="modfile"><h4>Modified: trunk/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp (70974 => 70975)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp        2010-10-30 04:07:39 UTC (rev 70974)
+++ trunk/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp        2010-10-30 05:38:42 UTC (rev 70975)
</span><span class="lines">@@ -544,6 +544,8 @@
</span><span class="cx">         coreEditingBehavior = EditingWindowsBehavior;
</span><span class="cx">     else if (editingBehavior == &quot;mac&quot;)
</span><span class="cx">         coreEditingBehavior = EditingMacBehavior;
</span><ins>+    else if (editingBehavior == &quot;unix&quot;)
+        coreEditingBehavior = EditingUnixBehavior;
</ins><span class="cx">     else {
</span><span class="cx">         ASSERT_NOT_REACHED();
</span><span class="cx">         return;
</span></span></pre></div>
<a id="trunkWebKitwinChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/WebKit/win/ChangeLog (70974 => 70975)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebKit/win/ChangeLog        2010-10-30 04:07:39 UTC (rev 70974)
+++ trunk/WebKit/win/ChangeLog        2010-10-30 05:38:42 UTC (rev 70975)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2010-10-28  Antonio Gomes  &lt;agomes@rim.com&gt;
+
+        Reviewed by Ojan Vafai.
+
+        Needs a &quot;LinuxEditingBehavior&quot;, perhaps with a better name
+        https://bugs.webkit.org/show_bug.cgi?id=36627
+
+        Added the corresponding GTK+ setting to WebCore's EditingUnixBehavior: WebKitEditingUnixBehavior.
+
+        * Interfaces/IWebPreferences.idl:
+
</ins><span class="cx"> 2010-10-29  Daniel Bates  &lt;dbates@rim.com&gt;
</span><span class="cx"> 
</span><span class="cx">         Reviewed by Adam Barth.
</span></span></pre></div>
<a id="trunkWebKitwinInterfacesIWebPreferencesidl"></a>
<div class="modfile"><h4>Modified: trunk/WebKit/win/Interfaces/IWebPreferences.idl (70974 => 70975)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebKit/win/Interfaces/IWebPreferences.idl        2010-10-30 04:07:39 UTC (rev 70974)
+++ trunk/WebKit/win/Interfaces/IWebPreferences.idl        2010-10-30 05:38:42 UTC (rev 70975)
</span><span class="lines">@@ -49,7 +49,8 @@
</span><span class="cx"> 
</span><span class="cx"> typedef enum WebKitEditingBehavior {
</span><span class="cx">     WebKitEditingMacBehavior = 0,
</span><del>-    WebKitEditingWinBehavior
</del><ins>+    WebKitEditingWinBehavior,
+    WebKitEditingUnixBehavior
</ins><span class="cx"> } WebKitEditingBehavior;
</span><span class="cx"> 
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkWebKitToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/WebKitTools/ChangeLog (70974 => 70975)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebKitTools/ChangeLog        2010-10-30 04:07:39 UTC (rev 70974)
+++ trunk/WebKitTools/ChangeLog        2010-10-30 05:38:42 UTC (rev 70975)
</span><span class="lines">@@ -1,3 +1,21 @@
</span><ins>+2010-10-28  Antonio Gomes  &lt;agomes@rim.com&gt;
+
+        Reviewed by Ojan Vafai.
+
+        Needs a &quot;LinuxEditingBehavior&quot;, perhaps with a better name
+        https://bugs.webkit.org/show_bug.cgi?id=36627
+
+        Adding support to Mac's, GTK+'s, Windows' and Chromium's LayoutTestController class to test the newly introduced Unix editing behavior.
+
+        * DumpRenderTree/chromium/LayoutTestController.cpp:
+        (LayoutTestController::setEditingBehavior):
+        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
+        (LayoutTestController::setEditingBehavior):
+        * DumpRenderTree/mac/LayoutTestControllerMac.mm:
+        (LayoutTestController::setEditingBehavior):
+        * DumpRenderTree/win/LayoutTestControllerWin.cpp:
+        (LayoutTestController::setEditingBehavior):
+
</ins><span class="cx"> 2010-10-29  Andreas Kling  &lt;kling@webkit.org&gt;
</span><span class="cx"> 
</span><span class="cx">         Reviewed by Kenneth Rohde Christiansen.
</span></span></pre></div>
<a id="trunkWebKitToolsDumpRenderTreechromiumLayoutTestControllercpp"></a>
<div class="modfile"><h4>Modified: trunk/WebKitTools/DumpRenderTree/chromium/LayoutTestController.cpp (70974 => 70975)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebKitTools/DumpRenderTree/chromium/LayoutTestController.cpp        2010-10-30 04:07:39 UTC (rev 70974)
+++ trunk/WebKitTools/DumpRenderTree/chromium/LayoutTestController.cpp        2010-10-30 05:38:42 UTC (rev 70975)
</span><span class="lines">@@ -1486,6 +1486,9 @@
</span><span class="cx">     } else if (key == &quot;win&quot;) {
</span><span class="cx">         m_shell-&gt;preferences()-&gt;editingBehavior = WebSettings::EditingBehaviorWin;
</span><span class="cx">         m_shell-&gt;applyPreferences();
</span><ins>+    } else if (key == &quot;unix&quot;) {
+        m_shell-&gt;preferences()-&gt;editingBehavior = WebSettings::EditingBehaviorUnix;
+        m_shell-&gt;applyPreferences();
</ins><span class="cx">     } else
</span><span class="cx">         logErrorToConsole(&quot;Passed invalid editing behavior. Should be 'mac' or 'win'.&quot;);
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkWebKitToolsDumpRenderTreegtkLayoutTestControllerGtkcpp"></a>
<div class="modfile"><h4>Modified: trunk/WebKitTools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp (70974 => 70975)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebKitTools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp        2010-10-30 04:07:39 UTC (rev 70974)
+++ trunk/WebKitTools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp        2010-10-30 05:38:42 UTC (rev 70975)
</span><span class="lines">@@ -813,8 +813,10 @@
</span><span class="cx"> 
</span><span class="cx">     if (!strcmp(editingBehavior, &quot;win&quot;))
</span><span class="cx">         g_object_set(G_OBJECT(settings), &quot;editing-behavior&quot;, WEBKIT_EDITING_BEHAVIOR_WINDOWS, NULL);
</span><del>-    if (!strcmp(editingBehavior, &quot;mac&quot;))
</del><ins>+    else if (!strcmp(editingBehavior, &quot;mac&quot;))
</ins><span class="cx">         g_object_set(G_OBJECT(settings), &quot;editing-behavior&quot;, WEBKIT_EDITING_BEHAVIOR_MAC, NULL);
</span><ins>+    else if (!strcmp(editingBehavior, &quot;unix&quot;))
+        g_object_set(G_OBJECT(settings), &quot;editing-behavior&quot;, WEBKIT_EDITING_BEHAVIOR_UNIX, NULL);
</ins><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> void LayoutTestController::abortModal()
</span></span></pre></div>
<a id="trunkWebKitToolsDumpRenderTreemacLayoutTestControllerMacmm"></a>
<div class="modfile"><h4>Modified: trunk/WebKitTools/DumpRenderTree/mac/LayoutTestControllerMac.mm (70974 => 70975)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebKitTools/DumpRenderTree/mac/LayoutTestControllerMac.mm        2010-10-30 04:07:39 UTC (rev 70974)
+++ trunk/WebKitTools/DumpRenderTree/mac/LayoutTestControllerMac.mm        2010-10-30 05:38:42 UTC (rev 70975)
</span><span class="lines">@@ -935,8 +935,10 @@
</span><span class="cx">     NSString* editingBehaviorNS = [[NSString alloc] initWithUTF8String:editingBehavior];
</span><span class="cx">     if ([editingBehaviorNS isEqualToString:@&quot;mac&quot;])
</span><span class="cx">         [[WebPreferences standardPreferences] setEditingBehavior:WebKitEditingMacBehavior];
</span><del>-    if ([editingBehaviorNS isEqualToString:@&quot;win&quot;])
</del><ins>+    else if ([editingBehaviorNS isEqualToString:@&quot;win&quot;])
</ins><span class="cx">         [[WebPreferences standardPreferences] setEditingBehavior:WebKitEditingWinBehavior];
</span><ins>+    else if ([editingBehaviorNS isEqualToString:@&quot;unix&quot;])
+        [[WebPreferences standardPreferences] setEditingBehavior:WebKitEditingUnixBehavior];
</ins><span class="cx">     [editingBehaviorNS release];
</span><span class="cx"> }
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkWebKitToolsDumpRenderTreewinLayoutTestControllerWincpp"></a>
<div class="modfile"><h4>Modified: trunk/WebKitTools/DumpRenderTree/win/LayoutTestControllerWin.cpp (70974 => 70975)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebKitTools/DumpRenderTree/win/LayoutTestControllerWin.cpp        2010-10-30 04:07:39 UTC (rev 70974)
+++ trunk/WebKitTools/DumpRenderTree/win/LayoutTestControllerWin.cpp        2010-10-30 05:38:42 UTC (rev 70975)
</span><span class="lines">@@ -1383,8 +1383,10 @@
</span><span class="cx">     string behaviorString(editingBehavior);
</span><span class="cx">     if (behaviorString == &quot;mac&quot;)
</span><span class="cx">         preferences-&gt;setEditingBehavior(WebKitEditingMacBehavior);
</span><del>-    if (behaviorString == &quot;win&quot;)
</del><ins>+    else if (behaviorString == &quot;win&quot;)
</ins><span class="cx">         preferences-&gt;setEditingBehavior(WebKitEditingWinBehavior);
</span><ins>+    else if (behaviorString == &quot;unix&quot;)
+        preferences-&gt;setEditingBehavior(WebKitEditingUnixBehavior);
</ins><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> void LayoutTestController::abortModal()
</span></span></pre>
</div>
</div>

</body>
</html>