<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[69063] trunk</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/69063">69063</a></dd>
<dt>Author</dt> <dd>chang.shu@nokia.com</dd>
<dt>Date</dt> <dd>2010-10-04 21:03:35 -0700 (Mon, 04 Oct 2010)</dd>
</dl>

<h3>Log Message</h3>
<pre>2010-10-04  Chang Shu  &lt;chang.shu@nokia.com&gt;

        Reviewed by Antonio Gomes.

        Fixed the typo that searches the wrong direction in the no-focus-node case.
        As a result, after page is loaded, pressing key &quot;arrowdown&quot; will bring the
        focus to the 1st element instead of the last element.
        https://bugs.webkit.org/show_bug.cgi?id=46901

        * fast/events/spatial-navigation/snav-1st-stop-expected.txt: Added.
        * fast/events/spatial-navigation/snav-1st-stop.html: Added.
2010-10-04  Chang Shu  &lt;chang.shu@nokia.com&gt;

        Reviewed by Antonio Gomes.

        Fixed the typo that searches the wrong direction in the no-focus-node case.
        As a result, after page is loaded, pressing key &quot;arrowdown&quot; will bring the
        focus to the 1st element instead of the last element.
        https://bugs.webkit.org/show_bug.cgi?id=46901

        Test: fast/events/spatial-navigation/snav-1st-stop.html

        * page/FocusController.cpp:
        (WebCore::FocusController::advanceFocusDirectionally):</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkWebCoreChangeLog">trunk/WebCore/ChangeLog</a></li>
<li><a href="#trunkWebCorepageFocusControllercpp">trunk/WebCore/page/FocusController.cpp</a></li>
</ul>

<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfasteventsspatialnavigationsnav1ststopexpectedtxt">trunk/LayoutTests/fast/events/spatial-navigation/snav-1st-stop-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfasteventsspatialnavigationsnav1ststophtml">trunk/LayoutTests/fast/events/spatial-navigation/snav-1st-stop.html</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (69062 => 69063)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog        2010-10-05 03:47:54 UTC (rev 69062)
+++ trunk/LayoutTests/ChangeLog        2010-10-05 04:03:35 UTC (rev 69063)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2010-10-04  Chang Shu  &lt;chang.shu@nokia.com&gt;
+
+        Reviewed by Antonio Gomes.
+
+        Fixed the typo that searches the wrong direction in the no-focus-node case.
+        As a result, after page is loaded, pressing key &quot;arrowdown&quot; will bring the
+        focus to the 1st element instead of the last element.
+        https://bugs.webkit.org/show_bug.cgi?id=46901
+
+        * fast/events/spatial-navigation/snav-1st-stop-expected.txt: Added.
+        * fast/events/spatial-navigation/snav-1st-stop.html: Added.
+
</ins><span class="cx"> 2010-10-04  Kent Tamura  &lt;tkent@chromium.org&gt;
</span><span class="cx"> 
</span><span class="cx">         Unreviewed, test expectation update.
</span></span></pre></div>
<a id="trunkLayoutTestsfasteventsspatialnavigationsnav1ststopexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/events/spatial-navigation/snav-1st-stop-expected.txt (0 => 69063)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/events/spatial-navigation/snav-1st-stop-expected.txt                                (rev 0)
+++ trunk/LayoutTests/fast/events/spatial-navigation/snav-1st-stop-expected.txt        2010-10-05 04:03:35 UTC (rev 69063)
</span><span class="lines">@@ -0,0 +1,5 @@
</span><ins>+1        2        3
+4        5        6
+7        8        9
+PASS gFocusedDocument.activeElement.getAttribute(&quot;id&quot;) is &quot;1&quot;
+
</ins></span></pre></div>
<a id="trunkLayoutTestsfasteventsspatialnavigationsnav1ststophtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/events/spatial-navigation/snav-1st-stop.html (0 => 69063)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/events/spatial-navigation/snav-1st-stop.html                                (rev 0)
+++ trunk/LayoutTests/fast/events/spatial-navigation/snav-1st-stop.html        2010-10-05 04:03:35 UTC (rev 69063)
</span><span class="lines">@@ -0,0 +1,68 @@
</span><ins>+&lt;html&gt;
+  &lt;!--
+    This test ensures the correctness of Spatial Navigation (SNav) algorithm from a non-focus scenario.
+
+    * Pre-conditions:
+    1) DRT support for SNav enable/disable.
+
+    * Navigation steps:
+    1) Loads this page and send key down.
+    2) The 1st link should be focused.
+  --&gt;
+  &lt;head&gt;
+    &lt;script src=&quot;../../js/resources/js-test-pre.js&quot;&gt;&lt;/script&gt;
+    &lt;script src=&quot;resources/spatial-navigation-utils.js&quot;&gt;&lt;/script&gt;
+    &lt;script type=&quot;application/javascript&quot;&gt;
+
+    var resultMap = [
+      [&quot;Down&quot;, &quot;1&quot;],
+      [&quot;DONE&quot;, &quot;DONE&quot;]
+    ];
+
+    if (window.layoutTestController) {
+      layoutTestController.dumpAsText();
+      layoutTestController.setSpatialNavigationEnabled(true);
+      layoutTestController.overridePreference(&quot;WebKitTabToLinksPreferenceKey&quot;, 1);
+      layoutTestController.waitUntilDone();
+    }
+
+    function runTest()
+    {
+      // starting the test from no focused node.
+      initTest(resultMap, testCompleted);
+    }
+
+    function testCompleted()
+    {
+      if (window.layoutTestController)
+        layoutTestController.notifyDone();
+    }
+
+    window.onload = runTest;
+
+    &lt;/script&gt;
+    &lt;script src=&quot;../js/resources/js-test-post.js&quot;&gt;&lt;/script&gt;
+  &lt;/head&gt;
+  &lt;body id=&quot;some-content&quot; xmlns=&quot;http://www.w3.org/1999/xhtml&quot;&gt;
+    &lt;table style=&quot;text-align: left; width: 100%; margin-left: auto; margin-right: auto;&quot; border=&quot;1&quot; cellpadding=&quot;2&quot; cellspacing=&quot;1&quot;&gt;
+      &lt;tbody&gt;
+        &lt;tr&gt;
+          &lt;td style=&quot;vertical-align: top; text-align: center;&quot;&gt;&lt;a id=&quot;1&quot; href=&quot;a&quot;&gt;1&lt;/a&gt;&lt;/td&gt;
+          &lt;td style=&quot;vertical-align: top; text-align: center;&quot;&gt;&lt;a id=&quot;2&quot; href=&quot;a&quot;&gt;2&lt;/a&gt;&lt;/td&gt;
+          &lt;td style=&quot;vertical-align: top; text-align: center;&quot;&gt;&lt;a id=&quot;3&quot; href=&quot;a&quot;&gt;3&lt;/a&gt;&lt;/td&gt;
+        &lt;/tr&gt;
+        &lt;tr&gt;
+          &lt;td style=&quot;vertical-align: top; text-align: center;&quot;&gt;&lt;a id=&quot;4&quot; href=&quot;a&quot;&gt;4&lt;/a&gt;&lt;/td&gt;
+          &lt;td style=&quot;vertical-align: top; text-align: center;&quot;&gt;&lt;a id=&quot;5&quot; href=&quot;a&quot;&gt;5&lt;/td&gt;
+          &lt;td style=&quot;vertical-align: top; text-align: center;&quot;&gt;&lt;a id=&quot;6&quot; href=&quot;a&quot;&gt;6&lt;/a&gt;&lt;/td&gt;
+        &lt;/tr&gt;
+        &lt;tr&gt;
+          &lt;td style=&quot;vertical-align: top; text-align: center;&quot;&gt;&lt;a id=&quot;7&quot; href=&quot;a&quot;&gt;7&lt;/a&gt;&lt;/td&gt;
+          &lt;td style=&quot;vertical-align: top; text-align: center;&quot;&gt;&lt;a id=&quot;8&quot; href=&quot;a&quot;&gt;8&lt;/a&gt;&lt;/td&gt;
+          &lt;td style=&quot;vertical-align: top; text-align: center;&quot;&gt;&lt;a id=&quot;9&quot; href=&quot;a&quot;&gt;9&lt;/a&gt;&lt;/td&gt;
+        &lt;/tr&gt;
+      &lt;/tbody&gt;
+    &lt;/table&gt;
+    &lt;div id=&quot;console&quot;&gt;&lt;/div&gt;
+  &lt;/body&gt;
+&lt;/html&gt;
</ins></span></pre></div>
<a id="trunkWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/ChangeLog (69062 => 69063)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/ChangeLog        2010-10-05 03:47:54 UTC (rev 69062)
+++ trunk/WebCore/ChangeLog        2010-10-05 04:03:35 UTC (rev 69063)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2010-10-04  Chang Shu  &lt;chang.shu@nokia.com&gt;
+
+        Reviewed by Antonio Gomes.
+
+        Fixed the typo that searches the wrong direction in the no-focus-node case.
+        As a result, after page is loaded, pressing key &quot;arrowdown&quot; will bring the
+        focus to the 1st element instead of the last element.
+        https://bugs.webkit.org/show_bug.cgi?id=46901
+
+        Test: fast/events/spatial-navigation/snav-1st-stop.html
+
+        * page/FocusController.cpp:
+        (WebCore::FocusController::advanceFocusDirectionally):
+
</ins><span class="cx"> 2010-10-04  Simon Fraser  &lt;simon.fraser@apple.com&gt;
</span><span class="cx"> 
</span><span class="cx">         No review.
</span></span></pre></div>
<a id="trunkWebCorepageFocusControllercpp"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/page/FocusController.cpp (69062 => 69063)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/page/FocusController.cpp        2010-10-05 03:47:54 UTC (rev 69062)
+++ trunk/WebCore/page/FocusController.cpp        2010-10-05 04:03:35 UTC (rev 69063)
</span><span class="lines">@@ -298,7 +298,7 @@
</span><span class="cx">     if (!focusedNode) {
</span><span class="cx">         // Just move to the first focusable node.
</span><span class="cx">         FocusDirection tabDirection = (direction == FocusDirectionUp || direction == FocusDirectionLeft) ?
</span><del>-                                       FocusDirectionForward : FocusDirectionBackward;
</del><ins>+                                       FocusDirectionBackward : FocusDirectionForward;
</ins><span class="cx">         // 'initialFocus' is set to true so the chrome is not focused.
</span><span class="cx">         return advanceFocusInDocumentOrder(tabDirection, event, true);
</span><span class="cx">     }
</span></span></pre>
</div>
</div>

</body>
</html>