<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[68899] trunk</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/68899">68899</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2010-10-01 10:50:39 -0700 (Fri, 01 Oct 2010)</dd>
</dl>

<h3>Log Message</h3>
<pre>2010-10-01  Pratik Solanki  &lt;psolanki@apple.com&gt;

        Reviewed by Geoffrey Garen.
        Specify ALWAYS_INLINE at function declaration not function definition
        https://bugs.webkit.org/show_bug.cgi?id=46960

        For functions defined with ALWAYS_INLINE, add the attribute to the declaration as well.

        * bytecompiler/BytecodeGenerator.h:
        * wtf/FastMalloc.cpp:
2010-10-01  Pratik Solanki  &lt;psolanki@apple.com&gt;

        Reviewed by Geoffrey Garen.
        Specify ALWAYS_INLINE at function declaration not function definition
        https://bugs.webkit.org/show_bug.cgi?id=46960

        For functions defined with ALWAYS_INLINE, add the attribute to the declaration as well.

        * css/CSSStyleSelector.h:
        * rendering/InlineIterator.h:
        * rendering/style/RenderStyle.h:</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkJavaScriptCoreChangeLog">trunk/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkJavaScriptCorebytecompilerBytecodeGeneratorh">trunk/JavaScriptCore/bytecompiler/BytecodeGenerator.h</a></li>
<li><a href="#trunkJavaScriptCorewtfFastMalloccpp">trunk/JavaScriptCore/wtf/FastMalloc.cpp</a></li>
<li><a href="#trunkWebCoreChangeLog">trunk/WebCore/ChangeLog</a></li>
<li><a href="#trunkWebCorecssCSSStyleSelectorh">trunk/WebCore/css/CSSStyleSelector.h</a></li>
<li><a href="#trunkWebCorerenderingInlineIteratorh">trunk/WebCore/rendering/InlineIterator.h</a></li>
<li><a href="#trunkWebCorerenderingstyleRenderStyleh">trunk/WebCore/rendering/style/RenderStyle.h</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/JavaScriptCore/ChangeLog (68898 => 68899)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/JavaScriptCore/ChangeLog        2010-10-01 17:46:27 UTC (rev 68898)
+++ trunk/JavaScriptCore/ChangeLog        2010-10-01 17:50:39 UTC (rev 68899)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2010-10-01  Pratik Solanki  &lt;psolanki@apple.com&gt;
+
+        Reviewed by Geoffrey Garen.
+        Specify ALWAYS_INLINE at function declaration not function definition
+        https://bugs.webkit.org/show_bug.cgi?id=46960
+
+        For functions defined with ALWAYS_INLINE, add the attribute to the declaration as well.
+
+        * bytecompiler/BytecodeGenerator.h:
+        * wtf/FastMalloc.cpp:
+
</ins><span class="cx"> 2010-10-01  Kwang Yul Seo  &lt;skyul@company100.net&gt;
</span><span class="cx"> 
</span><span class="cx">         Unreviewed.
</span></span></pre></div>
<a id="trunkJavaScriptCorebytecompilerBytecodeGeneratorh"></a>
<div class="modfile"><h4>Modified: trunk/JavaScriptCore/bytecompiler/BytecodeGenerator.h (68898 => 68899)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/JavaScriptCore/bytecompiler/BytecodeGenerator.h        2010-10-01 17:46:27 UTC (rev 68898)
+++ trunk/JavaScriptCore/bytecompiler/BytecodeGenerator.h        2010-10-01 17:50:39 UTC (rev 68899)
</span><span class="lines">@@ -424,8 +424,8 @@
</span><span class="cx">         void emitOpcode(OpcodeID);
</span><span class="cx">         void retrieveLastBinaryOp(int&amp; dstIndex, int&amp; src1Index, int&amp; src2Index);
</span><span class="cx">         void retrieveLastUnaryOp(int&amp; dstIndex, int&amp; srcIndex);
</span><del>-        void rewindBinaryOp();
-        void rewindUnaryOp();
</del><ins>+        ALWAYS_INLINE void rewindBinaryOp();
+        ALWAYS_INLINE void rewindUnaryOp();
</ins><span class="cx"> 
</span><span class="cx">         PassRefPtr&lt;Label&gt; emitComplexJumpScopes(Label* target, ControlFlowContext* topScope, ControlFlowContext* bottomScope);
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkJavaScriptCorewtfFastMalloccpp"></a>
<div class="modfile"><h4>Modified: trunk/JavaScriptCore/wtf/FastMalloc.cpp (68898 => 68899)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/JavaScriptCore/wtf/FastMalloc.cpp        2010-10-01 17:46:27 UTC (rev 68898)
+++ trunk/JavaScriptCore/wtf/FastMalloc.cpp        2010-10-01 17:50:39 UTC (rev 68899)
</span><span class="lines">@@ -2185,10 +2185,10 @@
</span><span class="cx">   // Total byte size in cache
</span><span class="cx">   size_t Size() const { return size_; }
</span><span class="cx"> 
</span><del>-  void* Allocate(size_t size);
</del><ins>+  ALWAYS_INLINE void* Allocate(size_t size);
</ins><span class="cx">   void Deallocate(void* ptr, size_t size_class);
</span><span class="cx"> 
</span><del>-  void FetchFromCentralCache(size_t cl, size_t allocationSize);
</del><ins>+  ALWAYS_INLINE void FetchFromCentralCache(size_t cl, size_t allocationSize);
</ins><span class="cx">   void ReleaseToCentralCache(size_t cl, int N);
</span><span class="cx">   void Scavenge();
</span><span class="cx">   void Print() const;
</span><span class="lines">@@ -2289,12 +2289,12 @@
</span><span class="cx">   // REQUIRES: lock_ is held
</span><span class="cx">   // Release an object to spans.
</span><span class="cx">   // May temporarily release lock_.
</span><del>-  void ReleaseToSpans(void* object);
</del><ins>+  ALWAYS_INLINE void ReleaseToSpans(void* object);
</ins><span class="cx"> 
</span><span class="cx">   // REQUIRES: lock_ is held
</span><span class="cx">   // Populate cache by fetching from the page heap.
</span><span class="cx">   // May temporarily release lock_.
</span><del>-  void Populate();
</del><ins>+  ALWAYS_INLINE void Populate();
</ins><span class="cx"> 
</span><span class="cx">   // REQUIRES: lock is held.
</span><span class="cx">   // Tries to make room for a TCEntry.  If the cache is full it will try to
</span><span class="lines">@@ -2307,7 +2307,7 @@
</span><span class="cx">   // just iterates over the sizeclasses but does so without taking a lock.
</span><span class="cx">   // Returns true on success.
</span><span class="cx">   // May temporarily lock a &quot;random&quot; size class.
</span><del>-  static bool EvictRandomSizeClass(size_t locked_size_class, bool force);
</del><ins>+  static ALWAYS_INLINE bool EvictRandomSizeClass(size_t locked_size_class, bool force);
</ins><span class="cx"> 
</span><span class="cx">   // REQUIRES: lock_ is *not* held.
</span><span class="cx">   // Tries to shrink the Cache.  If force is true it will relase objects to
</span><span class="lines">@@ -3705,7 +3705,7 @@
</span><span class="cx"> #define do_malloc do_malloc&lt;crashOnFailure&gt;
</span><span class="cx"> 
</span><span class="cx"> template &lt;bool crashOnFailure&gt;
</span><del>-void* malloc(size_t);
</del><ins>+ALWAYS_INLINE void* malloc(size_t);
</ins><span class="cx"> 
</span><span class="cx"> void* fastMalloc(size_t size)
</span><span class="cx"> {
</span><span class="lines">@@ -3766,7 +3766,7 @@
</span><span class="cx"> extern &quot;C&quot; 
</span><span class="cx"> #else
</span><span class="cx"> template &lt;bool crashOnFailure&gt;
</span><del>-void* calloc(size_t, size_t);
</del><ins>+ALWAYS_INLINE void* calloc(size_t, size_t);
</ins><span class="cx"> 
</span><span class="cx"> void* fastCalloc(size_t n, size_t elem_size)
</span><span class="cx"> {
</span><span class="lines">@@ -3830,7 +3830,7 @@
</span><span class="cx"> extern &quot;C&quot; 
</span><span class="cx"> #else
</span><span class="cx"> template &lt;bool crashOnFailure&gt;
</span><del>-void* realloc(void*, size_t);
</del><ins>+ALWAYS_INLINE void* realloc(void*, size_t);
</ins><span class="cx"> 
</span><span class="cx"> void* fastRealloc(void* old_ptr, size_t new_size)
</span><span class="cx"> {
</span></span></pre></div>
<a id="trunkWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/ChangeLog (68898 => 68899)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/ChangeLog        2010-10-01 17:46:27 UTC (rev 68898)
+++ trunk/WebCore/ChangeLog        2010-10-01 17:50:39 UTC (rev 68899)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2010-10-01  Pratik Solanki  &lt;psolanki@apple.com&gt;
+
+        Reviewed by Geoffrey Garen.
+        Specify ALWAYS_INLINE at function declaration not function definition
+        https://bugs.webkit.org/show_bug.cgi?id=46960
+
+        For functions defined with ALWAYS_INLINE, add the attribute to the declaration as well.
+
+        * css/CSSStyleSelector.h:
+        * rendering/InlineIterator.h:
+        * rendering/style/RenderStyle.h:
+
</ins><span class="cx"> 2010-10-01  David Hyatt  &lt;hyatt@apple.com&gt;
</span><span class="cx"> 
</span><span class="cx">         Reviewed by Dan Bernstein.
</span></span></pre></div>
<a id="trunkWebCorecssCSSStyleSelectorh"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/css/CSSStyleSelector.h (68898 => 68899)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/css/CSSStyleSelector.h        2010-10-01 17:46:27 UTC (rev 68898)
+++ trunk/WebCore/css/CSSStyleSelector.h        2010-10-01 17:50:39 UTC (rev 68899)
</span><span class="lines">@@ -109,7 +109,7 @@
</span><span class="cx">     private:
</span><span class="cx">         void initForStyleResolve(Element*, RenderStyle* parentStyle = 0, PseudoId = NOPSEUDO);
</span><span class="cx">         void initElement(Element*);
</span><del>-        RenderStyle* locateSharedStyle();
</del><ins>+        ALWAYS_INLINE RenderStyle* locateSharedStyle();
</ins><span class="cx">         Node* locateCousinList(Element* parent, unsigned depth = 1);
</span><span class="cx">         bool canShareStyleWithElement(Node*);
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkWebCorerenderingInlineIteratorh"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/rendering/InlineIterator.h (68898 => 68899)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/rendering/InlineIterator.h        2010-10-01 17:46:27 UTC (rev 68898)
+++ trunk/WebCore/rendering/InlineIterator.h        2010-10-01 17:50:39 UTC (rev 68899)
</span><span class="lines">@@ -53,7 +53,7 @@
</span><span class="cx">     bool atEnd() const;
</span><span class="cx"> 
</span><span class="cx">     UChar current() const;
</span><del>-    WTF::Unicode::Direction direction() const;
</del><ins>+    ALWAYS_INLINE WTF::Unicode::Direction direction() const;
</ins><span class="cx"> 
</span><span class="cx">     RenderBlock* block;
</span><span class="cx">     RenderObject* obj;
</span></span></pre></div>
<a id="trunkWebCorerenderingstyleRenderStyleh"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/rendering/style/RenderStyle.h (68898 => 68899)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/rendering/style/RenderStyle.h        2010-10-01 17:46:27 UTC (rev 68898)
+++ trunk/WebCore/rendering/style/RenderStyle.h        2010-10-01 17:50:39 UTC (rev 68899)
</span><span class="lines">@@ -306,10 +306,10 @@
</span><span class="cx">     }
</span><span class="cx"> 
</span><span class="cx"> private:
</span><del>-    RenderStyle();
</del><ins>+    ALWAYS_INLINE RenderStyle();
</ins><span class="cx">     // used to create the default style.
</span><del>-    RenderStyle(bool);
-    RenderStyle(const RenderStyle&amp;);
</del><ins>+    ALWAYS_INLINE RenderStyle(bool);
+    ALWAYS_INLINE RenderStyle(const RenderStyle&amp;);
</ins><span class="cx"> 
</span><span class="cx"> public:
</span><span class="cx">     static PassRefPtr&lt;RenderStyle&gt; create();
</span></span></pre>
</div>
</div>

</body>
</html>