<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[56789] trunk/WebCore</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/56789">56789</a></dd>
<dt>Author</dt> <dd>pfeldman@chromium.org</dd>
<dt>Date</dt> <dd>2010-03-30 07:50:29 -0700 (Tue, 30 Mar 2010)</dd>
</dl>

<h3>Log Message</h3>
<pre>2010-03-30  Ilya Tikhonovsky  &lt;loislo@chromium.org&gt;

        Reviewed by Pavel Feldman.

        Web Inspector: Title for show/hide short records button was adjusted.
        Some unused code was removed.
        https://bugs.webkit.org/show_bug.cgi?id=36823

        * inspector/front-end/TimelinePanel.js:
        (WebInspector.TimelinePanel.prototype._createStatusbarButtons):
        (WebInspector.TimelinePanel.prototype._toggleFilterButtonClicked):
        (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkWebCoreChangeLog">trunk/WebCore/ChangeLog</a></li>
<li><a href="#trunkWebCoreEnglishlprojlocalizedStringsjs">trunk/WebCore/English.lproj/localizedStrings.js</a></li>
<li><a href="#trunkWebCoreinspectorfrontendTimelinePaneljs">trunk/WebCore/inspector/front-end/TimelinePanel.js</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/ChangeLog (56788 => 56789)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/ChangeLog        2010-03-30 14:49:07 UTC (rev 56788)
+++ trunk/WebCore/ChangeLog        2010-03-30 14:50:29 UTC (rev 56789)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2010-03-30  Ilya Tikhonovsky  &lt;loislo@chromium.org&gt;
+
+        Reviewed by Pavel Feldman.
+
+        Web Inspector: Title for show/hide short records button was adjusted.
+        Some unused code was removed.
+        https://bugs.webkit.org/show_bug.cgi?id=36823
+
+        * inspector/front-end/TimelinePanel.js:
+        (WebInspector.TimelinePanel.prototype._createStatusbarButtons):
+        (WebInspector.TimelinePanel.prototype._toggleFilterButtonClicked):
+        (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
+
</ins><span class="cx"> 2010-03-30  Adam Roben  &lt;aroben@apple.com&gt;
</span><span class="cx"> 
</span><span class="cx">         Enable extra Direct3D debugging information in Debug builds
</span></span></pre></div>
<a id="trunkWebCoreEnglishlprojlocalizedStringsjs"></a>
<div class="binary"><h4>Modified: trunk/WebCore/English.lproj/localizedStrings.js</h4>
<pre class="diff"><span>
<span class="cx">(Binary files differ)
</span></span></pre></div>
<a id="trunkWebCoreinspectorfrontendTimelinePaneljs"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/inspector/front-end/TimelinePanel.js (56788 => 56789)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/inspector/front-end/TimelinePanel.js        2010-03-30 14:49:07 UTC (rev 56788)
+++ trunk/WebCore/inspector/front-end/TimelinePanel.js        2010-03-30 14:50:29 UTC (rev 56789)
</span><span class="lines">@@ -159,7 +159,7 @@
</span><span class="cx">         this.clearButton = new WebInspector.StatusBarButton(WebInspector.UIString(&quot;Clear&quot;), &quot;timeline-clear-status-bar-item&quot;);
</span><span class="cx">         this.clearButton.addEventListener(&quot;click&quot;, this._clearPanel.bind(this), false);
</span><span class="cx"> 
</span><del>-        this.toggleFilterButton = new WebInspector.StatusBarButton(WebInspector.UIString(&quot;Show short records&quot;), &quot;timeline-filter-status-bar-item&quot;);
</del><ins>+        this.toggleFilterButton = new WebInspector.StatusBarButton(WebInspector.UIString(&quot;Hide short records&quot;), &quot;timeline-filter-status-bar-item&quot;);
</ins><span class="cx">         this.toggleFilterButton.addEventListener(&quot;click&quot;, this._toggleFilterButtonClicked.bind(this), false);
</span><span class="cx"> 
</span><span class="cx">         this.recordsCounter = document.createElement(&quot;span&quot;);
</span><span class="lines">@@ -185,6 +185,7 @@
</span><span class="cx">     {
</span><span class="cx">         this.toggleFilterButton.toggled = !this.toggleFilterButton.toggled;
</span><span class="cx">         this._calculator._showShortEvents = this.toggleFilterButton.toggled;
</span><ins>+        this.toggleFilterButton.element.title = this._calculator._showShortEvents ? WebInspector.UIString(&quot;Hide short records&quot;) : WebInspector.UIString(&quot;Show short records&quot;);
</ins><span class="cx">         this._scheduleRefresh(true);
</span><span class="cx">     },
</span><span class="cx"> 
</span><span class="lines">@@ -243,21 +244,16 @@
</span><span class="cx">         if (parentRecord === this._rootRecord)
</span><span class="cx">             formattedRecord.collapsed = true;
</span><span class="cx"> 
</span><del>-        var hasLongChildrenEvents = false;
</del><span class="cx">         for (var i = 0; record.children &amp;&amp; i &lt; record.children.length; ++i)
</span><del>-            hasLongChildrenEvents |= this._innerAddRecordToTimeline(record.children[i], formattedRecord);
-        formattedRecord._hasLongChildrenEvents = hasLongChildrenEvents;
</del><ins>+            this._innerAddRecordToTimeline(record.children[i], formattedRecord);
</ins><span class="cx"> 
</span><span class="cx">         if (connectedToOldRecord) {
</span><span class="cx">             var record = formattedRecord;
</span><span class="cx">             while (record.parent &amp;&amp; record.parent._lastChildEndTime &lt; record._lastChildEndTime) {
</span><span class="cx">                 record.parent._lastChildEndTime = record._lastChildEndTime;
</span><del>-                if (!record.parent._hasLongChildrenEvents)
-                    record.parent._hasLongChildrenEvents = record._isLongEvent();
</del><span class="cx">                 record = record.parent;
</span><span class="cx">             }
</span><span class="cx">         }
</span><del>-        return hasLongChildrenEvents || formattedRecord._isLongEvent();
</del><span class="cx">     },
</span><span class="cx"> 
</span><span class="cx">     setSidebarWidth: function(width)
</span></span></pre>
</div>
</div>

</body>
</html>