<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[56374] trunk/WebCore</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/56374">56374</a></dd>
<dt>Author</dt> <dd>eric@webkit.org</dd>
<dt>Date</dt> <dd>2010-03-22 19:11:03 -0700 (Mon, 22 Mar 2010)</dd>
</dl>

<h3>Log Message</h3>
<pre>2010-03-22  Andrey Kosyakov  &lt;caseq@chromium.org&gt;

        Reviewed by Pavel Feldman.

        Support creation of fake workers before document is loaded by deferring
        attaching of fake workers iframe until document is loaded and buffering all
        messages addressed to worker.
        https://bugs.webkit.org/show_bug.cgi?id=36445

        * inspector/front-end/InjectedFakeWorker.js:
        (InjectedFakeWorker.FakeWorker.prototype.postMessage):
        (InjectedFakeWorker.FakeWorker.prototype._buildWorker):
        (InjectedFakeWorker.FakeWorker.prototype._attachWorkerFrameToDocument):
        (InjectedFakeWorker.FakeWorker.prototype._onWorkerFrameLoaded):</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkWebCoreChangeLog">trunk/WebCore/ChangeLog</a></li>
<li><a href="#trunkWebCoreinspectorfrontendInjectedFakeWorkerjs">trunk/WebCore/inspector/front-end/InjectedFakeWorker.js</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/ChangeLog (56373 => 56374)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/ChangeLog        2010-03-23 01:31:29 UTC (rev 56373)
+++ trunk/WebCore/ChangeLog        2010-03-23 02:11:03 UTC (rev 56374)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2010-03-22  Andrey Kosyakov  &lt;caseq@chromium.org&gt;
+
+        Reviewed by Pavel Feldman.
+
+
+        Support creation of fake workers before document is loaded by deferring
+        attaching of fake workers iframe until document is loaded and buffering all
+        messages addressed to worker.
+        https://bugs.webkit.org/show_bug.cgi?id=36445
+
+        * inspector/front-end/InjectedFakeWorker.js:
+        (InjectedFakeWorker.FakeWorker.prototype.postMessage):
+        (InjectedFakeWorker.FakeWorker.prototype._buildWorker):
+        (InjectedFakeWorker.FakeWorker.prototype._attachWorkerFrameToDocument):
+        (InjectedFakeWorker.FakeWorker.prototype._onWorkerFrameLoaded):
+
</ins><span class="cx"> 2010-03-22  Darin Fisher  &lt;darin@chromium.org&gt;
</span><span class="cx"> 
</span><span class="cx">         Reviewed by Brady Eidson.
</span></span></pre></div>
<a id="trunkWebCoreinspectorfrontendInjectedFakeWorkerjs"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/inspector/front-end/InjectedFakeWorker.js (56373 => 56374)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/inspector/front-end/InjectedFakeWorker.js        2010-03-23 01:31:29 UTC (rev 56373)
+++ trunk/WebCore/inspector/front-end/InjectedFakeWorker.js        2010-03-23 02:11:03 UTC (rev 56374)
</span><span class="lines">@@ -59,6 +59,10 @@
</span><span class="cx">     {
</span><span class="cx">         if (this._frame != null)
</span><span class="cx">             this._dispatchMessage(this._frame, bind(this._onmessageWrapper, this), msg);
</span><ins>+        else if (this._pendingMessages)
+            this._pendingMessages.push(msg)
+        else
+            this._pendingMessages = [ msg ];
</ins><span class="cx">     },
</span><span class="cx"> 
</span><span class="cx">     terminate: function()
</span><span class="lines">@@ -116,18 +120,35 @@
</span><span class="cx">         var code = this._loadScript(url.url);
</span><span class="cx">         var iframeElement = document.createElement(&quot;iframe&quot;);
</span><span class="cx">         iframeElement.style.display = &quot;none&quot;;
</span><ins>+
+        this._document = document;
+        iframeElement.onload = bind(this._onWorkerFrameLoaded, this, iframeElement, url, code);
+
+        if (document.body)
+            this._attachWorkerFrameToDocument(iframeElement, url, code);
+        else
+            window.addEventListener(&quot;load&quot;, bind(this._attachWorkerFrameToDocument, this, iframeElement), false);
+    },
+
+    _attachWorkerFrameToDocument: function(iframeElement)
+    {
</ins><span class="cx">         document.body.appendChild(iframeElement);
</span><ins>+    },
</ins><span class="cx"> 
</span><del>-        var frame = window.frames[window.frames.length - 1];
-
-        this._document = document;
</del><ins>+    _onWorkerFrameLoaded: function(iframeElement, url, code)
+    {
+        var frame = iframeElement.contentWindow;
</ins><span class="cx">         this._frame = frame;
</span><del>-
</del><span class="cx">         this._setupWorkerContext(frame, url);
</span><span class="cx"> 
</span><span class="cx">         var frameContents = '(function(location, window) { ' + code + '})(__devtools.location, undefined);\n' + '//@ sourceURL=' + url.url;
</span><span class="cx"> 
</span><span class="cx">         frame.eval(frameContents);
</span><ins>+        if (this._pendingMessages) {
+            for (var msg in this._pendingMessages)
+                this.postMessage(this._pendingMessages[msg]);
+            delete this._pendingMessages;
+        }
</ins><span class="cx">     },
</span><span class="cx"> 
</span><span class="cx">     _setupWorkerContext: function(workerFrame, url)
</span></span></pre>
</div>
</div>

</body>
</html>