<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[56337] trunk</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/56337">56337</a></dd>
<dt>Author</dt> <dd>kdecker@apple.com</dd>
<dt>Date</dt> <dd>2010-03-22 09:29:47 -0700 (Mon, 22 Mar 2010)</dd>
</dl>

<h3>Log Message</h3>
<pre>        Reviewed by John Sullivan.

        https://bugs.webkit.org/show_bug.cgi?id=36328

        * page/mac/WebCoreViewFactory.h: Added -missingPluginText method
        * platform/LocalizedStrings.h: Added missingPluginText()
        * platform/gtk/LocalizedStringsGtk.cpp: Likewise.
        * platform/mac/LocalizedStringsMac.mm: Same here.
        * platform/qt/Localizations.cpp: Ditto.
        * English.lproj/Localizable.strings: Added &quot;Missing Plug-in&quot; string.
        * src/LocalizedStrings.cpp:
        (WebCore::missingPluginText): Added
        * WebCoreSupport/WebViewFactory.mm:
        (-[WebViewFactory missingPluginText]): Added.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkWebCoreChangeLog">trunk/WebCore/ChangeLog</a></li>
<li><a href="#trunkWebCorepagemacWebCoreViewFactoryh">trunk/WebCore/page/mac/WebCoreViewFactory.h</a></li>
<li><a href="#trunkWebCoreplatformLocalizedStringsh">trunk/WebCore/platform/LocalizedStrings.h</a></li>
<li><a href="#trunkWebCoreplatformgtkLocalizedStringsGtkcpp">trunk/WebCore/platform/gtk/LocalizedStringsGtk.cpp</a></li>
<li><a href="#trunkWebCoreplatformmacLocalizedStringsMacmm">trunk/WebCore/platform/mac/LocalizedStringsMac.mm</a></li>
<li><a href="#trunkWebCoreplatformqtLocalizationscpp">trunk/WebCore/platform/qt/Localizations.cpp</a></li>
<li><a href="#trunkWebKitChangeLog">trunk/WebKit/ChangeLog</a></li>
<li><a href="#trunkWebKitEnglishlprojLocalizablestrings">trunk/WebKit/English.lproj/Localizable.strings</a></li>
<li><a href="#trunkWebKitchromiumChangeLog">trunk/WebKit/chromium/ChangeLog</a></li>
<li><a href="#trunkWebKitchromiumsrcLocalizedStringscpp">trunk/WebKit/chromium/src/LocalizedStrings.cpp</a></li>
<li><a href="#trunkWebKitmacChangeLog">trunk/WebKit/mac/ChangeLog</a></li>
<li><a href="#trunkWebKitmacWebCoreSupportWebViewFactorymm">trunk/WebKit/mac/WebCoreSupport/WebViewFactory.mm</a></li>
<li><a href="#trunkWebKitwinChangeLog">trunk/WebKit/win/ChangeLog</a></li>
<li><a href="#trunkWebKitwinWebCoreLocalizedStringscpp">trunk/WebKit/win/WebCoreLocalizedStrings.cpp</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/ChangeLog (56336 => 56337)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/ChangeLog        2010-03-22 16:24:32 UTC (rev 56336)
+++ trunk/WebCore/ChangeLog        2010-03-22 16:29:47 UTC (rev 56337)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2010-03-22  Kevin Decker  &lt;kdecker@apple.com&gt;
+
+        Reviewed by John Sullivan.
+
+        https://bugs.webkit.org/show_bug.cgi?id=36328
+
+        * page/mac/WebCoreViewFactory.h: Added -missingPluginText method 
+        * platform/LocalizedStrings.h: Added missingPluginText()
+        * platform/gtk/LocalizedStringsGtk.cpp: Likewise.
+        * platform/mac/LocalizedStringsMac.mm: Same here.
+        * platform/qt/Localizations.cpp: Ditto.
+
</ins><span class="cx"> 2010-03-22  Yury Semikhatsky  &lt;yurys@chromium.org&gt;
</span><span class="cx"> 
</span><span class="cx">         Reviewed by Pavel Feldman.
</span></span></pre></div>
<a id="trunkWebCorepagemacWebCoreViewFactoryh"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/page/mac/WebCoreViewFactory.h (56336 => 56337)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/page/mac/WebCoreViewFactory.h        2010-03-22 16:24:32 UTC (rev 56336)
+++ trunk/WebCore/page/mac/WebCoreViewFactory.h        2010-03-22 16:29:47 UTC (rev 56337)
</span><span class="lines">@@ -142,6 +142,8 @@
</span><span class="cx"> - (NSString *)AXMenuListPopupActionVerb;
</span><span class="cx"> - (NSString *)AXMenuListActionVerb;
</span><span class="cx"> 
</span><ins>+- (NSString *)missingPluginText;
+
</ins><span class="cx"> - (NSString *)multipleFileUploadTextForNumberOfFiles:(unsigned)numberOfFiles;
</span><span class="cx"> // FTP Directory Related
</span><span class="cx"> - (NSString *)unknownFileSizeText;
</span></span></pre></div>
<a id="trunkWebCoreplatformLocalizedStringsh"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/platform/LocalizedStrings.h (56336 => 56337)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/platform/LocalizedStrings.h        2010-03-22 16:24:32 UTC (rev 56336)
+++ trunk/WebCore/platform/LocalizedStrings.h        2010-03-22 16:29:47 UTC (rev 56337)
</span><span class="lines">@@ -128,6 +128,7 @@
</span><span class="cx">     String AXMenuListPopupActionVerb();
</span><span class="cx">     String AXLinkActionVerb();
</span><span class="cx"> 
</span><ins>+    String missingPluginText();
</ins><span class="cx">     String multipleFileUploadText(unsigned numberOfFiles);
</span><span class="cx">     String unknownFileSizeText();
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkWebCoreplatformgtkLocalizedStringsGtkcpp"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/platform/gtk/LocalizedStringsGtk.cpp (56336 => 56337)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/platform/gtk/LocalizedStringsGtk.cpp        2010-03-22 16:24:32 UTC (rev 56336)
+++ trunk/WebCore/platform/gtk/LocalizedStringsGtk.cpp        2010-03-22 16:29:47 UTC (rev 56337)
</span><span class="lines">@@ -335,6 +335,11 @@
</span><span class="cx"> {
</span><span class="cx">     return String();
</span><span class="cx"> }
</span><ins>+    
+String missingPluginText()
+{
+    return String::fromUTF8(_(&quot;Missing Plug-in&quot;));
+}
</ins><span class="cx"> 
</span><span class="cx"> String multipleFileUploadText(unsigned numberOfFiles)
</span><span class="cx"> {
</span></span></pre></div>
<a id="trunkWebCoreplatformmacLocalizedStringsMacmm"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/platform/mac/LocalizedStringsMac.mm (56336 => 56337)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/platform/mac/LocalizedStringsMac.mm        2010-03-22 16:24:32 UTC (rev 56336)
+++ trunk/WebCore/platform/mac/LocalizedStringsMac.mm        2010-03-22 16:29:47 UTC (rev 56337)
</span><span class="lines">@@ -699,6 +699,13 @@
</span><span class="cx">     return String();
</span><span class="cx"> }
</span><span class="cx"> 
</span><ins>+String missingPluginText()
+{
+    BEGIN_BLOCK_OBJC_EXCEPTIONS;
+    return [[WebCoreViewFactory sharedFactory] missingPluginText];
+    END_BLOCK_OBJC_EXCEPTIONS;
+    return String();
+}
</ins><span class="cx"> 
</span><span class="cx"> String multipleFileUploadText(unsigned numberOfFiles)
</span><span class="cx"> {
</span></span></pre></div>
<a id="trunkWebCoreplatformqtLocalizationscpp"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/platform/qt/Localizations.cpp (56336 => 56337)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/platform/qt/Localizations.cpp        2010-03-22 16:24:32 UTC (rev 56336)
+++ trunk/WebCore/platform/qt/Localizations.cpp        2010-03-22 16:29:47 UTC (rev 56337)
</span><span class="lines">@@ -350,6 +350,11 @@
</span><span class="cx"> {
</span><span class="cx">     return String();
</span><span class="cx"> }
</span><ins>+    
+String missingPluginText()
+{
+    return QCoreApplication::translate(&quot;QWebPage&quot;, &quot;Missing Plug-in&quot;, &quot;Label text to be used when a plug-in is missing&quot;);
+}
</ins><span class="cx"> 
</span><span class="cx"> String multipleFileUploadText(unsigned)
</span><span class="cx"> {
</span></span></pre></div>
<a id="trunkWebKitChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/WebKit/ChangeLog (56336 => 56337)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebKit/ChangeLog        2010-03-22 16:24:32 UTC (rev 56336)
+++ trunk/WebKit/ChangeLog        2010-03-22 16:29:47 UTC (rev 56337)
</span><span class="lines">@@ -1,3 +1,11 @@
</span><ins>+2010-03-22  Kevin Decker  &lt;kdecker@apple.com&gt;
+
+        Reviewed by John Sullivan.
+
+        https://bugs.webkit.org/show_bug.cgi?id=36328
+
+        * English.lproj/Localizable.strings: Added &quot;Missing Plug-in&quot; string.
+
</ins><span class="cx"> 2010-03-18  Leandro Pereira  &lt;leandro@profusion.mobi&gt;
</span><span class="cx"> 
</span><span class="cx">         Reviewed by Kenneth Rohde Christiansen.
</span></span></pre></div>
<a id="trunkWebKitEnglishlprojLocalizablestrings"></a>
<div class="modfile"><h4>Modified: trunk/WebKit/English.lproj/Localizable.strings (56336 => 56337)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebKit/English.lproj/Localizable.strings        2010-03-22 16:24:32 UTC (rev 56336)
+++ trunk/WebKit/English.lproj/Localizable.strings        2010-03-22 16:29:47 UTC (rev 56337)
</span><span class="lines">@@ -190,6 +190,9 @@
</span><span class="cx"> /* Make Upper Case context menu item */
</span><span class="cx"> &quot;Make Upper Case&quot; = &quot;Make Upper Case&quot;;
</span><span class="cx"> 
</span><ins>+/* Label text to be used when a plugin is missing */
+&quot;Missing Plug-in&quot; = &quot;Missing Plug-in&quot;;
+
</ins><span class="cx"> /* No Guesses Found context menu item */
</span><span class="cx"> &quot;No Guesses Found&quot; = &quot;No Guesses Found&quot;;
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkWebKitchromiumChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/WebKit/chromium/ChangeLog (56336 => 56337)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebKit/chromium/ChangeLog        2010-03-22 16:24:32 UTC (rev 56336)
+++ trunk/WebKit/chromium/ChangeLog        2010-03-22 16:29:47 UTC (rev 56337)
</span><span class="lines">@@ -1,3 +1,12 @@
</span><ins>+2010-03-22  Kevin Decker  &lt;kdecker@apple.com&gt;
+
+        Reviewed by John Sullivan.
+
+        https://bugs.webkit.org/show_bug.cgi?id=36328
+
+        * src/LocalizedStrings.cpp:
+        (WebCore::missingPluginText): Added
+
</ins><span class="cx"> 2010-03-22  Yury Semikhatsky  &lt;yurys@chromium.org&gt;
</span><span class="cx"> 
</span><span class="cx">         Reviewed by Pavel Feldman.
</span></span></pre></div>
<a id="trunkWebKitchromiumsrcLocalizedStringscpp"></a>
<div class="modfile"><h4>Modified: trunk/WebKit/chromium/src/LocalizedStrings.cpp (56336 => 56337)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebKit/chromium/src/LocalizedStrings.cpp        2010-03-22 16:24:32 UTC (rev 56336)
+++ trunk/WebKit/chromium/src/LocalizedStrings.cpp        2010-03-22 16:29:47 UTC (rev 56337)
</span><span class="lines">@@ -174,6 +174,12 @@
</span><span class="cx"> {
</span><span class="cx">     return String();
</span><span class="cx"> }
</span><ins>+    
+String missingPluginText()
+{
+    notImplemented();
+    return String(&quot;Missing Plug-in&quot;);
+}
</ins><span class="cx"> 
</span><span class="cx"> String multipleFileUploadText(unsigned numberOfFiles)
</span><span class="cx"> {
</span></span></pre></div>
<a id="trunkWebKitmacChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/WebKit/mac/ChangeLog (56336 => 56337)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebKit/mac/ChangeLog        2010-03-22 16:24:32 UTC (rev 56336)
+++ trunk/WebKit/mac/ChangeLog        2010-03-22 16:29:47 UTC (rev 56337)
</span><span class="lines">@@ -1,3 +1,12 @@
</span><ins>+2010-03-22  Kevin Decker  &lt;kdecker@apple.com&gt;
+
+        Reviewed by John Sullivan.
+
+        https://bugs.webkit.org/show_bug.cgi?id=36328
+
+        * WebCoreSupport/WebViewFactory.mm:
+        (-[WebViewFactory missingPluginText]): Added.
+
</ins><span class="cx"> 2010-03-18  Alexey Proskuryakov  &lt;ap@apple.com&gt;
</span><span class="cx"> 
</span><span class="cx">         Reviewed by Darin Adler.
</span></span></pre></div>
<a id="trunkWebKitmacWebCoreSupportWebViewFactorymm"></a>
<div class="modfile"><h4>Modified: trunk/WebKit/mac/WebCoreSupport/WebViewFactory.mm (56336 => 56337)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebKit/mac/WebCoreSupport/WebViewFactory.mm        2010-03-22 16:24:32 UTC (rev 56336)
+++ trunk/WebKit/mac/WebCoreSupport/WebViewFactory.mm        2010-03-22 16:29:47 UTC (rev 56337)
</span><span class="lines">@@ -640,6 +640,11 @@
</span><span class="cx">     return nil;
</span><span class="cx"> }
</span><span class="cx"> 
</span><ins>+- (NSString *)missingPluginText
+{
+    return UI_STRING(&quot;Missing Plug-in&quot;, &quot;Label text to be used when a plugin is missing&quot;);
+}
+
</ins><span class="cx"> - (NSString *)multipleFileUploadTextForNumberOfFiles:(unsigned)numberOfFiles
</span><span class="cx"> {
</span><span class="cx">     return [NSString stringWithFormat:UI_STRING(&quot;%d files&quot;, &quot;Label to describe the number of files selected in a file upload control that allows multiple files&quot;), numberOfFiles];
</span></span></pre></div>
<a id="trunkWebKitwinChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/WebKit/win/ChangeLog (56336 => 56337)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebKit/win/ChangeLog        2010-03-22 16:24:32 UTC (rev 56336)
+++ trunk/WebKit/win/ChangeLog        2010-03-22 16:29:47 UTC (rev 56337)
</span><span class="lines">@@ -1,3 +1,12 @@
</span><ins>+2010-03-22  Kevin Decker  &lt;kdecker@apple.com&gt;
+
+        Reviewed by John Sullivan.
+
+        https://bugs.webkit.org/show_bug.cgi?id=36328
+        
+        * WebCoreLocalizedStrings.cpp:
+        (WebCore::missingPluginText): Added.
+
</ins><span class="cx"> 2010-03-17  Enrica Casucci  &lt;enrica@apple.com&gt;
</span><span class="cx"> 
</span><span class="cx">         Reviewed by Darin Adler.
</span></span></pre></div>
<a id="trunkWebKitwinWebCoreLocalizedStringscpp"></a>
<div class="modfile"><h4>Modified: trunk/WebKit/win/WebCoreLocalizedStrings.cpp (56336 => 56337)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebKit/win/WebCoreLocalizedStrings.cpp        2010-03-22 16:24:32 UTC (rev 56336)
+++ trunk/WebKit/win/WebCoreLocalizedStrings.cpp        2010-03-22 16:29:47 UTC (rev 56337)
</span><span class="lines">@@ -97,7 +97,7 @@
</span><span class="cx"> String WebCore::unknownFileSizeText() { return String(LPCTSTR_UI_STRING(&quot;Unknown&quot;, &quot;Unknown filesize FTP directory listing item&quot;)); }
</span><span class="cx"> String WebCore::uploadFileText() { return String(LPCTSTR_UI_STRING(&quot;Upload file&quot;, &quot;(Windows) Form submit file upload dialog title&quot;)); }
</span><span class="cx"> String WebCore::allFilesText() { return String(LPCTSTR_UI_STRING(&quot;All Files&quot;, &quot;(Windows) Form submit file upload all files pop-up&quot;)); }
</span><del>-
</del><ins>+String WebCore::missingPluginText() { return String(LPCTSTR_UI_STRING(&quot;Missing Plug-in&quot;, &quot;Missing Plug-in label&quot;)); }
</ins><span class="cx"> String WebCore::imageTitle(const String&amp; filename, const IntSize&amp; size) 
</span><span class="cx"> { 
</span><span class="cx">     static RetainPtr&lt;CFStringRef&gt; format(AdoptCF, UI_STRING(&quot;%@ %d\xC3\x97%d pixels&quot;, &quot;window title for a standalone image (uses multiplication symbol, not x)&quot;));
</span></span></pre>
</div>
</div>

</body>
</html>