<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[55579] trunk/WebKit/qt</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/55579">55579</a></dd>
<dt>Author</dt> <dd>tonikitoo@webkit.org</dd>
<dt>Date</dt> <dd>2010-03-05 07:49:37 -0800 (Fri, 05 Mar 2010)</dd>
</dl>

<h3>Log Message</h3>
<pre>[Qt] QWebSettings attribute for toggle Spatial Navigation on/off
https://bugs.webkit.org/show_bug.cgi?id=33714 (Qt API part)

Reviewed by Simon Hausmann.
Patch by Antonio Gomes &lt;tonikitoo@webkit.org&gt;

Added 'SpatialNavigationEnabled' attribute to QWebSettings.

* Api/qwebsettings.cpp:
(QWebSettingsPrivate::apply):
* Api/qwebsettings.h:</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkWebKitqtApiqwebsettingscpp">trunk/WebKit/qt/Api/qwebsettings.cpp</a></li>
<li><a href="#trunkWebKitqtApiqwebsettingsh">trunk/WebKit/qt/Api/qwebsettings.h</a></li>
<li><a href="#trunkWebKitqtChangeLog">trunk/WebKit/qt/ChangeLog</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkWebKitqtApiqwebsettingscpp"></a>
<div class="modfile"><h4>Modified: trunk/WebKit/qt/Api/qwebsettings.cpp (55578 => 55579)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebKit/qt/Api/qwebsettings.cpp        2010-03-05 15:48:12 UTC (rev 55578)
+++ trunk/WebKit/qt/Api/qwebsettings.cpp        2010-03-05 15:49:37 UTC (rev 55579)
</span><span class="lines">@@ -183,6 +183,10 @@
</span><span class="cx">                                       global-&gt;attributes.value(QWebSettings::PrivateBrowsingEnabled));
</span><span class="cx">         settings-&gt;setPrivateBrowsingEnabled(value);
</span><span class="cx"> 
</span><ins>+        value = attributes.value(QWebSettings::SpatialNavigationEnabled,
+                                      global-&gt;attributes.value(QWebSettings::SpatialNavigationEnabled));
+        settings-&gt;setSpatialNavigationEnabled(value);
+
</ins><span class="cx">         value = attributes.value(QWebSettings::JavascriptCanAccessClipboard,
</span><span class="cx">                                       global-&gt;attributes.value(QWebSettings::JavascriptCanAccessClipboard));
</span><span class="cx">         settings-&gt;setDOMPasteAllowed(value);
</span><span class="lines">@@ -364,6 +368,13 @@
</span><span class="cx">         Currently this enables the &quot;Inspect&quot; element in the context menu as
</span><span class="cx">         well as the use of QWebInspector which controls the WebKit WebInspector
</span><span class="cx">         for web site debugging.
</span><ins>+    \value SpatialNavigationEnabled Enables or disables the Spatial Navigation
+        feature, which consists in the ability to navigate between focusable
+        elements in a Web page, such as hyperlinks and form controls, by using
+        Left, Right, Up and Down arrow keys. For example, if an user presses the
+        Right key, heuristics determine whether there is an element he might be
+        trying to reach towards the right, and if there are multiple elements,
+        which element he probably wants.
</ins><span class="cx">     \value LinksIncludedInFocusChain Specifies whether hyperlinks should be
</span><span class="cx">         included in the keyboard focus chain.
</span><span class="cx">     \value ZoomTextOnly Specifies whether the zoom factor on a frame applies to
</span><span class="lines">@@ -404,6 +415,7 @@
</span><span class="cx">     d-&gt;attributes.insert(QWebSettings::AutoLoadImages, true);
</span><span class="cx">     d-&gt;attributes.insert(QWebSettings::DnsPrefetchEnabled, false);
</span><span class="cx">     d-&gt;attributes.insert(QWebSettings::JavascriptEnabled, true);
</span><ins>+    d-&gt;attributes.insert(QWebSettings::SpatialNavigationEnabled, false);
</ins><span class="cx">     d-&gt;attributes.insert(QWebSettings::LinksIncludedInFocusChain, true);
</span><span class="cx">     d-&gt;attributes.insert(QWebSettings::ZoomTextOnly, false);
</span><span class="cx">     d-&gt;attributes.insert(QWebSettings::PrintElementBackgrounds, true);
</span></span></pre></div>
<a id="trunkWebKitqtApiqwebsettingsh"></a>
<div class="modfile"><h4>Modified: trunk/WebKit/qt/Api/qwebsettings.h (55578 => 55579)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebKit/qt/Api/qwebsettings.h        2010-03-05 15:48:12 UTC (rev 55578)
+++ trunk/WebKit/qt/Api/qwebsettings.h        2010-03-05 15:49:37 UTC (rev 55579)
</span><span class="lines">@@ -71,7 +71,8 @@
</span><span class="cx">         DnsPrefetchEnabled,
</span><span class="cx">         XSSAuditorEnabled,
</span><span class="cx">         AcceleratedCompositingEnabled,
</span><del>-        WebGLEnabled
</del><ins>+        WebGLEnabled,
+        SpatialNavigationEnabled
</ins><span class="cx">     };
</span><span class="cx">     enum WebGraphic {
</span><span class="cx">         MissingImageGraphic,
</span></span></pre></div>
<a id="trunkWebKitqtChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/WebKit/qt/ChangeLog (55578 => 55579)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebKit/qt/ChangeLog        2010-03-05 15:48:12 UTC (rev 55578)
+++ trunk/WebKit/qt/ChangeLog        2010-03-05 15:49:37 UTC (rev 55579)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2010-03-02  Antonio Gomes  &lt;tonikitoo@webkit.org&gt;
+
+        Reviewed by Simon Hausmann.
+        Patch by Antonio Gomes &lt;tonikitoo@webkit.org&gt;
+
+        [Qt] QWebSettings attribute for toggle Spatial Navigation on/off
+        https://bugs.webkit.org/show_bug.cgi?id=33714 (Qt API part)
+
+        Added 'SpatialNavigationEnabled' attribute to QWebSettings.
+
+        * Api/qwebsettings.cpp:
+        (QWebSettingsPrivate::apply):
+        * Api/qwebsettings.h:
+
</ins><span class="cx"> 2010-03-04  Simon Hausmann  &lt;simon.hausmann@nokia.com&gt;
</span><span class="cx"> 
</span><span class="cx">         Reviewed by Kenneth Rohde Christiansen.
</span></span></pre>
</div>
</div>

</body>
</html>