<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[55419] trunk</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/55419">55419</a></dd>
<dt>Author</dt> <dd>eric@webkit.org</dd>
<dt>Date</dt> <dd>2010-03-02 11:33:54 -0800 (Tue, 02 Mar 2010)</dd>
</dl>

<h3>Log Message</h3>
<pre>2010-03-02  Kenneth Russell  &lt;kbr@google.com&gt;

        Reviewed by Darin Fisher.

        Add EnabledAtRuntime attribute to WebGLArray constructors
        https://bugs.webkit.org/show_bug.cgi?id=35558

        New functionality verified manually in Chromium; not possible to
        write layout test. Ran WebGL tests in WebKit as well.

        * bindings/generic/RuntimeEnabledFeatures.cpp:
        * bindings/generic/RuntimeEnabledFeatures.h:
        (WebCore::RuntimeEnabledFeatures::setWebGLEnabled):
        (WebCore::RuntimeEnabledFeatures::webGLRenderingContextEnabled):
        (WebCore::RuntimeEnabledFeatures::webGLArrayBufferEnabled):
        (WebCore::RuntimeEnabledFeatures::webGLByteArrayEnabled):
        (WebCore::RuntimeEnabledFeatures::webGLUnsignedByteArrayEnabled):
        (WebCore::RuntimeEnabledFeatures::webGLShortArrayEnabled):
        (WebCore::RuntimeEnabledFeatures::webGLUnsignedShortArrayEnabled):
        (WebCore::RuntimeEnabledFeatures::webGLIntArrayEnabled):
        (WebCore::RuntimeEnabledFeatures::webGLUnsignedIntArrayEnabled):
        (WebCore::RuntimeEnabledFeatures::webGLFloatArrayEnabled):
        * page/DOMWindow.idl:
2010-03-02  Kenneth Russell  &lt;kbr@google.com&gt;

        Reviewed by Darin Fisher.

        Add EnabledAtRuntime attribute to WebGLArray constructors
        https://bugs.webkit.org/show_bug.cgi?id=35558

        * public/WebRuntimeFeatures.h:
        * src/WebRuntimeFeatures.cpp:
        (WebKit::WebRuntimeFeatures::enableWebGL):
        (WebKit::WebRuntimeFeatures::isWebGLEnabled):</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkWebCoreChangeLog">trunk/WebCore/ChangeLog</a></li>
<li><a href="#trunkWebCorebindingsgenericRuntimeEnabledFeaturescpp">trunk/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp</a></li>
<li><a href="#trunkWebCorebindingsgenericRuntimeEnabledFeaturesh">trunk/WebCore/bindings/generic/RuntimeEnabledFeatures.h</a></li>
<li><a href="#trunkWebCorepageDOMWindowidl">trunk/WebCore/page/DOMWindow.idl</a></li>
<li><a href="#trunkWebKitchromiumChangeLog">trunk/WebKit/chromium/ChangeLog</a></li>
<li><a href="#trunkWebKitchromiumpublicWebRuntimeFeaturesh">trunk/WebKit/chromium/public/WebRuntimeFeatures.h</a></li>
<li><a href="#trunkWebKitchromiumsrcWebRuntimeFeaturescpp">trunk/WebKit/chromium/src/WebRuntimeFeatures.cpp</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/ChangeLog (55418 => 55419)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/ChangeLog        2010-03-02 19:12:42 UTC (rev 55418)
+++ trunk/WebCore/ChangeLog        2010-03-02 19:33:54 UTC (rev 55419)
</span><span class="lines">@@ -1,3 +1,27 @@
</span><ins>+2010-03-02  Kenneth Russell  &lt;kbr@google.com&gt;
+
+        Reviewed by Darin Fisher.
+
+        Add EnabledAtRuntime attribute to WebGLArray constructors
+        https://bugs.webkit.org/show_bug.cgi?id=35558
+
+        New functionality verified manually in Chromium; not possible to
+        write layout test. Ran WebGL tests in WebKit as well.
+
+        * bindings/generic/RuntimeEnabledFeatures.cpp:
+        * bindings/generic/RuntimeEnabledFeatures.h:
+        (WebCore::RuntimeEnabledFeatures::setWebGLEnabled):
+        (WebCore::RuntimeEnabledFeatures::webGLRenderingContextEnabled):
+        (WebCore::RuntimeEnabledFeatures::webGLArrayBufferEnabled):
+        (WebCore::RuntimeEnabledFeatures::webGLByteArrayEnabled):
+        (WebCore::RuntimeEnabledFeatures::webGLUnsignedByteArrayEnabled):
+        (WebCore::RuntimeEnabledFeatures::webGLShortArrayEnabled):
+        (WebCore::RuntimeEnabledFeatures::webGLUnsignedShortArrayEnabled):
+        (WebCore::RuntimeEnabledFeatures::webGLIntArrayEnabled):
+        (WebCore::RuntimeEnabledFeatures::webGLUnsignedIntArrayEnabled):
+        (WebCore::RuntimeEnabledFeatures::webGLFloatArrayEnabled):
+        * page/DOMWindow.idl:
+
</ins><span class="cx"> 2010-03-02  Nate Chapin  &lt;japhet@chromium.org&gt;
</span><span class="cx"> 
</span><span class="cx">         Reviewed by Dimitri Glazkov.
</span></span></pre></div>
<a id="trunkWebCorebindingsgenericRuntimeEnabledFeaturescpp"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp (55418 => 55419)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp        2010-03-02 19:12:42 UTC (rev 55418)
+++ trunk/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp        2010-03-02 19:33:54 UTC (rev 55419)
</span><span class="lines">@@ -44,6 +44,7 @@
</span><span class="cx"> bool RuntimeEnabledFeatures::isApplicationCacheEnabled = true;
</span><span class="cx"> bool RuntimeEnabledFeatures::isGeolocationEnabled = true;
</span><span class="cx"> bool RuntimeEnabledFeatures::isIndexedDBEnabled = false;
</span><ins>+bool RuntimeEnabledFeatures::isWebGLEnabled = false;
</ins><span class="cx"> 
</span><span class="cx"> #if ENABLE(VIDEO)
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkWebCorebindingsgenericRuntimeEnabledFeaturesh"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/bindings/generic/RuntimeEnabledFeatures.h (55418 => 55419)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/bindings/generic/RuntimeEnabledFeatures.h        2010-03-02 19:12:42 UTC (rev 55418)
+++ trunk/WebCore/bindings/generic/RuntimeEnabledFeatures.h        2010-03-02 19:33:54 UTC (rev 55419)
</span><span class="lines">@@ -77,6 +77,19 @@
</span><span class="cx">     static bool openDatabaseEnabled();
</span><span class="cx"> #endif
</span><span class="cx"> 
</span><ins>+#if ENABLE(3D_CANVAS)
+    static void setWebGLEnabled(bool isEnabled) { isWebGLEnabled = isEnabled; }
+    static bool webGLRenderingContextEnabled() { return isWebGLEnabled; }
+    static bool webGLArrayBufferEnabled() { return isWebGLEnabled; }
+    static bool webGLByteArrayEnabled() { return isWebGLEnabled; }
+    static bool webGLUnsignedByteArrayEnabled() { return isWebGLEnabled; }
+    static bool webGLShortArrayEnabled() { return isWebGLEnabled; }
+    static bool webGLUnsignedShortArrayEnabled() { return isWebGLEnabled; }
+    static bool webGLIntArrayEnabled() { return isWebGLEnabled; }
+    static bool webGLUnsignedIntArrayEnabled() { return isWebGLEnabled; }
+    static bool webGLFloatArrayEnabled() { return isWebGLEnabled; }
+#endif
+
</ins><span class="cx"> private:
</span><span class="cx">     // Never instantiate.
</span><span class="cx">     RuntimeEnabledFeatures() { }
</span><span class="lines">@@ -87,6 +100,7 @@
</span><span class="cx">     static bool isApplicationCacheEnabled;
</span><span class="cx">     static bool isGeolocationEnabled;
</span><span class="cx">     static bool isIndexedDBEnabled;
</span><ins>+    static bool isWebGLEnabled;
</ins><span class="cx"> };
</span><span class="cx"> 
</span><span class="cx"> } // namespace WebCore
</span></span></pre></div>
<a id="trunkWebCorepageDOMWindowidl"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/page/DOMWindow.idl (55418 => 55419)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/page/DOMWindow.idl        2010-03-02 19:12:42 UTC (rev 55418)
+++ trunk/WebCore/page/DOMWindow.idl        2010-03-02 19:33:54 UTC (rev 55419)
</span><span class="lines">@@ -442,17 +442,17 @@
</span><span class="cx"> 
</span><span class="cx">         attribute CanvasRenderingContext2DConstructor CanvasRenderingContext2D;
</span><span class="cx">         attribute ImageDataConstructor ImageData;
</span><del>-        attribute [Conditional=3D_CANVAS] WebGLRenderingContextConstructor WebGLRenderingContext;
</del><ins>+        attribute [Conditional=3D_CANVAS,EnabledAtRuntime] WebGLRenderingContextConstructor WebGLRenderingContext;
</ins><span class="cx">         attribute TextMetricsConstructor TextMetrics;
</span><span class="cx"> 
</span><del>-        attribute [JSCCustomGetter,Conditional=3D_CANVAS] WebGLArrayBufferConstructor WebGLArrayBuffer; // Usable with new operator
-        attribute [JSCCustomGetter,Conditional=3D_CANVAS] WebGLByteArrayConstructor WebGLByteArray; // Usable with new operator
-        attribute [JSCCustomGetter,Conditional=3D_CANVAS] WebGLUnsignedByteArrayConstructor WebGLUnsignedByteArray; // Usable with new operator
-        attribute [JSCCustomGetter,Conditional=3D_CANVAS] WebGLShortArrayConstructor WebGLShortArray; // Usable with new operator
-        attribute [JSCCustomGetter,Conditional=3D_CANVAS] WebGLUnsignedShortArrayConstructor WebGLUnsignedShortArray; // Usable with new operator
-        attribute [JSCCustomGetter,Conditional=3D_CANVAS] WebGLIntArrayConstructor WebGLIntArray; // Usable with new operator
-        attribute [JSCCustomGetter,Conditional=3D_CANVAS] WebGLUnsignedIntArrayConstructor WebGLUnsignedIntArray; // Usable with new operator
-        attribute [JSCCustomGetter,Conditional=3D_CANVAS] WebGLFloatArrayConstructor WebGLFloatArray; // Usable with new operator
</del><ins>+        attribute [JSCCustomGetter,Conditional=3D_CANVAS,EnabledAtRuntime] WebGLArrayBufferConstructor WebGLArrayBuffer; // Usable with new operator
+        attribute [JSCCustomGetter,Conditional=3D_CANVAS,EnabledAtRuntime] WebGLByteArrayConstructor WebGLByteArray; // Usable with new operator
+        attribute [JSCCustomGetter,Conditional=3D_CANVAS,EnabledAtRuntime] WebGLUnsignedByteArrayConstructor WebGLUnsignedByteArray; // Usable with new operator
+        attribute [JSCCustomGetter,Conditional=3D_CANVAS,EnabledAtRuntime] WebGLShortArrayConstructor WebGLShortArray; // Usable with new operator
+        attribute [JSCCustomGetter,Conditional=3D_CANVAS,EnabledAtRuntime] WebGLUnsignedShortArrayConstructor WebGLUnsignedShortArray; // Usable with new operator
+        attribute [JSCCustomGetter,Conditional=3D_CANVAS,EnabledAtRuntime] WebGLIntArrayConstructor WebGLIntArray; // Usable with new operator
+        attribute [JSCCustomGetter,Conditional=3D_CANVAS,EnabledAtRuntime] WebGLUnsignedIntArrayConstructor WebGLUnsignedIntArray; // Usable with new operator
+        attribute [JSCCustomGetter,Conditional=3D_CANVAS,EnabledAtRuntime] WebGLFloatArrayConstructor WebGLFloatArray; // Usable with new operator
</ins><span class="cx"> 
</span><span class="cx">         attribute EventConstructor Event;
</span><span class="cx">         attribute BeforeLoadEventConstructor BeforeLoadEvent;
</span></span></pre></div>
<a id="trunkWebKitchromiumChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/WebKit/chromium/ChangeLog (55418 => 55419)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebKit/chromium/ChangeLog        2010-03-02 19:12:42 UTC (rev 55418)
+++ trunk/WebKit/chromium/ChangeLog        2010-03-02 19:33:54 UTC (rev 55419)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2010-03-02  Kenneth Russell  &lt;kbr@google.com&gt;
+
+        Reviewed by Darin Fisher.
+
+        Add EnabledAtRuntime attribute to WebGLArray constructors
+        https://bugs.webkit.org/show_bug.cgi?id=35558
+
+        * public/WebRuntimeFeatures.h:
+        * src/WebRuntimeFeatures.cpp:
+        (WebKit::WebRuntimeFeatures::enableWebGL):
+        (WebKit::WebRuntimeFeatures::isWebGLEnabled):
+
</ins><span class="cx"> 2010-03-02  James Hawkins  &lt;jhawkins@chromium.org&gt;
</span><span class="cx"> 
</span><span class="cx">         Reviewed by Darin Fisher.
</span></span></pre></div>
<a id="trunkWebKitchromiumpublicWebRuntimeFeaturesh"></a>
<div class="modfile"><h4>Modified: trunk/WebKit/chromium/public/WebRuntimeFeatures.h (55418 => 55419)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebKit/chromium/public/WebRuntimeFeatures.h        2010-03-02 19:12:42 UTC (rev 55418)
+++ trunk/WebKit/chromium/public/WebRuntimeFeatures.h        2010-03-02 19:33:54 UTC (rev 55419)
</span><span class="lines">@@ -68,6 +68,9 @@
</span><span class="cx">     WEBKIT_API static void enableIndexedDatabase(bool);
</span><span class="cx">     WEBKIT_API static bool isIndexedDatabaseEnabled();
</span><span class="cx"> 
</span><ins>+    WEBKIT_API static void enableWebGL(bool);
+    WEBKIT_API static bool isWebGLEnabled();
+
</ins><span class="cx"> private:
</span><span class="cx">     WebRuntimeFeatures();
</span><span class="cx"> };
</span></span></pre></div>
<a id="trunkWebKitchromiumsrcWebRuntimeFeaturescpp"></a>
<div class="modfile"><h4>Modified: trunk/WebKit/chromium/src/WebRuntimeFeatures.cpp (55418 => 55419)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebKit/chromium/src/WebRuntimeFeatures.cpp        2010-03-02 19:12:42 UTC (rev 55418)
+++ trunk/WebKit/chromium/src/WebRuntimeFeatures.cpp        2010-03-02 19:33:54 UTC (rev 55419)
</span><span class="lines">@@ -184,4 +184,20 @@
</span><span class="cx"> #endif
</span><span class="cx"> }
</span><span class="cx"> 
</span><ins>+void WebRuntimeFeatures::enableWebGL(bool enable)
+{
+#if ENABLE(3D_CANVAS)
+    RuntimeEnabledFeatures::setWebGLEnabled(enable);
+#endif
+}
+
+bool WebRuntimeFeatures::isWebGLEnabled()
+{
+#if ENABLE(3D_CANVAS)
+    return RuntimeEnabledFeatures::webGLRenderingContextEnabled();
+#else
+    return false;
+#endif
+}
+
</ins><span class="cx"> } // namespace WebKit
</span></span></pre>
</div>
</div>

</body>
</html>