<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[55385] trunk/WebKit/win</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/55385">55385</a></dd>
<dt>Author</dt> <dd>jhoneycutt@apple.com</dd>
<dt>Date</dt> <dd>2010-03-01 16:18:10 -0800 (Mon, 01 Mar 2010)</dd>
</dl>

<h3>Log Message</h3>
<pre>&lt;rdar://problem/7703368&gt; IWebUIDelegatePrivate::embeddedViewWithArguments
is passed wrong arguments

Reviewed by Adam Roben.

* Interfaces/IWebUIDelegatePrivate.idl:
Update copyright strings. Added a new key for the plug-in source URL.

* Interfaces/WebKit.idl:
Update copyright strings.

* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::createPlugin):
Pass the URL of the plug-in as the source URL. Pass the document's
base URI for the base URL.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkWebKitwinChangeLog">trunk/WebKit/win/ChangeLog</a></li>
<li><a href="#trunkWebKitwinInterfacesIWebUIDelegatePrivateidl">trunk/WebKit/win/Interfaces/IWebUIDelegatePrivate.idl</a></li>
<li><a href="#trunkWebKitwinInterfacesWebKitidl">trunk/WebKit/win/Interfaces/WebKit.idl</a></li>
<li><a href="#trunkWebKitwinWebCoreSupportWebFrameLoaderClientcpp">trunk/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkWebKitwinChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/WebKit/win/ChangeLog (55384 => 55385)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebKit/win/ChangeLog        2010-03-02 00:05:35 UTC (rev 55384)
+++ trunk/WebKit/win/ChangeLog        2010-03-02 00:18:10 UTC (rev 55385)
</span><span class="lines">@@ -1,3 +1,21 @@
</span><ins>+2010-02-26  Jon Honeycutt  &lt;jhoneycutt@apple.com&gt;
+
+        &lt;rdar://problem/7703368&gt; IWebUIDelegatePrivate::embeddedViewWithArguments
+        is passed wrong arguments
+
+        Reviewed by Adam Roben.
+
+        * Interfaces/IWebUIDelegatePrivate.idl:
+        Update copyright strings. Added a new key for the plug-in source URL.
+
+        * Interfaces/WebKit.idl:
+        Update copyright strings.
+
+        * WebCoreSupport/WebFrameLoaderClient.cpp:
+        (WebFrameLoaderClient::createPlugin):
+        Pass the URL of the plug-in as the source URL. Pass the document's
+        base URI for the base URL.
+
</ins><span class="cx"> 2010-02-23  Brady Eidson  &lt;beidson@apple.com&gt;
</span><span class="cx"> 
</span><span class="cx">         Reviewed by Tim Hatcher and Pavel Feldman.
</span></span></pre></div>
<a id="trunkWebKitwinInterfacesIWebUIDelegatePrivateidl"></a>
<div class="modfile"><h4>Modified: trunk/WebKit/win/Interfaces/IWebUIDelegatePrivate.idl (55384 => 55385)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebKit/win/Interfaces/IWebUIDelegatePrivate.idl        2010-03-02 00:05:35 UTC (rev 55384)
+++ trunk/WebKit/win/Interfaces/IWebUIDelegatePrivate.idl        2010-03-02 00:18:10 UTC (rev 55385)
</span><span class="lines">@@ -1,5 +1,5 @@
</span><span class="cx"> /*
</span><del>- * Copyright (C) 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
</del><ins>+ * Copyright (C) 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
</ins><span class="cx">  *
</span><span class="cx">  * Redistribution and use in source and binary forms, with or without
</span><span class="cx">  * modification, are permitted provided that the following conditions
</span><span class="lines">@@ -33,6 +33,7 @@
</span><span class="cx"> 
</span><span class="cx"> cpp_quote(&quot;#define WebEmbeddedViewAttributesKey TEXT(\&quot;WebEmbeddedViewAttributesKey\&quot;)&quot;)
</span><span class="cx"> cpp_quote(&quot;#define WebEmbeddedViewBaseURLKey TEXT(\&quot;WebEmbeddedViewBaseURLKey\&quot;)&quot;)
</span><ins>+cpp_quote(&quot;#define WebEmbeddedViewSourceURLKey TEXT(\&quot;WebEmbeddedViewSourceURLKey\&quot;)&quot;)
</ins><span class="cx"> cpp_quote(&quot;#define WebEmbeddedViewContainingElementKey TEXT(\&quot;WebEmbeddedViewContainingElementKey\&quot;)&quot;)
</span><span class="cx"> cpp_quote(&quot;#define WebEmbeddedViewMIMETypeKey TEXT(\&quot;WebEmbeddedViewMIMETypeKey\&quot;)&quot;)
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkWebKitwinInterfacesWebKitidl"></a>
<div class="modfile"><h4>Modified: trunk/WebKit/win/Interfaces/WebKit.idl (55384 => 55385)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebKit/win/Interfaces/WebKit.idl        2010-03-02 00:05:35 UTC (rev 55384)
+++ trunk/WebKit/win/Interfaces/WebKit.idl        2010-03-02 00:18:10 UTC (rev 55385)
</span><span class="lines">@@ -1,5 +1,5 @@
</span><span class="cx"> /*
</span><del>- * Copyright (C) 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
</del><ins>+ * Copyright (C) 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
</ins><span class="cx">  *
</span><span class="cx">  * Redistribution and use in source and binary forms, with or without
</span><span class="cx">  * modification, are permitted provided that the following conditions
</span><span class="lines">@@ -24,7 +24,7 @@
</span><span class="cx">  */
</span><span class="cx"> 
</span><span class="cx"> cpp_quote(&quot;/*&quot;)
</span><del>-cpp_quote(&quot; * Copyright (C) 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.&quot;)
</del><ins>+cpp_quote(&quot; * Copyright (C) 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.&quot;)
</ins><span class="cx"> cpp_quote(&quot; *&quot;)
</span><span class="cx"> cpp_quote(&quot; * Redistribution and use in source and binary forms, with or without&quot;)
</span><span class="cx"> cpp_quote(&quot; * modification, are permitted provided that the following conditions&quot;)
</span></span></pre></div>
<a id="trunkWebKitwinWebCoreSupportWebFrameLoaderClientcpp"></a>
<div class="modfile"><h4>Modified: trunk/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp (55384 => 55385)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp        2010-03-02 00:05:35 UTC (rev 55384)
+++ trunk/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp        2010-03-02 00:18:10 UTC (rev 55385)
</span><span class="lines">@@ -841,7 +841,8 @@
</span><span class="cx">             HashMap&lt;String, COMVariant&gt; arguments;
</span><span class="cx"> 
</span><span class="cx">             arguments.set(WebEmbeddedViewAttributesKey, viewArgumentsBag);
</span><del>-            arguments.set(WebEmbeddedViewBaseURLKey, url.string());
</del><ins>+            arguments.set(WebEmbeddedViewSourceURLKey, url.string());
+            arguments.set(WebEmbeddedViewBaseURLKey, element-&gt;document()-&gt;baseURI().string());
</ins><span class="cx">             arguments.set(WebEmbeddedViewContainingElementKey, containingElement);
</span><span class="cx">             arguments.set(WebEmbeddedViewMIMETypeKey, mimeType);
</span><span class="cx"> 
</span></span></pre>
</div>
</div>

</body>
</html>