<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[52683] trunk</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/52683">52683</a></dd>
<dt>Author</dt> <dd>mitz@apple.com</dd>
<dt>Date</dt> <dd>2009-12-31 10:41:23 -0800 (Thu, 31 Dec 2009)</dd>
</dl>

<h3>Log Message</h3>
<pre>&lt;rdar://problem/7503279&gt; REGRESSION (<a href="http://trac.webkit.org/projects/webkit/changeset/47440">r47440</a>): Incomplete repaint at macworldexpo.com
https://bugs.webkit.org/show_bug.cgi?id=33067

Reviewed by Simon Fraser.

WebCore: 

Test: fast/repaint/table-cell-overflow.html

* rendering/RenderTableCell.h:
(WebCore::RenderTableCell::hasVisibleOverflow): Added.
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::layoutRows): Set m_hasOverflowingCell if
any cell has visible overflow, like it was before <a href="http://trac.webkit.org/projects/webkit/changeset/47440">r47440</a>.

LayoutTests: 

* fast/repaint/table-cell-overflow-expected.checksum: Added.
* fast/repaint/table-cell-overflow-expected.png: Added.
* fast/repaint/table-cell-overflow-expected.txt: Added.
* fast/repaint/table-cell-overflow.html: Added.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkWebCoreChangeLog">trunk/WebCore/ChangeLog</a></li>
<li><a href="#trunkWebCorerenderingRenderTableCellh">trunk/WebCore/rendering/RenderTableCell.h</a></li>
<li><a href="#trunkWebCorerenderingRenderTableSectioncpp">trunk/WebCore/rendering/RenderTableSection.cpp</a></li>
</ul>

<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastrepainttablecelloverflowexpectedchecksum">trunk/LayoutTests/fast/repaint/table-cell-overflow-expected.checksum</a></li>
<li><a href="#trunkLayoutTestsfastrepainttablecelloverflowexpectedpng">trunk/LayoutTests/fast/repaint/table-cell-overflow-expected.png</a></li>
<li><a href="#trunkLayoutTestsfastrepainttablecelloverflowexpectedtxt">trunk/LayoutTests/fast/repaint/table-cell-overflow-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastrepainttablecelloverflowhtml">trunk/LayoutTests/fast/repaint/table-cell-overflow.html</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (52682 => 52683)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog        2009-12-31 18:07:03 UTC (rev 52682)
+++ trunk/LayoutTests/ChangeLog        2009-12-31 18:41:23 UTC (rev 52683)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2009-12-31  Dan Bernstein  &lt;mitz@apple.com&gt;
+
+        Reviewed by Simon Fraser.
+
+        &lt;rdar://problem/7503279&gt; REGRESSION (r47440): Incomplete repaint at macworldexpo.com
+        https://bugs.webkit.org/show_bug.cgi?id=33067
+
+        * fast/repaint/table-cell-overflow-expected.checksum: Added.
+        * fast/repaint/table-cell-overflow-expected.png: Added.
+        * fast/repaint/table-cell-overflow-expected.txt: Added.
+        * fast/repaint/table-cell-overflow.html: Added.
+
</ins><span class="cx"> 2009-12-30  Dirk Schulze  &lt;krit@webkit.org&gt;
</span><span class="cx"> 
</span><span class="cx">         Reviewed by Anders Carlsson.
</span></span></pre></div>
<a id="trunkLayoutTestsfastrepainttablecelloverflowexpectedchecksum"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/repaint/table-cell-overflow-expected.checksum (0 => 52683)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/repaint/table-cell-overflow-expected.checksum                                (rev 0)
+++ trunk/LayoutTests/fast/repaint/table-cell-overflow-expected.checksum        2009-12-31 18:41:23 UTC (rev 52683)
</span><span class="lines">@@ -0,0 +1 @@
</span><ins>+cea2348b80457eaaa9b19979c8134a9d
</ins><span class="cx">\ No newline at end of file
</span></span></pre></div>
<a id="trunkLayoutTestsfastrepainttablecelloverflowexpectedpng"></a>
<div class="binary"><h4>Added: trunk/LayoutTests/fast/repaint/table-cell-overflow-expected.png</h4>
<pre class="diff"><span>
<span class="cx">(Binary files differ)
</span></span></pre></div>
<span class="cx">Property changes on: trunk/LayoutTests/fast/repaint/table-cell-overflow-expected.png
</span><span class="cx">___________________________________________________________________
</span><a id="svnmimetype"></a>
<div class="addfile"><h4>Added: svn:mime-type</h4></div>
<a id="trunkLayoutTestsfastrepainttablecelloverflowexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/repaint/table-cell-overflow-expected.txt (0 => 52683)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/repaint/table-cell-overflow-expected.txt                                (rev 0)
+++ trunk/LayoutTests/fast/repaint/table-cell-overflow-expected.txt        2009-12-31 18:41:23 UTC (rev 52683)
</span><span class="lines">@@ -0,0 +1,13 @@
</span><ins>+layer at (0,0) size 800x600
+  RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+  RenderBlock {HTML} at (0,0) size 800x600
+    RenderBody {BODY} at (8,8) size 784x584
+      RenderTable {TABLE} at (0,0) size 204x102
+        RenderTableSection {TBODY} at (0,0) size 204x102
+          RenderTableRow {TR} at (0,0) size 204x102
+            RenderTableCell {TD} at (0,0) size 102x102 [r=0 c=0 rs=1 cs=1]
+              RenderBlock {DIV} at (1,1) size 100x100
+                RenderBlock {DIV} at (50,0) size 100x100 [bgcolor=#0000FF]
+            RenderTableCell {TD} at (102,0) size 102x102 [r=0 c=1 rs=1 cs=1]
+              RenderBlock {DIV} at (1,1) size 100x100
</ins></span></pre></div>
<a id="trunkLayoutTestsfastrepainttablecelloverflowhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/repaint/table-cell-overflow.html (0 => 52683)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/repaint/table-cell-overflow.html                                (rev 0)
+++ trunk/LayoutTests/fast/repaint/table-cell-overflow.html        2009-12-31 18:41:23 UTC (rev 52683)
</span><span class="lines">@@ -0,0 +1,23 @@
</span><ins>+&lt;head&gt;
+&lt;script src=&quot;resources/repaint.js&quot;&gt;&lt;/script&gt;
+&lt;script&gt;
+    function repaintTest()
+    {
+        document.getElementById(&quot;target&quot;).style.backgroundColor = &quot;transparent&quot;;
+    }
+&lt;/script&gt;
+&lt;/head&gt;
+&lt;body onload=&quot;runRepaintTest();&quot;&gt;
+&lt;table cellpadding=1 cellspacing=0&gt;
+    &lt;tr&gt;
+        &lt;td&gt;
+            &lt;div style=&quot;width: 100px;&quot;&gt;
+                &lt;div style=&quot;width: 100px; height: 100px; background-color: blue; margin-left: 50px;&quot;&gt;&lt;/div&gt;
+            &lt;/div&gt;
+        &lt;/td&gt;
+        &lt;td&gt;
+            &lt;div style=&quot;width: 100px; height: 100px; background-color: red;&quot; id=&quot;target&quot;&gt;&lt;/div&gt;
+        &lt;/td&gt;
+    &lt;/tr&gt;
+&lt;/table&gt;
+&lt;/body&gt;
</ins></span></pre></div>
<a id="trunkWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/ChangeLog (52682 => 52683)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/ChangeLog        2009-12-31 18:07:03 UTC (rev 52682)
+++ trunk/WebCore/ChangeLog        2009-12-31 18:41:23 UTC (rev 52683)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2009-12-31  Dan Bernstein  &lt;mitz@apple.com&gt;
+
+        Reviewed by Simon Fraser.
+
+        &lt;rdar://problem/7503279&gt; REGRESSION (r47440): Incomplete repaint at macworldexpo.com
+        https://bugs.webkit.org/show_bug.cgi?id=33067
+
+        Test: fast/repaint/table-cell-overflow.html
+
+        * rendering/RenderTableCell.h:
+        (WebCore::RenderTableCell::hasVisibleOverflow): Added.
+        * rendering/RenderTableSection.cpp:
+        (WebCore::RenderTableSection::layoutRows): Set m_hasOverflowingCell if
+        any cell has visible overflow, like it was before r47440.
+
</ins><span class="cx"> 2009-12-31  Laszlo Gombos  &lt;laszlo.1.gombos@nokia.com&gt;
</span><span class="cx"> 
</span><span class="cx">         Reviewed by Kenneth Rohde Christiansen.
</span></span></pre></div>
<a id="trunkWebCorerenderingRenderTableCellh"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/rendering/RenderTableCell.h (52682 => 52683)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/rendering/RenderTableCell.h        2009-12-31 18:07:03 UTC (rev 52682)
+++ trunk/WebCore/rendering/RenderTableCell.h        2009-12-31 18:41:23 UTC (rev 52683)
</span><span class="lines">@@ -99,6 +99,8 @@
</span><span class="cx"> 
</span><span class="cx">     virtual void setOverrideSize(int);
</span><span class="cx"> 
</span><ins>+    bool hasVisibleOverflow() const { return m_overflow; }
+
</ins><span class="cx"> protected:
</span><span class="cx">     virtual void styleWillChange(StyleDifference, const RenderStyle* newStyle);
</span><span class="cx">     virtual void styleDidChange(StyleDifference, const RenderStyle* oldStyle);
</span></span></pre></div>
<a id="trunkWebCorerenderingRenderTableSectioncpp"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/rendering/RenderTableSection.cpp (52682 => 52683)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/rendering/RenderTableSection.cpp        2009-12-31 18:07:03 UTC (rev 52682)
+++ trunk/WebCore/rendering/RenderTableSection.cpp        2009-12-31 18:41:23 UTC (rev 52683)
</span><span class="lines">@@ -646,12 +646,11 @@
</span><span class="cx">             if (r &lt; totalRows - 1 &amp;&amp; cell == cellAt(r + 1, c).cell)
</span><span class="cx">                 continue;
</span><span class="cx">             addOverflowFromChild(cell);
</span><ins>+            m_hasOverflowingCell |= cell-&gt;hasVisibleOverflow();
</ins><span class="cx">         }
</span><span class="cx">     }
</span><del>-    m_hasOverflowingCell = m_overflow;
-    
-    statePusher.pop();
</del><span class="cx"> 
</span><ins>+    statePusher.pop();
</ins><span class="cx">     return height();
</span><span class="cx"> }
</span><span class="cx"> 
</span></span></pre>
</div>
</div>

</body>
</html>