<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[52295] trunk/WebKitTools</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/52295">52295</a></dd>
<dt>Author</dt> <dd>eric@webkit.org</dd>
<dt>Date</dt> <dd>2009-12-17 17:28:27 -0800 (Thu, 17 Dec 2009)</dd>
</dl>

<h3>Log Message</h3>
<pre>2009-12-17  Eric Seidel  &lt;eric@webkit.org&gt;

        Reviewed by Adam Barth.

        Command.show_in_main_help should default to False
        https://bugs.webkit.org/show_bug.cgi?id=32686

        * Scripts/modules/commands/download.py:
        * Scripts/modules/commands/queries.py:
        * Scripts/modules/commands/queues.py:
        * Scripts/modules/commands/upload.py:
        * Scripts/modules/multicommandtool.py:</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkWebKitToolsChangeLog">trunk/WebKitTools/ChangeLog</a></li>
<li><a href="#trunkWebKitToolsScriptsmodulescommandsdownloadpy">trunk/WebKitTools/Scripts/modules/commands/download.py</a></li>
<li><a href="#trunkWebKitToolsScriptsmodulescommandsqueriespy">trunk/WebKitTools/Scripts/modules/commands/queries.py</a></li>
<li><a href="#trunkWebKitToolsScriptsmodulescommandsqueuespy">trunk/WebKitTools/Scripts/modules/commands/queues.py</a></li>
<li><a href="#trunkWebKitToolsScriptsmodulescommandsuploadpy">trunk/WebKitTools/Scripts/modules/commands/upload.py</a></li>
<li><a href="#trunkWebKitToolsScriptsmodulesmulticommandtoolpy">trunk/WebKitTools/Scripts/modules/multicommandtool.py</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkWebKitToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/WebKitTools/ChangeLog (52294 => 52295)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebKitTools/ChangeLog        2009-12-18 00:51:13 UTC (rev 52294)
+++ trunk/WebKitTools/ChangeLog        2009-12-18 01:28:27 UTC (rev 52295)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2009-12-17  Eric Seidel  &lt;eric@webkit.org&gt;
+
+        Reviewed by Adam Barth.
+
+        Command.show_in_main_help should default to False
+        https://bugs.webkit.org/show_bug.cgi?id=32686
+
+        * Scripts/modules/commands/download.py:
+        * Scripts/modules/commands/queries.py:
+        * Scripts/modules/commands/queues.py:
+        * Scripts/modules/commands/upload.py:
+        * Scripts/modules/multicommandtool.py:
+
</ins><span class="cx"> 2009-12-17  Alejandro G. Castro  &lt;alex@igalia.com&gt;
</span><span class="cx"> 
</span><span class="cx">         Reviewed by Eric Seidel.
</span></span></pre></div>
<a id="trunkWebKitToolsScriptsmodulescommandsdownloadpy"></a>
<div class="modfile"><h4>Modified: trunk/WebKitTools/Scripts/modules/commands/download.py (52294 => 52295)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebKitTools/Scripts/modules/commands/download.py        2009-12-18 00:51:13 UTC (rev 52294)
+++ trunk/WebKitTools/Scripts/modules/commands/download.py        2009-12-18 01:28:27 UTC (rev 52295)
</span><span class="lines">@@ -68,8 +68,6 @@
</span><span class="cx"> class Build(AbstractSequencedCommmand):
</span><span class="cx">     name = &quot;build&quot;
</span><span class="cx">     help_text = &quot;Update working copy and build&quot;
</span><del>-    argument_names = &quot;&quot;
-    show_in_main_help = False
</del><span class="cx">     steps = [
</span><span class="cx">         CleanWorkingDirectoryStep,
</span><span class="cx">         UpdateStep,
</span><span class="lines">@@ -166,7 +164,6 @@
</span><span class="cx">     name = &quot;check-style&quot;
</span><span class="cx">     help_text = &quot;Run check-webkit-style on the specified attachments&quot;
</span><span class="cx">     argument_names = &quot;ATTACHMENT_ID [ATTACHMENT_IDS]&quot;
</span><del>-    show_in_main_help = False
</del><span class="cx">     main_steps = [
</span><span class="cx">         CleanWorkingDirectoryStep,
</span><span class="cx">         UpdateStep,
</span><span class="lines">@@ -179,7 +176,6 @@
</span><span class="cx">     name = &quot;build-attachment&quot;
</span><span class="cx">     help_text = &quot;Apply and build patches from bugzilla&quot;
</span><span class="cx">     argument_names = &quot;ATTACHMENT_ID [ATTACHMENT_IDS]&quot;
</span><del>-    show_in_main_help = False
</del><span class="cx">     main_steps = [
</span><span class="cx">         CleanWorkingDirectoryStep,
</span><span class="cx">         UpdateStep,
</span></span></pre></div>
<a id="trunkWebKitToolsScriptsmodulescommandsqueriespy"></a>
<div class="modfile"><h4>Modified: trunk/WebKitTools/Scripts/modules/commands/queries.py (52294 => 52295)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebKitTools/Scripts/modules/commands/queries.py        2009-12-18 00:51:13 UTC (rev 52294)
+++ trunk/WebKitTools/Scripts/modules/commands/queries.py        2009-12-18 01:28:27 UTC (rev 52295)
</span><span class="lines">@@ -39,7 +39,6 @@
</span><span class="cx"> 
</span><span class="cx"> class BugsToCommit(Command):
</span><span class="cx">     name = &quot;bugs-to-commit&quot;
</span><del>-    show_in_main_help = False
</del><span class="cx">     def __init__(self):
</span><span class="cx">         Command.__init__(self, &quot;List bugs in the commit-queue&quot;)
</span><span class="cx"> 
</span><span class="lines">@@ -51,7 +50,6 @@
</span><span class="cx"> 
</span><span class="cx"> class PatchesToCommit(Command):
</span><span class="cx">     name = &quot;patches-to-commit&quot;
</span><del>-    show_in_main_help = False
</del><span class="cx">     def __init__(self):
</span><span class="cx">         Command.__init__(self, &quot;List patches in the commit-queue&quot;)
</span><span class="cx"> 
</span><span class="lines">@@ -64,7 +62,6 @@
</span><span class="cx"> 
</span><span class="cx"> class PatchesToCommitQueue(Command):
</span><span class="cx">     name = &quot;patches-to-commit-queue&quot;
</span><del>-    show_in_main_help = False
</del><span class="cx">     def __init__(self):
</span><span class="cx">         options = [
</span><span class="cx">             make_option(&quot;--bugs&quot;, action=&quot;store_true&quot;, dest=&quot;bugs&quot;, help=&quot;Output bug links instead of patch links&quot;),
</span><span class="lines">@@ -99,7 +96,6 @@
</span><span class="cx"> 
</span><span class="cx"> class PatchesToReview(Command):
</span><span class="cx">     name = &quot;patches-to-review&quot;
</span><del>-    show_in_main_help = False
</del><span class="cx">     def __init__(self):
</span><span class="cx">         Command.__init__(self, &quot;List patches that are pending review&quot;)
</span><span class="cx"> 
</span><span class="lines">@@ -112,7 +108,6 @@
</span><span class="cx"> 
</span><span class="cx"> class ReviewedPatches(Command):
</span><span class="cx">     name = &quot;reviewed-patches&quot;
</span><del>-    show_in_main_help = False
</del><span class="cx">     def __init__(self):
</span><span class="cx">         Command.__init__(self, &quot;List r+'d patches on a bug&quot;, &quot;BUGID&quot;)
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkWebKitToolsScriptsmodulescommandsqueuespy"></a>
<div class="modfile"><h4>Modified: trunk/WebKitTools/Scripts/modules/commands/queues.py (52294 => 52295)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebKitTools/Scripts/modules/commands/queues.py        2009-12-18 00:51:13 UTC (rev 52294)
+++ trunk/WebKitTools/Scripts/modules/commands/queues.py        2009-12-18 01:28:27 UTC (rev 52295)
</span><span class="lines">@@ -44,7 +44,6 @@
</span><span class="cx"> from modules.workqueue import WorkQueue, WorkQueueDelegate
</span><span class="cx"> 
</span><span class="cx"> class AbstractQueue(Command, WorkQueueDelegate):
</span><del>-    show_in_main_help = False
</del><span class="cx">     watchers = &quot;webkit-bot-watchers@googlegroups.com&quot;
</span><span class="cx">     def __init__(self, options=None): # Default values should never be collections (like []) as default values are shared between invocations
</span><span class="cx">         options_list = (options or []) + [
</span></span></pre></div>
<a id="trunkWebKitToolsScriptsmodulescommandsuploadpy"></a>
<div class="modfile"><h4>Modified: trunk/WebKitTools/Scripts/modules/commands/upload.py (52294 => 52295)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebKitTools/Scripts/modules/commands/upload.py        2009-12-18 00:51:13 UTC (rev 52294)
+++ trunk/WebKitTools/Scripts/modules/commands/upload.py        2009-12-18 01:28:27 UTC (rev 52295)
</span><span class="lines">@@ -44,7 +44,6 @@
</span><span class="cx"> # FIXME: Requires unit test.
</span><span class="cx"> class CommitMessageForCurrentDiff(Command):
</span><span class="cx">     name = &quot;commit-message&quot;
</span><del>-    show_in_main_help = False
</del><span class="cx">     def __init__(self):
</span><span class="cx">         Command.__init__(self, &quot;Print a commit message suitable for the uncommitted changes&quot;)
</span><span class="cx"> 
</span><span class="lines">@@ -55,7 +54,6 @@
</span><span class="cx"> 
</span><span class="cx"> class ObsoleteAttachments(Command):
</span><span class="cx">     name = &quot;obsolete-attachments&quot;
</span><del>-    show_in_main_help = False
</del><span class="cx">     def __init__(self):
</span><span class="cx">         Command.__init__(self, &quot;Mark all attachments on a bug as obsolete&quot;, &quot;BUGID&quot;)
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkWebKitToolsScriptsmodulesmulticommandtoolpy"></a>
<div class="modfile"><h4>Modified: trunk/WebKitTools/Scripts/modules/multicommandtool.py (52294 => 52295)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebKitTools/Scripts/modules/multicommandtool.py        2009-12-18 00:51:13 UTC (rev 52294)
+++ trunk/WebKitTools/Scripts/modules/multicommandtool.py        2009-12-18 01:28:27 UTC (rev 52295)
</span><span class="lines">@@ -40,7 +40,7 @@
</span><span class="cx"> 
</span><span class="cx"> class Command(object):
</span><span class="cx">     name = None
</span><del>-    # show_in_main_help = False # Subclasses must define show_in_main_help, we leave it out here to enforce that.
</del><ins>+    show_in_main_help = False
</ins><span class="cx">     def __init__(self, help_text, argument_names=None, options=None, requires_local_commits=False):
</span><span class="cx">         self.help_text = help_text
</span><span class="cx">         self.argument_names = argument_names
</span><span class="lines">@@ -128,7 +128,6 @@
</span><span class="cx"> 
</span><span class="cx"> class HelpCommand(Command):
</span><span class="cx">     name = &quot;help&quot;
</span><del>-    show_in_main_help = False
</del><span class="cx"> 
</span><span class="cx">     def __init__(self):
</span><span class="cx">         options = [
</span></span></pre>
</div>
</div>

</body>
</html>