<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[52224] trunk/WebCore</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/52224">52224</a></dd>
<dt>Author</dt> <dd>dglazkov@chromium.org</dd>
<dt>Date</dt> <dd>2009-12-16 16:03:49 -0800 (Wed, 16 Dec 2009)</dd>
</dl>

<h3>Log Message</h3>
<pre>2009-12-16  Dimitri Glazkov  &lt;dglazkov@chromium.org&gt;

        Reviewed by David Levin.

        https://bugs.webkit.org/show_bug.cgi?id=32637
        [V8] Generate most named property getters.

        Covered by existing tests.

        * bindings/scripts/CodeGeneratorV8.pm: Added generation of SetNamedPropertyHandler call.
        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::V8DOMWrapper::getTemplate): Removed now-generated SetNamedPropertyHandler callsites.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkWebCoreChangeLog">trunk/WebCore/ChangeLog</a></li>
<li><a href="#trunkWebCorebindingsscriptsCodeGeneratorV8pm">trunk/WebCore/bindings/scripts/CodeGeneratorV8.pm</a></li>
<li><a href="#trunkWebCorebindingsv8V8DOMWrappercpp">trunk/WebCore/bindings/v8/V8DOMWrapper.cpp</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/ChangeLog (52223 => 52224)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/ChangeLog        2009-12-16 23:52:38 UTC (rev 52223)
+++ trunk/WebCore/ChangeLog        2009-12-17 00:03:49 UTC (rev 52224)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2009-12-16  Dimitri Glazkov  &lt;dglazkov@chromium.org&gt;
+
+        Reviewed by David Levin.
+
+        https://bugs.webkit.org/show_bug.cgi?id=32637
+        [V8] Generate most named property getters.
+
+        Covered by existing tests.
+
+        * bindings/scripts/CodeGeneratorV8.pm: Added generation of SetNamedPropertyHandler call.
+        * bindings/v8/V8DOMWrapper.cpp:
+        (WebCore::V8DOMWrapper::getTemplate): Removed now-generated SetNamedPropertyHandler callsites.
+
</ins><span class="cx"> 2009-12-16  Luiz Agostini  &lt;luiz.agostini@openbossa.org&gt;
</span><span class="cx"> 
</span><span class="cx">         Reviewed by Kenneth Rohde Christiansen.
</span></span></pre></div>
<a id="trunkWebCorebindingsscriptsCodeGeneratorV8pm"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/bindings/scripts/CodeGeneratorV8.pm (52223 => 52224)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/bindings/scripts/CodeGeneratorV8.pm        2009-12-16 23:52:38 UTC (rev 52223)
+++ trunk/WebCore/bindings/scripts/CodeGeneratorV8.pm        2009-12-17 00:03:49 UTC (rev 52224)
</span><span class="lines">@@ -1164,14 +1164,31 @@
</span><span class="cx">     my $namedPropertyGetter = shift;
</span><span class="cx">     my $interfaceName = $dataNode-&gt;name;
</span><span class="cx"> 
</span><del>-    if ($dataNode-&gt;extendedAttributes-&gt;{&quot;HasNameGetter&quot;} &amp;&amp; !$namedPropertyGetter-&gt;extendedAttributes-&gt;{&quot;Custom&quot;}) {
</del><ins>+    my $hasGetter = $dataNode-&gt;extendedAttributes-&gt;{&quot;HasNameGetter&quot;} || $namedPropertyGetter;
+    if (!$hasGetter) {
+        return;
+    }
+
+    if ($namedPropertyGetter &amp;&amp; $namedPropertyGetter-&gt;type ne &quot;Node&quot; &amp;&amp; !$namedPropertyGetter-&gt;extendedAttributes-&gt;{&quot;Custom&quot;}) {
</ins><span class="cx">         $implIncludes{&quot;V8Collection.h&quot;} = 1;
</span><span class="cx">         my $type = $namedPropertyGetter-&gt;type;
</span><span class="cx">         my $classIndex = uc($type);
</span><span class="cx">         push(@implContent, &lt;&lt;END);
</span><span class="cx">   setCollectionNamedGetter&lt;${interfaceName}, ${type}&gt;(desc, V8ClassIndex::${classIndex});
</span><span class="cx"> END
</span><ins>+        return;
</ins><span class="cx">     }
</span><ins>+
+    my $hasSetter = $dataNode-&gt;extendedAttributes-&gt;{&quot;DelegatingPutFunction&quot;};
+    my $hasDeleter = $dataNode-&gt;extendedAttributes-&gt;{&quot;CustomDeleteProperty&quot;};
+    my $hasEnumerator = $dataNode-&gt;extendedAttributes-&gt;{&quot;CustomGetPropertyNames&quot;};
+
+    push(@implContent, &quot;  desc-&gt;InstanceTemplate()-&gt;SetNamedPropertyHandler(V8Custom::v8${interfaceName}NamedPropertyGetter, &quot;);
+    push(@implContent, $hasSetter ? &quot;V8Custom::v8${interfaceName}NamedPropertySetter, &quot; : &quot;0, &quot;);
+    push(@implContent, &quot;0 ,&quot;); # NamedPropertyQuery -- not being used at the moment.
+    push(@implContent, $hasDeleter ? &quot;V8Custom::v8${interfaceName}NamedPropertyDeleter, &quot; : &quot;0, &quot;);
+    push(@implContent, $hasEnumerator ? &quot;V8Custom::v8${interfaceName}NamedPropertyEnumerator&quot; : &quot;0&quot;);
+    push(@implContent, &quot;);\n&quot;);
</ins><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> sub GenerateImplementation
</span><span class="lines">@@ -1467,7 +1484,7 @@
</span><span class="cx">     }
</span><span class="cx"> 
</span><span class="cx">     GenerateImplementationIndexer($dataNode, $indexer) if $indexer;
</span><del>-    GenerateImplementationNamedPropertyGetter($dataNode, $namedPropertyGetter) if $namedPropertyGetter;
</del><ins>+    GenerateImplementationNamedPropertyGetter($dataNode, $namedPropertyGetter);
</ins><span class="cx"> 
</span><span class="cx">     # Define our functions with Set() or SetAccessor()
</span><span class="cx">     $total_functions = 0;
</span></span></pre></div>
<a id="trunkWebCorebindingsv8V8DOMWrappercpp"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/bindings/v8/V8DOMWrapper.cpp (52223 => 52224)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/bindings/v8/V8DOMWrapper.cpp        2009-12-16 23:52:38 UTC (rev 52223)
+++ trunk/WebCore/bindings/v8/V8DOMWrapper.cpp        2009-12-17 00:03:49 UTC (rev 52224)
</span><span class="lines">@@ -271,16 +271,9 @@
</span><span class="cx">         toStringTemplate = v8::Persistent&lt;v8::FunctionTemplate&gt;::New(v8::FunctionTemplate::New(ConstructorToString));
</span><span class="cx">     descriptor-&gt;Set(GetToStringName(), toStringTemplate);
</span><span class="cx">     switch (type) {
</span><del>-    case V8ClassIndex::CSSSTYLEDECLARATION:
-        // The named property handler for style declarations has a
-        // setter. Therefore, the interceptor has to be on the object
-        // itself and not on the prototype object.
-        descriptor-&gt;InstanceTemplate()-&gt;SetNamedPropertyHandler( USE_NAMED_PROPERTY_GETTER(CSSStyleDeclaration), USE_NAMED_PROPERTY_SETTER(CSSStyleDeclaration));
-        break;
</del><span class="cx">     case V8ClassIndex::HTMLALLCOLLECTION:
</span><span class="cx">         descriptor-&gt;InstanceTemplate()-&gt;MarkAsUndetectable(); // fall through
</span><span class="cx">     case V8ClassIndex::HTMLCOLLECTION:
</span><del>-        descriptor-&gt;InstanceTemplate()-&gt;SetNamedPropertyHandler(USE_NAMED_PROPERTY_GETTER(HTMLCollection));
</del><span class="cx">         descriptor-&gt;InstanceTemplate()-&gt;SetCallAsFunctionHandler(USE_CALLBACK(HTMLCollectionCallAsFunction));
</span><span class="cx">         break;
</span><span class="cx">     case V8ClassIndex::HTMLOPTIONSCOLLECTION:
</span><span class="lines">@@ -289,7 +282,6 @@
</span><span class="cx">         descriptor-&gt;InstanceTemplate()-&gt;SetCallAsFunctionHandler(USE_CALLBACK(HTMLCollectionCallAsFunction));
</span><span class="cx">         break;
</span><span class="cx">     case V8ClassIndex::HTMLSELECTELEMENT:
</span><del>-        descriptor-&gt;InstanceTemplate()-&gt;SetNamedPropertyHandler(USE_NAMED_PROPERTY_GETTER(HTMLSelectElement));
</del><span class="cx">         descriptor-&gt;InstanceTemplate()-&gt;SetIndexedPropertyHandler(USE_INDEXED_PROPERTY_GETTER(HTMLSelectElement), USE_INDEXED_PROPERTY_SETTER(HTMLSelectElement), 0, 0, nodeCollectionIndexedPropertyEnumerator&lt;HTMLSelectElement&gt;, v8::Integer::New(V8ClassIndex::NODE));
</span><span class="cx">         break;
</span><span class="cx">     case V8ClassIndex::HTMLDOCUMENT: {
</span><span class="lines">@@ -351,22 +343,14 @@
</span><span class="cx">         v8::Local&lt;v8::ObjectTemplate&gt; instanceTemplate = descriptor-&gt;InstanceTemplate();
</span><span class="cx">         ASSERT(instanceTemplate-&gt;InternalFieldCount() == V8Custom::kDefaultWrapperInternalFieldCount);
</span><span class="cx">         instanceTemplate-&gt;SetInternalFieldCount(V8Custom::kNamedNodeMapInternalFieldCount);
</span><del>-        instanceTemplate-&gt;SetNamedPropertyHandler(USE_NAMED_PROPERTY_GETTER(NamedNodeMap));
</del><span class="cx">         instanceTemplate-&gt;SetIndexedPropertyHandler(USE_INDEXED_PROPERTY_GETTER(NamedNodeMap), 0, 0, 0, collectionIndexedPropertyEnumerator&lt;NamedNodeMap&gt;, v8::Integer::New(V8ClassIndex::NODE));
</span><span class="cx">         break;
</span><span class="cx">     }
</span><span class="cx"> #if ENABLE(DOM_STORAGE)
</span><span class="cx">     case V8ClassIndex::STORAGE:
</span><del>-        descriptor-&gt;InstanceTemplate()-&gt;SetNamedPropertyHandler(USE_NAMED_PROPERTY_GETTER(Storage), USE_NAMED_PROPERTY_SETTER(Storage), 0, USE_NAMED_PROPERTY_DELETER(Storage), V8Custom::v8StorageNamedPropertyEnumerator);
</del><span class="cx">         descriptor-&gt;InstanceTemplate()-&gt;SetIndexedPropertyHandler(USE_INDEXED_PROPERTY_GETTER(Storage), USE_INDEXED_PROPERTY_SETTER(Storage), 0, USE_INDEXED_PROPERTY_DELETER(Storage));
</span><span class="cx">         break;
</span><span class="cx"> #endif
</span><del>-    case V8ClassIndex::NODELIST:
-        descriptor-&gt;InstanceTemplate()-&gt;SetNamedPropertyHandler(USE_NAMED_PROPERTY_GETTER(NodeList));
-        break;
-    case V8ClassIndex::STYLESHEETLIST:
-        descriptor-&gt;InstanceTemplate()-&gt;SetNamedPropertyHandler(USE_NAMED_PROPERTY_GETTER(StyleSheetList));
-        break;
</del><span class="cx">     case V8ClassIndex::DOMWINDOW: {
</span><span class="cx">         v8::Local&lt;v8::Signature&gt; defaultSignature = v8::Signature::New(descriptor);
</span><span class="cx"> 
</span><span class="lines">@@ -563,11 +547,6 @@
</span><span class="cx">     case V8ClassIndex::XSLTPROCESSOR:
</span><span class="cx">         descriptor-&gt;SetCallHandler(USE_CALLBACK(XSLTProcessorConstructor));
</span><span class="cx">         break;
</span><del>-#if ENABLE(DATAGRID)
-    case V8ClassIndex::DATAGRIDCOLUMNLIST:
-        descriptor-&gt;InstanceTemplate()-&gt;SetNamedPropertyHandler(USE_NAMED_PROPERTY_GETTER(DataGridColumnList));
-        break;
-#endif
</del><span class="cx">     default:
</span><span class="cx">         break;
</span><span class="cx">     }
</span></span></pre>
</div>
</div>

</body>
</html>