<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[52143] trunk/WebCore</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/52143">52143</a></dd>
<dt>Author</dt> <dd>zecke@webkit.org</dd>
<dt>Date</dt> <dd>2009-12-15 01:29:19 -0800 (Tue, 15 Dec 2009)</dd>
</dl>

<h3>Log Message</h3>
<pre>[Qt] Remove dead code from FontPlatformDataQt.cpp

https://bugs.webkit.org/show_bug.cgi?id=32540

In <a href="http://trac.webkit.org/projects/webkit/changeset/51758">r51758</a> the code that used familyNames was removed
and we should remove the creation of the familyNames
as well.

* platform/graphics/qt/FontPlatformDataQt.cpp:</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkWebCoreChangeLog">trunk/WebCore/ChangeLog</a></li>
<li><a href="#trunkWebCoreplatformgraphicsqtFontPlatformDataQtcpp">trunk/WebCore/platform/graphics/qt/FontPlatformDataQt.cpp</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/ChangeLog (52142 => 52143)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/ChangeLog        2009-12-15 08:57:31 UTC (rev 52142)
+++ trunk/WebCore/ChangeLog        2009-12-15 09:29:19 UTC (rev 52143)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2009-12-14  Holger Hans Peter Freyther  &lt;zecke@selfish.org&gt;
+
+        Reviewed by Eric Seidel.
+
+        [Qt] Remove dead code from FontPlatformDataQt.cpp
+        https://bugs.webkit.org/show_bug.cgi?id=32540
+
+        In r51758 the code that used familyNames was removed
+        and we should remove the creation of the familyNames
+        as well.
+
+        * platform/graphics/qt/FontPlatformDataQt.cpp:
+        (WebCore::FontPlatformData::FontPlatformData):
+
</ins><span class="cx"> 2009-12-15  Dan Bernstein  &lt;mitz@apple.com&gt;
</span><span class="cx"> 
</span><span class="cx">         Reviewed by Adam Roben.
</span></span></pre></div>
<a id="trunkWebCoreplatformgraphicsqtFontPlatformDataQtcpp"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/platform/graphics/qt/FontPlatformDataQt.cpp (52142 => 52143)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/platform/graphics/qt/FontPlatformDataQt.cpp        2009-12-15 08:57:31 UTC (rev 52142)
+++ trunk/WebCore/platform/graphics/qt/FontPlatformDataQt.cpp        2009-12-15 09:29:19 UTC (rev 52143)
</span><span class="lines">@@ -49,17 +49,6 @@
</span><span class="cx"> FontPlatformData::FontPlatformData(const FontDescription&amp; description, const AtomicString&amp; familyName, int wordSpacing, int letterSpacing)
</span><span class="cx">     : m_data(new FontPlatformDataPrivate())
</span><span class="cx"> {
</span><del>-    QString familyNames(familyName);
-    if (!familyName.isEmpty())
-        familyNames += QLatin1Char(',');
-
-    const FontFamily* family = &amp;description.family();
-    while (family) {
-        familyNames += family-&gt;family();
-        family = family-&gt;next();
-        if (family)
-            familyNames += QLatin1Char(',');
-    }
</del><span class="cx">     QFont&amp; font = m_data-&gt;font;
</span><span class="cx">     font.setFamily(familyName);
</span><span class="cx">     font.setPixelSize(qRound(description.computedSize()));
</span></span></pre>
</div>
</div>

</body>
</html>