<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[52001] trunk/WebCore</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/52001">52001</a></dd>
<dt>Author</dt> <dd>eric@webkit.org</dd>
<dt>Date</dt> <dd>2009-12-11 10:03:42 -0800 (Fri, 11 Dec 2009)</dd>
</dl>

<h3>Log Message</h3>
<pre>2009-12-11  Victor Wang  &lt;victorw@chromium.org&gt;

        Reviewed by Darin Fisher.

        Changed PopupMenuChromium to keep the value selected from
        keyboard when popup is closed.

        The problem is Chromium does not fire the onchange event
        when the popup is closed if an item is selected via
        keyboard by typing the first char of the item. This makes
        chromium popup not having consistent behaviours and also
        behaves differently from other major browsers.
        Calling popup-&gt;hide() instead of popup-&gt;hidePopup() in
        PopupMenu fixes the issues as it does extra step to check
        whethere there is a keyboard selection changed when closing
        the popup.

        https://bugs.webkit.org/show_bug.cgi?id=32403

        TEST: add a manual test as the current layout test shell
        does not support sending keyboard events to popup list.

        * manual-tests/chromium/select-close-popup-value-change.html: Added.
        * platform/chromium/PopupMenuChromium.cpp:
        (WebCore::PopupMenu::hide):</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkWebCoreChangeLog">trunk/WebCore/ChangeLog</a></li>
<li><a href="#trunkWebCoreplatformchromiumPopupMenuChromiumcpp">trunk/WebCore/platform/chromium/PopupMenuChromium.cpp</a></li>
</ul>

<h3>Added Paths</h3>
<ul>
<li><a href="#trunkWebCoremanualtestschromiumselectclosepopupvaluechangehtml">trunk/WebCore/manual-tests/chromium/select-close-popup-value-change.html</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/ChangeLog (52000 => 52001)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/ChangeLog        2009-12-11 17:31:45 UTC (rev 52000)
+++ trunk/WebCore/ChangeLog        2009-12-11 18:03:42 UTC (rev 52001)
</span><span class="lines">@@ -1,3 +1,29 @@
</span><ins>+2009-12-11  Victor Wang  &lt;victorw@chromium.org&gt;
+
+        Reviewed by Darin Fisher.
+
+        Changed PopupMenuChromium to keep the value selected from
+        keyboard when popup is closed.
+
+        The problem is Chromium does not fire the onchange event
+        when the popup is closed if an item is selected via
+        keyboard by typing the first char of the item. This makes
+        chromium popup not having consistent behaviours and also
+        behaves differently from other major browsers.
+        Calling popup-&gt;hide() instead of popup-&gt;hidePopup() in
+        PopupMenu fixes the issues as it does extra step to check
+        whethere there is a keyboard selection changed when closing
+        the popup.
+
+        https://bugs.webkit.org/show_bug.cgi?id=32403
+    
+        TEST: add a manual test as the current layout test shell
+        does not support sending keyboard events to popup list.
+
+        * manual-tests/chromium/select-close-popup-value-change.html: Added.
+        * platform/chromium/PopupMenuChromium.cpp:
+        (WebCore::PopupMenu::hide):
+
</ins><span class="cx"> 2009-12-11  anton muhin  &lt;antonm@chromium.org&gt;
</span><span class="cx"> 
</span><span class="cx">         Reviewed by Adam Barth.
</span></span></pre></div>
<a id="trunkWebCoremanualtestschromiumselectclosepopupvaluechangehtml"></a>
<div class="addfile"><h4>Added: trunk/WebCore/manual-tests/chromium/select-close-popup-value-change.html (0 => 52001)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/manual-tests/chromium/select-close-popup-value-change.html                                (rev 0)
+++ trunk/WebCore/manual-tests/chromium/select-close-popup-value-change.html        2009-12-11 18:03:42 UTC (rev 52001)
</span><span class="lines">@@ -0,0 +1,20 @@
</span><ins>+&lt;html&gt;
+&lt;head&gt;
+&lt;/head&gt;
+&lt;body&gt;
+    &lt;p&gt;Do the following, the test passes if the select keeps the selected value after step 4, fails if the value reverted.&lt;/p&gt;
+    &lt;ul&gt;
+        &lt;li&gt;1. Click the select to open the popup list.&lt;/li&gt; 
+        &lt;li&gt;2. Use keyboard to select a value by pressing the first letter of the value.&lt;/li&gt; 
+        &lt;li&gt;3. Click the select again to close the popup list, it should stay at the value from step 2.&lt;/li&gt; 
+        &lt;li&gt;4. Click anywhere else on the page to move the focus out of the select.&lt;/li&gt;
+    &lt;/ul&gt;
+
+    &lt;select&gt;
+        &lt;option&gt;0&lt;/option&gt;
+        &lt;option&gt;1&lt;/option&gt;
+        &lt;option&gt;2&lt;/option&gt;
+        &lt;option&gt;3&lt;/option&gt;
+    &lt;/select&gt;
+&lt;/body&gt;
+&lt;/html&gt;
</ins></span></pre></div>
<a id="trunkWebCoreplatformchromiumPopupMenuChromiumcpp"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/platform/chromium/PopupMenuChromium.cpp (52000 => 52001)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/platform/chromium/PopupMenuChromium.cpp        2009-12-11 17:31:45 UTC (rev 52000)
+++ trunk/WebCore/platform/chromium/PopupMenuChromium.cpp        2009-12-11 18:03:42 UTC (rev 52001)
</span><span class="lines">@@ -1234,7 +1234,7 @@
</span><span class="cx"> void PopupMenu::hide()
</span><span class="cx"> {
</span><span class="cx">     if (p.popup)
</span><del>-        p.popup-&gt;hidePopup();
</del><ins>+        p.popup-&gt;hide();
</ins><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> void PopupMenu::updateFromElement()
</span></span></pre>
</div>
</div>

</body>
</html>