<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[51985] trunk</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/51985">51985</a></dd>
<dt>Author</dt> <dd>eric@webkit.org</dd>
<dt>Date</dt> <dd>2009-12-11 07:21:55 -0800 (Fri, 11 Dec 2009)</dd>
</dl>

<h3>Log Message</h3>
<pre>2009-12-11  Benjamin Poulain  &lt;benjamin.poulain@nokia.com&gt;

        Reviewed by Darin Adler.

        The values of RuntimeArray are not enumerable
        https://bugs.webkit.org/show_bug.cgi?id=29005

        The indices of RuntimeArray should be enumerated like for a regular array.

        * platform/mac/fast/dom/wrapper-classes-objc-expected.txt:
        * platform/mac/fast/dom/wrapper-classes-objc.html:
2009-12-11  Benjamin Poulain  &lt;benjamin.poulain@nokia.com&gt;

        Reviewed by Darin Adler.

        The values of RuntimeArray are not enumerable
        https://bugs.webkit.org/show_bug.cgi?id=29005

        The indices of RuntimeArray should be enumerated like for a regular array.

        * bridge/runtime_array.cpp:
        (JSC::RuntimeArray::getOwnPropertyNames):
        * bridge/runtime_array.h:
2009-12-11  Benjamin Poulain  &lt;benjamin.poulain@nokia.com&gt;

        Reviewed by Darin Adler.

        The values of RuntimeArray are not enumerable
        https://bugs.webkit.org/show_bug.cgi?id=29005

        * DumpRenderTree/mac/ObjCController.m:
        (+[ObjCController isSelectorExcludedFromWebScript:]):
        (+[ObjCController webScriptNameForSelector:]):
        (-[ObjCController arrayOfString]):</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsplatformmacfastdomwrapperclassesobjcexpectedtxt">trunk/LayoutTests/platform/mac/fast/dom/wrapper-classes-objc-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformmacfastdomwrapperclassesobjchtml">trunk/LayoutTests/platform/mac/fast/dom/wrapper-classes-objc.html</a></li>
<li><a href="#trunkWebCoreChangeLog">trunk/WebCore/ChangeLog</a></li>
<li><a href="#trunkWebCorebridgeruntime_arraycpp">trunk/WebCore/bridge/runtime_array.cpp</a></li>
<li><a href="#trunkWebCorebridgeruntime_arrayh">trunk/WebCore/bridge/runtime_array.h</a></li>
<li><a href="#trunkWebKitToolsChangeLog">trunk/WebKitTools/ChangeLog</a></li>
<li><a href="#trunkWebKitToolsDumpRenderTreemacObjCControllerm">trunk/WebKitTools/DumpRenderTree/mac/ObjCController.m</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (51984 => 51985)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog        2009-12-11 15:07:55 UTC (rev 51984)
+++ trunk/LayoutTests/ChangeLog        2009-12-11 15:21:55 UTC (rev 51985)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2009-12-11  Benjamin Poulain  &lt;benjamin.poulain@nokia.com&gt;
+
+        Reviewed by Darin Adler.
+
+        The values of RuntimeArray are not enumerable
+        https://bugs.webkit.org/show_bug.cgi?id=29005
+
+        The indices of RuntimeArray should be enumerated like for a regular array.
+
+        * platform/mac/fast/dom/wrapper-classes-objc-expected.txt:
+        * platform/mac/fast/dom/wrapper-classes-objc.html:
+
</ins><span class="cx"> 2009-12-11  Simon Hausmann  &lt;hausmann@webkit.org&gt;
</span><span class="cx"> 
</span><span class="cx">         Reviewed by Antti Koivisto.
</span></span></pre></div>
<a id="trunkLayoutTestsplatformmacfastdomwrapperclassesobjcexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/mac/fast/dom/wrapper-classes-objc-expected.txt (51984 => 51985)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac/fast/dom/wrapper-classes-objc-expected.txt        2009-12-11 15:07:55 UTC (rev 51984)
+++ trunk/LayoutTests/platform/mac/fast/dom/wrapper-classes-objc-expected.txt        2009-12-11 15:21:55 UTC (rev 51985)
</span><span class="lines">@@ -192,4 +192,5 @@
</span><span class="cx"> PASS typeof objCObjectOfClass('NSCFString') is 'string'
</span><span class="cx"> PASS typeof objCObjectOfClass('WebScriptObject') is 'object'
</span><span class="cx"> PASS objCObjectOfClass('NSArray') instanceof Array is true
</span><ins>+PASS concatenateArray(objCArrayOfString()) is 'onetwothree'
</ins><span class="cx"> 
</span></span></pre></div>
<a id="trunkLayoutTestsplatformmacfastdomwrapperclassesobjchtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/mac/fast/dom/wrapper-classes-objc.html (51984 => 51985)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac/fast/dom/wrapper-classes-objc.html        2009-12-11 15:07:55 UTC (rev 51984)
+++ trunk/LayoutTests/platform/mac/fast/dom/wrapper-classes-objc.html        2009-12-11 15:21:55 UTC (rev 51985)
</span><span class="lines">@@ -34,6 +34,21 @@
</span><span class="cx">     return objCController.objectOfClass(name);
</span><span class="cx"> }
</span><span class="cx"> 
</span><ins>+function objCArrayOfString()
+{
+    if (!window.objCController)
+        return &quot;only works under DumpRenderTree&quot;;
+    return objCController.arrayOfString();
+}
+
+function concatenateArray(array)
+{
+    var result = '';
+    for (i in array)
+        result += array[i];
+    return result;
+}
+
</ins><span class="cx"> function tagObjCWrapperClass(tagName)
</span><span class="cx"> {
</span><span class="cx">     return objCWrapperClass(document.createElement(tagName));
</span><span class="lines">@@ -272,6 +287,8 @@
</span><span class="cx">     shouldBe(&quot;typeof objCObjectOfClass('WebScriptObject')&quot;, &quot;'object'&quot;);
</span><span class="cx">     shouldBeTrue(&quot;objCObjectOfClass('NSArray') instanceof Array&quot;);
</span><span class="cx"> 
</span><ins>+    shouldBe(&quot;concatenateArray(objCArrayOfString())&quot;, &quot;'onetwothree'&quot;);
+
</ins><span class="cx">     // Not yet tested:
</span><span class="cx"> 
</span><span class="cx">     // CSSCharsetRule
</span></span></pre></div>
<a id="trunkWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/ChangeLog (51984 => 51985)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/ChangeLog        2009-12-11 15:07:55 UTC (rev 51984)
+++ trunk/WebCore/ChangeLog        2009-12-11 15:21:55 UTC (rev 51985)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2009-12-11  Benjamin Poulain  &lt;benjamin.poulain@nokia.com&gt;
+
+        Reviewed by Darin Adler.
+
+        The values of RuntimeArray are not enumerable
+        https://bugs.webkit.org/show_bug.cgi?id=29005
+
+        The indices of RuntimeArray should be enumerated like for a regular array.
+
+        * bridge/runtime_array.cpp:
+        (JSC::RuntimeArray::getOwnPropertyNames):
+        * bridge/runtime_array.h:
+
</ins><span class="cx"> 2009-12-11  Andreas Kling  &lt;andreas.kling@nokia.com&gt;
</span><span class="cx"> 
</span><span class="cx">         Reviewed by Simon Hausmann.
</span></span></pre></div>
<a id="trunkWebCorebridgeruntime_arraycpp"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/bridge/runtime_array.cpp (51984 => 51985)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/bridge/runtime_array.cpp        2009-12-11 15:07:55 UTC (rev 51984)
+++ trunk/WebCore/bridge/runtime_array.cpp        2009-12-11 15:21:55 UTC (rev 51985)
</span><span class="lines">@@ -28,6 +28,7 @@
</span><span class="cx"> 
</span><span class="cx"> #include &lt;runtime/ArrayPrototype.h&gt;
</span><span class="cx"> #include &lt;runtime/Error.h&gt;
</span><ins>+#include &lt;runtime/PropertyNameArray.h&gt;
</ins><span class="cx"> #include &quot;JSDOMBinding.h&quot;
</span><span class="cx"> 
</span><span class="cx"> using namespace WebCore;
</span><span class="lines">@@ -56,6 +57,15 @@
</span><span class="cx">     return thisObj-&gt;getConcreteArray()-&gt;valueAt(exec, slot.index());
</span><span class="cx"> }
</span><span class="cx"> 
</span><ins>+void RuntimeArray::getOwnPropertyNames(ExecState* exec, PropertyNameArray&amp; propertyNames)
+{
+    unsigned length = getLength();
+    for (unsigned i = 0; i &lt; length; ++i)
+        propertyNames.add(Identifier::from(exec, i));
+
+    JSObject::getOwnPropertyNames(exec, propertyNames);
+}
+
</ins><span class="cx"> bool RuntimeArray::getOwnPropertySlot(ExecState* exec, const Identifier&amp; propertyName, PropertySlot&amp; slot)
</span><span class="cx"> {
</span><span class="cx">     if (propertyName == exec-&gt;propertyNames().length) {
</span></span></pre></div>
<a id="trunkWebCorebridgeruntime_arrayh"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/bridge/runtime_array.h (51984 => 51985)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/bridge/runtime_array.h        2009-12-11 15:07:55 UTC (rev 51984)
+++ trunk/WebCore/bridge/runtime_array.h        2009-12-11 15:21:55 UTC (rev 51985)
</span><span class="lines">@@ -34,7 +34,8 @@
</span><span class="cx"> class RuntimeArray : public JSObject {
</span><span class="cx"> public:
</span><span class="cx">     RuntimeArray(ExecState*, Bindings::Array*);
</span><del>-    
</del><ins>+
+    virtual void getOwnPropertyNames(ExecState*, PropertyNameArray&amp;);
</ins><span class="cx">     virtual bool getOwnPropertySlot(ExecState *, const Identifier&amp;, PropertySlot&amp;);
</span><span class="cx">     virtual bool getOwnPropertySlot(ExecState *, unsigned, PropertySlot&amp;);
</span><span class="cx">     virtual bool getOwnPropertyDescriptor(ExecState *, const Identifier&amp;, PropertyDescriptor&amp;);
</span></span></pre></div>
<a id="trunkWebKitToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/WebKitTools/ChangeLog (51984 => 51985)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebKitTools/ChangeLog        2009-12-11 15:07:55 UTC (rev 51984)
+++ trunk/WebKitTools/ChangeLog        2009-12-11 15:21:55 UTC (rev 51985)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2009-12-11  Benjamin Poulain  &lt;benjamin.poulain@nokia.com&gt;
+
+        Reviewed by Darin Adler.
+
+        The values of RuntimeArray are not enumerable
+        https://bugs.webkit.org/show_bug.cgi?id=29005
+
+        * DumpRenderTree/mac/ObjCController.m:
+        (+[ObjCController isSelectorExcludedFromWebScript:]):
+        (+[ObjCController webScriptNameForSelector:]):
+        (-[ObjCController arrayOfString]):
+
</ins><span class="cx"> 2009-12-10  Eric Seidel  &lt;eric@webkit.org&gt;
</span><span class="cx"> 
</span><span class="cx">         No review, just updating unit tests to match recent checkins.
</span></span></pre></div>
<a id="trunkWebKitToolsDumpRenderTreemacObjCControllerm"></a>
<div class="modfile"><h4>Modified: trunk/WebKitTools/DumpRenderTree/mac/ObjCController.m (51984 => 51985)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebKitTools/DumpRenderTree/mac/ObjCController.m        2009-12-11 15:07:55 UTC (rev 51984)
+++ trunk/WebKitTools/DumpRenderTree/mac/ObjCController.m        2009-12-11 15:21:55 UTC (rev 51985)
</span><span class="lines">@@ -58,6 +58,7 @@
</span><span class="cx">     if (0
</span><span class="cx">             || aSelector == @selector(classNameOf:)
</span><span class="cx">             || aSelector == @selector(objectOfClass:)
</span><ins>+            || aSelector == @selector(arrayOfString)
</ins><span class="cx">             || aSelector == @selector(identityIsEqual::)
</span><span class="cx">             || aSelector == @selector(longLongRoundTrip:)
</span><span class="cx">             || aSelector == @selector(unsignedLongLongRoundTrip:)
</span><span class="lines">@@ -77,6 +78,8 @@
</span><span class="cx">         return @&quot;className&quot;;
</span><span class="cx">     if (aSelector == @selector(objectOfClass:))
</span><span class="cx">         return @&quot;objectOfClass&quot;;
</span><ins>+    if (aSelector == @selector(arrayOfString))
+        return @&quot;arrayOfString&quot;;
</ins><span class="cx">     if (aSelector == @selector(identityIsEqual::))
</span><span class="cx">         return @&quot;identityIsEqual&quot;;
</span><span class="cx">     if (aSelector == @selector(longLongRoundTrip:))
</span><span class="lines">@@ -122,6 +125,16 @@
</span><span class="cx">     return nil;
</span><span class="cx"> }
</span><span class="cx"> 
</span><ins>+- (NSArray *)arrayOfString
+{
+    NSString *strings[3];
+    strings[0] = @&quot;one&quot;;
+    strings[1] = @&quot;two&quot;;
+    strings[2] = @&quot;three&quot;;
+    NSArray *array = [NSArray arrayWithObjects:strings count:3];
+    return array;
+}
+
</ins><span class="cx"> - (BOOL)identityIsEqual:(WebScriptObject *)a :(WebScriptObject *)b
</span><span class="cx"> {
</span><span class="cx">     if ([a isKindOfClass:[NSString class]] &amp;&amp; [b isKindOfClass:[NSString class]])
</span></span></pre>
</div>
</div>

</body>
</html>