<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[51629] trunk</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/51629">51629</a></dd>
<dt>Author</dt> <dd>benm@google.com</dd>
<dt>Date</dt> <dd>2009-12-03 04:18:23 -0800 (Thu, 03 Dec 2009)</dd>
</dl>

<h3>Log Message</h3>
<pre>[Android] The FrameLoaderClient is unaware of BackForwardList changes.
https://bugs.webkit.org/show_bug.cgi?id=31914

Reviewed by Brady Eidson.

WebCore: 

This change adds three new methods on the FrameLoaderClient interface to receive notifications when the BackForwardList changes.

No new tests required. Functionality on all platforms upstream remains the same. Android is the first platform to make use of these callbacks.

* history/BackForwardList.cpp:
(WebCore::BackForwardList::addItem): Execute the callback.
(WebCore::BackForwardList::goBack): ditto.
(WebCore::BackForwardList::goForward): ditto.
(WebCore::BackForwardList::goToItem): ditto.
(WebCore::BackForwardList::setCapacity): dito.
* loader/EmptyClients.h:
(WebCore::EmptyFrameLoaderClient::dispatchDidAddBackForwardItem): Add an empty implementation for the callback that does nothing.
(WebCore::EmptyFrameLoaderClient::dispatchDidRemoveBackForwardItem): ditto.
(WebCore::EmptyFrameLoaderClient::dispatchDidChangeBackForwardIndex): ditto.
* loader/FrameLoaderClient.h:

WebKit/chromium: 

* src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::dispatchDidAddBackForwardItem): Add an empty implementation. Method added to FrameLoaderClient by Android (see bug).
(WebKit::FrameLoaderClientImpl::dispatchDidRemoveBackForwardItem): ditto.
(WebKit::FrameLoaderClientImpl::dispatchDidChangeBackForwardIndex): dito.
* src/FrameLoaderClientImpl.h:

WebKit/gtk: 

* WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::dispatchDidAddBackForwardItem): Add an empty implementation. Method added to FrameLoaderClient by Android (see bug).
(WebKit::FrameLoaderClient::dispatchDidRemoveBackForwardItem): ditto.
(WebKit::FrameLoaderClient::dispatchDidChangeBackForwardIndex): ditto.
* WebCoreSupport/FrameLoaderClientGtk.h:

WebKit/haiku: 

* WebCoreSupport/FrameLoaderClientHaiku.cpp:
(WebCore::FrameLoaderClientHaiku::dispatchDidAddBackForwardItem): Add an empty implementation. Method added to FrameLoaderClient by Android (see bug).
(WebCore::FrameLoaderClientHaiku::dispatchDidRemoveBackForwardItem): ditto.
(WebCore::FrameLoaderClientHaiku::dispatchDidChangeBackForwardIndex): ditto.
* WebCoreSupport/FrameLoaderClientHaiku.h:

WebKit/mac: 

* WebCoreSupport/WebFrameLoaderClient.h:
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::dispatchDidAddBackForwardItem): Add an empty implementation. Method added to FrameLoaderClient by Android (see bug).
(WebFrameLoaderClient::dispatchDidRemoveBackForwardItem): ditto.
(WebFrameLoaderClient::dispatchDidChangeBackForwardIndex): ditto.

WebKit/qt: 

* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::dispatchDidAddBackForwardItem): Add an empty implementation. Method added to FrameLoaderClient by Android (see bug).
(WebCore::FrameLoaderClientQt::dispatchDidRemoveBackForwardItem): ditto.
(WebCore::FrameLoaderClientQt::dispatchDidChangeBackForwardIndex): ditto.
* WebCoreSupport/FrameLoaderClientQt.h:

WebKit/win: 

* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::dispatchDidAddBackForwardItem): Add an empty implementation. Method added to FrameLoaderClient by Android (see bug).
(WebFrameLoaderClient::dispatchDidRemoveBackForwardItem): ditto.
(WebFrameLoaderClient::dispatchDidChangeBackForwardIndex): ditto.
* WebCoreSupport/WebFrameLoaderClient.h:

WebKit/wx: 

* WebKitSupport/FrameLoaderClientWx.cpp:
(WebCore::FrameLoaderClientWx::dispatchDidAddBackForwardItem): Add an empty implementation. Method added to FrameLoaderClient by Android (see bug).
(WebCore::FrameLoaderClientWx::dispatchDidRemoveBackForwardItem): ditto.
(WebCore::FrameLoaderClientWx::dispatchDidChangeBackForwardIndex): ditto.
* WebKitSupport/FrameLoaderClientWx.h:</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkWebCoreChangeLog">trunk/WebCore/ChangeLog</a></li>
<li><a href="#trunkWebCorehistoryBackForwardListcpp">trunk/WebCore/history/BackForwardList.cpp</a></li>
<li><a href="#trunkWebCoreloaderEmptyClientsh">trunk/WebCore/loader/EmptyClients.h</a></li>
<li><a href="#trunkWebCoreloaderFrameLoaderClienth">trunk/WebCore/loader/FrameLoaderClient.h</a></li>
<li><a href="#trunkWebKitchromiumChangeLog">trunk/WebKit/chromium/ChangeLog</a></li>
<li><a href="#trunkWebKitchromiumsrcFrameLoaderClientImplcpp">trunk/WebKit/chromium/src/FrameLoaderClientImpl.cpp</a></li>
<li><a href="#trunkWebKitchromiumsrcFrameLoaderClientImplh">trunk/WebKit/chromium/src/FrameLoaderClientImpl.h</a></li>
<li><a href="#trunkWebKitgtkChangeLog">trunk/WebKit/gtk/ChangeLog</a></li>
<li><a href="#trunkWebKitgtkWebCoreSupportFrameLoaderClientGtkcpp">trunk/WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp</a></li>
<li><a href="#trunkWebKitgtkWebCoreSupportFrameLoaderClientGtkh">trunk/WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.h</a></li>
<li><a href="#trunkWebKithaikuChangeLog">trunk/WebKit/haiku/ChangeLog</a></li>
<li><a href="#trunkWebKithaikuWebCoreSupportFrameLoaderClientHaikucpp">trunk/WebKit/haiku/WebCoreSupport/FrameLoaderClientHaiku.cpp</a></li>
<li><a href="#trunkWebKithaikuWebCoreSupportFrameLoaderClientHaikuh">trunk/WebKit/haiku/WebCoreSupport/FrameLoaderClientHaiku.h</a></li>
<li><a href="#trunkWebKitmacChangeLog">trunk/WebKit/mac/ChangeLog</a></li>
<li><a href="#trunkWebKitmacWebCoreSupportWebFrameLoaderClienth">trunk/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.h</a></li>
<li><a href="#trunkWebKitmacWebCoreSupportWebFrameLoaderClientmm">trunk/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm</a></li>
<li><a href="#trunkWebKitqtChangeLog">trunk/WebKit/qt/ChangeLog</a></li>
<li><a href="#trunkWebKitqtWebCoreSupportFrameLoaderClientQtcpp">trunk/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp</a></li>
<li><a href="#trunkWebKitqtWebCoreSupportFrameLoaderClientQth">trunk/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.h</a></li>
<li><a href="#trunkWebKitwinChangeLog">trunk/WebKit/win/ChangeLog</a></li>
<li><a href="#trunkWebKitwinWebCoreSupportWebFrameLoaderClientcpp">trunk/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp</a></li>
<li><a href="#trunkWebKitwinWebCoreSupportWebFrameLoaderClienth">trunk/WebKit/win/WebCoreSupport/WebFrameLoaderClient.h</a></li>
<li><a href="#trunkWebKitwxChangeLog">trunk/WebKit/wx/ChangeLog</a></li>
<li><a href="#trunkWebKitwxWebKitSupportFrameLoaderClientWxcpp">trunk/WebKit/wx/WebKitSupport/FrameLoaderClientWx.cpp</a></li>
<li><a href="#trunkWebKitwxWebKitSupportFrameLoaderClientWxh">trunk/WebKit/wx/WebKitSupport/FrameLoaderClientWx.h</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/ChangeLog (51628 => 51629)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/ChangeLog        2009-12-03 11:52:29 UTC (rev 51628)
+++ trunk/WebCore/ChangeLog        2009-12-03 12:18:23 UTC (rev 51629)
</span><span class="lines">@@ -2,6 +2,29 @@
</span><span class="cx"> 
</span><span class="cx">         Reviewed by Brady Eidson.
</span><span class="cx"> 
</span><ins>+        [Android] The FrameLoaderClient is unaware of BackForwardList changes.
+        https://bugs.webkit.org/show_bug.cgi?id=31914
+
+        This change adds three new methods on the FrameLoaderClient interface to receive notifications when the BackForwardList changes.
+
+        No new tests required. Functionality on all platforms upstream remains the same. Android is the first platform to make use of these callbacks.
+
+        * history/BackForwardList.cpp:
+        (WebCore::BackForwardList::addItem): Execute the callback.
+        (WebCore::BackForwardList::goBack): ditto.
+        (WebCore::BackForwardList::goForward): ditto.
+        (WebCore::BackForwardList::goToItem): ditto.
+        (WebCore::BackForwardList::setCapacity): dito.
+        * loader/EmptyClients.h:
+        (WebCore::EmptyFrameLoaderClient::dispatchDidAddBackForwardItem): Add an empty implementation for the callback that does nothing.
+        (WebCore::EmptyFrameLoaderClient::dispatchDidRemoveBackForwardItem): ditto.
+        (WebCore::EmptyFrameLoaderClient::dispatchDidChangeBackForwardIndex): ditto.
+        * loader/FrameLoaderClient.h:
+
+2009-12-03  Ben Murdoch  &lt;benm@google.com&gt;
+
+        Reviewed by Brady Eidson.
+
</ins><span class="cx">         [Android] Upstream WebCore/history/android: Require some platform specific state attached to HistoryItem.
</span><span class="cx">         https://bugs.webkit.org/show_bug.cgi?id=31913
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkWebCorehistoryBackForwardListcpp"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/history/BackForwardList.cpp (51628 => 51629)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/history/BackForwardList.cpp        2009-12-03 11:52:29 UTC (rev 51628)
+++ trunk/WebCore/history/BackForwardList.cpp        2009-12-03 12:18:23 UTC (rev 51629)
</span><span class="lines">@@ -27,8 +27,12 @@
</span><span class="cx"> #include &quot;config.h&quot;
</span><span class="cx"> #include &quot;BackForwardList.h&quot;
</span><span class="cx"> 
</span><ins>+#include &quot;Frame.h&quot;
+#include &quot;FrameLoader.h&quot;
+#include &quot;FrameLoaderClient.h&quot;
</ins><span class="cx"> #include &quot;HistoryItem.h&quot;
</span><span class="cx"> #include &quot;Logging.h&quot;
</span><ins>+#include &quot;Page.h&quot;
</ins><span class="cx"> #include &quot;PageCache.h&quot;
</span><span class="cx"> 
</span><span class="cx"> using namespace std;
</span><span class="lines">@@ -77,25 +81,31 @@
</span><span class="cx">         m_entryHash.remove(item);
</span><span class="cx">         pageCache()-&gt;remove(item.get());
</span><span class="cx">         m_current--;
</span><ins>+        m_page-&gt;mainFrame()-&gt;loader()-&gt;client()-&gt;dispatchDidRemoveBackForwardItem(item.get());
</ins><span class="cx">     }
</span><span class="cx">     
</span><span class="cx">     m_entries.append(prpItem);
</span><span class="cx">     m_entryHash.add(m_entries.last());
</span><span class="cx">     m_current++;
</span><ins>+    m_page-&gt;mainFrame()-&gt;loader()-&gt;client()-&gt;dispatchDidAddBackForwardItem(currentItem());
</ins><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> void BackForwardList::goBack()
</span><span class="cx"> {
</span><span class="cx">     ASSERT(m_current &gt; 0);
</span><del>-    if (m_current &gt; 0)
</del><ins>+    if (m_current &gt; 0) {
</ins><span class="cx">         m_current--;
</span><ins>+        m_page-&gt;mainFrame()-&gt;loader()-&gt;client()-&gt;dispatchDidChangeBackForwardIndex();
+    }
</ins><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> void BackForwardList::goForward()
</span><span class="cx"> {
</span><span class="cx">     ASSERT(m_current &lt; m_entries.size() - 1);
</span><del>-    if (m_current &lt; m_entries.size() - 1)
</del><ins>+    if (m_current &lt; m_entries.size() - 1) {
</ins><span class="cx">         m_current++;
</span><ins>+        m_page-&gt;mainFrame()-&gt;loader()-&gt;client()-&gt;dispatchDidChangeBackForwardIndex();
+    }
</ins><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> void BackForwardList::goToItem(HistoryItem* item)
</span><span class="lines">@@ -107,8 +117,10 @@
</span><span class="cx">     for (; index &lt; m_entries.size(); ++index)
</span><span class="cx">         if (m_entries[index] == item)
</span><span class="cx">             break;
</span><del>-    if (index &lt; m_entries.size())
</del><ins>+    if (index &lt; m_entries.size()) {
</ins><span class="cx">         m_current = index;
</span><ins>+        m_page-&gt;mainFrame()-&gt;loader()-&gt;client()-&gt;dispatchDidChangeBackForwardIndex();
+    }
</ins><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> HistoryItem* BackForwardList::backItem()
</span><span class="lines">@@ -174,9 +186,10 @@
</span><span class="cx"> 
</span><span class="cx">     if (!size)
</span><span class="cx">         m_current = NoCurrentItemIndex;
</span><del>-    else if (m_current &gt; m_entries.size() - 1)
</del><ins>+    else if (m_current &gt; m_entries.size() - 1) {
</ins><span class="cx">         m_current = m_entries.size() - 1;
</span><del>-        
</del><ins>+        m_page-&gt;mainFrame()-&gt;loader()-&gt;client()-&gt;dispatchDidChangeBackForwardIndex();
+    }
</ins><span class="cx">     m_capacity = size;
</span><span class="cx"> }
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkWebCoreloaderEmptyClientsh"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/loader/EmptyClients.h (51628 => 51629)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/loader/EmptyClients.h        2009-12-03 11:52:29 UTC (rev 51628)
+++ trunk/WebCore/loader/EmptyClients.h        2009-12-03 12:18:23 UTC (rev 51629)
</span><span class="lines">@@ -281,6 +281,9 @@
</span><span class="cx">     virtual void updateGlobalHistory() { }
</span><span class="cx">     virtual void updateGlobalHistoryRedirectLinks() { }
</span><span class="cx">     virtual bool shouldGoToHistoryItem(HistoryItem*) const { return false; }
</span><ins>+    virtual void dispatchDidAddBackForwardItem(HistoryItem*) const { }
+    virtual void dispatchDidRemoveBackForwardItem(HistoryItem*) const { };
+    virtual void dispatchDidChangeBackForwardIndex() const { }
</ins><span class="cx">     virtual void saveViewStateToItem(HistoryItem*) { }
</span><span class="cx">     virtual bool canCachePage() const { return false; }
</span><span class="cx">     virtual void didDisplayInsecureContent() { }
</span></span></pre></div>
<a id="trunkWebCoreloaderFrameLoaderClienth"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/loader/FrameLoaderClient.h (51628 => 51629)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/loader/FrameLoaderClient.h        2009-12-03 11:52:29 UTC (rev 51628)
+++ trunk/WebCore/loader/FrameLoaderClient.h        2009-12-03 12:18:23 UTC (rev 51629)
</span><span class="lines">@@ -166,6 +166,9 @@
</span><span class="cx">         virtual void updateGlobalHistoryRedirectLinks() = 0;
</span><span class="cx"> 
</span><span class="cx">         virtual bool shouldGoToHistoryItem(HistoryItem*) const = 0;
</span><ins>+        virtual void dispatchDidAddBackForwardItem(HistoryItem*) const = 0;
+        virtual void dispatchDidRemoveBackForwardItem(HistoryItem*) const = 0;
+        virtual void dispatchDidChangeBackForwardIndex() const = 0;
</ins><span class="cx"> 
</span><span class="cx">         // This frame has displayed inactive content (such as an image) from an
</span><span class="cx">         // insecure source.  Inactive content cannot spread to other frames.
</span></span></pre></div>
<a id="trunkWebKitchromiumChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/WebKit/chromium/ChangeLog (51628 => 51629)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebKit/chromium/ChangeLog        2009-12-03 11:52:29 UTC (rev 51628)
+++ trunk/WebKit/chromium/ChangeLog        2009-12-03 12:18:23 UTC (rev 51629)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2009-12-03  Ben Murdoch  &lt;benm@google.com&gt;
+
+        Reviewed by Brady Eidson.
+
+        [Android] The FrameLoaderClient is unaware of BackForwardList changes.
+        https://bugs.webkit.org/show_bug.cgi?id=31914
+
+        * src/FrameLoaderClientImpl.cpp:
+        (WebKit::FrameLoaderClientImpl::dispatchDidAddBackForwardItem): Add an empty implementation. Method added to FrameLoaderClient by Android (see bug).
+        (WebKit::FrameLoaderClientImpl::dispatchDidRemoveBackForwardItem): ditto.
+        (WebKit::FrameLoaderClientImpl::dispatchDidChangeBackForwardIndex): dito.
+        * src/FrameLoaderClientImpl.h:
+
</ins><span class="cx"> 2009-12-02  Yusuke Sato  &lt;yusukes@chromium.org&gt;
</span><span class="cx"> 
</span><span class="cx">         Reviewed by Eric Seidel.
</span></span></pre></div>
<a id="trunkWebKitchromiumsrcFrameLoaderClientImplcpp"></a>
<div class="modfile"><h4>Modified: trunk/WebKit/chromium/src/FrameLoaderClientImpl.cpp (51628 => 51629)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebKit/chromium/src/FrameLoaderClientImpl.cpp        2009-12-03 11:52:29 UTC (rev 51628)
+++ trunk/WebKit/chromium/src/FrameLoaderClientImpl.cpp        2009-12-03 12:18:23 UTC (rev 51629)
</span><span class="lines">@@ -1056,6 +1056,18 @@
</span><span class="cx">     return true;
</span><span class="cx"> }
</span><span class="cx"> 
</span><ins>+void FrameLoaderClientImpl::dispatchDidAddBackForwardItem(HistoryItem*) const
+{
+}
+
+void FrameLoaderClientImpl::dispatchDidRemoveBackForwardItem(HistoryItem*) const
+{
+}
+
+void FrameLoaderClientImpl::dispatchDidChangeBackForwardIndex() const
+{
+}
+
</ins><span class="cx"> void FrameLoaderClientImpl::didDisplayInsecureContent()
</span><span class="cx"> {
</span><span class="cx">     if (m_webFrame-&gt;client())
</span></span></pre></div>
<a id="trunkWebKitchromiumsrcFrameLoaderClientImplh"></a>
<div class="modfile"><h4>Modified: trunk/WebKit/chromium/src/FrameLoaderClientImpl.h (51628 => 51629)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebKit/chromium/src/FrameLoaderClientImpl.h        2009-12-03 11:52:29 UTC (rev 51628)
+++ trunk/WebKit/chromium/src/FrameLoaderClientImpl.h        2009-12-03 12:18:23 UTC (rev 51629)
</span><span class="lines">@@ -131,6 +131,9 @@
</span><span class="cx">     virtual void updateGlobalHistory();
</span><span class="cx">     virtual void updateGlobalHistoryRedirectLinks();
</span><span class="cx">     virtual bool shouldGoToHistoryItem(WebCore::HistoryItem*) const;
</span><ins>+    virtual void dispatchDidAddBackForwardItem(WebCore::HistoryItem*) const;
+    virtual void dispatchDidRemoveBackForwardItem(WebCore::HistoryItem*) const;
+    virtual void dispatchDidChangeBackForwardIndex() const;
</ins><span class="cx">     virtual void didDisplayInsecureContent();
</span><span class="cx">     virtual void didRunInsecureContent(WebCore::SecurityOrigin*);
</span><span class="cx">     virtual WebCore::ResourceError blockedError(const WebCore::ResourceRequest&amp;);
</span></span></pre></div>
<a id="trunkWebKitgtkChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/WebKit/gtk/ChangeLog (51628 => 51629)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebKit/gtk/ChangeLog        2009-12-03 11:52:29 UTC (rev 51628)
+++ trunk/WebKit/gtk/ChangeLog        2009-12-03 12:18:23 UTC (rev 51629)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2009-12-03  Ben Murdoch  &lt;benm@google.com&gt;
+
+        Reviewed by Brady Eidson.
+
+        [Android] The FrameLoaderClient is unaware of BackForwardList changes.
+        https://bugs.webkit.org/show_bug.cgi?id=31914
+
+        * WebCoreSupport/FrameLoaderClientGtk.cpp:
+        (WebKit::FrameLoaderClient::dispatchDidAddBackForwardItem): Add an empty implementation. Method added to FrameLoaderClient by Android (see bug).
+        (WebKit::FrameLoaderClient::dispatchDidRemoveBackForwardItem): ditto.
+        (WebKit::FrameLoaderClient::dispatchDidChangeBackForwardIndex): ditto.
+        * WebCoreSupport/FrameLoaderClientGtk.h:
+
</ins><span class="cx"> 2009-12-01  Nikolas Zimmermann  &lt;nzimmermann@rim.com&gt;
</span><span class="cx"> 
</span><span class="cx">         Reviewed by Simon Fraser.
</span></span></pre></div>
<a id="trunkWebKitgtkWebCoreSupportFrameLoaderClientGtkcpp"></a>
<div class="modfile"><h4>Modified: trunk/WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp (51628 => 51629)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp        2009-12-03 11:52:29 UTC (rev 51628)
+++ trunk/WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp        2009-12-03 12:18:23 UTC (rev 51629)
</span><span class="lines">@@ -584,6 +584,18 @@
</span><span class="cx">     return item != 0;
</span><span class="cx"> }
</span><span class="cx"> 
</span><ins>+void FrameLoaderClient::dispatchDidAddBackForwardItem(HistoryItem*) const
+{
+}
+
+void FrameLoaderClient::dispatchDidRemoveBackForwardItem(HistoryItem*) const
+{
+}
+
+void FrameLoaderClient::dispatchDidChangeBackForwardIndex() const
+{
+}
+
</ins><span class="cx"> void FrameLoaderClient::didDisplayInsecureContent()
</span><span class="cx"> {
</span><span class="cx">     notImplemented();
</span></span></pre></div>
<a id="trunkWebKitgtkWebCoreSupportFrameLoaderClientGtkh"></a>
<div class="modfile"><h4>Modified: trunk/WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.h (51628 => 51629)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.h        2009-12-03 11:52:29 UTC (rev 51628)
+++ trunk/WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.h        2009-12-03 12:18:23 UTC (rev 51629)
</span><span class="lines">@@ -135,6 +135,9 @@
</span><span class="cx">         virtual void updateGlobalHistory();
</span><span class="cx">         virtual void updateGlobalHistoryRedirectLinks();
</span><span class="cx">         virtual bool shouldGoToHistoryItem(WebCore::HistoryItem*) const;
</span><ins>+        virtual void dispatchDidAddBackForwardItem(WebCore::HistoryItem*) const;
+        virtual void dispatchDidRemoveBackForwardItem(WebCore::HistoryItem*) const;
+        virtual void dispatchDidChangeBackForwardIndex() const;
</ins><span class="cx"> 
</span><span class="cx">         virtual void didDisplayInsecureContent();
</span><span class="cx">         virtual void didRunInsecureContent(WebCore::SecurityOrigin*);
</span></span></pre></div>
<a id="trunkWebKithaikuChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/WebKit/haiku/ChangeLog (51628 => 51629)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebKit/haiku/ChangeLog        2009-12-03 11:52:29 UTC (rev 51628)
+++ trunk/WebKit/haiku/ChangeLog        2009-12-03 12:18:23 UTC (rev 51629)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2009-12-03  Ben Murdoch  &lt;benm@google.com&gt;
+
+        Reviewed by Brady Eidson.
+
+        [Android] The FrameLoaderClient is unaware of BackForwardList changes.
+        https://bugs.webkit.org/show_bug.cgi?id=31914
+
+        * WebCoreSupport/FrameLoaderClientHaiku.cpp:
+        (WebCore::FrameLoaderClientHaiku::dispatchDidAddBackForwardItem): Add an empty implementation. Method added to FrameLoaderClient by Android (see bug).
+        (WebCore::FrameLoaderClientHaiku::dispatchDidRemoveBackForwardItem): ditto.
+        (WebCore::FrameLoaderClientHaiku::dispatchDidChangeBackForwardIndex): ditto.
+        * WebCoreSupport/FrameLoaderClientHaiku.h:
+
</ins><span class="cx"> 2009-11-13  Adam Roben  &lt;aroben@apple.com&gt;
</span><span class="cx"> 
</span><span class="cx">         Update for changes to FrameLoaderClient
</span></span></pre></div>
<a id="trunkWebKithaikuWebCoreSupportFrameLoaderClientHaikucpp"></a>
<div class="modfile"><h4>Modified: trunk/WebKit/haiku/WebCoreSupport/FrameLoaderClientHaiku.cpp (51628 => 51629)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebKit/haiku/WebCoreSupport/FrameLoaderClientHaiku.cpp        2009-12-03 11:52:29 UTC (rev 51628)
+++ trunk/WebKit/haiku/WebCoreSupport/FrameLoaderClientHaiku.cpp        2009-12-03 12:18:23 UTC (rev 51629)
</span><span class="lines">@@ -462,6 +462,18 @@
</span><span class="cx">     return true;
</span><span class="cx"> }
</span><span class="cx"> 
</span><ins>+void FrameLoaderClientHaiku::dispatchDidAddBackForwardItem(WebCore::HistoryItem*) const
+{
+}
+
+void FrameLoaderClientHaiku::dispatchDidRemoveBackForwardItem(WebCore::HistoryItem*) const
+{
+}
+
+void FrameLoaderClientHaiku::dispatchDidChangeBackForwardIndex() const
+{
+}
+
</ins><span class="cx"> void FrameLoaderClientHaiku::saveScrollPositionAndViewStateToItem(WebCore::HistoryItem*)
</span><span class="cx"> {
</span><span class="cx">     notImplemented();
</span></span></pre></div>
<a id="trunkWebKithaikuWebCoreSupportFrameLoaderClientHaikuh"></a>
<div class="modfile"><h4>Modified: trunk/WebKit/haiku/WebCoreSupport/FrameLoaderClientHaiku.h (51628 => 51629)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebKit/haiku/WebCoreSupport/FrameLoaderClientHaiku.h        2009-12-03 11:52:29 UTC (rev 51628)
+++ trunk/WebKit/haiku/WebCoreSupport/FrameLoaderClientHaiku.h        2009-12-03 12:18:23 UTC (rev 51629)
</span><span class="lines">@@ -150,6 +150,9 @@
</span><span class="cx">         virtual void updateGlobalHistory();
</span><span class="cx">         virtual void updateGlobalHistoryRedirectLinks();
</span><span class="cx">         virtual bool shouldGoToHistoryItem(HistoryItem*) const;
</span><ins>+        virtual void dispatchDidAddBackForwardItem(HistoryItem*) const;
+        virtual void dispatchDidRemoveBackForwardItem(HistoryItem*) const;
+        virtual void dispatchDidChangeBackForwardIndex() const;
</ins><span class="cx">         virtual void saveScrollPositionAndViewStateToItem(HistoryItem*);
</span><span class="cx">         virtual bool canCachePage() const;
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkWebKitmacChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/WebKit/mac/ChangeLog (51628 => 51629)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebKit/mac/ChangeLog        2009-12-03 11:52:29 UTC (rev 51628)
+++ trunk/WebKit/mac/ChangeLog        2009-12-03 12:18:23 UTC (rev 51629)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2009-12-03  Ben Murdoch  &lt;benm@google.com&gt;
+
+        Reviewed by Brady Eidson.
+
+        [Android] The FrameLoaderClient is unaware of BackForwardList changes.
+        https://bugs.webkit.org/show_bug.cgi?id=31914
+
+        * WebCoreSupport/WebFrameLoaderClient.h:
+        * WebCoreSupport/WebFrameLoaderClient.mm:
+        (WebFrameLoaderClient::dispatchDidAddBackForwardItem): Add an empty implementation. Method added to FrameLoaderClient by Android (see bug).
+        (WebFrameLoaderClient::dispatchDidRemoveBackForwardItem): ditto.
+        (WebFrameLoaderClient::dispatchDidChangeBackForwardIndex): ditto.
+
</ins><span class="cx"> 2009-12-02  Dan Bernstein  &lt;mitz@apple.com&gt;
</span><span class="cx"> 
</span><span class="cx">         Reviewed by Mark Rowe.
</span></span></pre></div>
<a id="trunkWebKitmacWebCoreSupportWebFrameLoaderClienth"></a>
<div class="modfile"><h4>Modified: trunk/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.h (51628 => 51629)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.h        2009-12-03 11:52:29 UTC (rev 51628)
+++ trunk/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.h        2009-12-03 12:18:23 UTC (rev 51629)
</span><span class="lines">@@ -143,6 +143,9 @@
</span><span class="cx">     virtual void updateGlobalHistoryRedirectLinks();
</span><span class="cx"> 
</span><span class="cx">     virtual bool shouldGoToHistoryItem(WebCore::HistoryItem*) const;
</span><ins>+    virtual void dispatchDidAddBackForwardItem(WebCore::HistoryItem*) const;
+    virtual void dispatchDidRemoveBackForwardItem(WebCore::HistoryItem*) const;
+    virtual void dispatchDidChangeBackForwardIndex() const;
</ins><span class="cx"> 
</span><span class="cx">     virtual void didDisplayInsecureContent();
</span><span class="cx">     virtual void didRunInsecureContent(WebCore::SecurityOrigin*);
</span></span></pre></div>
<a id="trunkWebKitmacWebCoreSupportWebFrameLoaderClientmm"></a>
<div class="modfile"><h4>Modified: trunk/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm (51628 => 51629)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm        2009-12-03 11:52:29 UTC (rev 51628)
+++ trunk/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm        2009-12-03 12:18:23 UTC (rev 51629)
</span><span class="lines">@@ -877,6 +877,18 @@
</span><span class="cx">     return [[view _policyDelegateForwarder] webView:view shouldGoToHistoryItem:webItem];
</span><span class="cx"> }
</span><span class="cx"> 
</span><ins>+void WebFrameLoaderClient::dispatchDidAddBackForwardItem(HistoryItem*) const
+{
+}
+
+void WebFrameLoaderClient::dispatchDidRemoveBackForwardItem(HistoryItem*) const
+{
+}
+
+void WebFrameLoaderClient::dispatchDidChangeBackForwardIndex() const
+{
+}
+
</ins><span class="cx"> void WebFrameLoaderClient::didDisplayInsecureContent()
</span><span class="cx"> {
</span><span class="cx">     WebView *webView = getWebView(m_webFrame.get());   
</span></span></pre></div>
<a id="trunkWebKitqtChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/WebKit/qt/ChangeLog (51628 => 51629)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebKit/qt/ChangeLog        2009-12-03 11:52:29 UTC (rev 51628)
+++ trunk/WebKit/qt/ChangeLog        2009-12-03 12:18:23 UTC (rev 51629)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2009-12-03  Ben Murdoch  &lt;benm@google.com&gt;
+
+        Reviewed by Brady Eidson.
+
+        [Android] The FrameLoaderClient is unaware of BackForwardList changes.
+        https://bugs.webkit.org/show_bug.cgi?id=31914
+
+        * WebCoreSupport/FrameLoaderClientQt.cpp:
+        (WebCore::FrameLoaderClientQt::dispatchDidAddBackForwardItem): Add an empty implementation. Method added to FrameLoaderClient by Android (see bug).
+        (WebCore::FrameLoaderClientQt::dispatchDidRemoveBackForwardItem): ditto.
+        (WebCore::FrameLoaderClientQt::dispatchDidChangeBackForwardIndex): ditto.
+        * WebCoreSupport/FrameLoaderClientQt.h:
+
</ins><span class="cx"> 2009-12-01  Nikolas Zimmermann  &lt;nzimmermann@rim.com&gt;
</span><span class="cx"> 
</span><span class="cx">         Not reviewed. Try to fix Qt build.
</span></span></pre></div>
<a id="trunkWebKitqtWebCoreSupportFrameLoaderClientQtcpp"></a>
<div class="modfile"><h4>Modified: trunk/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp (51628 => 51629)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp        2009-12-03 11:52:29 UTC (rev 51628)
+++ trunk/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp        2009-12-03 12:18:23 UTC (rev 51629)
</span><span class="lines">@@ -642,6 +642,18 @@
</span><span class="cx">     return true;
</span><span class="cx"> }
</span><span class="cx"> 
</span><ins>+void FrameLoaderClientQt::dispatchDidAddBackForwardItem(WebCore::HistoryItem*) const
+{
+}
+
+void FrameLoaderClientQt::dispatchDidRemoveBackForwardItem(WebCore::HistoryItem*) const
+{
+}
+
+void FrameLoaderClientQt::dispatchDidChangeBackForwardIndex() const
+{
+}
+
</ins><span class="cx"> void FrameLoaderClientQt::didDisplayInsecureContent()
</span><span class="cx"> {
</span><span class="cx">     notImplemented();
</span></span></pre></div>
<a id="trunkWebKitqtWebCoreSupportFrameLoaderClientQth"></a>
<div class="modfile"><h4>Modified: trunk/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.h (51628 => 51629)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.h        2009-12-03 11:52:29 UTC (rev 51628)
+++ trunk/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.h        2009-12-03 12:18:23 UTC (rev 51629)
</span><span class="lines">@@ -148,7 +148,9 @@
</span><span class="cx">         virtual void updateGlobalHistory();
</span><span class="cx">         virtual void updateGlobalHistoryRedirectLinks();
</span><span class="cx">         virtual bool shouldGoToHistoryItem(HistoryItem*) const;
</span><del>-
</del><ins>+        virtual void dispatchDidAddBackForwardItem(HistoryItem*) const;
+        virtual void dispatchDidRemoveBackForwardItem(HistoryItem*) const;
+        virtual void dispatchDidChangeBackForwardIndex() const;
</ins><span class="cx">         virtual void didDisplayInsecureContent();
</span><span class="cx">         virtual void didRunInsecureContent(SecurityOrigin*);
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkWebKitwinChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/WebKit/win/ChangeLog (51628 => 51629)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebKit/win/ChangeLog        2009-12-03 11:52:29 UTC (rev 51628)
+++ trunk/WebKit/win/ChangeLog        2009-12-03 12:18:23 UTC (rev 51629)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2009-12-03  Ben Murdoch  &lt;benm@google.com&gt;
+
+        Reviewed by Brady Eidson.
+
+        [Android] The FrameLoaderClient is unaware of BackForwardList changes.
+        https://bugs.webkit.org/show_bug.cgi?id=31914
+
+        * WebCoreSupport/WebFrameLoaderClient.cpp:
+        (WebFrameLoaderClient::dispatchDidAddBackForwardItem): Add an empty implementation. Method added to FrameLoaderClient by Android (see bug).
+        (WebFrameLoaderClient::dispatchDidRemoveBackForwardItem): ditto.
+        (WebFrameLoaderClient::dispatchDidChangeBackForwardIndex): ditto.
+        * WebCoreSupport/WebFrameLoaderClient.h:
+
</ins><span class="cx"> 2009-12-02  Timothy Hatcher  &lt;timothy@apple.com&gt;
</span><span class="cx"> 
</span><span class="cx">         Move setValueForUser to the end of the DOMHTMLInputElement interface
</span></span></pre></div>
<a id="trunkWebKitwinWebCoreSupportWebFrameLoaderClientcpp"></a>
<div class="modfile"><h4>Modified: trunk/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp (51628 => 51629)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp        2009-12-03 11:52:29 UTC (rev 51628)
+++ trunk/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp        2009-12-03 12:18:23 UTC (rev 51629)
</span><span class="lines">@@ -564,6 +564,18 @@
</span><span class="cx">     return true;
</span><span class="cx"> }
</span><span class="cx"> 
</span><ins>+void WebFrameLoaderClient::dispatchDidAddBackForwardItem(HistoryItem*) const
+{
+}
+
+void WebFrameLoaderClient::dispatchDidRemoveBackForwardItem(HistoryItem*) const
+{
+}
+
+void WebFrameLoaderClient::dispatchDidChangeBackForwardIndex() const
+{
+}
+
</ins><span class="cx"> void WebFrameLoaderClient::didDisplayInsecureContent()
</span><span class="cx"> {
</span><span class="cx">     WebView* webView = m_webFrame-&gt;webView();
</span></span></pre></div>
<a id="trunkWebKitwinWebCoreSupportWebFrameLoaderClienth"></a>
<div class="modfile"><h4>Modified: trunk/WebKit/win/WebCoreSupport/WebFrameLoaderClient.h (51628 => 51629)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebKit/win/WebCoreSupport/WebFrameLoaderClient.h        2009-12-03 11:52:29 UTC (rev 51628)
+++ trunk/WebKit/win/WebCoreSupport/WebFrameLoaderClient.h        2009-12-03 12:18:23 UTC (rev 51629)
</span><span class="lines">@@ -91,6 +91,9 @@
</span><span class="cx">     virtual void updateGlobalHistory();
</span><span class="cx">     virtual void updateGlobalHistoryRedirectLinks();
</span><span class="cx">     virtual bool shouldGoToHistoryItem(WebCore::HistoryItem*) const;
</span><ins>+    virtual void dispatchDidAddBackForwardItem(WebCore::HistoryItem*) const;
+    virtual void dispatchDidRemoveBackForwardItem(WebCore::HistoryItem*) const;
+    virtual void dispatchDidChangeBackForwardIndex() const;
</ins><span class="cx"> 
</span><span class="cx">     virtual void didDisplayInsecureContent();
</span><span class="cx">     virtual void didRunInsecureContent(WebCore::SecurityOrigin*);
</span></span></pre></div>
<a id="trunkWebKitwxChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/WebKit/wx/ChangeLog (51628 => 51629)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebKit/wx/ChangeLog        2009-12-03 11:52:29 UTC (rev 51628)
+++ trunk/WebKit/wx/ChangeLog        2009-12-03 12:18:23 UTC (rev 51629)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2009-12-03  Ben Murdoch  &lt;benm@google.com&gt;
+
+        Reviewed by Brady Eidson.
+
+        [Android] The FrameLoaderClient is unaware of BackForwardList changes.
+        https://bugs.webkit.org/show_bug.cgi?id=31914
+
+        * WebKitSupport/FrameLoaderClientWx.cpp:
+        (WebCore::FrameLoaderClientWx::dispatchDidAddBackForwardItem): Add an empty implementation. Method added to FrameLoaderClient by Android (see bug).
+        (WebCore::FrameLoaderClientWx::dispatchDidRemoveBackForwardItem): ditto.
+        (WebCore::FrameLoaderClientWx::dispatchDidChangeBackForwardIndex): ditto.
+        * WebKitSupport/FrameLoaderClientWx.h:
+
</ins><span class="cx"> 2009-11-23  Laszlo Gombos  &lt;laszlo.1.gombos@nokia.com&gt;
</span><span class="cx"> 
</span><span class="cx">         Reviewed by Kenneth Rohde Christiansen.
</span></span></pre></div>
<a id="trunkWebKitwxWebKitSupportFrameLoaderClientWxcpp"></a>
<div class="modfile"><h4>Modified: trunk/WebKit/wx/WebKitSupport/FrameLoaderClientWx.cpp (51628 => 51629)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebKit/wx/WebKitSupport/FrameLoaderClientWx.cpp        2009-12-03 11:52:29 UTC (rev 51628)
+++ trunk/WebKit/wx/WebKitSupport/FrameLoaderClientWx.cpp        2009-12-03 12:18:23 UTC (rev 51629)
</span><span class="lines">@@ -547,6 +547,18 @@
</span><span class="cx">     return true;
</span><span class="cx"> }
</span><span class="cx"> 
</span><ins>+void FrameLoaderClientWx::dispatchDidAddBackForwardItem(WebCore::HistoryItem*) const
+{
+}
+
+void FrameLoaderClientWx::dispatchDidRemoveBackForwardItem(WebCore::HistoryItem*) const
+{
+}
+
+void FrameLoaderClientWx::dispatchDidChangeBackForwardIndex() const
+{
+}
+
</ins><span class="cx"> void FrameLoaderClientWx::didDisplayInsecureContent()
</span><span class="cx"> {
</span><span class="cx">     notImplemented();
</span></span></pre></div>
<a id="trunkWebKitwxWebKitSupportFrameLoaderClientWxh"></a>
<div class="modfile"><h4>Modified: trunk/WebKit/wx/WebKitSupport/FrameLoaderClientWx.h (51628 => 51629)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebKit/wx/WebKitSupport/FrameLoaderClientWx.h        2009-12-03 11:52:29 UTC (rev 51628)
+++ trunk/WebKit/wx/WebKitSupport/FrameLoaderClientWx.h        2009-12-03 12:18:23 UTC (rev 51629)
</span><span class="lines">@@ -149,6 +149,9 @@
</span><span class="cx">         virtual void updateGlobalHistory();
</span><span class="cx">         virtual void updateGlobalHistoryRedirectLinks();
</span><span class="cx">         virtual bool shouldGoToHistoryItem(HistoryItem*) const;
</span><ins>+        virtual void dispatchDidAddBackForwardItem(HistoryItem*) const;
+        virtual void dispatchDidRemoveBackForwardItem(HistoryItem*) const;
+        virtual void dispatchDidChangeBackForwardIndex() const;
</ins><span class="cx">         virtual void saveScrollPositionAndViewStateToItem(HistoryItem*);
</span><span class="cx">         virtual bool canCachePage() const;
</span><span class="cx">         
</span></span></pre>
</div>
</div>

</body>
</html>