<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[50928] trunk</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/50928">50928</a></dd>
<dt>Author</dt> <dd>dumi@chromium.org</dd>
<dt>Date</dt> <dd>2009-11-12 21:17:55 -0800 (Thu, 12 Nov 2009)</dd>
</dl>

<h3>Log Message</h3>
<pre>Renaming some parameters passed to DB-related methods to better
indicate their purpose.

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=31449

WebCore: 

* platform/chromium/ChromiumBridge.h:

WebKit/chromium: 

* public/WebKitClient.h:
* src/ChromiumBridge.cpp:
(WebCore::ChromiumBridge::databaseOpenFile):
(WebCore::ChromiumBridge::databaseDeleteFile):
(WebCore::ChromiumBridge::databaseGetFileAttributes):
(WebCore::ChromiumBridge::databaseGetFileSize):</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkWebCoreChangeLog">trunk/WebCore/ChangeLog</a></li>
<li><a href="#trunkWebCoreplatformchromiumChromiumBridgeh">trunk/WebCore/platform/chromium/ChromiumBridge.h</a></li>
<li><a href="#trunkWebKitchromiumChangeLog">trunk/WebKit/chromium/ChangeLog</a></li>
<li><a href="#trunkWebKitchromiumpublicWebKitClienth">trunk/WebKit/chromium/public/WebKitClient.h</a></li>
<li><a href="#trunkWebKitchromiumsrcChromiumBridgecpp">trunk/WebKit/chromium/src/ChromiumBridge.cpp</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/ChangeLog (50927 => 50928)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/ChangeLog        2009-11-13 05:08:00 UTC (rev 50927)
+++ trunk/WebCore/ChangeLog        2009-11-13 05:17:55 UTC (rev 50928)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2009-11-12  Dumitru Daniliuc  &lt;dumi@chromium.org&gt;
+
+        Reviewed by Dimitri Glazkov.
+
+        Renaming some parameters passed to DB-related methods to better
+        indicate their purpose.
+
+        https://bugs.webkit.org/show_bug.cgi?id=31449
+
+        * platform/chromium/ChromiumBridge.h:
+
</ins><span class="cx"> 2009-11-12  Simon Fraser  &lt;simon.fraser@apple.com&gt;
</span><span class="cx"> 
</span><span class="cx">         Reviewed by Dan Bernstein.
</span></span></pre></div>
<a id="trunkWebCoreplatformchromiumChromiumBridgeh"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/platform/chromium/ChromiumBridge.h (50927 => 50928)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/platform/chromium/ChromiumBridge.h        2009-11-13 05:08:00 UTC (rev 50927)
+++ trunk/WebCore/platform/chromium/ChromiumBridge.h        2009-11-13 05:17:55 UTC (rev 50928)
</span><span class="lines">@@ -118,13 +118,13 @@
</span><span class="cx">         // HTML5 DB -----------------------------------------------------------
</span><span class="cx"> #if ENABLE(DATABASE)
</span><span class="cx">         // Returns a handle to the DB file and ooptionally a handle to its containing directory
</span><del>-        static PlatformFileHandle databaseOpenFile(const String&amp; fileName, int desiredFlags, PlatformFileHandle* dirHandle = 0);
</del><ins>+        static PlatformFileHandle databaseOpenFile(const String&amp; vfsFleName, int desiredFlags, PlatformFileHandle* dirHandle = 0);
</ins><span class="cx">         // Returns a SQLite code (SQLITE_OK = 0, on success)
</span><del>-        static int databaseDeleteFile(const String&amp; fileName, bool syncDir = false);
</del><ins>+        static int databaseDeleteFile(const String&amp; vfsFileName, bool syncDir = false);
</ins><span class="cx">         // Returns the attributes of the DB file
</span><del>-        static long databaseGetFileAttributes(const String&amp; fileName);
</del><ins>+        static long databaseGetFileAttributes(const String&amp; vfsFileName);
</ins><span class="cx">         // Returns the size of the DB file
</span><del>-        static long long databaseGetFileSize(const String&amp; fileName);
</del><ins>+        static long long databaseGetFileSize(const String&amp; vfsFileName);
</ins><span class="cx"> #endif
</span><span class="cx"> 
</span><span class="cx">         // JavaScript ---------------------------------------------------------
</span></span></pre></div>
<a id="trunkWebKitchromiumChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/WebKit/chromium/ChangeLog (50927 => 50928)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebKit/chromium/ChangeLog        2009-11-13 05:08:00 UTC (rev 50927)
+++ trunk/WebKit/chromium/ChangeLog        2009-11-13 05:17:55 UTC (rev 50928)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2009-11-12  Dumitru Daniliuc  &lt;dumi@chromium.org&gt;
+
+        Reviewed by Dimitri Glazkov.
+
+        Renaming some parameters passed to DB-related methods to better
+        indicate their purpose.
+
+        https://bugs.webkit.org/show_bug.cgi?id=31449
+
+        * public/WebKitClient.h:
+        * src/ChromiumBridge.cpp:
+        (WebCore::ChromiumBridge::databaseOpenFile):
+        (WebCore::ChromiumBridge::databaseDeleteFile):
+        (WebCore::ChromiumBridge::databaseGetFileAttributes):
+        (WebCore::ChromiumBridge::databaseGetFileSize):
+
</ins><span class="cx"> 2009-11-12  Adam Barth  &lt;abarth&gt;
</span><span class="cx"> 
</span><span class="cx">         Reviewed by Dimitri Glazkov.
</span></span></pre></div>
<a id="trunkWebKitchromiumpublicWebKitClienth"></a>
<div class="modfile"><h4>Modified: trunk/WebKit/chromium/public/WebKitClient.h (50927 => 50928)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebKit/chromium/public/WebKitClient.h        2009-11-13 05:08:00 UTC (rev 50927)
+++ trunk/WebKit/chromium/public/WebKitClient.h        2009-11-13 05:17:55 UTC (rev 50928)
</span><span class="lines">@@ -137,16 +137,16 @@
</span><span class="cx">     // Opens a database file; dirHandle should be 0 if the caller does not need
</span><span class="cx">     // a handle to the directory containing this file
</span><span class="cx">     virtual FileHandle databaseOpenFile(
</span><del>-        const WebString&amp; fileName, int desiredFlags, FileHandle* dirHandle) = 0;
</del><ins>+        const WebString&amp; vfsFileName, int desiredFlags, FileHandle* dirHandle) = 0;
</ins><span class="cx"> 
</span><span class="cx">     // Deletes a database file and returns the error code
</span><del>-    virtual int databaseDeleteFile(const WebString&amp; fileName, bool syncDir) = 0;
</del><ins>+    virtual int databaseDeleteFile(const WebString&amp; vfsFileName, bool syncDir) = 0;
</ins><span class="cx"> 
</span><span class="cx">     // Returns the attributes of the given database file
</span><del>-    virtual long databaseGetFileAttributes(const WebString&amp; fileName) = 0;
</del><ins>+    virtual long databaseGetFileAttributes(const WebString&amp; vfsFileName) = 0;
</ins><span class="cx"> 
</span><span class="cx">     // Returns the size of the given database file
</span><del>-    virtual long long databaseGetFileSize(const WebString&amp; fileName) = 0;
</del><ins>+    virtual long long databaseGetFileSize(const WebString&amp; vfsFileName) = 0;
</ins><span class="cx"> 
</span><span class="cx"> 
</span><span class="cx">     // Keygen --------------------------------------------------------------
</span></span></pre></div>
<a id="trunkWebKitchromiumsrcChromiumBridgecpp"></a>
<div class="modfile"><h4>Modified: trunk/WebKit/chromium/src/ChromiumBridge.cpp (50927 => 50928)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebKit/chromium/src/ChromiumBridge.cpp        2009-11-13 05:08:00 UTC (rev 50927)
+++ trunk/WebKit/chromium/src/ChromiumBridge.cpp        2009-11-13 05:17:55 UTC (rev 50928)
</span><span class="lines">@@ -306,24 +306,24 @@
</span><span class="cx"> // HTML5 DB -------------------------------------------------------------------
</span><span class="cx"> 
</span><span class="cx"> #if ENABLE(DATABASE)
</span><del>-PlatformFileHandle ChromiumBridge::databaseOpenFile(const String&amp; fileName, int desiredFlags, PlatformFileHandle* dirHandle)
</del><ins>+PlatformFileHandle ChromiumBridge::databaseOpenFile(const String&amp; vfsFileName, int desiredFlags, PlatformFileHandle* dirHandle)
</ins><span class="cx"> {
</span><del>-    return webKitClient()-&gt;databaseOpenFile(WebString(fileName), desiredFlags, dirHandle);
</del><ins>+    return webKitClient()-&gt;databaseOpenFile(WebString(vfsFileName), desiredFlags, dirHandle);
</ins><span class="cx"> }
</span><span class="cx"> 
</span><del>-int ChromiumBridge::databaseDeleteFile(const String&amp; fileName, bool syncDir)
</del><ins>+int ChromiumBridge::databaseDeleteFile(const String&amp; vfsFileName, bool syncDir)
</ins><span class="cx"> {
</span><del>-    return webKitClient()-&gt;databaseDeleteFile(WebString(fileName), syncDir);
</del><ins>+    return webKitClient()-&gt;databaseDeleteFile(WebString(vfsFileName), syncDir);
</ins><span class="cx"> }
</span><span class="cx"> 
</span><del>-long ChromiumBridge::databaseGetFileAttributes(const String&amp; fileName)
</del><ins>+long ChromiumBridge::databaseGetFileAttributes(const String&amp; vfsFileName)
</ins><span class="cx"> {
</span><del>-    return webKitClient()-&gt;databaseGetFileAttributes(WebString(fileName));
</del><ins>+    return webKitClient()-&gt;databaseGetFileAttributes(WebString(vfsFileName));
</ins><span class="cx"> }
</span><span class="cx"> 
</span><del>-long long ChromiumBridge::databaseGetFileSize(const String&amp; fileName)
</del><ins>+long long ChromiumBridge::databaseGetFileSize(const String&amp; vfsFileName)
</ins><span class="cx"> {
</span><del>-    return webKitClient()-&gt;databaseGetFileSize(WebString(fileName));
</del><ins>+    return webKitClient()-&gt;databaseGetFileSize(WebString(vfsFileName));
</ins><span class="cx"> }
</span><span class="cx"> #endif
</span><span class="cx"> 
</span></span></pre>
</div>
</div>

</body>
</html>