<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[50909] trunk/WebCore</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/50909">50909</a></dd>
<dt>Author</dt> <dd>pfeldman@chromium.org</dd>
<dt>Date</dt> <dd>2009-11-12 15:07:25 -0800 (Thu, 12 Nov 2009)</dd>
</dl>

<h3>Log Message</h3>
<pre>2009-11-12  Pavel Feldman  &lt;pfeldman@chromium.org&gt;

        Reviewed by Timothy Hatcher.

        Web Inspector: profile timeline panel, fix obvious problems.

        https://bugs.webkit.org/show_bug.cgi?id=31432

        * inspector/front-end/AbstractTimelinePanel.js:
        (WebInspector.AbstractTimelinePanel.prototype.updateGraphDividersIfNeeded):
        * inspector/front-end/TimelinePanel.js:
        (WebInspector.TimelinePanel.prototype._setWindowPosition):
        (WebInspector.TimelineCalculator):
        (WebInspector.TimelineCalculator.prototype.get minimumBoundary):
        (WebInspector.TimelineCalculator.prototype.get maximumBoundary):
        (WebInspector.TimelineCalculator.prototype.reset):
        (WebInspector.TimelineCalculator.prototype.updateBoundaries):
        (WebInspector.TimelineCalculator.prototype.formatValue):
        (WebInspector.TimelineGraph):
        (WebInspector.TimelineGraph.prototype.refresh):
        * inspector/front-end/utilities.js:
        (Element.prototype.hasStyleClass):</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkWebCoreChangeLog">trunk/WebCore/ChangeLog</a></li>
<li><a href="#trunkWebCoreinspectorfrontendAbstractTimelinePaneljs">trunk/WebCore/inspector/front-end/AbstractTimelinePanel.js</a></li>
<li><a href="#trunkWebCoreinspectorfrontendTimelinePaneljs">trunk/WebCore/inspector/front-end/TimelinePanel.js</a></li>
<li><a href="#trunkWebCoreinspectorfrontendutilitiesjs">trunk/WebCore/inspector/front-end/utilities.js</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/ChangeLog (50908 => 50909)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/ChangeLog        2009-11-12 23:04:24 UTC (rev 50908)
+++ trunk/WebCore/ChangeLog        2009-11-12 23:07:25 UTC (rev 50909)
</span><span class="lines">@@ -2,6 +2,29 @@
</span><span class="cx"> 
</span><span class="cx">         Reviewed by Timothy Hatcher.
</span><span class="cx"> 
</span><ins>+        Web Inspector: profile timeline panel, fix obvious problems.
+
+        https://bugs.webkit.org/show_bug.cgi?id=31432
+
+        * inspector/front-end/AbstractTimelinePanel.js:
+        (WebInspector.AbstractTimelinePanel.prototype.updateGraphDividersIfNeeded):
+        * inspector/front-end/TimelinePanel.js:
+        (WebInspector.TimelinePanel.prototype._setWindowPosition):
+        (WebInspector.TimelineCalculator):
+        (WebInspector.TimelineCalculator.prototype.get minimumBoundary):
+        (WebInspector.TimelineCalculator.prototype.get maximumBoundary):
+        (WebInspector.TimelineCalculator.prototype.reset):
+        (WebInspector.TimelineCalculator.prototype.updateBoundaries):
+        (WebInspector.TimelineCalculator.prototype.formatValue):
+        (WebInspector.TimelineGraph):
+        (WebInspector.TimelineGraph.prototype.refresh):
+        * inspector/front-end/utilities.js:
+        (Element.prototype.hasStyleClass):
+
+2009-11-12  Pavel Feldman  &lt;pfeldman@chromium.org&gt;
+
+        Reviewed by Timothy Hatcher.
+
</ins><span class="cx">         Web Inspector: preload status bar button glyphs
</span><span class="cx">         in order to prevent them from flickering.
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkWebCoreinspectorfrontendAbstractTimelinePaneljs"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/inspector/front-end/AbstractTimelinePanel.js (50908 => 50909)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/inspector/front-end/AbstractTimelinePanel.js        2009-11-12 23:04:24 UTC (rev 50908)
+++ trunk/WebCore/inspector/front-end/AbstractTimelinePanel.js        2009-11-12 23:07:25 UTC (rev 50909)
</span><span class="lines">@@ -209,13 +209,6 @@
</span><span class="cx">             this.needsRefresh = true;
</span><span class="cx">             return false;
</span><span class="cx">         }
</span><del>-
-        if (document.body.offsetWidth &lt;= 0) {
-            // The stylesheet hasn't loaded yet or the window is closed,
-            // so we can't calculate what is need. Return early.
-            return false;
-        }
-
</del><span class="cx">         return this._timelineGrid.updateDividers(force, this.calculator);
</span><span class="cx">     },
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkWebCoreinspectorfrontendTimelinePaneljs"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/inspector/front-end/TimelinePanel.js (50908 => 50909)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/inspector/front-end/TimelinePanel.js        2009-11-12 23:04:24 UTC (rev 50908)
+++ trunk/WebCore/inspector/front-end/TimelinePanel.js        2009-11-12 23:07:25 UTC (rev 50909)
</span><span class="lines">@@ -417,21 +417,23 @@
</span><span class="cx">         this.calculator.reset();
</span><span class="cx">         this.invalidateAllItems();
</span><span class="cx">         if (typeof start === &quot;number&quot;) {
</span><del>-          if (start &gt; this._rightResizeElement.offsetLeft - 25)
-              start = this._rightResizeElement.offsetLeft - 25;
</del><ins>+            if (start &gt; this._rightResizeElement.offsetLeft - 25)
+                start = this._rightResizeElement.offsetLeft - 25;
</ins><span class="cx"> 
</span><del>-          this.calculator.windowLeft = start / this._overviewGridElement.clientWidth;
-          this._leftResizeElement.style.left = this.calculator.windowLeft*100 + &quot;%&quot;;
-          this._overviewWindowElement.style.left = this.calculator.windowLeft*100 + &quot;%&quot;;
</del><ins>+            var windowLeft = start / this._overviewGridElement.clientWidth;
+            this.calculator.windowLeft = windowLeft;
+            this._leftResizeElement.style.left = windowLeft * 100 + &quot;%&quot;;
+            this._overviewWindowElement.style.left = windowLeft * 100 + &quot;%&quot;;
</ins><span class="cx">         }
</span><span class="cx">         if (typeof end === &quot;number&quot;) {
</span><span class="cx">             if (end &lt; this._leftResizeElement.offsetLeft + 30)
</span><span class="cx">                 end = this._leftResizeElement.offsetLeft + 30;
</span><span class="cx"> 
</span><del>-            this.calculator.windowRight = end / this._overviewGridElement.clientWidth;
-            this._rightResizeElement.style.left = this.calculator.windowRight*100 + &quot;%&quot;;
</del><ins>+            var windowRight = end / this._overviewGridElement.clientWidth;
+            this.calculator.windowRight = windowRight;
+            this._rightResizeElement.style.left = windowRight * 100 + &quot;%&quot;;
</ins><span class="cx">         }
</span><del>-        this._overviewWindowElement.style.width = (this.calculator.windowRight - this.calculator.windowLeft)*100 + &quot;%&quot;;
</del><ins>+        this._overviewWindowElement.style.width = (this.calculator.windowRight - this.calculator.windowLeft) * 100 + &quot;%&quot;;
</ins><span class="cx">         this.needsRefresh = true;
</span><span class="cx">     },
</span><span class="cx"> 
</span><span class="lines">@@ -540,7 +542,8 @@
</span><span class="cx">         }
</span><span class="cx">     },
</span><span class="cx"> 
</span><del>-    _updateDetails: function() {
</del><ins>+    _updateDetails: function()
+    {
</ins><span class="cx">         if (this.dataElement &amp;&amp; this._record.details !== this._details) {
</span><span class="cx">             this._details = this._record.details;
</span><span class="cx">             this.dataElement.textContent = &quot;(&quot; + this._details + &quot;)&quot;;
</span><span class="lines">@@ -573,6 +576,7 @@
</span><span class="cx">     WebInspector.AbstractTimelineCalculator.call(this);
</span><span class="cx">     this.windowLeft = 0.0;
</span><span class="cx">     this.windowRight = 1.0;
</span><ins>+    this._uiString = WebInspector.UIString.bind(WebInspector);
</ins><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> WebInspector.TimelineCalculator.prototype = {
</span><span class="lines">@@ -595,22 +599,34 @@
</span><span class="cx"> 
</span><span class="cx">     get minimumBoundary()
</span><span class="cx">     {
</span><ins>+        if (typeof this._minimumBoundary === &quot;number&quot;)
+            return this._minimumBoundary;
+
</ins><span class="cx">         if (typeof this.windowLeft === &quot;number&quot;)
</span><del>-            return this._absoluteMinimumBoundary + this.windowLeft * (this._absoluteMaximumBoundary - this._absoluteMinimumBoundary);
-        return this._absoluteMinimumBoundary;
</del><ins>+            this._minimumBoundary = this._absoluteMinimumBoundary + this.windowLeft * (this._absoluteMaximumBoundary - this._absoluteMinimumBoundary);
+        else
+            this._minimumBoundary = this._absoluteMinimumBoundary;
+        return this._minimumBoundary;
</ins><span class="cx">     },
</span><span class="cx"> 
</span><span class="cx">     get maximumBoundary()
</span><span class="cx">     {
</span><ins>+        if (typeof this._maximumBoundary === &quot;number&quot;)
+            return this._maximumBoundary;
+
</ins><span class="cx">         if (typeof this.windowLeft === &quot;number&quot;)
</span><del>-            return this._absoluteMinimumBoundary + this.windowRight * (this._absoluteMaximumBoundary - this._absoluteMinimumBoundary);
-        return this._absoluteMaximumBoundary;
</del><ins>+            this._maximumBoundary = this._absoluteMinimumBoundary + this.windowRight * (this._absoluteMaximumBoundary - this._absoluteMinimumBoundary);
+        else
+            this._maximumBoundary = this._absoluteMaximumBoundary;
+        return this._maximumBoundary;
</ins><span class="cx">     },
</span><span class="cx"> 
</span><span class="cx">     reset: function()
</span><span class="cx">     {
</span><span class="cx">         delete this._absoluteMinimumBoundary;
</span><span class="cx">         delete this._absoluteMaximumBoundary;
</span><ins>+        delete this._minimumBoundary;
+        delete this._maximumBoundary;
</ins><span class="cx">     },
</span><span class="cx"> 
</span><span class="cx">     updateBoundaries: function(record)
</span><span class="lines">@@ -621,12 +637,14 @@
</span><span class="cx"> 
</span><span class="cx">         if (typeof this._absoluteMinimumBoundary === &quot;undefined&quot; || lowerBound &lt; this._absoluteMinimumBoundary) {
</span><span class="cx">             this._absoluteMinimumBoundary = lowerBound;
</span><ins>+            delete this._minimumBoundary;
</ins><span class="cx">             didChange = true;
</span><span class="cx">         }
</span><span class="cx"> 
</span><span class="cx">         var upperBound = record.endTime;
</span><span class="cx">         if (typeof this._absoluteMaximumBoundary === &quot;undefined&quot; || upperBound &gt; this._absoluteMaximumBoundary) {
</span><span class="cx">             this._absoluteMaximumBoundary = upperBound;
</span><ins>+            delete this._maximumBoundary;
</ins><span class="cx">             didChange = true;
</span><span class="cx">         }
</span><span class="cx"> 
</span><span class="lines">@@ -635,7 +653,7 @@
</span><span class="cx"> 
</span><span class="cx">     formatValue: function(value)
</span><span class="cx">     {
</span><del>-        return Number.secondsToString(value + this.minimumBoundary - this._absoluteMinimumBoundary, WebInspector.UIString.bind(WebInspector));
</del><ins>+        return Number.secondsToString(value + this.minimumBoundary - this._absoluteMinimumBoundary, this._uiString);
</ins><span class="cx">     }
</span><span class="cx"> }
</span><span class="cx"> 
</span><span class="lines">@@ -700,6 +718,7 @@
</span><span class="cx">     this._barAreaElement.appendChild(this._barElement);
</span><span class="cx"> 
</span><span class="cx">     this._graphElement.addStyleClass(&quot;timeline-category-&quot; + record.category.name);
</span><ins>+    this._hidden = false;
</ins><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> WebInspector.TimelineGraph.prototype = {
</span><span class="lines">@@ -720,13 +739,19 @@
</span><span class="cx">         this._percentages = percentages;
</span><span class="cx"> 
</span><span class="cx">         if (percentages.start &gt; 100 || percentages.end &lt; 0) {
</span><del>-            this._graphElement.addStyleClass(&quot;hidden&quot;);
-            this.record._itemsTreeElement.listItemElement.addStyleClass(&quot;hidden&quot;);
</del><ins>+            if (!this._hidden) {
+                this._graphElement.addStyleClass(&quot;hidden&quot;);
+                this.record._itemsTreeElement.listItemElement.addStyleClass(&quot;hidden&quot;);
+                this._hidden = true;
+            }
</ins><span class="cx">         } else {
</span><span class="cx">             this._barElement.style.setProperty(&quot;left&quot;, percentages.start + &quot;%&quot;);
</span><span class="cx">             this._barElement.style.setProperty(&quot;right&quot;, (100 - percentages.end) + &quot;%&quot;);
</span><del>-            this._graphElement.removeStyleClass(&quot;hidden&quot;);
-            this.record._itemsTreeElement.listItemElement.removeStyleClass(&quot;hidden&quot;);
</del><ins>+            if (this._hidden) {
+                this._graphElement.removeStyleClass(&quot;hidden&quot;);
+                this.record._itemsTreeElement.listItemElement.removeStyleClass(&quot;hidden&quot;);
+                this._hidden = false;
+            }
</ins><span class="cx">         }
</span><span class="cx">         var tooltip = (labels.tooltip || &quot;&quot;);
</span><span class="cx">         this._barElement.title = tooltip;
</span></span></pre></div>
<a id="trunkWebCoreinspectorfrontendutilitiesjs"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/inspector/front-end/utilities.js (50908 => 50909)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/inspector/front-end/utilities.js        2009-11-12 23:04:24 UTC (rev 50908)
+++ trunk/WebCore/inspector/front-end/utilities.js        2009-11-12 23:07:25 UTC (rev 50909)
</span><span class="lines">@@ -147,13 +147,18 @@
</span><span class="cx"> 
</span><span class="cx"> Element.prototype.removeStyleClass = function(className) 
</span><span class="cx"> {
</span><del>-    // Test for the simple case before using a RegExp.
</del><ins>+    // Test for the simple case first.
</ins><span class="cx">     if (this.className === className) {
</span><span class="cx">         this.className = &quot;&quot;;
</span><span class="cx">         return;
</span><span class="cx">     }
</span><span class="cx"> 
</span><del>-    this.removeMatchingStyleClasses(className.escapeForRegExp());
</del><ins>+    var index = this.className.indexOf(className);
+    if (index === -1)
+        return;
+
+    var newClassName = &quot; &quot; + this.className + &quot; &quot;;
+    this.className = newClassName.replace(&quot; &quot; + className + &quot; &quot;, &quot; &quot;);
</ins><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> Element.prototype.removeMatchingStyleClasses = function(classNameRegex)
</span><span class="lines">@@ -176,8 +181,12 @@
</span><span class="cx">     // Test for the simple case before using a RegExp.
</span><span class="cx">     if (this.className === className)
</span><span class="cx">         return true;
</span><del>-    var regex = new RegExp(&quot;(^|\\s)&quot; + className.escapeForRegExp() + &quot;($|\\s)&quot;);
-    return regex.test(this.className);
</del><ins>+
+    var index = this.className.indexOf(className);
+    if (index === -1)
+        return false;
+    var toTest = &quot; &quot; + this.className + &quot; &quot;;
+    return toTest.indexOf(&quot; &quot; + className + &quot; &quot;, index) !== -1;
</ins><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> Element.prototype.positionAt = function(x, y)
</span></span></pre>
</div>
</div>

</body>
</html>