<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[47319] trunk/WebCore</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/47319">47319</a></dd>
<dt>Author</dt> <dd>pfeldman@chromium.org</dd>
<dt>Date</dt> <dd>2009-08-15 02:02:45 -0700 (Sat, 15 Aug 2009)</dd>
</dl>

<h3>Log Message</h3>
<pre>2009-08-15  Pavel Feldman  &lt;pfeldman@chromium.org&gt;

        Reviewed by Timothy Hatcher.

        WebInspector: Minor DOMAgent bugfixes.

        https://bugs.webkit.org/show_bug.cgi?id=28177

        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::nodeForId):
        * inspector/front-end/DOMAgent.js:
        (WebInspector.DOMAgent):
        * inspector/front-end/ElementsPanel.js:
        (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged):</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkWebCoreChangeLog">trunk/WebCore/ChangeLog</a></li>
<li><a href="#trunkWebCoreinspectorInspectorDOMAgentcpp">trunk/WebCore/inspector/InspectorDOMAgent.cpp</a></li>
<li><a href="#trunkWebCoreinspectorfrontendDOMAgentjs">trunk/WebCore/inspector/front-end/DOMAgent.js</a></li>
<li><a href="#trunkWebCoreinspectorfrontendElementsPaneljs">trunk/WebCore/inspector/front-end/ElementsPanel.js</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/ChangeLog (47318 => 47319)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/ChangeLog        2009-08-15 08:56:08 UTC (rev 47318)
+++ trunk/WebCore/ChangeLog        2009-08-15 09:02:45 UTC (rev 47319)
</span><span class="lines">@@ -2,6 +2,21 @@
</span><span class="cx"> 
</span><span class="cx">         Reviewed by Timothy Hatcher.
</span><span class="cx"> 
</span><ins>+        WebInspector: Minor DOMAgent bugfixes.
+
+        https://bugs.webkit.org/show_bug.cgi?id=28177
+
+        * inspector/InspectorDOMAgent.cpp:
+        (WebCore::InspectorDOMAgent::nodeForId):
+        * inspector/front-end/DOMAgent.js:
+        (WebInspector.DOMAgent):
+        * inspector/front-end/ElementsPanel.js:
+        (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged):
+
+2009-08-15  Pavel Feldman  &lt;pfeldman@chromium.org&gt;
+
+        Reviewed by Timothy Hatcher.
+
</ins><span class="cx">         WebInspector: Evaluating objects while on a breakpoint dumps string
</span><span class="cx">         representation instead of live object. 
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkWebCoreinspectorInspectorDOMAgentcpp"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/inspector/InspectorDOMAgent.cpp (47318 => 47319)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/inspector/InspectorDOMAgent.cpp        2009-08-15 08:56:08 UTC (rev 47318)
+++ trunk/WebCore/inspector/InspectorDOMAgent.cpp        2009-08-15 09:02:45 UTC (rev 47319)
</span><span class="lines">@@ -231,7 +231,7 @@
</span><span class="cx"> Node* InspectorDOMAgent::nodeForId(long id)
</span><span class="cx"> {
</span><span class="cx">     if (!id)
</span><del>-        return mainFrameDocument();
</del><ins>+        return 0;
</ins><span class="cx"> 
</span><span class="cx">     HashMap&lt;long, Node*&gt;::iterator it = m_idToNode.find(id);
</span><span class="cx">     if (it != m_idToNode.end())
</span></span></pre></div>
<a id="trunkWebCoreinspectorfrontendDOMAgentjs"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/inspector/front-end/DOMAgent.js (47318 => 47319)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/inspector/front-end/DOMAgent.js        2009-08-15 08:56:08 UTC (rev 47318)
+++ trunk/WebCore/inspector/front-end/DOMAgent.js        2009-08-15 09:02:45 UTC (rev 47319)
</span><span class="lines">@@ -58,10 +58,12 @@
</span><span class="cx">     this.style = null;
</span><span class="cx">     this._matchedCSSRules = [];
</span><span class="cx"> 
</span><del>-    if (this.nodeType == Node.DOCUMENT_NODE)
-        this.ownerDocument.documentElement = this;
-    if (this.nodeType == Node.ELEMENT_NODE &amp;&amp; this.nodeName == &quot;BODY&quot;)
-        this.ownerDocument.body = this;
</del><ins>+    if (this.nodeType == Node.ELEMENT_NODE) {
+        if (this.nodeName == &quot;HTML&quot;)
+            this.ownerDocument.documentElement = this;
+        if (this.nodeName == &quot;BODY&quot;)
+            this.ownerDocument.body = this;
+    }
</ins><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> WebInspector.DOMNode.prototype = {
</span></span></pre></div>
<a id="trunkWebCoreinspectorfrontendElementsPaneljs"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/inspector/front-end/ElementsPanel.js (47318 => 47319)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/inspector/front-end/ElementsPanel.js        2009-08-15 08:56:08 UTC (rev 47318)
+++ trunk/WebCore/inspector/front-end/ElementsPanel.js        2009-08-15 09:02:45 UTC (rev 47319)
</span><span class="lines">@@ -61,7 +61,8 @@
</span><span class="cx">             InspectorController.toggleNodeSearch();
</span><span class="cx">             this.panel.nodeSearchButton.removeStyleClass(&quot;toggled-on&quot;);
</span><span class="cx">         }
</span><del>-        InspectorController.addInspectedNode(this._focusedDOMNode.id, function() {});
</del><ins>+        if (this._focusedDOMNode)
+            InspectorController.addInspectedNode(this._focusedDOMNode.id, function() {});
</ins><span class="cx">     };
</span><span class="cx"> 
</span><span class="cx">     this.contentElement.appendChild(this.treeOutline.element);
</span></span></pre>
</div>
</div>

</body>
</html>