<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[46939] trunk/WebCore</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/46939">46939</a></dd>
<dt>Author</dt> <dd>abarth@webkit.org</dd>
<dt>Date</dt> <dd>2009-08-07 18:25:07 -0700 (Fri, 07 Aug 2009)</dd>
</dl>

<h3>Log Message</h3>
<pre>2009-08-07  Yong Li  &lt;yong.li@torchmobile.com&gt;

        WINCE PORT: store only width for GlyphBufferAdvance, to save space on low-memory devices
        https://bugs.webkit.org/show_bug.cgi?id=27734

        * platform/graphics/GlyphBuffer.h:
        (WebCore::GlyphBuffer::advanceAt):
        (WebCore::GlyphBuffer::advanceData):
        (WebCore::GlyphBuffer::add):</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkWebCoreChangeLog">trunk/WebCore/ChangeLog</a></li>
<li><a href="#trunkWebCoreplatformgraphicsGlyphBufferh">trunk/WebCore/platform/graphics/GlyphBuffer.h</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/ChangeLog (46938 => 46939)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/ChangeLog        2009-08-08 01:24:13 UTC (rev 46938)
+++ trunk/WebCore/ChangeLog        2009-08-08 01:25:07 UTC (rev 46939)
</span><span class="lines">@@ -1,5 +1,15 @@
</span><span class="cx"> 2009-08-07  Yong Li  &lt;yong.li@torchmobile.com&gt;
</span><span class="cx"> 
</span><ins>+        WINCE PORT: store only width for GlyphBufferAdvance, to save space on low-memory devices
+        https://bugs.webkit.org/show_bug.cgi?id=27734
+
+        * platform/graphics/GlyphBuffer.h:
+        (WebCore::GlyphBuffer::advanceAt):
+        (WebCore::GlyphBuffer::advanceData):
+        (WebCore::GlyphBuffer::add):
+
+2009-08-07  Yong Li  &lt;yong.li@torchmobile.com&gt;
+
</ins><span class="cx">         Reviewed by Eric Seidel.
</span><span class="cx"> 
</span><span class="cx">         WINCE PORT: pass unrecognized glyphs to GDI to handle
</span></span></pre></div>
<a id="trunkWebCoreplatformgraphicsGlyphBufferh"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/platform/graphics/GlyphBuffer.h (46938 => 46939)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/platform/graphics/GlyphBuffer.h        2009-08-08 01:24:13 UTC (rev 46938)
+++ trunk/WebCore/platform/graphics/GlyphBuffer.h        2009-08-08 01:25:07 UTC (rev 46939)
</span><span class="lines">@@ -1,5 +1,6 @@
</span><span class="cx"> /*
</span><span class="cx">  * Copyright (C) 2006, 2009 Apple Inc. All rights reserved.
</span><ins>+ * Copyright (C) 2007-2008 Torch Mobile Inc.
</ins><span class="cx">  *
</span><span class="cx">  * Redistribution and use in source and binary forms, with or without
</span><span class="cx">  * modification, are permitted provided that the following conditions
</span><span class="lines">@@ -49,6 +50,8 @@
</span><span class="cx"> #if PLATFORM(CAIRO)
</span><span class="cx"> // FIXME: Why does Cairo use such a huge struct instead of just an offset into an array?
</span><span class="cx"> typedef cairo_glyph_t GlyphBufferGlyph;
</span><ins>+#elif PLATFORM(WINCE)
+typedef wchar_t GlyphBufferGlyph;
</ins><span class="cx"> #else
</span><span class="cx"> typedef Glyph GlyphBufferGlyph;
</span><span class="cx"> #endif
</span><span class="lines">@@ -57,6 +60,10 @@
</span><span class="cx"> // can be passed directly to CGContextShowGlyphsWithAdvances in FontMac.mm
</span><span class="cx"> #if PLATFORM(CG)
</span><span class="cx"> typedef CGSize GlyphBufferAdvance;
</span><ins>+#elif PLATFORM(WINCE)
+// There is no cross-platform code that uses the height of GlyphBufferAdvance,
+// so we can save memory space on embedded devices by storing only the width
+typedef float GlyphBufferAdvance;
</ins><span class="cx"> #else
</span><span class="cx"> typedef FloatSize GlyphBufferAdvance;
</span><span class="cx"> #endif
</span><span class="lines">@@ -117,11 +124,20 @@
</span><span class="cx">     {
</span><span class="cx"> #if PLATFORM(CG)
</span><span class="cx">         return m_advances[index].width;
</span><ins>+#elif PLATFORM(WINCE)
+        return m_advances[index];
</ins><span class="cx"> #else
</span><span class="cx">         return m_advances[index].width();
</span><span class="cx"> #endif
</span><span class="cx">     }
</span><span class="cx"> 
</span><ins>+#if PLATFORM(WINCE)
+    const GlyphBufferAdvance* advanceData() const
+    {
+        return m_advances.data();
+    }
+#endif
+
</ins><span class="cx">     FloatSize offsetAt(int index) const
</span><span class="cx">     {
</span><span class="cx"> #if PLATFORM(WIN)
</span><span class="lines">@@ -147,6 +163,8 @@
</span><span class="cx"> #if PLATFORM(CG)
</span><span class="cx">         CGSize advance = { width, 0 };
</span><span class="cx">         m_advances.append(advance);
</span><ins>+#elif PLATFORM(WINCE)
+        m_advances.append(width);
</ins><span class="cx"> #else
</span><span class="cx">         m_advances.append(FloatSize(width, 0));
</span><span class="cx"> #endif
</span><span class="lines">@@ -161,6 +179,7 @@
</span><span class="cx"> #endif
</span><span class="cx">     }
</span><span class="cx">     
</span><ins>+#if !PLATFORM(WINCE)
</ins><span class="cx">     void add(Glyph glyph, const SimpleFontData* font, GlyphBufferAdvance advance)
</span><span class="cx">     {
</span><span class="cx">         m_fontData.append(font);
</span><span class="lines">@@ -174,6 +193,7 @@
</span><span class="cx"> 
</span><span class="cx">         m_advances.append(advance);
</span><span class="cx">     }
</span><ins>+#endif
</ins><span class="cx">     
</span><span class="cx"> private:
</span><span class="cx">     Vector&lt;const SimpleFontData*, 2048&gt; m_fontData;
</span></span></pre>
</div>
</div>

</body>
</html>