<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[46638] trunk/WebKit/win</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/46638">46638</a></dd>
<dt>Author</dt> <dd>andersca@apple.com</dd>
<dt>Date</dt> <dd>2009-07-31 13:21:01 -0700 (Fri, 31 Jul 2009)</dd>
</dl>

<h3>Log Message</h3>
<pre>2009-07-31  Anders Carlsson  &lt;andersca@apple.com&gt;

        Reviewed by Dan Bernstein.

        -Fix &lt;rdar://problem/7104097&gt;

        Make EmbeddedWidget::create return a PassRefPtr so it will have the correct ref count.
        
        * WebCoreSupport/EmbeddedWidget.cpp:
        (EmbeddedWidget::create):
        * WebCoreSupport/EmbeddedWidget.h:</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkWebKitwinChangeLog">trunk/WebKit/win/ChangeLog</a></li>
<li><a href="#trunkWebKitwinWebCoreSupportEmbeddedWidgetcpp">trunk/WebKit/win/WebCoreSupport/EmbeddedWidget.cpp</a></li>
<li><a href="#trunkWebKitwinWebCoreSupportEmbeddedWidgeth">trunk/WebKit/win/WebCoreSupport/EmbeddedWidget.h</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkWebKitwinChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/WebKit/win/ChangeLog (46637 => 46638)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebKit/win/ChangeLog        2009-07-31 20:12:14 UTC (rev 46637)
+++ trunk/WebKit/win/ChangeLog        2009-07-31 20:21:01 UTC (rev 46638)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2009-07-31  Anders Carlsson  &lt;andersca@apple.com&gt;
+
+        Reviewed by Dan Bernstein.
+
+        -Fix &lt;rdar://problem/7104097&gt;
+
+        Make EmbeddedWidget::create return a PassRefPtr so it will have the correct ref count.
+        
+        * WebCoreSupport/EmbeddedWidget.cpp:
+        (EmbeddedWidget::create):
+        * WebCoreSupport/EmbeddedWidget.h:
+
</ins><span class="cx"> 2009-07-29  Brian Weinstein  &lt;bweinstein@apple.com&gt;
</span><span class="cx"> 
</span><span class="cx">         Was doing the build fix wrong, NotImplemented.h is in WebCore.
</span></span></pre></div>
<a id="trunkWebKitwinWebCoreSupportEmbeddedWidgetcpp"></a>
<div class="modfile"><h4>Modified: trunk/WebKit/win/WebCoreSupport/EmbeddedWidget.cpp (46637 => 46638)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebKit/win/WebCoreSupport/EmbeddedWidget.cpp        2009-07-31 20:12:14 UTC (rev 46637)
+++ trunk/WebKit/win/WebCoreSupport/EmbeddedWidget.cpp        2009-07-31 20:21:01 UTC (rev 46638)
</span><span class="lines">@@ -37,12 +37,12 @@
</span><span class="cx"> 
</span><span class="cx"> using namespace WebCore;
</span><span class="cx"> 
</span><del>-EmbeddedWidget* EmbeddedWidget::create(IWebEmbeddedView* view, Element* element, HWND parentWindow, const IntSize&amp; size)
</del><ins>+PassRefPtr&lt;EmbeddedWidget&gt; EmbeddedWidget::create(IWebEmbeddedView* view, Element* element, HWND parentWindow, const IntSize&amp; size)
</ins><span class="cx"> {
</span><del>-    EmbeddedWidget* widget = new EmbeddedWidget(view, element);
</del><ins>+    RefPtr&lt;EmbeddedWidget&gt; widget = adoptRef(new EmbeddedWidget(view, element));
</ins><span class="cx"> 
</span><span class="cx">     widget-&gt;createWindow(parentWindow, size);
</span><del>-    return widget;
</del><ins>+    return widget.release();
</ins><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> EmbeddedWidget::~EmbeddedWidget()
</span></span></pre></div>
<a id="trunkWebKitwinWebCoreSupportEmbeddedWidgeth"></a>
<div class="modfile"><h4>Modified: trunk/WebKit/win/WebCoreSupport/EmbeddedWidget.h (46637 => 46638)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebKit/win/WebCoreSupport/EmbeddedWidget.h        2009-07-31 20:12:14 UTC (rev 46637)
+++ trunk/WebKit/win/WebCoreSupport/EmbeddedWidget.h        2009-07-31 20:21:01 UTC (rev 46638)
</span><span class="lines">@@ -39,7 +39,7 @@
</span><span class="cx"> 
</span><span class="cx"> class EmbeddedWidget : public WebCore::Widget, public WebCore::PluginManualLoader {
</span><span class="cx"> public:
</span><del>-    static EmbeddedWidget* create(IWebEmbeddedView*, WebCore::Element* element, HWND parentWindow, const WebCore::IntSize&amp;);
</del><ins>+    static PassRefPtr&lt;EmbeddedWidget&gt; create(IWebEmbeddedView*, WebCore::Element* element, HWND parentWindow, const WebCore::IntSize&amp;);
</ins><span class="cx">     ~EmbeddedWidget();
</span><span class="cx"> 
</span><span class="cx"> private:
</span><span class="lines">@@ -54,10 +54,10 @@
</span><span class="cx"> 
</span><span class="cx">     bool createWindow(HWND parentWindow, const WebCore::IntSize&amp; size);
</span><span class="cx"> 
</span><del>-    virtual void didReceiveResponse(const WebCore::ResourceResponse&amp;);
-    virtual void didReceiveData(const char*, int);
-    virtual void didFinishLoading();
-    virtual void didFail(const WebCore::ResourceError&amp;);
</del><ins>+    virtual void didReceiveResponse(const WebCore::ResourceResponse&amp;);
+    virtual void didReceiveData(const char*, int);
+    virtual void didFinishLoading();
+    virtual void didFail(const WebCore::ResourceError&amp;);
</ins><span class="cx"> 
</span><span class="cx">     virtual void invalidateRect(const WebCore::IntRect&amp;);
</span><span class="cx">     virtual void setFrameRect(const WebCore::IntRect&amp;);
</span></span></pre>
</div>
</div>

</body>
</html>