<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[46235] trunk/WebKitTools</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/46235">46235</a></dd>
<dt>Author</dt> <dd>treat@webkit.org</dd>
<dt>Date</dt> <dd>2009-07-22 13:18:50 -0700 (Wed, 22 Jul 2009)</dd>
</dl>

<h3>Log Message</h3>
<pre>Revert bugfix for 27557 as this is invalid according to Darin Adler
who states that include order sorting should be case-sensitive.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkWebKitToolsChangeLog">trunk/WebKitTools/ChangeLog</a></li>
<li><a href="#trunkWebKitToolsScriptsmodulescpplintpy">trunk/WebKitTools/Scripts/modules/cpplint.py</a></li>
<li><a href="#trunkWebKitToolsScriptsmodulescpplint_unittestpy">trunk/WebKitTools/Scripts/modules/cpplint_unittest.py</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkWebKitToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/WebKitTools/ChangeLog (46234 => 46235)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebKitTools/ChangeLog        2009-07-22 20:06:42 UTC (rev 46234)
+++ trunk/WebKitTools/ChangeLog        2009-07-22 20:18:50 UTC (rev 46235)
</span><span class="lines">@@ -2,16 +2,6 @@
</span><span class="cx"> 
</span><span class="cx">         Reviewed by Adam Treat.
</span><span class="cx"> 
</span><del>-        Case-insensitive comparison of include file order for cpplint.
-        https://bugs.webkit.org/show_bug.cgi?id=27557
-
-        * Scripts/modules/cpplint.py:
-        * Scripts/modules/cpplint_unittest.py:
-
-2009-07-22  Jakob Petsovits  &lt;jakob.petsovits@torchmobile.com&gt;
-
-        Reviewed by Adam Treat.
-
</del><span class="cx">         Fix cpplint generating false positives for
</span><span class="cx">         &quot;primary&quot; includes in headers.
</span><span class="cx">         https://bugs.webkit.org/show_bug.cgi?id=27553
</span></span></pre></div>
<a id="trunkWebKitToolsScriptsmodulescpplintpy"></a>
<div class="modfile"><h4>Modified: trunk/WebKitTools/Scripts/modules/cpplint.py (46234 => 46235)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebKitTools/Scripts/modules/cpplint.py        2009-07-22 20:06:42 UTC (rev 46234)
+++ trunk/WebKitTools/Scripts/modules/cpplint.py        2009-07-22 20:18:50 UTC (rev 46235)
</span><span class="lines">@@ -2226,7 +2226,7 @@
</span><span class="cx">                     previous_match = _RE_PATTERN_INCLUDE.search(previous_line)
</span><span class="cx">                  if previous_match:
</span><span class="cx">                     previous_header_type = include_state.header_types[previous_line_number]
</span><del>-                    if previous_header_type == _OTHER_HEADER and previous_line.strip().lower() &gt; line.strip().lower():
</del><ins>+                    if previous_header_type == _OTHER_HEADER and previous_line.strip() &gt; line.strip():
</ins><span class="cx">                         error(filename, line_number, 'build/include_order', 4,
</span><span class="cx">                               'Alphabetical sorting problem.')
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkWebKitToolsScriptsmodulescpplint_unittestpy"></a>
<div class="modfile"><h4>Modified: trunk/WebKitTools/Scripts/modules/cpplint_unittest.py (46234 => 46235)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebKitTools/Scripts/modules/cpplint_unittest.py        2009-07-22 20:06:42 UTC (rev 46234)
+++ trunk/WebKitTools/Scripts/modules/cpplint_unittest.py        2009-07-22 20:18:50 UTC (rev 46235)
</span><span class="lines">@@ -2094,12 +2094,6 @@
</span><span class="cx">                                          '')
</span><span class="cx"> 
</span><span class="cx">         self.assert_language_rules_check('foo.h',
</span><del>-                                         '#include &quot;a.h&quot;\n'
-                                         '#include &quot;B.h&quot;\n'
-                                         '#include &quot;c.h&quot;\n',
-                                         '')
-
-        self.assert_language_rules_check('foo.h',
</del><span class="cx">                                          '#include &lt;assert.h&gt;\n'
</span><span class="cx">                                          '#include &quot;bar.h&quot;\n',
</span><span class="cx">                                          'Alphabetical sorting problem.  [build/include_order] [4]')
</span></span></pre>
</div>
</div>

</body>
</html>