<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[45770] branches/safari-4-branch/WebCore</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/45770">45770</a></dd>
<dt>Author</dt> <dd>mrowe@apple.com</dd>
<dt>Date</dt> <dd>2009-07-12 14:48:46 -0700 (Sun, 12 Jul 2009)</dd>
</dl>

<h3>Log Message</h3>
<pre>Merge r45728.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#branchessafari4branchWebCoreChangeLog">branches/safari-4-branch/WebCore/ChangeLog</a></li>
<li><a href="#branchessafari4branchWebCorepagemacEventHandlerMacmm">branches/safari-4-branch/WebCore/page/mac/EventHandlerMac.mm</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="branchessafari4branchWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: branches/safari-4-branch/WebCore/ChangeLog (45769 => 45770)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-4-branch/WebCore/ChangeLog        2009-07-12 21:48:42 UTC (rev 45769)
+++ branches/safari-4-branch/WebCore/ChangeLog        2009-07-12 21:48:46 UTC (rev 45770)
</span><span class="lines">@@ -1,5 +1,22 @@
</span><span class="cx"> 2009-07-12  Mark Rowe  &lt;mrowe@apple.com&gt;
</span><span class="cx"> 
</span><ins>+        Merge r45728.
+
+    2009-07-10  Beth Dakin  &lt;bdakin@apple.com&gt;
+
+        Reviewed by Anders Carlsson.
+
+        The rest of the fix for &lt;rdar://problem/7038831&gt; REGRESSION (TOT): 
+        In Mail, a crash occurs at WebCore::Widget::afterMouseDown() after 
+        clicking To Do's close box
+
+        Make the Widget* in passMouseDownEventToWidget() a RefPtr.
+
+        * page/mac/EventHandlerMac.mm:
+        (WebCore::EventHandler::passMouseDownEventToWidget):
+
+2009-07-12  Mark Rowe  &lt;mrowe@apple.com&gt;
+
</ins><span class="cx">         Merge r45721.
</span><span class="cx"> 
</span><span class="cx">     2009-07-10  Steve Falkenburg  &lt;sfalken@apple.com&gt;
</span></span></pre></div>
<a id="branchessafari4branchWebCorepagemacEventHandlerMacmm"></a>
<div class="modfile"><h4>Modified: branches/safari-4-branch/WebCore/page/mac/EventHandlerMac.mm (45769 => 45770)</h4>
<pre class="diff"><span>
<span class="info">--- branches/safari-4-branch/WebCore/page/mac/EventHandlerMac.mm        2009-07-12 21:48:42 UTC (rev 45769)
+++ branches/safari-4-branch/WebCore/page/mac/EventHandlerMac.mm        2009-07-12 21:48:46 UTC (rev 45770)
</span><span class="lines">@@ -258,10 +258,12 @@
</span><span class="cx">     return false;
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-bool EventHandler::passMouseDownEventToWidget(Widget* widget)
</del><ins>+bool EventHandler::passMouseDownEventToWidget(Widget* pWidget)
</ins><span class="cx"> {
</span><span class="cx">     // FIXME: This function always returns true. It should be changed either to return
</span><span class="cx">     // false in some cases or the return value should be removed.
</span><ins>+    
+    RefPtr&lt;Widget&gt; widget = pWidget;
</ins><span class="cx"> 
</span><span class="cx">     if (!widget) {
</span><span class="cx">         LOG_ERROR(&quot;hit a RenderWidget without a corresponding Widget, means a frame is half-constructed&quot;);
</span><span class="lines">@@ -304,9 +306,9 @@
</span><span class="cx">     ASSERT(!m_sendingEventToSubview);
</span><span class="cx">     m_sendingEventToSubview = true;
</span><span class="cx">     NSView *outerView = widget-&gt;getOuterView();
</span><del>-    widget-&gt;beforeMouseDown(outerView, widget);
</del><ins>+    widget-&gt;beforeMouseDown(outerView, widget.get());
</ins><span class="cx">     [view mouseDown:currentNSEvent()];
</span><del>-    widget-&gt;afterMouseDown(outerView, widget);
</del><ins>+    widget-&gt;afterMouseDown(outerView, widget.get());
</ins><span class="cx">     m_sendingEventToSubview = false;
</span><span class="cx">     
</span><span class="cx">     if (!wasDeferringLoading)
</span></span></pre>
</div>
</div>

</body>
</html>