<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[45666] trunk/WebCore</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/45666">45666</a></dd>
<dt>Author</dt> <dd>japhet@chromium.org</dd>
<dt>Date</dt> <dd>2009-07-09 11:18:12 -0700 (Thu, 09 Jul 2009)</dd>
</dl>

<h3>Log Message</h3>
<pre>2009-07-09  Mads Ager  &lt;ager@chromium.org&gt;

        Reviewed by Dimitri Glazkov.

        Update the V8 bindings codegenerator to use the RGBColor::create
        method to handle refcounts for RGBColor objects correctly.
        
       * bindings/scripts/CodeGeneratorV8.pm: Use RGBColor::create to create RGBColor objects.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkWebCoreChangeLog">trunk/WebCore/ChangeLog</a></li>
<li><a href="#trunkWebCorebindingsscriptsCodeGeneratorV8pm">trunk/WebCore/bindings/scripts/CodeGeneratorV8.pm</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/ChangeLog (45665 => 45666)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/ChangeLog        2009-07-09 17:41:30 UTC (rev 45665)
+++ trunk/WebCore/ChangeLog        2009-07-09 18:18:12 UTC (rev 45666)
</span><span class="lines">@@ -1,3 +1,12 @@
</span><ins>+2009-07-09  Mads Ager  &lt;ager@chromium.org&gt;
+
+        Reviewed by Dimitri Glazkov.
+
+        Update the V8 bindings codegenerator to use the RGBColor::create
+        method to handle refcounts for RGBColor objects correctly.
+        
+       * bindings/scripts/CodeGeneratorV8.pm: Use RGBColor::create to create RGBColor objects.
+
</ins><span class="cx"> 2009-07-09  Eric Carlson  &lt;eric.carlson@apple.com&gt;
</span><span class="cx"> 
</span><span class="cx">         Reviewed by Adele Peterson.
</span></span></pre></div>
<a id="trunkWebCorebindingsscriptsCodeGeneratorV8pm"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/bindings/scripts/CodeGeneratorV8.pm (45665 => 45666)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/bindings/scripts/CodeGeneratorV8.pm        2009-07-09 17:41:30 UTC (rev 45665)
+++ trunk/WebCore/bindings/scripts/CodeGeneratorV8.pm        2009-07-09 18:18:12 UTC (rev 45666)
</span><span class="lines">@@ -626,7 +626,7 @@
</span><span class="cx">         my $classIndex = uc($attrType);
</span><span class="cx">         push(@implContentDecls, &quot;    return V8DOMWrapper::convertToV8Object(V8ClassIndex::$classIndex, wrapper);\n&quot;);
</span><span class="cx">     } else {
</span><del>-        push(@implContentDecls, &quot;    return &quot;.NativeToJSValue($attribute-&gt;signature, $result).&quot;;\n&quot;);
</del><ins>+        push(@implContentDecls, &quot;    &quot; . ReturnNativeToJSValue($attribute-&gt;signature, $result, &quot;    &quot;).&quot;;\n&quot;);
</ins><span class="cx">     }
</span><span class="cx"> 
</span><span class="cx">     push(@implContentDecls, &quot;  }\n\n&quot;);  # end of getter
</span><span class="lines">@@ -1549,7 +1549,7 @@
</span><span class="cx">         my $classIndex = uc($returnType);
</span><span class="cx">         $result .= $indent . &quot;return V8DOMWrapper::convertToV8Object(V8ClassIndex::$classIndex, wrapper);\n&quot;;
</span><span class="cx">     } else {
</span><del>-        $result .= $indent . &quot;return &quot; . NativeToJSValue($function-&gt;signature, $return) . &quot;;\n&quot;;
</del><ins>+        $result .= $indent . ReturnNativeToJSValue($function-&gt;signature, $return, $indent) . &quot;;\n&quot;;
</ins><span class="cx">     }
</span><span class="cx"> 
</span><span class="cx">     return $result;
</span><span class="lines">@@ -1976,33 +1976,34 @@
</span><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> 
</span><del>-sub NativeToJSValue
</del><ins>+sub ReturnNativeToJSValue
</ins><span class="cx"> {
</span><span class="cx">     my $signature = shift;
</span><span class="cx">     my $value = shift;
</span><ins>+    my $indent = shift;
</ins><span class="cx">     my $type = $codeGenerator-&gt;StripModule($signature-&gt;type);
</span><span class="cx">     my $className= &quot;V8$type&quot;;
</span><span class="cx"> 
</span><del>-    return &quot;v8::Date::New(static_cast&lt;double&gt;($value))&quot; if $type eq &quot;DOMTimeStamp&quot;;
-    return &quot;$value ? v8::True() : v8::False()&quot; if $type eq &quot;boolean&quot;;
-    return &quot;v8::Undefined()&quot; if $type eq &quot;void&quot;;
</del><ins>+    return &quot;return v8::Date::New(static_cast&lt;double&gt;($value))&quot; if $type eq &quot;DOMTimeStamp&quot;;
+    return &quot;return $value ? v8::True() : v8::False()&quot; if $type eq &quot;boolean&quot;;
+    return &quot;return v8::Undefined()&quot; if $type eq &quot;void&quot;;
</ins><span class="cx"> 
</span><span class="cx">     # For all the types where we use 'int' as the representation type,
</span><span class="cx">     # we use Integer::New which has a fast Smi conversion check.
</span><del>-    return &quot;v8::Integer::New($value)&quot; if GetNativeType($type) eq &quot;int&quot;;
</del><ins>+    return &quot;return v8::Integer::New($value)&quot; if GetNativeType($type) eq &quot;int&quot;;
</ins><span class="cx"> 
</span><del>-    return &quot;v8::Number::New($value)&quot; if $codeGenerator-&gt;IsPrimitiveType($type) or $type eq &quot;SVGPaintType&quot;;
</del><ins>+    return &quot;return v8::Number::New($value)&quot; if $codeGenerator-&gt;IsPrimitiveType($type) or $type eq &quot;SVGPaintType&quot;;
</ins><span class="cx"> 
</span><span class="cx">     if ($codeGenerator-&gt;IsStringType($type)) {
</span><span class="cx">         my $conv = $signature-&gt;extendedAttributes-&gt;{&quot;ConvertNullStringTo&quot;};
</span><span class="cx">         if (defined $conv) {
</span><del>-            return &quot;v8StringOrNull($value)&quot; if $conv eq &quot;Null&quot;;
-            return &quot;v8StringOrUndefined($value)&quot; if $conv eq &quot;Undefined&quot;;
-            return &quot;v8StringOrFalse($value)&quot; if $conv eq &quot;False&quot;;
</del><ins>+            return &quot;return v8StringOrNull($value)&quot; if $conv eq &quot;Null&quot;;
+            return &quot;return v8StringOrUndefined($value)&quot; if $conv eq &quot;Undefined&quot;;
+            return &quot;return v8StringOrFalse($value)&quot; if $conv eq &quot;False&quot;;
</ins><span class="cx"> 
</span><span class="cx">             die &quot;Unknown value for ConvertNullStringTo extended attribute&quot;;
</span><span class="cx">         }
</span><del>-        return &quot;v8String($value)&quot;;
</del><ins>+        return &quot;return v8String($value)&quot;;
</ins><span class="cx">     }
</span><span class="cx"> 
</span><span class="cx">     # V8 specific.
</span><span class="lines">@@ -2012,30 +2013,32 @@
</span><span class="cx"> 
</span><span class="cx">     # special case for non-DOM node interfaces
</span><span class="cx">     if (IsDOMNodeType($type)) {
</span><del>-        return &quot;V8DOMWrapper::convertNodeToV8Object($value)&quot;;
</del><ins>+        return &quot;return V8DOMWrapper::convertNodeToV8Object($value)&quot;;
</ins><span class="cx">     }
</span><span class="cx"> 
</span><span class="cx">     if ($type eq &quot;EventTarget&quot; or $type eq &quot;SVGElementInstance&quot;) {
</span><del>-        return &quot;V8DOMWrapper::convertEventTargetToV8Object($value)&quot;;
</del><ins>+        return &quot;return V8DOMWrapper::convertEventTargetToV8Object($value)&quot;;
</ins><span class="cx">     }
</span><span class="cx"> 
</span><span class="cx">     if ($type eq &quot;Event&quot;) {
</span><del>-        return &quot;V8DOMWrapper::convertEventToV8Object($value)&quot;;
</del><ins>+        return &quot;return V8DOMWrapper::convertEventToV8Object($value)&quot;;
</ins><span class="cx">     }
</span><span class="cx"> 
</span><span class="cx">     if ($type eq &quot;EventListener&quot;) {
</span><del>-        return &quot;V8DOMWrapper::convertEventListenerToV8Object($value)&quot;;
</del><ins>+        return &quot;return V8DOMWrapper::convertEventListenerToV8Object($value)&quot;;
</ins><span class="cx">     }
</span><span class="cx"> 
</span><span class="cx">     if ($type eq &quot;RGBColor&quot;) {
</span><del>-        return &quot;V8DOMWrapper::convertToV8Object(V8ClassIndex::RGBCOLOR, new RGBColor($value))&quot;;
</del><ins>+        my $construct = &quot;RefPtr&lt;RGBColor&gt; rgbcolor = RGBColor::create($value);\n&quot;;
+        my $convert = &quot;V8DOMWrapper::convertToV8Object(V8ClassIndex::RGBCOLOR, WTF::getPtr(rgbcolor))&quot;;
+        return $construct . $indent . &quot;return &quot; . $convert;
</ins><span class="cx">     }
</span><span class="cx"> 
</span><span class="cx">     if ($type eq &quot;WorkerContext&quot; or $type eq &quot;WorkerLocation&quot; or $type eq &quot;WorkerNavigator&quot;) {
</span><span class="cx">         $implIncludes{&quot;WorkerContextExecutionProxy.h&quot;} = 1;
</span><span class="cx">         my $classIndex = uc($type);
</span><span class="cx"> 
</span><del>-        return &quot;WorkerContextExecutionProxy::ToV8Object(V8ClassIndex::$classIndex, $value)&quot;;
</del><ins>+        return &quot;return WorkerContextExecutionProxy::ToV8Object(V8ClassIndex::$classIndex, $value)&quot;;
</ins><span class="cx">     }
</span><span class="cx"> 
</span><span class="cx">     else {
</span><span class="lines">@@ -2047,7 +2050,7 @@
</span><span class="cx">             $value = GenerateSVGStaticPodTypeWrapper($type, $value);
</span><span class="cx">         }
</span><span class="cx"> 
</span><del>-        return &quot;V8DOMWrapper::convertToV8Object(V8ClassIndex::$classIndex, $value)&quot;;
</del><ins>+        return &quot;return V8DOMWrapper::convertToV8Object(V8ClassIndex::$classIndex, $value)&quot;;
</ins><span class="cx">     }
</span><span class="cx"> }
</span><span class="cx"> 
</span></span></pre>
</div>
</div>

</body>
</html>