<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[45535] trunk/WebCore</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/45535">45535</a></dd>
<dt>Author</dt> <dd>xan@webkit.org</dd>
<dt>Date</dt> <dd>2009-07-03 07:08:34 -0700 (Fri, 03 Jul 2009)</dd>
</dl>

<h3>Log Message</h3>
<pre>2009-07-02  Xan Lopez  &lt;xlopez@igalia.com&gt;

        Reviewed by Jan Alonzo.

        https://bugs.webkit.org/show_bug.cgi?id=26814
        [Gtk] Caret-moved events are not issued for the correct offset
        when text is selected forward

        Report the caret offset from the end of the selection, otherwise
        we'll report the same offset when moving the caret while
        modififying the selection (eg, with Shift + Right).

        * editing/gtk/SelectionControllerGtk.cpp:
        (WebCore::SelectionController::notifyAccessibilityForSelectionChange):</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkWebCoreChangeLog">trunk/WebCore/ChangeLog</a></li>
<li><a href="#trunkWebCoreeditinggtkSelectionControllerGtkcpp">trunk/WebCore/editing/gtk/SelectionControllerGtk.cpp</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/ChangeLog (45534 => 45535)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/ChangeLog        2009-07-03 14:08:22 UTC (rev 45534)
+++ trunk/WebCore/ChangeLog        2009-07-03 14:08:34 UTC (rev 45535)
</span><span class="lines">@@ -2,6 +2,21 @@
</span><span class="cx"> 
</span><span class="cx">         Reviewed by Jan Alonzo.
</span><span class="cx"> 
</span><ins>+        https://bugs.webkit.org/show_bug.cgi?id=26814
+        [Gtk] Caret-moved events are not issued for the correct offset
+        when text is selected forward
+
+        Report the caret offset from the end of the selection, otherwise
+        we'll report the same offset when moving the caret while
+        modififying the selection (eg, with Shift + Right).
+
+        * editing/gtk/SelectionControllerGtk.cpp:
+        (WebCore::SelectionController::notifyAccessibilityForSelectionChange):
+
+2009-07-02  Xan Lopez  &lt;xlopez@igalia.com&gt;
+
+        Reviewed by Jan Alonzo.
+
</ins><span class="cx">         https://bugs.webkit.org/show_bug.cgi?id=26815
</span><span class="cx">         [Gtk] text-selection-changed events are not issued for the correct
</span><span class="cx">         object when the selection spans multiple objects
</span></span></pre></div>
<a id="trunkWebCoreeditinggtkSelectionControllerGtkcpp"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/editing/gtk/SelectionControllerGtk.cpp (45534 => 45535)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/editing/gtk/SelectionControllerGtk.cpp        2009-07-03 14:08:22 UTC (rev 45534)
+++ trunk/WebCore/editing/gtk/SelectionControllerGtk.cpp        2009-07-03 14:08:34 UTC (rev 45535)
</span><span class="lines">@@ -34,7 +34,7 @@
</span><span class="cx">         AccessibilityObject* accessibilityObject = m_frame-&gt;document()-&gt;axObjectCache()-&gt;getOrCreate(focusedNode);
</span><span class="cx">         AtkObject* wrapper = accessibilityObject-&gt;wrapper();
</span><span class="cx">         if (ATK_IS_TEXT(wrapper)) {
</span><del>-            g_signal_emit_by_name(wrapper, &quot;text-caret-moved&quot;, m_sel.start().computeOffsetInContainerNode());
</del><ins>+            g_signal_emit_by_name(wrapper, &quot;text-caret-moved&quot;, m_sel.end().computeOffsetInContainerNode());
</ins><span class="cx"> 
</span><span class="cx">             if (m_sel.isRange())
</span><span class="cx">                 g_signal_emit_by_name(wrapper, &quot;text-selection-changed&quot;);
</span></span></pre>
</div>
</div>

</body>
</html>