<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[42314] trunk</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/42314">42314</a></dd>
<dt>Author</dt> <dd>ap@webkit.org</dd>
<dt>Date</dt> <dd>2009-04-08 00:02:06 -0700 (Wed, 08 Apr 2009)</dd>
</dl>

<h3>Log Message</h3>
<pre>        Reviewed by Maciej Stachowiak.

        https://bugs.webkit.org/show_bug.cgi?id=24957
        REGRESSION: Google calendar widget no longer shows upcoming events

        Test: http/tests/xmlhttprequest/authorization-header.html

        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequestStaticData::XMLHttpRequestStaticData): Removed Authorization from
        the list of forbidden headers.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestshttptestsxmlhttprequestsetdangerousheadersexpectedtxt">trunk/LayoutTests/http/tests/xmlhttprequest/set-dangerous-headers-expected.txt</a></li>
<li><a href="#trunkWebCoreChangeLog">trunk/WebCore/ChangeLog</a></li>
<li><a href="#trunkWebCorexmlXMLHttpRequestcpp">trunk/WebCore/xml/XMLHttpRequest.cpp</a></li>
</ul>

<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestshttptestsxmlhttprequestauthorizationheaderexpectedtxt">trunk/LayoutTests/http/tests/xmlhttprequest/authorization-header-expected.txt</a></li>
<li><a href="#trunkLayoutTestshttptestsxmlhttprequestauthorizationheaderhtml">trunk/LayoutTests/http/tests/xmlhttprequest/authorization-header.html</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (42313 => 42314)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog        2009-04-08 05:33:03 UTC (rev 42313)
+++ trunk/LayoutTests/ChangeLog        2009-04-08 07:02:06 UTC (rev 42314)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2009-04-07  Alexey Proskuryakov  &lt;ap@webkit.org&gt;
+
+        Reviewed by Maciej Stachowiak.
+
+        https://bugs.webkit.org/show_bug.cgi?id=24957
+        REGRESSION: Google calendar widget no longer shows upcoming events
+
+        * http/tests/xmlhttprequest/authorization-header-expected.txt: Added.
+        * http/tests/xmlhttprequest/authorization-header.html: Added.
+        * http/tests/xmlhttprequest/set-dangerous-headers-expected.txt:
+
</ins><span class="cx"> 2009-04-07  Dan Bernstein  &lt;mitz@apple.com&gt;
</span><span class="cx"> 
</span><span class="cx">         Reviewed by Adam Roben.
</span></span></pre></div>
<a id="trunkLayoutTestshttptestsxmlhttprequestauthorizationheaderexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/http/tests/xmlhttprequest/authorization-header-expected.txt (0 => 42314)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/http/tests/xmlhttprequest/authorization-header-expected.txt                                (rev 0)
+++ trunk/LayoutTests/http/tests/xmlhttprequest/authorization-header-expected.txt        2009-04-08 07:02:06 UTC (rev 42314)
</span><span class="lines">@@ -0,0 +1,3 @@
</span><ins>+Test that Authorization header can be set via setRequestHeader.
+
+PASS
</ins><span class="cx">Property changes on: trunk/LayoutTests/http/tests/xmlhttprequest/authorization-header-expected.txt
</span><span class="cx">___________________________________________________________________
</span></span></pre></div>
<a id="svnmimetype"></a>
<div class="addfile"><h4>Added: svn:mime-type</h4></div>
<a id="svneolstyle"></a>
<div class="addfile"><h4>Added: svn:eol-style</h4></div>
<a id="trunkLayoutTestshttptestsxmlhttprequestauthorizationheaderhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/http/tests/xmlhttprequest/authorization-header.html (0 => 42314)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/http/tests/xmlhttprequest/authorization-header.html                                (rev 0)
+++ trunk/LayoutTests/http/tests/xmlhttprequest/authorization-header.html        2009-04-08 07:02:06 UTC (rev 42314)
</span><span class="lines">@@ -0,0 +1,15 @@
</span><ins>+&lt;p&gt;Test that Authorization header can be set via setRequestHeader.&lt;/p&gt;
+&lt;script&gt;
+if (window.layoutTestController)
+    layoutTestController.dumpAsText();
+
+try {
+    var req = new XMLHttpRequest;
+    req.open(&quot;GET&quot;, &quot;resources/basic-auth/basic-auth.php?uid=Authorization-Header&quot;, false);
+    req.setRequestHeader(&quot;Authorization&quot;, &quot;Basic QXV0aG9yaXphdGlvbi1IZWFkZXI6QXV0aG9yaXphdGlvbi1IZWFkZXI=&quot;);
+    req.send(null);
+    document.write(req.responseText.match(/Authorization\-Header/) ? &quot;PASS&quot; : (&quot;FAIL. Unexpected response: &quot; + req.responseText));
+} catch (ex) {
+    document.write(&quot;FAIL. Exception: &quot; + ex);
+}
+&lt;/script&gt;
</ins><span class="cx">Property changes on: trunk/LayoutTests/http/tests/xmlhttprequest/authorization-header.html
</span><span class="cx">___________________________________________________________________
</span></span></pre></div>
<a id="svnmimetype"></a>
<div class="addfile"><h4>Added: svn:mime-type</h4></div>
<a id="trunkLayoutTestshttptestsxmlhttprequestsetdangerousheadersexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/http/tests/xmlhttprequest/set-dangerous-headers-expected.txt (42313 => 42314)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/http/tests/xmlhttprequest/set-dangerous-headers-expected.txt        2009-04-08 05:33:03 UTC (rev 42313)
+++ trunk/LayoutTests/http/tests/xmlhttprequest/set-dangerous-headers-expected.txt        2009-04-08 07:02:06 UTC (rev 42314)
</span><span class="lines">@@ -2,7 +2,6 @@
</span><span class="cx"> CONSOLE MESSAGE: line 1: Refused to set unsafe header &quot;ACCEPT-ENCODING&quot;
</span><span class="cx"> CONSOLE MESSAGE: line 1: Refused to set unsafe header &quot;ACCESS-CONTROL-REQUEST-HEADERS&quot;
</span><span class="cx"> CONSOLE MESSAGE: line 1: Refused to set unsafe header &quot;ACCESS-CONTROL-REQUEST-METHOD&quot;
</span><del>-CONSOLE MESSAGE: line 1: Refused to set unsafe header &quot;AUTHORIZATION&quot;
</del><span class="cx"> CONSOLE MESSAGE: line 1: Refused to set unsafe header &quot;CONNECTION&quot;
</span><span class="cx"> CONSOLE MESSAGE: line 1: Refused to set unsafe header &quot;CONTENT-LENGTH&quot;
</span><span class="cx"> CONSOLE MESSAGE: line 1: Refused to set unsafe header &quot;CONTENT-TRANSFER-ENCODING&quot;
</span></span></pre></div>
<a id="trunkWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/ChangeLog (42313 => 42314)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/ChangeLog        2009-04-08 05:33:03 UTC (rev 42313)
+++ trunk/WebCore/ChangeLog        2009-04-08 07:02:06 UTC (rev 42314)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2009-04-07  Alexey Proskuryakov  &lt;ap@webkit.org&gt;
+
+        Reviewed by Maciej Stachowiak.
+
+        https://bugs.webkit.org/show_bug.cgi?id=24957
+        REGRESSION: Google calendar widget no longer shows upcoming events
+
+        Test: http/tests/xmlhttprequest/authorization-header.html
+
+        * xml/XMLHttpRequest.cpp:
+        (WebCore::XMLHttpRequestStaticData::XMLHttpRequestStaticData): Removed Authorization from
+        the list of forbidden headers.
+
</ins><span class="cx"> 2009-04-07  miggilin  &lt;mr.diggilin@gmail.com&gt;
</span><span class="cx"> 
</span><span class="cx">         Reviewed by Kevin Ollivier.
</span></span></pre></div>
<a id="trunkWebCorexmlXMLHttpRequestcpp"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/xml/XMLHttpRequest.cpp (42313 => 42314)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/xml/XMLHttpRequest.cpp        2009-04-08 05:33:03 UTC (rev 42313)
+++ trunk/WebCore/xml/XMLHttpRequest.cpp        2009-04-08 07:02:06 UTC (rev 42314)
</span><span class="lines">@@ -66,7 +66,6 @@
</span><span class="cx">     m_forbiddenRequestHeaders.add(&quot;accept-encoding&quot;);
</span><span class="cx">     m_forbiddenRequestHeaders.add(&quot;access-control-request-headers&quot;);
</span><span class="cx">     m_forbiddenRequestHeaders.add(&quot;access-control-request-method&quot;);
</span><del>-    m_forbiddenRequestHeaders.add(&quot;authorization&quot;);
</del><span class="cx">     m_forbiddenRequestHeaders.add(&quot;connection&quot;);
</span><span class="cx">     m_forbiddenRequestHeaders.add(&quot;content-length&quot;);
</span><span class="cx">     m_forbiddenRequestHeaders.add(&quot;content-transfer-encoding&quot;);
</span></span></pre>
</div>
</div>

</body>
</html>