<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[38720] trunk/JavaScriptCore</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/38720">38720</a></dd>
<dt>Author</dt> <dd>ggaren@apple.com</dd>
<dt>Date</dt> <dd>2008-11-24 13:25:01 -0800 (Mon, 24 Nov 2008)</dd>
</dl>

<h3>Log Message</h3>
<pre>2008-11-24  Geoffrey Garen  &lt;ggaren@apple.com&gt;

        Reviewed by Sam Weinig.
        
        Removed some unnecessary &quot;Generator::&quot; prefixes.

        * wrec/WRECGenerator.cpp:
        (JSC::WREC::Generator::generateEnter):
        (JSC::WREC::Generator::generateReturnSuccess):
        (JSC::WREC::Generator::generateSaveIndex):
        (JSC::WREC::Generator::generateIncrementIndex):
        (JSC::WREC::Generator::generateLoopIfNotEndOfInput):
        (JSC::WREC::Generator::generateReturnFailure):</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkJavaScriptCoreChangeLog">trunk/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkJavaScriptCorewrecWRECGeneratorcpp">trunk/JavaScriptCore/wrec/WRECGenerator.cpp</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/JavaScriptCore/ChangeLog (38719 => 38720)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/JavaScriptCore/ChangeLog        2008-11-24 21:21:51 UTC (rev 38719)
+++ trunk/JavaScriptCore/ChangeLog        2008-11-24 21:25:01 UTC (rev 38720)
</span><span class="lines">@@ -2,6 +2,20 @@
</span><span class="cx"> 
</span><span class="cx">         Reviewed by Sam Weinig.
</span><span class="cx">         
</span><ins>+        Removed some unnecessary &quot;Generator::&quot; prefixes.
+
+        * wrec/WRECGenerator.cpp:
+        (JSC::WREC::Generator::generateEnter):
+        (JSC::WREC::Generator::generateReturnSuccess):
+        (JSC::WREC::Generator::generateSaveIndex):
+        (JSC::WREC::Generator::generateIncrementIndex):
+        (JSC::WREC::Generator::generateLoopIfNotEndOfInput):
+        (JSC::WREC::Generator::generateReturnFailure):
+
+2008-11-24  Geoffrey Garen  &lt;ggaren@apple.com&gt;
+
+        Reviewed by Sam Weinig.
+        
</ins><span class="cx">         Made a bunch of WREC::Parser functions private, and added an explicit
</span><span class="cx">         &quot;reset()&quot; function, so a parser can be reused.
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkJavaScriptCorewrecWRECGeneratorcpp"></a>
<div class="modfile"><h4>Modified: trunk/JavaScriptCore/wrec/WRECGenerator.cpp (38719 => 38720)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/JavaScriptCore/wrec/WRECGenerator.cpp        2008-11-24 21:21:51 UTC (rev 38719)
+++ trunk/JavaScriptCore/wrec/WRECGenerator.cpp        2008-11-24 21:25:01 UTC (rev 38720)
</span><span class="lines">@@ -52,15 +52,15 @@
</span><span class="cx">     __ convertToFastCall();
</span><span class="cx"> 
</span><span class="cx">     // Save callee save registers.
</span><del>-    __ pushl_r(Generator::output);
-    __ pushl_r(Generator::character);
</del><ins>+    __ pushl_r(output);
+    __ pushl_r(character);
</ins><span class="cx">     
</span><span class="cx">     // Initialize output register.
</span><del>-    __ movl_mr(outputParameter, X86::esp, Generator::output);
</del><ins>+    __ movl_mr(outputParameter, X86::esp, output);
</ins><span class="cx"> 
</span><span class="cx"> #ifndef NDEBUG
</span><span class="cx">     // ASSERT that the output register is not null.
</span><del>-    __ testl_rr(Generator::output, Generator::output);
</del><ins>+    __ testl_rr(output, output);
</ins><span class="cx">     X86Assembler::JmpSrc outputNotNull = __ jne();
</span><span class="cx">     __ int3();
</span><span class="cx">     __ link(outputNotNull, __ label());
</span><span class="lines">@@ -71,25 +71,25 @@
</span><span class="cx"> {
</span><span class="cx">     // Set return value.
</span><span class="cx">     __ popl_r(X86::eax); // match begin
</span><del>-    __ movl_rm(X86::eax, Generator::output);
-    __ movl_rm(Generator::index, 4, Generator::output); // match end
</del><ins>+    __ movl_rm(X86::eax, output);
+    __ movl_rm(index, 4, output); // match end
</ins><span class="cx">     
</span><span class="cx">     // Restore callee save registers.
</span><del>-    __ popl_r(Generator::character);
-    __ popl_r(Generator::output);
</del><ins>+    __ popl_r(character);
+    __ popl_r(output);
</ins><span class="cx">     __ ret();
</span><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> void Generator::generateSaveIndex()
</span><span class="cx"> {
</span><del>-    __ pushl_r(Generator::index);
</del><ins>+    __ pushl_r(index);
</ins><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> void Generator::generateIncrementIndex()
</span><span class="cx"> {
</span><del>-    __ movl_mr(X86::esp, Generator::index);
-    __ addl_i8r(1, Generator::index);
-    __ movl_rm(Generator::index, X86::esp);
</del><ins>+    __ movl_mr(X86::esp, index);
+    __ addl_i8r(1, index);
+    __ movl_rm(index, X86::esp);
</ins><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> void Generator::generateLoadCharacter(JmpSrcVector&amp; failures)
</span><span class="lines">@@ -101,7 +101,7 @@
</span><span class="cx"> 
</span><span class="cx"> void Generator::generateLoopIfNotEndOfInput(JmpDst target)
</span><span class="cx"> {
</span><del>-    __ cmpl_rr(Generator::length, Generator::index);
</del><ins>+    __ cmpl_rr(length, index);
</ins><span class="cx">     __ link(__ jle(), target);
</span><span class="cx"> }
</span><span class="cx"> 
</span><span class="lines">@@ -109,8 +109,8 @@
</span><span class="cx"> {
</span><span class="cx">     __ addl_i8r(4, X86::esp);
</span><span class="cx">     __ movl_i32r(-1, X86::eax);
</span><del>-    __ popl_r(Generator::character);
-    __ popl_r(Generator::output);
</del><ins>+    __ popl_r(character);
+    __ popl_r(output);
</ins><span class="cx">     __ ret();
</span><span class="cx"> }
</span><span class="cx"> 
</span></span></pre>
</div>
</div>

</body>
</html>