<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[37859] trunk/JavaScriptCore</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/37859">37859</a></dd>
<dt>Author</dt> <dd>cwzwarich@webkit.org</dd>
<dt>Date</dt> <dd>2008-10-24 13:44:58 -0700 (Fri, 24 Oct 2008)</dd>
</dl>

<h3>Log Message</h3>
<pre>2008-10-24  Cameron Zwarich  &lt;zwarich@apple.com&gt;

        Reviewed by Maciej Stachowiak.

        Bug 21862: Create JSFunction prototype property lazily
        &lt;https://bugs.webkit.org/show_bug.cgi?id=21862&gt;

        This is a 1.5% speedup on SunSpider and a 1.4% speedup on the V8
        benchmark suite, including a 3.8% speedup on Earley-Boyer.

        * kjs/JSFunction.cpp:
        (JSC::JSFunction::getOwnPropertySlot):
        * kjs/nodes.cpp:
        (JSC::FuncDeclNode::makeFunction):
        (JSC::FuncExprNode::makeFunction):</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkJavaScriptCoreChangeLog">trunk/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkJavaScriptCorekjsJSFunctioncpp">trunk/JavaScriptCore/kjs/JSFunction.cpp</a></li>
<li><a href="#trunkJavaScriptCorekjsnodescpp">trunk/JavaScriptCore/kjs/nodes.cpp</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/JavaScriptCore/ChangeLog (37858 => 37859)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/JavaScriptCore/ChangeLog        2008-10-24 20:43:02 UTC (rev 37858)
+++ trunk/JavaScriptCore/ChangeLog        2008-10-24 20:44:58 UTC (rev 37859)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2008-10-24  Cameron Zwarich  &lt;zwarich@apple.com&gt;
+
+        Reviewed by Maciej Stachowiak.
+
+        Bug 21862: Create JSFunction prototype property lazily
+        &lt;https://bugs.webkit.org/show_bug.cgi?id=21862&gt;
+
+        This is a 1.5% speedup on SunSpider and a 1.4% speedup on the V8
+        benchmark suite, including a 3.8% speedup on Earley-Boyer.
+
+        * kjs/JSFunction.cpp:
+        (JSC::JSFunction::getOwnPropertySlot):
+        * kjs/nodes.cpp:
+        (JSC::FuncDeclNode::makeFunction):
+        (JSC::FuncExprNode::makeFunction):
+
</ins><span class="cx"> 2008-10-24  Greg Bolsinga  &lt;bolsinga@apple.com&gt;
</span><span class="cx"> 
</span><span class="cx">         Reviewed by Sam Weinig.
</span></span></pre></div>
<a id="trunkJavaScriptCorekjsJSFunctioncpp"></a>
<div class="modfile"><h4>Modified: trunk/JavaScriptCore/kjs/JSFunction.cpp (37858 => 37859)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/JavaScriptCore/kjs/JSFunction.cpp        2008-10-24 20:43:02 UTC (rev 37858)
+++ trunk/JavaScriptCore/kjs/JSFunction.cpp        2008-10-24 20:44:58 UTC (rev 37859)
</span><span class="lines">@@ -102,6 +102,19 @@
</span><span class="cx"> 
</span><span class="cx"> bool JSFunction::getOwnPropertySlot(ExecState* exec, const Identifier&amp; propertyName, PropertySlot&amp; slot)
</span><span class="cx"> {
</span><ins>+    if (propertyName == exec-&gt;propertyNames().prototype) {
+        JSValue** location = getDirectLocation(propertyName);
+
+        if (!location) {
+            JSObject* prototype = new (exec) JSObject(m_scopeChain.globalObject()-&gt;emptyObjectStructure());
+            prototype-&gt;putDirect(exec-&gt;propertyNames().constructor, this, DontEnum);
+            putDirect(exec-&gt;propertyNames().prototype, prototype, DontDelete);
+            location = getDirectLocation(propertyName);
+        }
+
+        slot.setValueSlot(this, location, offsetForLocation(location));
+    }
+
</ins><span class="cx">     if (propertyName == exec-&gt;propertyNames().arguments) {
</span><span class="cx">         slot.setCustom(this, argumentsGetter);
</span><span class="cx">         return true;
</span></span></pre></div>
<a id="trunkJavaScriptCorekjsnodescpp"></a>
<div class="modfile"><h4>Modified: trunk/JavaScriptCore/kjs/nodes.cpp (37858 => 37859)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/JavaScriptCore/kjs/nodes.cpp        2008-10-24 20:43:02 UTC (rev 37858)
+++ trunk/JavaScriptCore/kjs/nodes.cpp        2008-10-24 20:44:58 UTC (rev 37859)
</span><span class="lines">@@ -1871,12 +1871,7 @@
</span><span class="cx"> 
</span><span class="cx"> JSFunction* FuncDeclNode::makeFunction(ExecState* exec, ScopeChainNode* scopeChain)
</span><span class="cx"> {
</span><del>-    JSFunction* func = new (exec) JSFunction(exec, m_ident, m_body.get(), scopeChain);
-
-    JSObject* proto = constructEmptyObject(exec);
-    proto-&gt;putDirect(exec-&gt;propertyNames().constructor, func, DontEnum);
-    func-&gt;putDirect(exec-&gt;propertyNames().prototype, proto, DontDelete);
-    return func;
</del><ins>+    return new (exec) JSFunction(exec, m_ident, m_body.get(), scopeChain);
</ins><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> RegisterID* FuncDeclNode::emitCode(CodeGenerator&amp;, RegisterID* dst)
</span><span class="lines">@@ -1894,9 +1889,6 @@
</span><span class="cx"> JSFunction* FuncExprNode::makeFunction(ExecState* exec, ScopeChainNode* scopeChain)
</span><span class="cx"> {
</span><span class="cx">     JSFunction* func = new (exec) JSFunction(exec, m_ident, m_body.get(), scopeChain);
</span><del>-    JSObject* proto = constructEmptyObject(exec);
-    proto-&gt;putDirect(exec-&gt;propertyNames().constructor, func, DontEnum);
-    func-&gt;putDirect(exec-&gt;propertyNames().prototype, proto, DontDelete);
</del><span class="cx"> 
</span><span class="cx">     /* 
</span><span class="cx">         The Identifier in a FunctionExpression can be referenced from inside
</span></span></pre>
</div>
</div>

</body>
</html>