<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[37784] trunk/WebCore</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/37784">37784</a></dd>
<dt>Author</dt> <dd>ap@webkit.org</dd>
<dt>Date</dt> <dd>2008-10-22 10:43:26 -0700 (Wed, 22 Oct 2008)</dd>
</dl>

<h3>Log Message</h3>
<pre>        Reviewed by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=21791
        WebCore JS bindings should be able to use non-static hash tables for properties

        Add a map for HashTables to WebCore JS client data.

        This makes property access noticeably slower, so it is an opt-in. For classes that need to be
        supported in workers in forseeable future this is not critical.

        * bindings/js/JSDOMBinding.cpp:
        (WebCore::DOMObjectHashTableMap::get):
        (WebCore::DOMObjectHashTableMap::mapFor):
        (WebCore::getHashTableForGlobalData):
        (WebCore::DOMObjectWrapperMap::mapFor):
        WebCore client data is now a class that contains both a DOM wrapper map and a property hash
        table one.

        * bindings/js/JSDOMBinding.h: Added getHashTableForGlobalData() to query the hash table map.

        * bindings/scripts/CodeGeneratorJS.pm: If the class has a NoStaticTables attribute, use
        JSDOMBinding map to access its property hash tables.

        * dom/MessageChannel.idl:
        * dom/MessagePort.idl:
        Added NoStaticTables attribute.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkWebCoreChangeLog">trunk/WebCore/ChangeLog</a></li>
<li><a href="#trunkWebCorebindingsjsJSDOMBindingcpp">trunk/WebCore/bindings/js/JSDOMBinding.cpp</a></li>
<li><a href="#trunkWebCorebindingsjsJSDOMBindingh">trunk/WebCore/bindings/js/JSDOMBinding.h</a></li>
<li><a href="#trunkWebCorebindingsscriptsCodeGeneratorJSpm">trunk/WebCore/bindings/scripts/CodeGeneratorJS.pm</a></li>
<li><a href="#trunkWebCoredomMessageChannelidl">trunk/WebCore/dom/MessageChannel.idl</a></li>
<li><a href="#trunkWebCoredomMessagePortidl">trunk/WebCore/dom/MessagePort.idl</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/ChangeLog (37783 => 37784)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/ChangeLog        2008-10-22 16:47:02 UTC (rev 37783)
+++ trunk/WebCore/ChangeLog        2008-10-22 17:43:26 UTC (rev 37784)
</span><span class="lines">@@ -1,3 +1,32 @@
</span><ins>+2008-10-22  Alexey Proskuryakov  &lt;ap@webkit.org&gt;
+
+        Reviewed by Sam Weinig.
+
+        https://bugs.webkit.org/show_bug.cgi?id=21791
+        WebCore JS bindings should be able to use non-static hash tables for properties
+
+        Add a map for HashTables to WebCore JS client data.
+
+        This makes property access noticeably slower, so it is an opt-in. For classes that need to be
+        supported in workers in forseeable future this is not critical.
+
+        * bindings/js/JSDOMBinding.cpp:
+        (WebCore::DOMObjectHashTableMap::get):
+        (WebCore::DOMObjectHashTableMap::mapFor):
+        (WebCore::getHashTableForGlobalData):
+        (WebCore::DOMObjectWrapperMap::mapFor):
+        WebCore client data is now a class that contains both a DOM wrapper map and a property hash
+        table one.
+
+        * bindings/js/JSDOMBinding.h: Added getHashTableForGlobalData() to query the hash table map.
+
+        * bindings/scripts/CodeGeneratorJS.pm: If the class has a NoStaticTables attribute, use
+        JSDOMBinding map to access its property hash tables.
+
+        * dom/MessageChannel.idl:
+        * dom/MessagePort.idl:
+        Added NoStaticTables attribute.
+
</ins><span class="cx"> 2008-10-22  Gustavo Noronha Silva  &lt;gns@gnome.org&gt;
</span><span class="cx"> 
</span><span class="cx">         Reviewed by Timothy Hatcher.
</span></span></pre></div>
<a id="trunkWebCorebindingsjsJSDOMBindingcpp"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/bindings/js/JSDOMBinding.cpp (37783 => 37784)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/bindings/js/JSDOMBinding.cpp        2008-10-22 16:47:02 UTC (rev 37783)
+++ trunk/WebCore/bindings/js/JSDOMBinding.cpp        2008-10-22 17:43:26 UTC (rev 37784)
</span><span class="lines">@@ -132,17 +132,9 @@
</span><span class="cx"> 
</span><span class="cx"> #endif
</span><span class="cx"> 
</span><del>-class DOMObjectWrapperMap : public JSGlobalData::ClientData {
</del><ins>+class DOMObjectWrapperMap {
</ins><span class="cx"> public:
</span><del>-    static DOMObjectWrapperMap&amp; mapFor(JSGlobalData&amp; globalData)
-    {
-        JSGlobalData::ClientData* clientData = globalData.clientData;
-        if (!clientData) {
-            clientData = new DOMObjectWrapperMap;
-            globalData.clientData = clientData;
-        }
-        return *static_cast&lt;DOMObjectWrapperMap*&gt;(clientData);
-    }
</del><ins>+    static DOMObjectWrapperMap&amp; mapFor(JSGlobalData&amp;);
</ins><span class="cx"> 
</span><span class="cx">     DOMObject* get(void* objectHandle)
</span><span class="cx">     {
</span><span class="lines">@@ -164,6 +156,54 @@
</span><span class="cx">     HashMap&lt;void*, DOMObject*&gt; m_map;
</span><span class="cx"> };
</span><span class="cx"> 
</span><ins>+// Map from static HashTable instances to per-GlobalData ones.
+class DOMObjectHashTableMap {
+public:
+    static DOMObjectHashTableMap&amp; mapFor(JSGlobalData&amp;);
+
+    const JSC::HashTable* get(const JSC::HashTable* staticTable)
+    {
+        HashMap&lt;const JSC::HashTable*, JSC::HashTable&gt;::iterator iter = m_map.find(staticTable);
+        if (iter != m_map.end())
+            return &amp;iter-&gt;second;
+        return &amp;m_map.set(staticTable, JSC::HashTable(*staticTable)).first-&gt;second;
+    }
+
+private:
+    HashMap&lt;const JSC::HashTable*, JSC::HashTable&gt; m_map;
+};
+
+class WebCoreJSClientData : public JSGlobalData::ClientData {
+public:
+    DOMObjectHashTableMap hashTableMap;
+    DOMObjectWrapperMap wrapperMap;
+};
+
+DOMObjectHashTableMap&amp; DOMObjectHashTableMap::mapFor(JSGlobalData&amp; globalData)
+{
+    JSGlobalData::ClientData* clientData = globalData.clientData;
+    if (!clientData) {
+        clientData = new WebCoreJSClientData;
+        globalData.clientData = clientData;
+    }
+    return static_cast&lt;WebCoreJSClientData*&gt;(clientData)-&gt;hashTableMap;
+}
+
+const JSC::HashTable* getHashTableForGlobalData(JSGlobalData&amp; globalData, const JSC::HashTable* staticTable)
+{
+    return DOMObjectHashTableMap::mapFor(globalData).get(staticTable);
+}
+
+inline DOMObjectWrapperMap&amp; DOMObjectWrapperMap::mapFor(JSGlobalData&amp; globalData)
+{
+    JSGlobalData::ClientData* clientData = globalData.clientData;
+    if (!clientData) {
+        clientData = new WebCoreJSClientData;
+        globalData.clientData = clientData;
+    }
+    return static_cast&lt;WebCoreJSClientData*&gt;(clientData)-&gt;wrapperMap;
+}
+
</ins><span class="cx"> DOMObject* getCachedDOMObjectWrapper(JSGlobalData&amp; globalData, void* objectHandle) 
</span><span class="cx"> {
</span><span class="cx">     return DOMObjectWrapperMap::mapFor(globalData).get(objectHandle);
</span></span></pre></div>
<a id="trunkWebCorebindingsjsJSDOMBindingh"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/bindings/js/JSDOMBinding.h (37783 => 37784)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/bindings/js/JSDOMBinding.h        2008-10-22 16:47:02 UTC (rev 37783)
+++ trunk/WebCore/bindings/js/JSDOMBinding.h        2008-10-22 17:43:26 UTC (rev 37784)
</span><span class="lines">@@ -152,6 +152,8 @@
</span><span class="cx">         return createDOMNodeWrapper&lt;WrapperClass&gt;(exec, node);
</span><span class="cx">     }
</span><span class="cx"> 
</span><ins>+    const JSC::HashTable* getHashTableForGlobalData(JSC::JSGlobalData&amp;, const JSC::HashTable* staticTable);
+
</ins><span class="cx">     // Convert a DOM implementation exception code into a JavaScript exception in the execution state.
</span><span class="cx">     void setDOMException(JSC::ExecState*, ExceptionCode);
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkWebCorebindingsscriptsCodeGeneratorJSpm"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/bindings/scripts/CodeGeneratorJS.pm (37783 => 37784)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/bindings/scripts/CodeGeneratorJS.pm        2008-10-22 16:47:02 UTC (rev 37783)
+++ trunk/WebCore/bindings/scripts/CodeGeneratorJS.pm        2008-10-22 17:43:26 UTC (rev 37784)
</span><span class="lines">@@ -248,6 +248,28 @@
</span><span class="cx">     return &quot;${class}::$name&quot;;
</span><span class="cx"> }
</span><span class="cx"> 
</span><ins>+sub hashTableAccessor
+{
+    my $noStaticTables = shift;
+    my $className = shift;
+    if ($noStaticTables) {
+        return &quot;get${className}Table(exec)&quot;;
+    } else {
+        return &quot;&amp;${className}Table&quot;;
+    }
+}
+
+sub prototypeHashTableAccessor
+{
+    my $noStaticTables = shift;
+    my $className = shift;
+    if ($noStaticTables) {
+        return &quot;get${className}PrototypeTable(exec)&quot;;
+    } else {
+        return &quot;&amp;${className}PrototypeTable&quot;;
+    }
+}
+
</ins><span class="cx"> sub GenerateGetOwnPropertySlotBody
</span><span class="cx"> {
</span><span class="cx">     my ($dataNode, $interfaceName, $className, $implClassName, $hasAttributes, $inlined) = @_;
</span><span class="lines">@@ -311,9 +333,10 @@
</span><span class="cx"> 
</span><span class="cx">     if ($hasAttributes) {
</span><span class="cx">         if ($inlined) {
</span><ins>+            die &quot;Cannot inline if NoStaticTables is set.&quot; if ($dataNode-&gt;extendedAttributes-&gt;{&quot;NoStaticTables&quot;});
</ins><span class="cx">             push(@getOwnPropertySlotImpl, &quot;    return ${namespaceMaybe}getStaticValueSlot&lt;$className, Base&gt;(exec, s_info.staticPropHashTable, this, propertyName, slot);\n&quot;);
</span><span class="cx">         } else {
</span><del>-           push(@getOwnPropertySlotImpl, &quot;    return ${namespaceMaybe}getStaticValueSlot&lt;$className, Base&gt;(exec, &amp;${className}Table, this, propertyName, slot);\n&quot;);
</del><ins>+            push(@getOwnPropertySlotImpl, &quot;    return ${namespaceMaybe}getStaticValueSlot&lt;$className, Base&gt;(exec, &quot; . hashTableAccessor($dataNode-&gt;extendedAttributes-&gt;{&quot;NoStaticTables&quot;}, $className) . &quot;, this, propertyName, slot);\n&quot;);
</ins><span class="cx">         }
</span><span class="cx">     } else {
</span><span class="cx">         push(@getOwnPropertySlotImpl, &quot;    return Base::getOwnPropertySlot(exec, propertyName, slot);\n&quot;);
</span><span class="lines">@@ -845,7 +868,15 @@
</span><span class="cx">                                \@hashKeys, \@hashSpecials,
</span><span class="cx">                                \@hashValue1, \@hashValue2);
</span><span class="cx"> 
</span><del>-    push(@implContent, &quot;const ClassInfo ${className}Prototype::s_info = { \&quot;${visibleClassName}Prototype\&quot;, 0, &amp;${className}PrototypeTable, 0 };\n\n&quot;);
</del><ins>+    if ($dataNode-&gt;extendedAttributes-&gt;{&quot;NoStaticTables&quot;}) {
+        push(@implContent, &quot;static const HashTable* get${className}PrototypeTable(ExecState* exec)\n&quot;);
+        push(@implContent, &quot;{\n&quot;);
+        push(@implContent, &quot;    return getHashTableForGlobalData(exec-&gt;globalData(), &amp;${className}PrototypeTable);\n&quot;);
+        push(@implContent, &quot;}\n&quot;);
+        push(@implContent, &quot;const ClassInfo ${className}Prototype::s_info = { \&quot;${visibleClassName}Prototype\&quot;, 0, 0, get${className}PrototypeTable };\n\n&quot;);
+    } else {
+        push(@implContent, &quot;const ClassInfo ${className}Prototype::s_info = { \&quot;${visibleClassName}Prototype\&quot;, 0, &amp;${className}PrototypeTable, 0 };\n\n&quot;);
+    }
</ins><span class="cx">     if ($interfaceName ne &quot;DOMWindow&quot;) {
</span><span class="cx">         push(@implContent, &quot;JSObject* ${className}Prototype::self(ExecState* exec)\n&quot;);
</span><span class="cx">         push(@implContent, &quot;{\n&quot;);
</span><span class="lines">@@ -862,16 +893,22 @@
</span><span class="cx">         push(@implContent, &quot;bool ${className}Prototype::getOwnPropertySlot(ExecState* exec, const Identifier&amp; propertyName, PropertySlot&amp; slot)\n&quot;);
</span><span class="cx">         push(@implContent, &quot;{\n&quot;);
</span><span class="cx">         if ($numConstants eq 0) {
</span><del>-            push(@implContent, &quot;    return getStaticFunctionSlot&lt;JSObject&gt;(exec, &amp;${className}PrototypeTable, this, propertyName, slot);\n&quot;);
</del><ins>+            push(@implContent, &quot;    return getStaticFunctionSlot&lt;JSObject&gt;(exec, &quot; . prototypeHashTableAccessor($dataNode-&gt;extendedAttributes-&gt;{&quot;NoStaticTables&quot;}, $className) . &quot;, this, propertyName, slot);\n&quot;);
</ins><span class="cx">         } elsif ($numFunctions eq 0) {
</span><del>-            push(@implContent, &quot;    return getStaticValueSlot&lt;${className}Prototype, JSObject&gt;(exec, &amp;${className}PrototypeTable, this, propertyName, slot);\n&quot;);
</del><ins>+            push(@implContent, &quot;    return getStaticValueSlot&lt;${className}Prototype, JSObject&gt;(exec, &quot; . prototypeHashTableAccessor($dataNode-&gt;extendedAttributes-&gt;{&quot;NoStaticTables&quot;}, $className) . &quot;, this, propertyName, slot);\n&quot;);
</ins><span class="cx">         } else {
</span><del>-            push(@implContent, &quot;    return getStaticPropertySlot&lt;${className}Prototype, JSObject&gt;(exec, &amp;${className}PrototypeTable, this, propertyName, slot);\n&quot;);
</del><ins>+            push(@implContent, &quot;    return getStaticPropertySlot&lt;${className}Prototype, JSObject&gt;(exec, &quot; . prototypeHashTableAccessor($dataNode-&gt;extendedAttributes-&gt;{&quot;NoStaticTables&quot;}, $className) . &quot;, this, propertyName, slot);\n&quot;);
</ins><span class="cx">         }
</span><span class="cx">         push(@implContent, &quot;}\n\n&quot;);
</span><span class="cx">     }
</span><span class="cx"> 
</span><span class="cx">     # - Initialize static ClassInfo object
</span><ins>+    if ($numAttributes &gt; 0 &amp;&amp; $dataNode-&gt;extendedAttributes-&gt;{&quot;NoStaticTables&quot;}) {
+        push(@implContent, &quot;static const HashTable* get${className}Table(ExecState* exec)\n&quot;);
+        push(@implContent, &quot;{\n&quot;);
+        push(@implContent, &quot;    return getHashTableForGlobalData(exec-&gt;globalData(), &amp;${className}Table);\n&quot;);
+        push(@implContent, &quot;}\n&quot;);
+    }
</ins><span class="cx">     push(@implContent, &quot;const ClassInfo $className&quot; . &quot;::s_info = { \&quot;${visibleClassName}\&quot;, &quot;);
</span><span class="cx">     if ($hasParent) {
</span><span class="cx">         push(@implContent, &quot;&amp;&quot; . $parentClassName . &quot;::s_info, &quot;);
</span><span class="lines">@@ -879,12 +916,16 @@
</span><span class="cx">         push(@implContent, &quot;0, &quot;);
</span><span class="cx">     }
</span><span class="cx"> 
</span><del>-    if ($numAttributes &gt; 0) {
-        push(@implContent, &quot;&amp;${className}Table &quot;);
</del><ins>+    if ($numAttributes &gt; 0 &amp;&amp; !$dataNode-&gt;extendedAttributes-&gt;{&quot;NoStaticTables&quot;}) {
+        push(@implContent, &quot;&amp;${className}Table&quot;);
</ins><span class="cx">     } else {
</span><del>-        push(@implContent, &quot;0 &quot;);
</del><ins>+        push(@implContent, &quot;0&quot;);
</ins><span class="cx">     }
</span><del>-    push(@implContent, &quot;, 0 &quot;);
</del><ins>+    if ($numAttributes &gt; 0 &amp;&amp; $dataNode-&gt;extendedAttributes-&gt;{&quot;NoStaticTables&quot;}) {
+        push(@implContent, &quot;, get${className}Table &quot;);
+    } else {
+        push(@implContent, &quot;, 0 &quot;);
+    }
</ins><span class="cx">     push(@implContent, &quot;};\n\n&quot;);
</span><span class="cx"> 
</span><span class="cx">     # Get correct pass/store types respecting PODType flag
</span><span class="lines">@@ -1111,7 +1152,7 @@
</span><span class="cx">             }
</span><span class="cx"> 
</span><span class="cx">             if ($hasReadWriteProperties) {
</span><del>-                push(@implContent, &quot;    lookupPut&lt;$className, Base&gt;(exec, propertyName, value, &amp;${className}Table, this, slot);\n&quot;);
</del><ins>+                push(@implContent, &quot;    lookupPut&lt;$className, Base&gt;(exec, propertyName, value, &quot; . hashTableAccessor($dataNode-&gt;extendedAttributes-&gt;{&quot;NoStaticTables&quot;}, $className) . &quot;, this, slot);\n&quot;);
</ins><span class="cx">             } else {
</span><span class="cx">                 push(@implContent, &quot;    Base::put(exec, propertyName, value, slot);\n&quot;);
</span><span class="cx">             }
</span></span></pre></div>
<a id="trunkWebCoredomMessageChannelidl"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/dom/MessageChannel.idl (37783 => 37784)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/dom/MessageChannel.idl        2008-10-22 16:47:02 UTC (rev 37783)
+++ trunk/WebCore/dom/MessageChannel.idl        2008-10-22 17:43:26 UTC (rev 37784)
</span><span class="lines">@@ -26,7 +26,7 @@
</span><span class="cx"> 
</span><span class="cx"> module events {
</span><span class="cx"> 
</span><del>-    interface [CustomMarkFunction] MessageChannel {
</del><ins>+    interface [CustomMarkFunction, NoStaticTables] MessageChannel {
</ins><span class="cx"> 
</span><span class="cx">         readonly attribute MessagePort port1;
</span><span class="cx">         readonly attribute MessagePort port2;
</span></span></pre></div>
<a id="trunkWebCoredomMessagePortidl"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/dom/MessagePort.idl (37783 => 37784)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/dom/MessagePort.idl        2008-10-22 16:47:02 UTC (rev 37783)
+++ trunk/WebCore/dom/MessagePort.idl        2008-10-22 17:43:26 UTC (rev 37784)
</span><span class="lines">@@ -26,7 +26,7 @@
</span><span class="cx"> 
</span><span class="cx"> module events {
</span><span class="cx"> 
</span><del>-    interface [CustomMarkFunction] MessagePort {
</del><ins>+    interface [CustomMarkFunction, NoStaticTables] MessagePort {
</ins><span class="cx"> // We need to have something as an ObjC binding, because MessagePort is used in MessageEvent, which already has one,
</span><span class="cx"> // but we don't want to actually expose the API while it is in flux.
</span><span class="cx"> #if defined(LANGUAGE_JAVASCRIPT)
</span></span></pre>
</div>
</div>

</body>
</html>