<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[37757] trunk/WebCore</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/37757">37757</a></dd>
<dt>Author</dt> <dd>timothy@apple.com</dd>
<dt>Date</dt> <dd>2008-10-20 21:50:34 -0700 (Mon, 20 Oct 2008)</dd>
</dl>

<h3>Log Message</h3>
<pre>        Make auto-complete only suggest properties that are valid syntax
        when using dot-notation. Also when completing numeric properties,
        the quotes are omitted inside the brackets.

        https://bugs.webkit.org/show_bug.cgi?id=21760
        https://bugs.webkit.org/show_bug.cgi?id=21761

        Reviewed by Oliver Hunt.

        * inspector/front-end/Console.js:
        (WebInspector.Console.prototype.completions): Skip properties that
        are not valid identifies when using dot-notation. And omit the quotes
        when completing numbers in bracket-notation.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkWebCoreChangeLog">trunk/WebCore/ChangeLog</a></li>
<li><a href="#trunkWebCoreinspectorfrontendConsolejs">trunk/WebCore/inspector/front-end/Console.js</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/ChangeLog (37756 => 37757)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/ChangeLog        2008-10-21 04:50:24 UTC (rev 37756)
+++ trunk/WebCore/ChangeLog        2008-10-21 04:50:34 UTC (rev 37757)
</span><span class="lines">@@ -1,5 +1,21 @@
</span><span class="cx"> 2008-10-20  Timothy Hatcher  &lt;timothy@apple.com&gt;
</span><span class="cx"> 
</span><ins>+        Make auto-complete only suggest properties that are valid syntax
+        when using dot-notation. Also when completing numeric properties,
+        the quotes are omitted inside the brackets.
+
+        https://bugs.webkit.org/show_bug.cgi?id=21760
+        https://bugs.webkit.org/show_bug.cgi?id=21761
+
+        Reviewed by Oliver Hunt.
+
+        * inspector/front-end/Console.js:
+        (WebInspector.Console.prototype.completions): Skip properties that
+        are not valid identifies when using dot-notation. And omit the quotes
+        when completing numbers in bracket-notation.
+
+2008-10-20  Timothy Hatcher  &lt;timothy@apple.com&gt;
+
</ins><span class="cx">         Fixes the Profiles panel in the Web Inspector, which was broken by
</span><span class="cx">         the JSValue base-class changes. Also renames some functions and
</span><span class="cx">         variables in JavaScriptProfileNode.cpp that where title case.
</span></span></pre></div>
<a id="trunkWebCoreinspectorfrontendConsolejs"></a>
<div class="modfile"><h4>Modified: trunk/WebCore/inspector/front-end/Console.js (37756 => 37757)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/WebCore/inspector/front-end/Console.js        2008-10-21 04:50:24 UTC (rev 37756)
+++ trunk/WebCore/inspector/front-end/Console.js        2008-10-21 04:50:34 UTC (rev 37757)
</span><span class="lines">@@ -284,12 +284,21 @@
</span><span class="cx">         var properties = Object.sortedProperties(result);
</span><span class="cx">         for (var i = 0; i &lt; properties.length; ++i) {
</span><span class="cx">             var property = properties[i];
</span><del>-            if (bracketNotation)
-                property = quoteUsed + property.escapeCharacters(quoteUsed + &quot;\\&quot;) + quoteUsed + &quot;]&quot;;
</del><ins>+
+            if (dotNotation &amp;&amp; !/^[a-zA-Z_$][a-zA-Z0-9_$]*$/.test(property))
+                continue;
+
+            if (bracketNotation) {
+                if (!/^[0-9]+$/.test(property))
+                    property = quoteUsed + property.escapeCharacters(quoteUsed + &quot;\\&quot;) + quoteUsed;
+                property += &quot;]&quot;;
+            }
+
</ins><span class="cx">             if (property.length &lt; prefix.length)
</span><span class="cx">                 continue;
</span><span class="cx">             if (property.indexOf(prefix) !== 0)
</span><span class="cx">                 continue;
</span><ins>+
</ins><span class="cx">             results.push(property);
</span><span class="cx">             if (bestMatchOnly)
</span><span class="cx">                 break;
</span></span></pre>
</div>
</div>

</body>
</html>