<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[37629] trunk/JavaScriptCore</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/37629">37629</a></dd>
<dt>Author</dt> <dd>weinig@apple.com</dd>
<dt>Date</dt> <dd>2008-10-15 22:31:41 -0700 (Wed, 15 Oct 2008)</dd>
</dl>

<h3>Log Message</h3>
<pre>2008-10-15  Sam Weinig  &lt;sam@webkit.org&gt;

        Reviewed by Goeffrey Garen.

        Add function to dump statistics for StructureIDs.

        * kjs/StructureID.cpp:
        (JSC::StructureID::dumpStatistics):
        (JSC::StructureID::StructureID):
        (JSC::StructureID::~StructureID):
        * kjs/StructureID.h:</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkJavaScriptCoreChangeLog">trunk/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkJavaScriptCorekjsStructureIDcpp">trunk/JavaScriptCore/kjs/StructureID.cpp</a></li>
<li><a href="#trunkJavaScriptCorekjsStructureIDh">trunk/JavaScriptCore/kjs/StructureID.h</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/JavaScriptCore/ChangeLog (37628 => 37629)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/JavaScriptCore/ChangeLog        2008-10-16 04:56:46 UTC (rev 37628)
+++ trunk/JavaScriptCore/ChangeLog        2008-10-16 05:31:41 UTC (rev 37629)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2008-10-15  Sam Weinig  &lt;sam@webkit.org&gt;
+
+        Reviewed by Goeffrey Garen.
+
+        Add function to dump statistics for StructureIDs.
+
+        * kjs/StructureID.cpp:
+        (JSC::StructureID::dumpStatistics):
+        (JSC::StructureID::StructureID):
+        (JSC::StructureID::~StructureID):
+        * kjs/StructureID.h:
+
</ins><span class="cx"> 2008-10-15  Cameron Zwarich  &lt;zwarich@apple.com&gt;
</span><span class="cx"> 
</span><span class="cx">         Reviewed by Maciej Stachowiak.
</span></span></pre></div>
<a id="trunkJavaScriptCorekjsStructureIDcpp"></a>
<div class="modfile"><h4>Modified: trunk/JavaScriptCore/kjs/StructureID.cpp (37628 => 37629)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/JavaScriptCore/kjs/StructureID.cpp        2008-10-16 04:56:46 UTC (rev 37628)
+++ trunk/JavaScriptCore/kjs/StructureID.cpp        2008-10-16 05:31:41 UTC (rev 37629)
</span><span class="lines">@@ -37,13 +37,32 @@
</span><span class="cx"> 
</span><span class="cx"> namespace JSC {
</span><span class="cx"> 
</span><del>-#ifndef NDEBUG    
</del><ins>+#ifndef NDEBUG
</ins><span class="cx"> static WTF::RefCountedLeakCounter structureIDCounter(&quot;StructureID&quot;);
</span><span class="cx"> 
</span><span class="cx"> static bool shouldIgnoreLeaks;
</span><span class="cx"> static HashSet&lt;StructureID*&gt; ignoreSet;
</span><span class="cx"> #endif
</span><span class="cx"> 
</span><ins>+#if DUMP_STRUCTURE_ID_STATISTICS
+static HashSet&lt;StructureID*&gt; liveStructureIDSet;
+
+void StructureID::dumpStatistics()
+{
+    unsigned numberUsingSingleSlot = 0;
+
+    HashSet&lt;StructureID*&gt;::const_iterator end = liveStructureIDSet.end();
+    for (HashSet&lt;StructureID*&gt;::const_iterator it = liveStructureIDSet.begin(); it != end; ++it) {
+        StructureID* structureID = *it;
+        if (structureID-&gt;m_usingSingleTransitionSlot)
+            ++numberUsingSingleSlot;
+    }
+
+    printf(&quot;Number of live StructureIDs: %d\n&quot;, liveStructureIDSet.size());
+    printf(&quot;Number of StructureIDs using the single item optimization for transition map: %d\n&quot;, numberUsingSingleSlot);
+}
+#endif
+
</ins><span class="cx"> StructureID::StructureID(JSValue* prototype, const TypeInfo&amp; typeInfo)
</span><span class="cx">     : m_typeInfo(typeInfo)
</span><span class="cx">     , m_isDictionary(false)
</span><span class="lines">@@ -68,6 +87,10 @@
</span><span class="cx">     else
</span><span class="cx">         structureIDCounter.increment();
</span><span class="cx"> #endif
</span><ins>+
+#if DUMP_STRUCTURE_ID_STATISTICS
+    liveStructureIDSet.add(this);
+#endif
</ins><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> StructureID::~StructureID()
</span><span class="lines">@@ -98,6 +121,10 @@
</span><span class="cx">     else
</span><span class="cx">         structureIDCounter.decrement();
</span><span class="cx"> #endif
</span><ins>+
+#if DUMP_STRUCTURE_ID_STATISTICS
+    liveStructureIDSet.remove(this);
+#endif
</ins><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> void StructureID::startIgnoringLeaks()
</span></span></pre></div>
<a id="trunkJavaScriptCorekjsStructureIDh"></a>
<div class="modfile"><h4>Modified: trunk/JavaScriptCore/kjs/StructureID.h (37628 => 37629)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/JavaScriptCore/kjs/StructureID.h        2008-10-16 04:56:46 UTC (rev 37628)
+++ trunk/JavaScriptCore/kjs/StructureID.h        2008-10-16 05:31:41 UTC (rev 37629)
</span><span class="lines">@@ -38,6 +38,8 @@
</span><span class="cx"> #include &lt;wtf/PassRefPtr.h&gt;
</span><span class="cx"> #include &lt;wtf/RefCounted.h&gt;
</span><span class="cx"> 
</span><ins>+#define DUMP_STRUCTURE_ID_STATISTICS 0
+
</ins><span class="cx"> namespace JSC {
</span><span class="cx"> 
</span><span class="cx">     class JSValue;
</span><span class="lines">@@ -85,6 +87,10 @@
</span><span class="cx">         static void startIgnoringLeaks();
</span><span class="cx">         static void stopIgnoringLeaks();
</span><span class="cx"> 
</span><ins>+#if DUMP_STRUCTURE_ID_STATISTICS
+        static void dumpStatistics();
+#endif
+
</ins><span class="cx">         static PassRefPtr&lt;StructureID&gt; changePrototypeTransition(StructureID*, JSValue* prototype);
</span><span class="cx">         static PassRefPtr&lt;StructureID&gt; addPropertyTransition(StructureID*, const Identifier&amp; propertyName, unsigned attributes, size_t&amp; offset);
</span><span class="cx">         static PassRefPtr&lt;StructureID&gt; getterSetterTransition(StructureID*);
</span></span></pre>
</div>
</div>

</body>
</html>