[webkit-changes] [WebKit/WebKit] 223163: AX: Adopt AXTextMarkerRange::toString() as the can...

[AndresGonzalezApple]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2231639e2fa41c6dda2ab2fe990fe005d80bbcac
      https://github.com/WebKit/WebKit/commit/2231639e2fa41c6dda2ab2fe990fe005d80bbcac
  Author: Andres Gonzalez <andresg_22 at apple.com>
  Date:   2025-03-24 (Mon, 24 Mar 2025)

  Changed paths:
    M Source/WebCore/accessibility/AXCoreObject.h
    M Source/WebCore/accessibility/AXTextMarker.cpp
    M Source/WebCore/accessibility/AXTextMarker.h
    M Source/WebCore/accessibility/AccessibilityObject.cpp
    M Source/WebCore/accessibility/AccessibilityObject.h
    M Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h
    M Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm

  Log Message:
  -----------
  AX: Adopt AXTextMarkerRange::toString() as the canonical way to extract text from a range.
https://bugs.webkit.org/show_bug.cgi?id=290330
<rdar://problem/147770908>

Reviewed by Tyler Wilcock.

As part of the work to support text APIs on the AX thread, we added the method AXTextMarkerRange::toString. This change extends the implementation of this method to be used in all cases, whether on the AX or main thread. This functionality is removed from the AXCoreObject interface and implementations, and is now part of the AXTextMarkerRange class where it belongs. This simplifies the platform layer code and allows for a consistent and unified interface for this functionality.

* Source/WebCore/accessibility/AXCoreObject.h:
* Source/WebCore/accessibility/AXTextMarker.cpp:
(WebCore::AXTextMarkerRange::toString const):
* Source/WebCore/accessibility/AXTextMarker.h:
* Source/WebCore/accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::textContentPrefixFromListMarker const):
(WebCore::AccessibilityObject::textContent const):
(WebCore::AccessibilityObject::stringForRange const): Deleted.
* Source/WebCore/accessibility/AccessibilityObject.h:
* Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper stringForTextMarkers:]):
(-[WebAccessibilityObjectWrapper stringForRange:]):
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:
(WebCore::AXIsolatedObject::stringForRange const): Deleted.
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:
* Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):

Canonical link: https://commits.webkit.org/292623@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications