[webkit-changes] [WebKit/WebKit] a5cb99: Remove default constructor of FrameInfoData

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a5cb991f8f7b3d8c8a0362e958c5ab57043183b8
      https://github.com/WebKit/WebKit/commit/a5cb991f8f7b3d8c8a0362e958c5ab57043183b8
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2025-03-21 (Fri, 21 Mar 2025)

  Changed paths:
    M Source/WebKit/Shared/Extensions/WebExtensionFrameIdentifier.cpp
    A Source/WebKit/Shared/FrameInfoData.cpp
    M Source/WebKit/Shared/FrameInfoData.h
    M Source/WebKit/Shared/FrameInfoData.serialization.in
    M Source/WebKit/Sources.txt
    M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
    M Source/WebKit/UIProcess/Downloads/DownloadProxy.cpp
    M Source/WebKit/UIProcess/ProvisionalPageProxy.cpp
    M Source/WebKit/UIProcess/UserMediaPermissionRequestProxy.h
    M Source/WebKit/UIProcess/WebPageProxy.cpp
    M Source/WebKit/UIProcess/ios/WKContentViewInteraction.h
    M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
    M Source/WebKit/WebKit.xcodeproj/project.pbxproj

  Log Message:
  -----------
  Remove default constructor of FrameInfoData
https://bugs.webkit.org/show_bug.cgi?id=290085

Reviewed by Chris Dumez.

FrameInfoData is only constructed in WebFrame::info()
and 2 places where we use legacyEmptyFrameInfo.
This will inhibit us from trying to reconstruct a FrameInfoData
from something that isn't a WebFrame.

* Source/WebKit/Shared/Extensions/WebExtensionFrameIdentifier.cpp:
(WebKit::toWebExtensionFrameIdentifier):
* Source/WebKit/Shared/FrameInfoData.cpp: Copied from Source/WebKit/Shared/FrameInfoData.h.
(WebKit::legacyEmptyFrameInfo):
* Source/WebKit/Shared/FrameInfoData.h:
* Source/WebKit/Shared/FrameInfoData.serialization.in:
* Source/WebKit/Sources.txt:
* Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _convertPoint:fromFrame:toMainFrameCoordinates:]):
(-[WKWebView _convertRect:fromFrame:toMainFrameCoordinates:]):
* Source/WebKit/UIProcess/Downloads/DownloadProxy.cpp:
(WebKit::DownloadProxy::DownloadProxy):
(WebKit::legacyEmptyFrameInfo): Deleted.
* Source/WebKit/UIProcess/ProvisionalPageProxy.cpp:
(WebKit::ProvisionalPageProxy::didFailProvisionalLoadForFrame):
(WebKit::ProvisionalPageProxy::decidePolicyForNavigationActionAsync):
(WebKit::ProvisionalPageProxy::decidePolicyForResponse):
* Source/WebKit/UIProcess/UserMediaPermissionRequestProxy.h:
(WebKit::UserMediaPermissionRequestProxy::frameID const):
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::loadRequestWithNavigationShared):
(WebKit::WebPageProxy::didSameDocumentNavigationForFrameViaJS):
(WebKit::WebPageProxy::createNewPage):
(WebKit::WebPageProxy::didPerformImmediateActionHitTest):
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:

Canonical link: https://commits.webkit.org/292471@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications