[webkit-changes] [WebKit/WebKit] 1d2101: REGRESSION(290838 at main): Entering QuickLook fullsc...

Etienne Segonzac noreply at github.com
Wed Mar 19 10:22:57 PDT 2025


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1d210108fe4f5c4686b58ceaa8801ce40e43f5a0
      https://github.com/WebKit/WebKit/commit/1d210108fe4f5c4686b58ceaa8801ce40e43f5a0
  Author: Etienne Segonzac <sgz at apple.com>
  Date:   2025-03-19 (Wed, 19 Mar 2025)

  Changed paths:
    M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm

  Log Message:
  -----------
  REGRESSION(290838 at main): Entering QuickLook fullscreen calls the completion handler twice
https://bugs.webkit.org/show_bug.cgi?id=289970
<rdar://147261212>

Reviewed by Geoffrey Garen.

A small issue sneaked in the refactoring, causing us to call the completion
handler twice.

* Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:
(-[WKFullScreenWindowController _enterFullScreen:windowScene:completionHandler:]):
Only call the completion handler once the WKSPreviewWindowController has been presented.

Canonical link: https://commits.webkit.org/292366@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list