[webkit-changes] [WebKit/WebKit] 41c253: [Regression at 292296@main] textureDimensions is brok...

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 41c2531885689f1396affaf45a8c702a19f2287d
      https://github.com/WebKit/WebKit/commit/41c2531885689f1396affaf45a8c702a19f2287d
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2025-03-18 (Tue, 18 Mar 2025)

  Changed paths:
    M LayoutTests/fast/webgpu/regression/repro_275624-expected.txt
    M Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp

  Log Message:
  -----------
  [Regression at 292296@main] textureDimensions is broken for 1D textures
https://bugs.webkit.org/show_bug.cgi?id=289971
rdar://147325897

Reviewed by Tadeu Zagallo.

292296 at main clamps the lod to the max mip level, but for 1D textures which
require constant levels we shouldn't do this. 1D textures don't support
mip levels in WebGPU, so the level is always zero.

Testing: existing wgslc tests caught this

* Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp:
(WGSL::Metal::emitTextureDimensions):

Canonical link: https://commits.webkit.org/292319@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications