[webkit-changes] [WebKit/WebKit] 72acb3: Address Safer CPP failures in WebKit/Shared/

Chris Dumez noreply at github.com
Thu Mar 13 17:31:11 PDT 2025 

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 72acb3c653a2944adb8db03d0e1413bfe328ea62
      https://github.com/WebKit/WebKit/commit/72acb3c653a2944adb8db03d0e1413bfe328ea62
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2025-03-13 (Thu, 13 Mar 2025)

  Changed paths:
    M Source/WebKit/SaferCPPExpectations/MemoryUnsafeCastCheckerExpectations
    M Source/WebKit/SaferCPPExpectations/UncountedCallArgsCheckerExpectations
    M Source/WebKit/Shared/API/APIArray.h
    M Source/WebKit/Shared/API/APIDictionary.h
    M Source/WebKit/Shared/API/c/WKArray.cpp
    M Source/WebKit/Shared/API/c/WKContextMenuItem.cpp
    M Source/WebKit/Shared/API/c/WKDictionary.cpp
    M Source/WebKit/Shared/API/c/WKErrorRef.cpp
    M Source/WebKit/Shared/API/c/WKImage.cpp
    M Source/WebKit/Shared/API/c/WKMutableDictionary.cpp
    M Source/WebKit/Shared/API/c/WKSecurityOriginRef.cpp
    M Source/WebKit/Shared/API/c/WKSharedAPICast.h
    M Source/WebKit/Shared/API/c/WKString.cpp
    M Source/WebKit/Shared/API/c/WKType.cpp
    M Source/WebKit/Shared/API/c/WKURL.cpp
    M Source/WebKit/Shared/API/c/WKUserContentURLPattern.cpp
    M Source/WebKit/Shared/API/c/cf/WKStringCF.mm
    M Source/WebKit/Shared/API/c/cf/WKURLCF.mm
    M Source/WebKit/Shared/API/c/mac/WKWebArchiveRef.cpp
    M Source/WebKit/Shared/API/c/mac/WKWebArchiveResource.cpp
    M Source/WebKit/Shared/APIWebArchiveResource.h
    M Source/WebKit/Shared/APIWebArchiveResource.mm
    M Source/WebKit/Shared/BlobDataFileReferenceWithSandboxExtension.h
    M Source/WebKit/Shared/Cocoa/WKNSData.mm
    M Source/WebKit/Shared/Cocoa/WKNSString.mm
    M Source/WebKit/Shared/Cocoa/WKNSURL.mm
    M Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStoreCollection.h
    M Source/WebKit/Shared/RemoteLayerTree/RemoteLayerWithInProcessRenderingBackingStore.mm
    M Source/WebKit/Shared/RemoteLayerTree/RemoteLayerWithRemoteRenderingBackingStore.mm
    M Source/WebKit/Shared/WebBackForwardListItem.h
    M Source/WebKit/Shared/WebContextMenuItem.h
    M Source/WebKit/Shared/WebGeolocationPosition.h
    M Source/WebKit/UIProcess/API/APIApplicationManifest.h
    M Source/WebKit/UIProcess/API/APIAttachment.h
    M Source/WebKit/UIProcess/API/APIContentRuleList.h
    M Source/WebKit/UIProcess/API/APIContentRuleListAction.h
    M Source/WebKit/UIProcess/API/APIContentRuleListStore.h
    M Source/WebKit/UIProcess/API/APIContentWorld.h
    M Source/WebKit/UIProcess/API/APIContextMenuElementInfo.h
    M Source/WebKit/UIProcess/API/APIContextMenuElementInfoMac.h
    M Source/WebKit/UIProcess/API/APIDataTask.h
    M Source/WebKit/UIProcess/API/APIFeature.h
    M Source/WebKit/UIProcess/API/APIFrameInfo.h
    M Source/WebKit/UIProcess/API/APIFrameTreeNode.h
    M Source/WebKit/UIProcess/API/APIHTTPCookieStore.h
    M Source/WebKit/UIProcess/API/APIHitTestResult.h
    M Source/WebKit/UIProcess/API/APIInspectorExtension.h
    M Source/WebKit/UIProcess/API/APIMessageListener.h
    M Source/WebKit/UIProcess/API/APINavigation.h
    M Source/WebKit/UIProcess/API/APINavigationAction.h
    M Source/WebKit/UIProcess/API/APINavigationData.h
    M Source/WebKit/UIProcess/API/APINavigationResponse.h
    M Source/WebKit/UIProcess/API/APIOpenPanelParameters.h
    M Source/WebKit/UIProcess/API/APIPageConfiguration.h
    M Source/WebKit/UIProcess/API/APIProcessPoolConfiguration.h
    M Source/WebKit/UIProcess/API/APIResourceLoadInfo.h
    M Source/WebKit/UIProcess/API/APIResourceLoadStatisticsFirstParty.h
    M Source/WebKit/UIProcess/API/APIResourceLoadStatisticsThirdParty.h
    M Source/WebKit/UIProcess/API/APISessionState.h
    M Source/WebKit/UIProcess/API/APITargetedElementInfo.h
    M Source/WebKit/UIProcess/API/APITargetedElementRequest.h
    M Source/WebKit/UIProcess/API/APITextRun.h
    M Source/WebKit/UIProcess/API/APIUserInitiatedAction.h
    M Source/WebKit/UIProcess/API/APIWebAuthenticationPanel.h
    M Source/WebKit/UIProcess/API/APIWebPushDaemonConnection.h
    M Source/WebKit/UIProcess/API/APIWebPushMessage.h
    M Source/WebKit/UIProcess/API/APIWebPushSubscriptionData.h
    M Source/WebKit/UIProcess/API/APIWebsiteDataRecord.h
    M Source/WebKit/UIProcess/API/APIWebsitePolicies.h
    M Source/WebKit/UIProcess/API/APIWindowFeatures.h
    M Source/WebKit/UIProcess/API/C/WKPage.cpp
    M Source/WebKit/UIProcess/API/wpe/WPEWebView.h
    M Source/WebKit/UIProcess/Authentication/AuthenticationChallengeProxy.h
    M Source/WebKit/UIProcess/Authentication/AuthenticationDecisionListener.h
    M Source/WebKit/UIProcess/Authentication/WebCredential.h
    M Source/WebKit/UIProcess/Authentication/WebProtectionSpace.h
    M Source/WebKit/UIProcess/Downloads/DownloadProxy.h
    M Source/WebKit/UIProcess/GeolocationPermissionRequestProxy.h
    M Source/WebKit/UIProcess/Inspector/WebInspectorUIProxy.h
    M Source/WebKit/UIProcess/MediaKeySystemPermissionRequest.h
    M Source/WebKit/UIProcess/Notifications/NotificationPermissionRequest.h
    M Source/WebKit/UIProcess/Notifications/WebNotification.h
    M Source/WebKit/UIProcess/Notifications/WebNotificationManagerProxy.h
    M Source/WebKit/UIProcess/QueryPermissionResultCallback.h
    M Source/WebKit/UIProcess/SpeechRecognitionPermissionRequest.h
    M Source/WebKit/UIProcess/UserContent/WebUserContentControllerProxy.h
    M Source/WebKit/UIProcess/UserMediaPermissionCheckProxy.h
    M Source/WebKit/UIProcess/UserMediaPermissionRequestProxy.h
    M Source/WebKit/UIProcess/WebBackForwardList.h
    M Source/WebKit/UIProcess/WebContextMenuListenerProxy.h
    M Source/WebKit/UIProcess/WebFormSubmissionListenerProxy.h
    M Source/WebKit/UIProcess/WebFramePolicyListenerProxy.h
    M Source/WebKit/UIProcess/WebGeolocationManagerProxy.h
    M Source/WebKit/UIProcess/WebOpenPanelResultListenerProxy.h
    M Source/WebKit/UIProcess/WebPreferences.h
    M Source/WebKit/UIProcess/WebProcessPool.h
    M Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h
    M Source/WebKit/UIProcess/WebsiteData/WebsiteDataStoreConfiguration.h
    M Source/WebKit/UIProcess/win/WebView.h
    M Source/WebKit/WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h
    M Source/WebKit/WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp
    M Source/WebKit/WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.h
    M Source/WebKit/WebProcess/InjectedBundle/InjectedBundle.h
    M Source/WebKit/WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.h
    M Source/WebKit/WebProcess/InjectedBundle/InjectedBundleHitTestResult.h
    M Source/WebKit/WebProcess/InjectedBundle/InjectedBundleScriptWorld.h
    M Source/WebKit/WebProcess/WebPage/PageBanner.h
    M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeContext.h
    M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeContext.mm
    M Source/WebKit/WebProcess/WebPage/WebPageOverlay.h

  Log Message:
  -----------
  Address Safer CPP failures in WebKit/Shared/
https://bugs.webkit.org/show_bug.cgi?id=289660

Reviewed by Darin Adler.

* Source/WebKit/SaferCPPExpectations/MemoryUnsafeCastCheckerExpectations:
* Source/WebKit/SaferCPPExpectations/UncountedCallArgsCheckerExpectations:
* Source/WebKit/Shared/API/c/WKArray.cpp:
(WKArrayGetItemAtIndex):
* Source/WebKit/Shared/API/c/WKContextMenuItem.cpp:
(WKContextMenuItemCreateAsAction):
(WKContextMenuItemCreateAsCheckableAction):
(WKContextMenuItemCreateAsSubmenu):
(WKContextMenuItemSeparatorItem):
(WKContextMenuCopySubmenuItems):
(WKContextMenuItemGetUserData):
(WKContextMenuItemSetUserData):
* Source/WebKit/Shared/API/c/WKDictionary.cpp:
(WKDictionaryCreate):
(WKDictionaryGetItemForKey):
(WKDictionaryCopyKeys):
* Source/WebKit/Shared/API/c/WKErrorRef.cpp:
(WKErrorCopyDomain):
(WKErrorGetErrorCode):
(WKErrorCopyFailingURL):
(WKErrorCopyLocalizedDescription):
* Source/WebKit/Shared/API/c/WKImage.cpp:
(WKImageGetSize):
* Source/WebKit/Shared/API/c/WKMutableDictionary.cpp:
(WKDictionarySetItem):
* Source/WebKit/Shared/API/c/WKSecurityOriginRef.cpp:
(WKSecurityOriginCreateFromString):
(WKSecurityOriginCreateFromDatabaseIdentifier):
(WKSecurityOriginCreate):
* Source/WebKit/Shared/API/c/WKSharedAPICast.h:
(WebKit::toAPILeakingRef):
(WebKit::toImpl):
(WebKit::toProtectedImpl):
(WebKit::toWTFString):
* Source/WebKit/Shared/API/c/WKString.cpp:
(WKStringIsEmpty):
(WKStringGetLength):
(WKStringGetCharacters):
(WKStringGetMaximumUTF8CStringSize):
(WKStringGetUTF8CStringImpl):
(WKStringIsEqual):
(WKStringIsEqualToUTF8CString):
(WKStringIsEqualToUTF8CStringIgnoringCase):
(WKStringCopyJSString):
* Source/WebKit/Shared/API/c/WKType.cpp:
(WKGetTypeID):
* Source/WebKit/Shared/API/c/WKURL.cpp:
(WKURLCreateWithBaseURL):
(WKURLIsEqual):
(WKURLCopyHostName):
(WKURLCopyScheme):
(WKURLCopyPath):
(WKURLCopyLastPathComponent):
* Source/WebKit/Shared/API/c/WKUserContentURLPattern.cpp:
(WKUserContentURLPatternCreate):
(WKUserContentURLPatternMatchesURL):
* Source/WebKit/Shared/API/c/cf/WKStringCF.mm:
(WKStringCreateWithCFString):
(WKStringCopyCFString):
* Source/WebKit/Shared/API/c/cf/WKURLCF.mm:
(WKURLCreateWithCFURL):
* Source/WebKit/Shared/API/c/mac/WKWebArchiveRef.cpp:
(WKWebArchiveCreate):
(WKWebArchiveCreateWithData):
(WKWebArchiveCreateFromRange):
(WKWebArchiveCopyMainResource):
(WKWebArchiveCopySubresources):
(WKWebArchiveCopySubframeArchives):
(WKWebArchiveCopyData):
* Source/WebKit/Shared/API/c/mac/WKWebArchiveResource.cpp:
(WKWebArchiveResourceCreate):
(WKWebArchiveResourceCopyData):
(WKWebArchiveResourceCopyURL):
(WKWebArchiveResourceCopyMIMEType):
(WKWebArchiveResourceCopyTextEncoding):
* Source/WebKit/Shared/APIWebArchiveResource.h:
* Source/WebKit/Shared/BlobDataFileReferenceWithSandboxExtension.h:
* Source/WebKit/Shared/Cocoa/WKNSData.mm:
(-[WKNSData dealloc]):
* Source/WebKit/Shared/Cocoa/WKNSString.mm:
* Source/WebKit/Shared/Cocoa/WKNSURL.mm:
(-[WKNSURL _web_createTarget]):
* Source/WebKit/Shared/RemoteLayerTree/RemoteLayerWithInProcessRenderingBackingStore.mm:
(WebKit::RemoteLayerWithInProcessRenderingBackingStore::frontBufferMayBeVolatile const):
(WebKit::RemoteLayerWithInProcessRenderingBackingStore::createContextAndPaintContents):
(WebKit::RemoteLayerWithInProcessRenderingBackingStore::createFlusher):
(WebKit::RemoteLayerWithInProcessRenderingBackingStore::setBufferNonVolatile):
* Source/WebKit/Shared/RemoteLayerTree/RemoteLayerWithRemoteRenderingBackingStore.mm:
(WebKit::RemoteLayerWithRemoteRenderingBackingStore::RemoteLayerWithRemoteRenderingBackingStore):
* Source/WebKit/Shared/WebBackForwardListItem.h:
(isType):
* Source/WebKit/Shared/WebGeolocationPosition.h:
(isType):
* Source/WebKit/UIProcess/API/APIApplicationManifest.h:
* Source/WebKit/UIProcess/API/APIAttachment.h:
* Source/WebKit/UIProcess/API/APIContentRuleList.h:
* Source/WebKit/UIProcess/API/APIContentRuleListAction.h:
* Source/WebKit/UIProcess/API/APIContentRuleListStore.h:
* Source/WebKit/UIProcess/API/APIContentWorld.h:
* Source/WebKit/UIProcess/API/APIContextMenuElementInfo.h:
* Source/WebKit/UIProcess/API/APIContextMenuElementInfoMac.h:
* Source/WebKit/UIProcess/API/APIDataTask.h:
* Source/WebKit/UIProcess/API/APIFeature.h:
* Source/WebKit/UIProcess/API/APIFrameInfo.h:
* Source/WebKit/UIProcess/API/APIFrameTreeNode.h:
* Source/WebKit/UIProcess/API/APIHTTPCookieStore.h:
* Source/WebKit/UIProcess/API/APIHitTestResult.h:
* Source/WebKit/UIProcess/API/APIInspectorExtension.h:
* Source/WebKit/UIProcess/API/APIMessageListener.h:
* Source/WebKit/UIProcess/API/APINavigation.h:
* Source/WebKit/UIProcess/API/APINavigationAction.h:
* Source/WebKit/UIProcess/API/APINavigationData.h:
* Source/WebKit/UIProcess/API/APINavigationResponse.h:
* Source/WebKit/UIProcess/API/APIOpenPanelParameters.h:
* Source/WebKit/UIProcess/API/APIPageConfiguration.h:
* Source/WebKit/UIProcess/API/APIProcessPoolConfiguration.h:
* Source/WebKit/UIProcess/API/APIResourceLoadInfo.h:
* Source/WebKit/UIProcess/API/APIResourceLoadStatisticsFirstParty.h:
* Source/WebKit/UIProcess/API/APIResourceLoadStatisticsThirdParty.h:
* Source/WebKit/UIProcess/API/APISessionState.h:
* Source/WebKit/UIProcess/API/APITargetedElementInfo.h:
* Source/WebKit/UIProcess/API/APITargetedElementRequest.h:
* Source/WebKit/UIProcess/API/APITextRun.h:
* Source/WebKit/UIProcess/API/APIUserInitiatedAction.h:
* Source/WebKit/UIProcess/API/APIWebAuthenticationPanel.h:
* Source/WebKit/UIProcess/API/APIWebPushDaemonConnection.h:
* Source/WebKit/UIProcess/API/APIWebPushMessage.h:
* Source/WebKit/UIProcess/API/APIWebPushSubscriptionData.h:
* Source/WebKit/UIProcess/API/APIWebsiteDataRecord.h:
* Source/WebKit/UIProcess/API/APIWebsitePolicies.h:
* Source/WebKit/UIProcess/API/APIWindowFeatures.h:
* Source/WebKit/UIProcess/Authentication/AuthenticationChallengeProxy.h:
(isType):
* Source/WebKit/UIProcess/Authentication/AuthenticationDecisionListener.h:
(isType):
* Source/WebKit/UIProcess/Authentication/WebCredential.h:
(isType):
* Source/WebKit/UIProcess/Authentication/WebProtectionSpace.h:
(isType):
* Source/WebKit/UIProcess/Downloads/DownloadProxy.h:
(isType):
* Source/WebKit/UIProcess/GeolocationPermissionRequestProxy.h:
(isType):
* Source/WebKit/UIProcess/Inspector/WebInspectorUIProxy.h:
(isType):
* Source/WebKit/UIProcess/MediaKeySystemPermissionRequest.h:
(isType):
* Source/WebKit/UIProcess/Notifications/WebNotification.h:
(isType):
* Source/WebKit/UIProcess/QueryPermissionResultCallback.h:
(isType):
* Source/WebKit/UIProcess/SpeechRecognitionPermissionRequest.h:
(isType):
* Source/WebKit/UIProcess/UserContent/WebUserContentControllerProxy.h:
(isType):
* Source/WebKit/UIProcess/UserMediaPermissionCheckProxy.h:
(isType):
* Source/WebKit/UIProcess/UserMediaPermissionRequestProxy.h:
(isType):
* Source/WebKit/UIProcess/WebBackForwardList.h:
(isType):
* Source/WebKit/UIProcess/WebContextMenuListenerProxy.h:
(isType):
* Source/WebKit/UIProcess/WebFormSubmissionListenerProxy.h:
(isType):
* Source/WebKit/UIProcess/WebFramePolicyListenerProxy.h:
(isType):
* Source/WebKit/UIProcess/WebGeolocationManagerProxy.h:
(isType):
* Source/WebKit/UIProcess/WebPreferences.h:
(isType):
* Source/WebKit/UIProcess/WebProcessPool.h:
(isType):
* Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h:
(isType):
* Source/WebKit/UIProcess/WebsiteData/WebsiteDataStoreConfiguration.h:
(isType):
* Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeContext.h:
* Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeContext.mm:
(WebKit::RemoteLayerTreeContext::ensureProtectedRemoteRenderingBackendProxy):

Canonical link: https://commits.webkit.org/292130@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications

More information about the webkit-changes mailing list