[webkit-changes] [WebKit/WebKit] cc0609: REGRESSION(291284 at main) WebAutomationSession needs...

[Lauro Moura]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cc06097b2c44c4543f1a689059eec6d32e9de6aa
      https://github.com/WebKit/WebKit/commit/cc06097b2c44c4543f1a689059eec6d32e9de6aa
  Author: Lauro Moura <lmoura at igalia.com>
  Date:   2025-03-12 (Wed, 12 Mar 2025)

  Changed paths:
    M Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_backend_dispatcher_implementation.py
    M Source/JavaScriptCore/inspector/scripts/tests/expected/commands-with-async-attribute.json-result

  Log Message:
  -----------
  REGRESSION(291284 at main) WebAutomationSession needs to push a command failure as soon as it gets it
https://bugs.webkit.org/show_bug.cgi?id=289259

Reviewed by BJ Burg.

Ensure we flush the newly reported error as soon as we get them, to
avoid clients hanging waiting for a reply.

This aligns with the original CallbackBase::sendFailure behavior when
an error was reported.

Also make sure we report the right request id in the error.

* Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_backend_dispatcher_implementation.py:
(CppBackendDispatcherImplementationGenerator._generate_dispatcher_implementation_for_command):
* Source/JavaScriptCore/inspector/scripts/tests/expected/commands-with-async-attribute.json-result:

Canonical link: https://commits.webkit.org/292050@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications